[jira] [Commented] (YARN-9584) Should put initializeProcessTrees method call before get pid

["Zhankun Tang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848838#comment-16848838 ] 

Zhankun Tang commented on YARN-9584:
------------------------------------

[~jiwq], thanks for reporting this. It looks good to me and it would be much better if we can write a test case for it. :)

> Should put initializeProcessTrees method call before get pid
> ------------------------------------------------------------
>
>                 Key: YARN-9584
>                 URL: https://issues.apache.org/jira/browse/YARN-9584
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.2.0, 3.0.3, 3.1.2
>            Reporter: Wanqiang Ji
>            Assignee: Wanqiang Ji
>            Priority: Critical
>         Attachments: YARN-9584.001.patch
>
>
> In ContainerMonitorImpl#MonitoringThread.run method had a logic error that get pid first then initialize uninitialized process trees. 
> {code:java}
> String pId = ptInfo.getPID();
> // Initialize uninitialized process trees
> initializeProcessTrees(entry);
> if (pId == null || !isResourceCalculatorAvailable()) {
>   continue; // processTree cannot be tracked
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org