You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/01 21:36:34 UTC
[GitHub] [spark] sadikovi commented on a change in pull request #35700: [SPARK-38094][SQL][FOLLOWUP] Fix exception message and add a test case
sadikovi commented on a change in pull request #35700:
URL: https://github.com/apache/spark/pull/35700#discussion_r817159109
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
##########
@@ -139,8 +139,8 @@ object ParquetReadSupport extends Logging {
throw new RuntimeException(
"Spark read schema expects field Ids, " +
"but Parquet file schema doesn't contain any field Ids.\n" +
- "Please remove the field ids from Spark schema or ignore missing ids by " +
- "setting `spark.sql.parquet.fieldId.ignoreMissing = true`\n" +
+ s"Please remove the field ids from Spark schema or ignore missing ids by " +
+ s"setting ${SQLConf.IGNORE_MISSING_PARQUET_FIELD_ID.key}` = true`\n" +
Review comment:
Do we need \` character at the end of `${SQLConf.IGNORE_MISSING_PARQUET_FIELD_ID.key}`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org