You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "nagarjunahp88-byte (via GitHub)" <gi...@apache.org> on 2025/12/23 15:19:25 UTC

[PR] Fix #5205: Handle invalid SubscriptionMode values safely (eventmesh)

nagarjunahp88-byte opened a new pull request, #5218:
URL: https://github.com/apache/eventmesh/pull/5218

   This PR fixes issue #5205 by improving SubscriptionModeConverter.
   
   Changes:
   - Safely handles null and empty values
   - Normalizes input using trim and uppercase
   - Prevents IllegalArgumentException for invalid enum values
   
   This ensures the application does not crash on invalid input.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


Re: [PR] Fix #5205: Handle invalid SubscriptionMode values safely (eventmesh)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5218:
URL: https://github.com/apache/eventmesh/pull/5218#issuecomment-3941509944

   It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.
   
   If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] Fix #5205: Handle invalid SubscriptionMode values safely (eventmesh)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5218:
URL: https://github.com/apache/eventmesh/pull/5218#issuecomment-4782594701

   It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.
   
   If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] Fix #5205: Handle invalid SubscriptionMode values safely (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #5218:
URL: https://github.com/apache/eventmesh/pull/5218#issuecomment-3687101635

   plz check code style


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] Fix #5205: Handle invalid SubscriptionMode values safely (eventmesh)

Posted by "nagarjunahp88-byte (via GitHub)" <gi...@apache.org>.
nagarjunahp88-byte commented on PR #5218:
URL: https://github.com/apache/eventmesh/pull/5218#issuecomment-3688948897

   The CI failure seems to be related to Gradle build scan publishing
   (develocity.apache.org authentication required), not a compilation
   or test failure.
   
   Please let me know if this is expected or if any change is needed
   from my side.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] Fix #5205: Handle invalid SubscriptionMode values safely (eventmesh)

Posted by "nagarjunahp88-byte (via GitHub)" <gi...@apache.org>.
nagarjunahp88-byte commented on PR #5218:
URL: https://github.com/apache/eventmesh/pull/5218#issuecomment-3687218860

   Thanks for the review!
   I’ve updated the code style and added unit tests to cover invalid and null SubscriptionMode values.
   Please take another look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] Fix #5205: Handle invalid SubscriptionMode values safely (eventmesh)

Posted by "nagarjunahp88-byte (via GitHub)" <gi...@apache.org>.
nagarjunahp88-byte commented on PR #5218:
URL: https://github.com/apache/eventmesh/pull/5218#issuecomment-3688687572

   Hi, I’m a new contributor.
   I tried joining the ASF Slack via https://s.apache.org/slack-invite
   but I’m unable to join since I don’t have an @apache.org email yet.
   Could someone please help me with Slack access or guide me to the right channel?
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org