You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/04/19 13:12:38 UTC

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang 

zhaorenhai@hotmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15755


Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................

IMPALA-9676 Add aarch64 compile options for clang

Add signed-char and armv8a and crc compile options to clang

Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
---
M be/CMakeLists.txt
1 file changed, 7 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/15755/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................

IMPALA-9676 Add aarch64 compile options for clang

Add signed-char and armv8a and crc compile options to clang

Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
---
M be/CMakeLists.txt
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/15755/15
-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 15
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................

IMPALA-9676 Add aarch64 compile options for clang

Add signed-char and armv8a and crc compile options to clang

Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
---
M be/CMakeLists.txt
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/15755/11
-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 11
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................

IMPALA-9676 Add aarch64 compile options for clang

Add signed-char and armv8a and crc compile options to clang

Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
---
M be/CMakeLists.txt
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/15755/14
-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 14
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 12:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6560/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 12
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 11 Jul 2020 13:11:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 10:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6110/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 10
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 May 2020 03:28:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 14:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6647/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 14
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Jul 2020 04:13:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................

IMPALA-9676 Add aarch64 compile options for clang

Add signed-char and armv8a and crc compile options to clang

Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
---
M be/CMakeLists.txt
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/15755/8
-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 18: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 18
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Aug 2020 02:22:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 8:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6035/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 8
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 May 2020 04:15:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 18:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6890/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 18
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Aug 2020 09:44:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 15: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 15
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Aug 2020 22:18:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 15:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6669/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 15
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Jul 2020 02:10:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 6:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6005/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 02:45:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................

IMPALA-9676 Add aarch64 compile options for clang

Add signed-char and armv8a and crc compile options to clang

Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
---
M be/CMakeLists.txt
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/15755/6
-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 6
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#18). ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................

IMPALA-9676 Add aarch64 compile options for clang

Add signed-char and armv8a and crc compile options to clang

Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
---
M be/CMakeLists.txt
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/15755/18
-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 18
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/5828/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 19 Apr 2020 13:31:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................

IMPALA-9676 Add aarch64 compile options for clang

Add signed-char and armv8a and crc compile options to clang

Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
---
M be/CMakeLists.txt
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/15755/10
-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 10
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................

IMPALA-9676 Add aarch64 compile options for clang

Add signed-char and armv8a and crc compile options to clang

Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
---
M be/CMakeLists.txt
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/15755/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 7:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6020/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 02:33:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................

IMPALA-9676 Add aarch64 compile options for clang

Add signed-char and armv8a and crc compile options to clang

Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
---
M be/CMakeLists.txt
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/15755/12
-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 12
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................

IMPALA-9676 Add aarch64 compile options for clang

Add signed-char and armv8a and crc compile options to clang

Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Reviewed-on: http://gerrit.cloudera.org:8080/15755
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M be/CMakeLists.txt
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Tim Armstrong: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 19
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 16:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6832/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 16
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Aug 2020 20:36:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 18: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 18
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Aug 2020 16:23:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 11:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/6283/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 11
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Jun 2020 11:00:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................

IMPALA-9676 Add aarch64 compile options for clang

Add signed-char and armv8a and crc compile options to clang

Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
---
M be/CMakeLists.txt
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/15755/16
-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 16
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 16: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 16
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Aug 2020 21:08:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................

IMPALA-9676 Add aarch64 compile options for clang

Add signed-char and armv8a and crc compile options to clang

Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
---
M be/CMakeLists.txt
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/15755/7
-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 17:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6849/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 17
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Aug 2020 12:06:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
zhaorenhai@hotmail.com has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................

IMPALA-9676 Add aarch64 compile options for clang

Add signed-char and armv8a and crc compile options to clang

Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
---
M be/CMakeLists.txt
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/15755/17
-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 17
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 17: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 17
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Aug 2020 18:18:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9676 Add aarch64 compile options for clang

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15755 )

Change subject: IMPALA-9676 Add aarch64 compile options for clang
......................................................................


Patch Set 4:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/5988/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/15755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69a5ff64bbd4427dd87ec6e884251e76d6a73122
Gerrit-Change-Number: 15755
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 09:58:29 +0000
Gerrit-HasComments: No