You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Nicolas Malin <ni...@nereide.fr> on 2017/08/16 11:49:04 UTC

Common-theme next step

Hello;

To continue the common-theme subject, I haven't see negative return to 
the issue Create a common theme (OFBIZ-9138) [1] and on threads on the 
same subject [2] and the additional theme xml definition [3], I suggest 
to create a documentation on the wiki how work the "theme engine" and 
commit the current git branch [4] [5] on trunk

After that, the engine will be present on the trunk and we continue the 
work to :
* Clean the common-theme and create a real theme
* Migrate properly the current theme with the new structure
* Analyze more how organize the screen api

But don't panic, before that I'm listening to all suggest or remarks ;)

Nicolas

[1] https://issues.apache.org/jira/browse/OFBIZ-9138
[2] 
https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
[3] 
https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
[4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
[5] 
https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1


-- 
logoNrd <https://nereide.fr/>
	Nicolas Malin
The apache way <http://theapacheway.com/> : *Openness* Technical 
decisions are made publicly
information@nereide.fr
8 rue des Déportés 37000 TOURS, 02 47 50 30 54

Apache OFBiz <http://ofbiz.apache.org/>|The Apache Way 
<http://theapacheway.com/>|ofbiz-fr <http://www.ofbiz-fr.org/>|réseau LE 
<http://www.libre-entreprise.org/>

Re: Common-theme next step

Posted by Taher Alkhateeb <sl...@gmail.com>.
I wanted to thank you again for this work Nicolas. Hopefully with a little
more time and refinement we can purge all "web" stuff outside the framework
and make it a pure DSL infrastructure independent of the output technology.
This also opens the door for selecting front end technology stacks without
touching the core.

On Aug 25, 2017 3:35 PM, "Nicolas Malin" <ni...@nereide.fr> wrote:

Hello

Le 25/08/2017 à 12:54, Deepak Dixit a écrit :

> Thanks Nicolas, Nice work.
>
Thanks Deepak, in line

I noticed some console warning while data load
> {quote}
>
> 2017-08-25 16:14:37,945 |main                 |UtilXml
>    |E| XmlFileLoader: File
> file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight
> /widget/Theme.xml
> process error. Line: 20. Error message: TargetNamespace.2: Expecting no
> namespace, but the schema document has a target namespace of '
> http://ofbiz.apache.org/Widget-Theme'.
>
> 2017-08-25 16:14:37,946 |main                 |UtilXml
>    |E| XmlFileLoader: File
> file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight
> /widget/Theme.xml
> process error. Line: 23. Error message: cvc-elt.1: Cannot find the
> declaration of element 'theme'.
>
> {quote}
>
Yes I detected it during my work, but I supposed to push the theme dtd on
the website will be solve it.
Else I will complete my knowledge with this mistake :)

Nicolas


> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> www.hotwax.co
>
> On Fri, Aug 25, 2017 at 3:45 PM, Nicolas Malin <ni...@nereide.fr>
> wrote:
>
> I loaded all my local :)
>>
>> Le 25/08/2017 à 00:03, Nicolas Malin a écrit :
>>
>> I started to load common-theme on trunk, at this time to resume :
>>>
>>> r1806075, r1806076 : I loaded engine and documentation
>>> r1806084 : I moved all images folder to common-theme
>>> r1806091, r1806093: I moved all ftl template from common to common-theme
>>> and all macro ftl libraries.
>>>
>>> 1806134 : load VisualTheme and ModelTheme on different session and
>> context
>> 1806137, 180614[0-9] : Migrate themes, common screens, handler to exploit
>> values from the theme definition
>> 1806150 : migrate all other screen and scripts  to exploit values from the
>> theme definition
>> 180615 : improve error message and announce the commit end :)
>>
>> Cheers,
>> Nicolas
>>
>>
>> I hope to break nothing at this time.
>>> The next steps will load the dynamic theme load on session
>>>
>>> Cheers,
>>>
>>> Nicolas
>>>
>>>
>>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
>>>
>>> Hi Taher,
>>>>
>>>> If you have few time to have a look on these three class :
>>>>
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> model/ModelTheme.java
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> model/ThemeFactory.java
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> renderer/VisualTheme.java
>>>>
>>>> ModelTheme is java class to load all Theme definition who interact with
>>>> the system
>>>>
>>>> VisualTheme is java class regards the VisualTheme entity who interact
>>>> with the user to exploit the modelTheme
>>>>
>>>> ThemeFactory is the factory to create both.
>>>>
>>>> I prepare my commits, but I need to separate properly each code
>>>> modification to help other learn the work.
>>>>
>>>> Cheers,
>>>> Nicolas
>>>>
>>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>>>>
>>>> Hi Nicolas,
>>>>>
>>>>> If it helps you, I suggest to isolate files / code where you are not
>>>>> very comfortable and put them in a separate patch (not the full patch)
>>>>> with an explanation of what you've done and where you feel a little
>>>>> hesitant or uneasy. I think if you make us focus with you on very
>>>>> specific pieces of code then our review will be faster and your
>>>>> confidence of the review will be better.
>>>>>
>>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>>>>> <ni...@nereide.fr> wrote:
>>>>>
>>>>> Thanks,
>>>>>>
>>>>>> I will commit on trunk after a second review of my code because i was
>>>>>> concentrated to increase the flexibility with macro and screen but not
>>>>>> manage correctly the VisualTheme concept.
>>>>>>
>>>>>> So I will take care about this, complete the documentation and commit
>>>>>> on
>>>>>> trunk.
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>>
>>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>>>>
>>>>>> Like Michael, I also prefer to include the work into the code base and
>>>>>>> test it over there. It seems like you put a lot of effort into this
>>>>>>> code so thank you! I like the fact that you brought all the artifacts
>>>>>>> into the theme along with the FTL macros. This is a good first step,
>>>>>>> and I believe continuing on this direction is where we need to go.
>>>>>>>
>>>>>>> +1 to committing into the code base and testing over there.
>>>>>>>
>>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>>>>> <ja...@les7arts.com> wrote:
>>>>>>>
>>>>>>> That sounds great,
>>>>>>>>
>>>>>>>> Thanks Nicolas!
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>>>>
>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> I started the documentation here
>>>>>>>>>
>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>> themes/README.md
>>>>>>>>>
>>>>>>>>> It's a begging, I hope improve it quickly
>>>>>>>>>
>>>>>>>>> Nicolas
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>>>>
>>>>>>>>> Hello;
>>>>>>>>>>
>>>>>>>>>> To continue the common-theme subject, I haven't see negative
>>>>>>>>>> return to
>>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on
>>>>>>>>>> the
>>>>>>>>>> same
>>>>>>>>>> subject [2] and the additional theme xml definition [3], I suggest
>>>>>>>>>> to
>>>>>>>>>> create
>>>>>>>>>> a documentation on the wiki how work the "theme engine" and commit
>>>>>>>>>> the
>>>>>>>>>> current git branch [4] [5] on trunk
>>>>>>>>>>
>>>>>>>>>> After that, the engine will be present on the trunk and we
>>>>>>>>>> continue the
>>>>>>>>>> work to :
>>>>>>>>>> * Clean the common-theme and create a real theme
>>>>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>>>>> * Analyze more how organize the screen api
>>>>>>>>>>
>>>>>>>>>> But don't panic, before that I'm listening to all suggest or
>>>>>>>>>> remarks ;)
>>>>>>>>>>
>>>>>>>>>> Nicolas
>>>>>>>>>>
>>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>>>>> [2]
>>>>>>>>>>
>>>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15
>>>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>> [3]
>>>>>>>>>>
>>>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38ab
>>>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>>>>>>> [5]
>>>>>>>>>>
>>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...
>>>>>>>>>> nmalin:common-theme?expand=1
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>
>>>

Re: Common-theme next step

Posted by Nicolas Malin <ni...@nereide.fr>.
:) thanks Deepak for your support you fill my weaknesses.

Nicolas

Le 25/08/2017 à 20:31, Deepak Dixit a écrit :
> Thanks Nicolas for your effort.
> I confirm that above reported warning has been fixed.
> I found some more console warning related to xml schema validation, those
> has been fixed at r# 1806206, 1806209, 1806211
> Also updated the site xsd at r#1806208 and r#1806210
>
>
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> www.hotwax.co
>
> On Fri, Aug 25, 2017 at 6:50 PM, Nicolas Malin <ni...@nereide.fr>
> wrote:
>
>> Le 25/08/2017 à 14:34, Nicolas Malin a écrit :
>>
>>> Yes I detected it during my work, but I supposed to push the theme dtd on
>>> the website will be solve it.
>>> Else I will complete my knowledge with this mistake :)
>>>
>> Ok it's a mistake, idea help me to resolve this issue because I not
>> understand all. Commited at r1806170, can you confirm that it's solved ?
>>
>> Nicolas
>>


Re: Common-theme next step

Posted by Deepak Dixit <de...@hotwaxsystems.com>.
Thanks Nicolas for your effort.
I confirm that above reported warning has been fixed.
I found some more console warning related to xml schema validation, those
has been fixed at r# 1806206, 1806209, 1806211
Also updated the site xsd at r#1806208 and r#1806210



Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Fri, Aug 25, 2017 at 6:50 PM, Nicolas Malin <ni...@nereide.fr>
wrote:

> Le 25/08/2017 à 14:34, Nicolas Malin a écrit :
>
>> Yes I detected it during my work, but I supposed to push the theme dtd on
>> the website will be solve it.
>> Else I will complete my knowledge with this mistake :)
>>
> Ok it's a mistake, idea help me to resolve this issue because I not
> understand all. Commited at r1806170, can you confirm that it's solved ?
>
> Nicolas
>

Re: Common-theme next step

Posted by Nicolas Malin <ni...@nereide.fr>.
Le 25/08/2017 à 14:34, Nicolas Malin a écrit :
> Yes I detected it during my work, but I supposed to push the theme dtd 
> on the website will be solve it.
> Else I will complete my knowledge with this mistake :)
Ok it's a mistake, idea help me to resolve this issue because I not 
understand all. Commited at r1806170, can you confirm that it's solved ?

Nicolas

Re: Common-theme next step

Posted by Nicolas Malin <ni...@nereide.fr>.
Hello

Le 25/08/2017 à 12:54, Deepak Dixit a écrit :
> Thanks Nicolas, Nice work.
Thanks Deepak, in line
> I noticed some console warning while data load
> {quote}
>
> 2017-08-25 16:14:37,945 |main                 |UtilXml
>    |E| XmlFileLoader: File
> file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight/widget/Theme.xml
> process error. Line: 20. Error message: TargetNamespace.2: Expecting no
> namespace, but the schema document has a target namespace of '
> http://ofbiz.apache.org/Widget-Theme'.
>
> 2017-08-25 16:14:37,946 |main                 |UtilXml
>    |E| XmlFileLoader: File
> file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight/widget/Theme.xml
> process error. Line: 23. Error message: cvc-elt.1: Cannot find the
> declaration of element 'theme'.
>
> {quote}
Yes I detected it during my work, but I supposed to push the theme dtd 
on the website will be solve it.
Else I will complete my knowledge with this mistake :)

Nicolas
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> www.hotwax.co
>
> On Fri, Aug 25, 2017 at 3:45 PM, Nicolas Malin <ni...@nereide.fr>
> wrote:
>
>> I loaded all my local :)
>>
>> Le 25/08/2017 à 00:03, Nicolas Malin a écrit :
>>
>>> I started to load common-theme on trunk, at this time to resume :
>>>
>>> r1806075, r1806076 : I loaded engine and documentation
>>> r1806084 : I moved all images folder to common-theme
>>> r1806091, r1806093: I moved all ftl template from common to common-theme
>>> and all macro ftl libraries.
>>>
>> 1806134 : load VisualTheme and ModelTheme on different session and context
>> 1806137, 180614[0-9] : Migrate themes, common screens, handler to exploit
>> values from the theme definition
>> 1806150 : migrate all other screen and scripts  to exploit values from the
>> theme definition
>> 180615 : improve error message and announce the commit end :)
>>
>> Cheers,
>> Nicolas
>>
>>
>>> I hope to break nothing at this time.
>>> The next steps will load the dynamic theme load on session
>>>
>>> Cheers,
>>>
>>> Nicolas
>>>
>>>
>>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
>>>
>>>> Hi Taher,
>>>>
>>>> If you have few time to have a look on these three class :
>>>>
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> model/ModelTheme.java
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> model/ThemeFactory.java
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> renderer/VisualTheme.java
>>>>
>>>> ModelTheme is java class to load all Theme definition who interact with
>>>> the system
>>>>
>>>> VisualTheme is java class regards the VisualTheme entity who interact
>>>> with the user to exploit the modelTheme
>>>>
>>>> ThemeFactory is the factory to create both.
>>>>
>>>> I prepare my commits, but I need to separate properly each code
>>>> modification to help other learn the work.
>>>>
>>>> Cheers,
>>>> Nicolas
>>>>
>>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>>>>
>>>>> Hi Nicolas,
>>>>>
>>>>> If it helps you, I suggest to isolate files / code where you are not
>>>>> very comfortable and put them in a separate patch (not the full patch)
>>>>> with an explanation of what you've done and where you feel a little
>>>>> hesitant or uneasy. I think if you make us focus with you on very
>>>>> specific pieces of code then our review will be faster and your
>>>>> confidence of the review will be better.
>>>>>
>>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>>>>> <ni...@nereide.fr> wrote:
>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> I will commit on trunk after a second review of my code because i was
>>>>>> concentrated to increase the flexibility with macro and screen but not
>>>>>> manage correctly the VisualTheme concept.
>>>>>>
>>>>>> So I will take care about this, complete the documentation and commit
>>>>>> on
>>>>>> trunk.
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>>
>>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>>>>
>>>>>>> Like Michael, I also prefer to include the work into the code base and
>>>>>>> test it over there. It seems like you put a lot of effort into this
>>>>>>> code so thank you! I like the fact that you brought all the artifacts
>>>>>>> into the theme along with the FTL macros. This is a good first step,
>>>>>>> and I believe continuing on this direction is where we need to go.
>>>>>>>
>>>>>>> +1 to committing into the code base and testing over there.
>>>>>>>
>>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>>>>> <ja...@les7arts.com> wrote:
>>>>>>>
>>>>>>>> That sounds great,
>>>>>>>>
>>>>>>>> Thanks Nicolas!
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>>>>
>>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> I started the documentation here
>>>>>>>>>
>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>> themes/README.md
>>>>>>>>>
>>>>>>>>> It's a begging, I hope improve it quickly
>>>>>>>>>
>>>>>>>>> Nicolas
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>>>>
>>>>>>>>>> Hello;
>>>>>>>>>>
>>>>>>>>>> To continue the common-theme subject, I haven't see negative
>>>>>>>>>> return to
>>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on
>>>>>>>>>> the
>>>>>>>>>> same
>>>>>>>>>> subject [2] and the additional theme xml definition [3], I suggest
>>>>>>>>>> to
>>>>>>>>>> create
>>>>>>>>>> a documentation on the wiki how work the "theme engine" and commit
>>>>>>>>>> the
>>>>>>>>>> current git branch [4] [5] on trunk
>>>>>>>>>>
>>>>>>>>>> After that, the engine will be present on the trunk and we
>>>>>>>>>> continue the
>>>>>>>>>> work to :
>>>>>>>>>> * Clean the common-theme and create a real theme
>>>>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>>>>> * Analyze more how organize the screen api
>>>>>>>>>>
>>>>>>>>>> But don't panic, before that I'm listening to all suggest or
>>>>>>>>>> remarks ;)
>>>>>>>>>>
>>>>>>>>>> Nicolas
>>>>>>>>>>
>>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>>>>> [2]
>>>>>>>>>>
>>>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15
>>>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>> [3]
>>>>>>>>>>
>>>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38ab
>>>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>>>>>>> [5]
>>>>>>>>>>
>>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...
>>>>>>>>>> nmalin:common-theme?expand=1
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>
>>>


Re: Common-theme next step

Posted by Deepak Dixit <de...@hotwaxsystems.com>.
Thanks Nicolas, Nice work.
I noticed some console warning while data load
{quote}

2017-08-25 16:14:37,945 |main                 |UtilXml
  |E| XmlFileLoader: File
file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight/widget/Theme.xml
process error. Line: 20. Error message: TargetNamespace.2: Expecting no
namespace, but the schema document has a target namespace of '
http://ofbiz.apache.org/Widget-Theme'.

2017-08-25 16:14:37,946 |main                 |UtilXml
  |E| XmlFileLoader: File
file:/Users/deepakdixit/sandbox/plain_ofbiz/themes/bluelight/widget/Theme.xml
process error. Line: 23. Error message: cvc-elt.1: Cannot find the
declaration of element 'theme'.

{quote}

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Fri, Aug 25, 2017 at 3:45 PM, Nicolas Malin <ni...@nereide.fr>
wrote:

> I loaded all my local :)
>
> Le 25/08/2017 à 00:03, Nicolas Malin a écrit :
>
>> I started to load common-theme on trunk, at this time to resume :
>>
>> r1806075, r1806076 : I loaded engine and documentation
>> r1806084 : I moved all images folder to common-theme
>> r1806091, r1806093: I moved all ftl template from common to common-theme
>> and all macro ftl libraries.
>>
> 1806134 : load VisualTheme and ModelTheme on different session and context
> 1806137, 180614[0-9] : Migrate themes, common screens, handler to exploit
> values from the theme definition
> 1806150 : migrate all other screen and scripts  to exploit values from the
> theme definition
> 180615 : improve error message and announce the commit end :)
>
> Cheers,
> Nicolas
>
>
>> I hope to break nothing at this time.
>> The next steps will load the dynamic theme load on session
>>
>> Cheers,
>>
>> Nicolas
>>
>>
>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
>>
>>> Hi Taher,
>>>
>>> If you have few time to have a look on these three class :
>>>
>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>> model/ModelTheme.java
>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>> model/ThemeFactory.java
>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>> renderer/VisualTheme.java
>>>
>>> ModelTheme is java class to load all Theme definition who interact with
>>> the system
>>>
>>> VisualTheme is java class regards the VisualTheme entity who interact
>>> with the user to exploit the modelTheme
>>>
>>> ThemeFactory is the factory to create both.
>>>
>>> I prepare my commits, but I need to separate properly each code
>>> modification to help other learn the work.
>>>
>>> Cheers,
>>> Nicolas
>>>
>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>>>
>>>> Hi Nicolas,
>>>>
>>>> If it helps you, I suggest to isolate files / code where you are not
>>>> very comfortable and put them in a separate patch (not the full patch)
>>>> with an explanation of what you've done and where you feel a little
>>>> hesitant or uneasy. I think if you make us focus with you on very
>>>> specific pieces of code then our review will be faster and your
>>>> confidence of the review will be better.
>>>>
>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>>>> <ni...@nereide.fr> wrote:
>>>>
>>>>> Thanks,
>>>>>
>>>>> I will commit on trunk after a second review of my code because i was
>>>>> concentrated to increase the flexibility with macro and screen but not
>>>>> manage correctly the VisualTheme concept.
>>>>>
>>>>> So I will take care about this, complete the documentation and commit
>>>>> on
>>>>> trunk.
>>>>>
>>>>> Nicolas
>>>>>
>>>>>
>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>>>
>>>>>> Like Michael, I also prefer to include the work into the code base and
>>>>>> test it over there. It seems like you put a lot of effort into this
>>>>>> code so thank you! I like the fact that you brought all the artifacts
>>>>>> into the theme along with the FTL macros. This is a good first step,
>>>>>> and I believe continuing on this direction is where we need to go.
>>>>>>
>>>>>> +1 to committing into the code base and testing over there.
>>>>>>
>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>>>> <ja...@les7arts.com> wrote:
>>>>>>
>>>>>>> That sounds great,
>>>>>>>
>>>>>>> Thanks Nicolas!
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>>
>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>>>
>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> I started the documentation here
>>>>>>>>
>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>> themes/README.md
>>>>>>>>
>>>>>>>> It's a begging, I hope improve it quickly
>>>>>>>>
>>>>>>>> Nicolas
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>>>
>>>>>>>>> Hello;
>>>>>>>>>
>>>>>>>>> To continue the common-theme subject, I haven't see negative
>>>>>>>>> return to
>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on
>>>>>>>>> the
>>>>>>>>> same
>>>>>>>>> subject [2] and the additional theme xml definition [3], I suggest
>>>>>>>>> to
>>>>>>>>> create
>>>>>>>>> a documentation on the wiki how work the "theme engine" and commit
>>>>>>>>> the
>>>>>>>>> current git branch [4] [5] on trunk
>>>>>>>>>
>>>>>>>>> After that, the engine will be present on the trunk and we
>>>>>>>>> continue the
>>>>>>>>> work to :
>>>>>>>>> * Clean the common-theme and create a real theme
>>>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>>>> * Analyze more how organize the screen api
>>>>>>>>>
>>>>>>>>> But don't panic, before that I'm listening to all suggest or
>>>>>>>>> remarks ;)
>>>>>>>>>
>>>>>>>>> Nicolas
>>>>>>>>>
>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>>>> [2]
>>>>>>>>>
>>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15
>>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>> [3]
>>>>>>>>>
>>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38ab
>>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>>>>>> [5]
>>>>>>>>>
>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...
>>>>>>>>> nmalin:common-theme?expand=1
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>
>>>
>>
>>
>

Re: Common-theme next step

Posted by Swapnil Mane <sw...@hotwaxsystems.com>.
Thank you Jacques!
Done - https://issues.apache.org/jira/browse/OFBIZ-9794


- Best Regards,
Swapnil M Mane

On Tue, Sep 26, 2017 at 8:40 PM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:

> Hi Swapnil,
>
> Could you please open a Jira for your case?
>
> I'll double check mine and will add it also
>
> Thanks
>
> Jacques
>
>
>
> Le 26/09/2017 à 10:46, Swapnil Mane a écrit :
>
>> Yes Jacques, thanks for looking into this.
>>
>>
>> - Best Regards,
>> Swapnil M Mane
>>
>> On Tue, Sep 26, 2017 at 2:08 PM, Jacques Le Roux <
>> jacques.le.roux@les7arts.com> wrote:
>>
>> Hi Swapnil, All,
>>>
>>> This is a real problem, I just crossed it also with
>>>
>>> 2017-09-26 10:03:34,730 |jsse-nio-8443-exec-6
>>> |ServiceDispatcher             |T| [[ASync service failed...-
>>> total:0.004,since last(ASync service sta...):0.004]] - 'ecommerce /
>>> sendOrderConfirmation'
>>> 2017-09-26 10:03:34,730 |jsse-nio-8443-exec-6
>>> |ServiceDispatcher             |E| Service [sendOrderConfirmation] threw
>>> an
>>> unexpected exception/error
>>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>>> service attributes (Cannot serialize object of class
>>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>>
>>> and
>>>
>>> 2017-09-26 10:03:40,283 |jsse-nio-8443-exec-6
>>> |ScreenFactory                 |I| Got 2 screens in 0.005s from:
>>> file:/C:/projectsASF/ofbiz/plugins/ecommerce/widget/Shopping
>>> ListScreens.xml
>>> 2017-09-26 10:03:40,578 |jsse-nio-8443-exec-6
>>> |ScriptUtil                    |W| Error running script at location
>>> [component://ecommerce/groovyScripts/shoppinglist/EditShoppi
>>> ngList.groovy]:
>>> org.codehaus.groov
>>> y.runtime.typehandling.GroovyCastException: Cannot cast object 'USD'
>>> with
>>> class 'java.lang.String' to class 'org.apache.ofbiz.widget.rende
>>> rer.VisualTheme'
>>> org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot
>>> cast
>>> object 'USD' with class 'java.lang.String' to class
>>> 'org.apache.ofbiz.widget.renderer.VisualTheme'
>>>
>>> I have no other ideas yet (working on something else). But I'll have a
>>> look ASAP
>>>
>>> Jacques
>>>
>>>
>>>
>>> Le 23/09/2017 à 11:11, Swapnil Mane a écrit :
>>>
>>> Thanks Jacques for your timings and suggestion.
>>>> @SuppressWarnings("serial") doesn't work for me.
>>>>
>>>> ========= Console Log start =========
>>>>
>>>> 2017-09-23 14:38:25,610 |jsse-nio-8443-exec-8
>>>> |ServiceDispatcher             |T| [[ASync service started...-
>>>> total:0.0,since last(Begin):0.0]] - 'manufacturing / executeMrp'
>>>> 2017-09-23 14:38:25,630 |jsse-nio-8443-exec-8
>>>> |SequenceUtil                  |I| Got bank of sequenced IDs for
>>>> [RuntimeData]; curSeqId=10600, maxSeqId=10700, bankSize=100
>>>> 2017-09-23 14:38:25,649 |jsse-nio-8443-exec-8
>>>> |UtilObject                    |E| null
>>>> java.io.NotSerializableException: org.apache.ofbiz.widget.model.
>>>> ModelTheme$ModelTemplate
>>>>           at java.io.ObjectOutputStream.wri
>>>> teObject0(ObjectOutputStream.
>>>> java:1184)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.
>>>> java:348)
>>>> ~[?:1.8.0_66]
>>>>           at java.util.HashMap.internalWriteEntries(HashMap.java:1777)
>>>> ~[?:1.8.0_66]
>>>>           at java.util.HashMap.writeObject(HashMap.java:1354)
>>>> ~[?:1.8.0_66]
>>>>           at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
>>>> Method)
>>>> ~[?:1.8.0_66]
>>>>           at sun.reflect.NativeMethodAccessorImpl.invoke(
>>>> NativeMethodAccessorImpl.java:62) ~[?:1.8.0_66]
>>>>           at sun.reflect.DelegatingMethodAccessorImpl.invoke(
>>>> DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_66]
>>>>           at java.lang.reflect.Method.invoke(Method.java:497)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectStreamClass.invo
>>>> keWriteObject(ObjectStreamClas
>>>> s.java:1028)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.wri
>>>> teSerialData(ObjectOutputStrea
>>>> m.java:1496)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.wri
>>>> teOrdinaryObject(ObjectOutputS
>>>> tream.java:1432)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.wri
>>>> teObject0(ObjectOutputStream.
>>>> java:1178)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.def
>>>> aultWriteFields(ObjectOutputSt
>>>> ream.java:1548)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.wri
>>>> teSerialData(ObjectOutputStrea
>>>> m.java:1509)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.wri
>>>> teOrdinaryObject(ObjectOutputS
>>>> tream.java:1432)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.wri
>>>> teObject0(ObjectOutputStream.
>>>> java:1178)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.def
>>>> aultWriteFields(ObjectOutputSt
>>>> ream.java:1548)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.wri
>>>> teSerialData(ObjectOutputStrea
>>>> m.java:1509)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.wri
>>>> teOrdinaryObject(ObjectOutputS
>>>> tream.java:1432)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.wri
>>>> teObject0(ObjectOutputStream.
>>>> java:1178)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.def
>>>> aultWriteFields(ObjectOutputSt
>>>> ream.java:1548)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.wri
>>>> teSerialData(ObjectOutputStrea
>>>> m.java:1509)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.wri
>>>> teOrdinaryObject(ObjectOutputS
>>>> tream.java:1432)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.wri
>>>> teObject0(ObjectOutputStream.
>>>> java:1178)
>>>> ~[?:1.8.0_66]
>>>>           at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.
>>>> java:348)
>>>> ~[?:1.8.0_66]
>>>>           at org.apache.ofbiz.base.util.UtilObject.getBytes(UtilObject.
>>>> java:82)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>>> serializeCustom(XmlSerializer.java:262) [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>>> serializeSingle(XmlSerializer.java:257) [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>>> serializeSingle(XmlSerializer.java:252) [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>>> serialize(XmlSerializer.java:78) [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>>> runAsync(GenericAsyncEngine.java:94) [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>>> runAsync(GenericAsyncEngine.java:70) [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.Servi
>>>> ceDispatcher.runAsync(ServiceD
>>>> ispatcher.java:715)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.Servi
>>>> ceDispatcher.runAsync(ServiceD
>>>> ispatcher.java:780)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.GenericDispatcherFactory$
>>>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.GenericDispatcherFactory$
>>>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.event.
>>>> ServiceEventHandler.invoke(Ser
>>>> viceEventHandler.java:348)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.control.RequestHandler.
>>>> runEvent(RequestHandler.java:730) [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.control.RequestHandler.
>>>> doRequest(RequestHandler.java:454) [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.contro
>>>> l.ControlServlet.doGet(Control
>>>> Servlet.java:212)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.contro
>>>> l.ControlServlet.doPost(Contro
>>>> lServlet.java:87)
>>>> [ofbiz.jar:?]
>>>>           at javax.servlet.http.HttpServlet
>>>> .service(HttpServlet.java:707)
>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>           at javax.servlet.http.HttpServlet
>>>> .service(HttpServlet.java:790)
>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>           at org.apache.catalina.core.Appli
>>>> cationFilterChain.internalDoFi
>>>> lter(
>>>> ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.tomcat.websocket.se
>>>> rver.WsFilter.doFilter(WsFilte
>>>> r.java:52)
>>>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>>>           at org.apache.catalina.core.Appli
>>>> cationFilterChain.internalDoFi
>>>> lter(
>>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.ofbiz.webapp.control.ContextFilter.
>>>> doFilter(ContextFilter.java:196) [ofbiz.jar:?]
>>>>           at org.apache.catalina.core.Appli
>>>> cationFilterChain.internalDoFi
>>>> lter(
>>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.ofbiz.webapp.control.ControlFilter.
>>>> doFilter(ControlFilter.java:157) [ofbiz.jar:?]
>>>>           at org.apache.catalina.core.Appli
>>>> cationFilterChain.internalDoFi
>>>> lter(
>>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.Stand
>>>> ardWrapperValve.invoke(Standar
>>>> dWrapperValve.java:198)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.Stand
>>>> ardContextValve.invoke(Standar
>>>> dContextValve.java:96)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.authentica
>>>> tor.AuthenticatorBase.invoke(A
>>>> uthenticatorBase.java:478)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.Stand
>>>> ardHostValve.invoke(StandardHo
>>>> stValve.java:140)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.valves.Err
>>>> orReportValve.invoke(ErrorRepo
>>>> rtValve.java:80)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.Stand
>>>> ardEngineValve.invoke(Standard
>>>> EngineValve.java:87)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
>>>> AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.connector.
>>>> CoyoteAdapter.service(CoyoteAd
>>>> apter.java:342)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.coyote.http11.Http1
>>>> 1Processor.service(Http11Proce
>>>> ssor.java:799)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at org.apache.coyote.AbstractProcessorLight.process(
>>>> AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at org.apache.coyote.AbstractProtocol$ConnectionHandler.
>>>> process(AbstractProtocol.java:868)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at org.apache.tomcat.util.net.Nio
>>>> Endpoint$SocketProcessor.doRun
>>>> (NioEndpoint.java:1455)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at org.apache.tomcat.util.net.Soc
>>>> ketProcessorBase.run(SocketPro
>>>> cessorBase.java:49)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at java.util.concurrent.ThreadPoo
>>>> lExecutor.runWorker(ThreadPool
>>>> Executor.java:1142)
>>>> [?:1.8.0_66]
>>>>           at java.util.concurrent.ThreadPoo
>>>> lExecutor$Worker.run(ThreadPoo
>>>> lExecutor.java:617)
>>>> [?:1.8.0_66]
>>>>           at org.apache.tomcat.util.threads
>>>> .TaskThread$WrappingRunnable.
>>>> run(TaskThread.java:61)
>>>> [tomcat-util-8.5.16.jar:8.5.16]
>>>>           at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>>>> 2017-09-23 14:38:25,653 |jsse-nio-8443-exec-8
>>>> |ServiceDispatcher             |T| [[ASync service failed...-
>>>> total:0.043,since last(ASync service sta...):0.043]] - 'manufacturing /
>>>> executeMrp'
>>>> 2017-09-23 14:38:25,653 |jsse-nio-8443-exec-8
>>>> |ServiceDispatcher             |E| Service [executeMrp] threw an
>>>> unexpected
>>>> exception/error
>>>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>>>> service attributes (Unable to serialize object; null byte array
>>>> returned)
>>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>>> runAsync(GenericAsyncEngine.java:124) ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>>> runAsync(GenericAsyncEngine.java:70) ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.Servi
>>>> ceDispatcher.runAsync(ServiceD
>>>> ispatcher.java:715)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.Servi
>>>> ceDispatcher.runAsync(ServiceD
>>>> ispatcher.java:780)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.GenericDispatcherFactory$
>>>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.GenericDispatcherFactory$
>>>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.event.
>>>> ServiceEventHandler.invoke(Ser
>>>> viceEventHandler.java:348)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.control.RequestHandler.
>>>> runEvent(RequestHandler.java:730) [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.control.RequestHandler.
>>>> doRequest(RequestHandler.java:454) [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.contro
>>>> l.ControlServlet.doGet(Control
>>>> Servlet.java:212)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.contro
>>>> l.ControlServlet.doPost(Contro
>>>> lServlet.java:87)
>>>> [ofbiz.jar:?]
>>>>           at javax.servlet.http.HttpServlet
>>>> .service(HttpServlet.java:707)
>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>           at javax.servlet.http.HttpServlet
>>>> .service(HttpServlet.java:790)
>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>           at org.apache.catalina.core.Appli
>>>> cationFilterChain.internalDoFi
>>>> lter(
>>>> ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.tomcat.websocket.se
>>>> rver.WsFilter.doFilter(WsFilte
>>>> r.java:52)
>>>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>>>           at org.apache.catalina.core.Appli
>>>> cationFilterChain.internalDoFi
>>>> lter(
>>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.ofbiz.webapp.control.ContextFilter.
>>>> doFilter(ContextFilter.java:196) [ofbiz.jar:?]
>>>>           at org.apache.catalina.core.Appli
>>>> cationFilterChain.internalDoFi
>>>> lter(
>>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.ofbiz.webapp.control.ControlFilter.
>>>> doFilter(ControlFilter.java:157) [ofbiz.jar:?]
>>>>           at org.apache.catalina.core.Appli
>>>> cationFilterChain.internalDoFi
>>>> lter(
>>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.Stand
>>>> ardWrapperValve.invoke(Standar
>>>> dWrapperValve.java:198)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.Stand
>>>> ardContextValve.invoke(Standar
>>>> dContextValve.java:96)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.authentica
>>>> tor.AuthenticatorBase.invoke(A
>>>> uthenticatorBase.java:478)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.Stand
>>>> ardHostValve.invoke(StandardHo
>>>> stValve.java:140)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.valves.Err
>>>> orReportValve.invoke(ErrorRepo
>>>> rtValve.java:80)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.Stand
>>>> ardEngineValve.invoke(Standard
>>>> EngineValve.java:87)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
>>>> AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.connector.
>>>> CoyoteAdapter.service(CoyoteAd
>>>> apter.java:342)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.coyote.http11.Http1
>>>> 1Processor.service(Http11Proce
>>>> ssor.java:799)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at org.apache.coyote.AbstractProcessorLight.process(
>>>> AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at org.apache.coyote.AbstractProtocol$ConnectionHandler.
>>>> process(AbstractProtocol.java:868)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at org.apache.tomcat.util.net.Nio
>>>> Endpoint$SocketProcessor.doRun
>>>> (NioEndpoint.java:1455)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at org.apache.tomcat.util.net.Soc
>>>> ketProcessorBase.run(SocketPro
>>>> cessorBase.java:49)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at java.util.concurrent.ThreadPoo
>>>> lExecutor.runWorker(ThreadPool
>>>> Executor.java:1142)
>>>> [?:1.8.0_66]
>>>>           at java.util.concurrent.ThreadPoo
>>>> lExecutor$Worker.run(ThreadPoo
>>>> lExecutor.java:617)
>>>> [?:1.8.0_66]
>>>>           at org.apache.tomcat.util.threads
>>>> .TaskThread$WrappingRunnable.
>>>> run(TaskThread.java:61)
>>>> [tomcat-util-8.5.16.jar:8.5.16]
>>>>
>>>>           at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>>>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Unable
>>>> to
>>>> serialize object; null byte array returned
>>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>>> serializeCustom(XmlSerializer.java:264) ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>>> serializeSingle(XmlSerializer.java:257) ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>>> serializeSingle(XmlSerializer.java:252) ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>>> serialize(XmlSerializer.java:78) ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>>> runAsync(GenericAsyncEngine.java:94) ~[ofbiz.jar:?]
>>>>           ... 40 more
>>>> 2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
>>>> |TransactionUtil               |I| Transaction rolled back
>>>> 2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
>>>> |TransactionUtil               |W| Not committing transaction, status is
>>>> No
>>>> Transaction (6)
>>>> 2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
>>>> |ServiceEventHandler           |E| Service invocation error
>>>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>>>> service attributes (Unable to serialize object; null byte array
>>>> returned)
>>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>>> runAsync(GenericAsyncEngine.java:124) ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>>> runAsync(GenericAsyncEngine.java:70) ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.Servi
>>>> ceDispatcher.runAsync(ServiceD
>>>> ispatcher.java:715)
>>>> ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.Servi
>>>> ceDispatcher.runAsync(ServiceD
>>>> ispatcher.java:780)
>>>> ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.GenericDispatcherFactory$
>>>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
>>>> ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.GenericDispatcherFactory$
>>>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
>>>> ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.event.
>>>> ServiceEventHandler.invoke(Ser
>>>> viceEventHandler.java:348)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.control.RequestHandler.
>>>> runEvent(RequestHandler.java:730) [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.control.RequestHandler.
>>>> doRequest(RequestHandler.java:454) [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.contro
>>>> l.ControlServlet.doGet(Control
>>>> Servlet.java:212)
>>>> [ofbiz.jar:?]
>>>>           at org.apache.ofbiz.webapp.contro
>>>> l.ControlServlet.doPost(Contro
>>>> lServlet.java:87)
>>>> [ofbiz.jar:?]
>>>>           at javax.servlet.http.HttpServlet
>>>> .service(HttpServlet.java:707)
>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>           at javax.servlet.http.HttpServlet
>>>> .service(HttpServlet.java:790)
>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>           at org.apache.catalina.core.Appli
>>>> cationFilterChain.internalDoFi
>>>> lter(
>>>> ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.tomcat.websocket.se
>>>> rver.WsFilter.doFilter(WsFilte
>>>> r.java:52)
>>>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>>>           at org.apache.catalina.core.Appli
>>>> cationFilterChain.internalDoFi
>>>> lter(
>>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.ofbiz.webapp.control.ContextFilter.
>>>> doFilter(ContextFilter.java:196) [ofbiz.jar:?]
>>>>           at org.apache.catalina.core.Appli
>>>> cationFilterChain.internalDoFi
>>>> lter(
>>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.ofbiz.webapp.control.ControlFilter.
>>>> doFilter(ControlFilter.java:157) [ofbiz.jar:?]
>>>>           at org.apache.catalina.core.Appli
>>>> cationFilterChain.internalDoFi
>>>> lter(
>>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.Stand
>>>> ardWrapperValve.invoke(Standar
>>>> dWrapperValve.java:198)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.Stand
>>>> ardContextValve.invoke(Standar
>>>> dContextValve.java:96)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.authentica
>>>> tor.AuthenticatorBase.invoke(A
>>>> uthenticatorBase.java:478)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.Stand
>>>> ardHostValve.invoke(StandardHo
>>>> stValve.java:140)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.valves.Err
>>>> orReportValve.invoke(ErrorRepo
>>>> rtValve.java:80)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.core.Stand
>>>> ardEngineValve.invoke(Standard
>>>> EngineValve.java:87)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
>>>> AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.catalina.connector.
>>>> CoyoteAdapter.service(CoyoteAd
>>>> apter.java:342)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at org.apache.coyote.http11.Http1
>>>> 1Processor.service(Http11Proce
>>>> ssor.java:799)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at org.apache.coyote.AbstractProcessorLight.process(
>>>> AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at org.apache.coyote.AbstractProtocol$ConnectionHandler.
>>>> process(AbstractProtocol.java:868)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at org.apache.tomcat.util.net.Nio
>>>> Endpoint$SocketProcessor.doRun
>>>> (NioEndpoint.java:1455)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at org.apache.tomcat.util.net.Soc
>>>> ketProcessorBase.run(SocketPro
>>>> cessorBase.java:49)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at java.util.concurrent.ThreadPoo
>>>> lExecutor.runWorker(ThreadPool
>>>> Executor.java:1142)
>>>> [?:1.8.0_66]
>>>>           at java.util.concurrent.ThreadPoo
>>>> lExecutor$Worker.run(ThreadPoo
>>>> lExecutor.java:617)
>>>> [?:1.8.0_66]
>>>>           at org.apache.tomcat.util.threads
>>>> .TaskThread$WrappingRunnable.
>>>> run(TaskThread.java:61)
>>>> [tomcat-util-8.5.16.jar:8.5.16]
>>>>
>>>>           at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>>>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Unable
>>>> to
>>>> serialize object; null byte array returned
>>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>>> serializeCustom(XmlSerializer.java:264) ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>>> serializeSingle(XmlSerializer.java:257) ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>>> serializeSingle(XmlSerializer.java:252) ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>>> serialize(XmlSerializer.java:78) ~[ofbiz.jar:?]
>>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>>> runAsync(GenericAsyncEngine.java:94) ~[ofbiz.jar:?]
>>>>           ... 40 more
>>>>
>>>> ========= Console Log end =========
>>>>
>>>>
>>>> - Best Regards,
>>>> Swapnil
>>>>
>>>> On Sat, Sep 23, 2017 at 1:33 PM, Jacques Le Roux <
>>>> jacques.le.roux@les7arts.com> wrote:
>>>>
>>>> Hi Swapnil,
>>>>
>>>>> Did you try?
>>>>>
>>>>> @SuppressWarnings("serial")
>>>>> public final class VisualTheme implements Serializable {
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>>
>>>>> Le 23/09/2017 à 08:29, Swapnil Mane a écrit :
>>>>>
>>>>> Thank you Nicolas and team for this great work.
>>>>>
>>>>>> Highly appreciated!!
>>>>>>
>>>>>> I am facing some Exception related to VisualTheme while running the
>>>>>> MRP.
>>>>>> https://demo-trunk.ofbiz.apache.org/manufacturing/control/RunMrp
>>>>>>
>>>>>> I guess it is related to theme work we have done, please let me know,
>>>>>> if I
>>>>>> am missing anything.
>>>>>>
>>>>>>
>>>>>> ========= Console Log start =========
>>>>>> [[ASync service failed...- total:0.012,since last(ASync service
>>>>>> sta...):0.012]] - 'manufacturing / executeMrp'
>>>>>> 2017-09-23 11:44:24,458 |jsse-nio-8443-exec-6
>>>>>> |ServiceDispatcher             |E| Service [executeMrp] threw an
>>>>>> unexpected
>>>>>> exception/error
>>>>>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>>>>>> service attributes (Cannot serialize object of class
>>>>>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>>>>>            at
>>>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>>>> GenericAsyncEngine.java:124)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>>>> GenericAsyncEngine.java:70)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>>>>> ispatcher.java:715)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>>>>> ispatcher.java:780)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>>>>> patcher.runAsync(GenericDispatcherFactory.java:181)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>>>>> patcher.runAsync(GenericDispatcherFactory.java:191)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>>>>>> viceEventHandler.java:348)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(Requ
>>>>>> estHandler.java:730)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(Req
>>>>>> uestHandler.java:454)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>>>>>> Servlet.java:212)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>>>>>> lServlet.java:87)
>>>>>> [ofbiz.jar:?]
>>>>>>            at javax.servlet.http.HttpServlet
>>>>>> .service(HttpServlet.java:707)
>>>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>>>            at javax.servlet.http.HttpServlet
>>>>>> .service(HttpServlet.java:790)
>>>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>>> lter(ApplicationFilterChain.java:231)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>>> licationFilterChain.java:166)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilte
>>>>>> r.java:52)
>>>>>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>>> lter(ApplicationFilterChain.java:193)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>>> licationFilterChain.java:166)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(Conte
>>>>>> xtFilter.java:196)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>>> lter(ApplicationFilterChain.java:193)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>>> licationFilterChain.java:166)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(Contr
>>>>>> olFilter.java:157)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>>> lter(ApplicationFilterChain.java:193)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>>> licationFilterChain.java:166)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>>>>>> dWrapperValve.java:198)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.StandardContextValve.invoke(Standar
>>>>>> dContextValve.java:96)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>>>>>> uthenticatorBase.java:478)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>>>>>> stValve.java:140)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>>>>>> rtValve.java:80)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.StandardEngineValve.invoke(Standard
>>>>>> EngineValve.java:87)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.valves.AbstractAccessLogValve.invoke(Abs
>>>>>> tractAccessLogValve.java:624)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>>>>>> apter.java:342)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.coyote.http11.Http11Processor.service(Http11Proce
>>>>>> ssor.java:799)
>>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.coyote.AbstractProcessorLight.process(AbstractPro
>>>>>> cessorLight.java:66)
>>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.coyote.AbstractProtocol$ConnectionHandler.process
>>>>>> (AbstractProtocol.java:868)
>>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>>>>>> (NioEndpoint.java:1455)
>>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>>>>>> cessorBase.java:49)
>>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>>>>>> Executor.java:1142)
>>>>>> [?:1.8.0_66]
>>>>>>            at
>>>>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>>>>>> lExecutor.java:617)
>>>>>> [?:1.8.0_66]
>>>>>>            at
>>>>>> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.r
>>>>>> un(TaskThread.java:61)
>>>>>> [tomcat-util-8.5.16.jar:8.5.16]
>>>>>>            at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>>>>>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException:
>>>>>> Cannot
>>>>>> serialize object of class org.apache.ofbiz.widget.render
>>>>>> er.VisualTheme
>>>>>>            at
>>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCus
>>>>>> tom(XmlSerializer.java:273)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>>>>> gle(XmlSerializer.java:257)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>>>>> gle(XmlSerializer.java:252)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(Xm
>>>>>> lSerializer.java:78)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>>>> GenericAsyncEngine.java:94)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            ... 40 more
>>>>>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>>>>>> |TransactionUtil               |I| Transaction rolled back
>>>>>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>>>>>> |TransactionUtil               |W| Not committing transaction, status
>>>>>> is
>>>>>> No
>>>>>> Transaction (6)
>>>>>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>>>>>> |ServiceEventHandler           |E| Service invocation error
>>>>>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>>>>>> service attributes (Cannot serialize object of class
>>>>>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>>>>>            at
>>>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>>>> GenericAsyncEngine.java:124)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>>>> GenericAsyncEngine.java:70)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>>>>> ispatcher.java:715)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>>>>> ispatcher.java:780)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>>>>> patcher.runAsync(GenericDispatcherFactory.java:181)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>>>>> patcher.runAsync(GenericDispatcherFactory.java:191)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>>>>>> viceEventHandler.java:348)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(Requ
>>>>>> estHandler.java:730)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(Req
>>>>>> uestHandler.java:454)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>>>>>> Servlet.java:212)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>>>>>> lServlet.java:87)
>>>>>> [ofbiz.jar:?]
>>>>>>            at javax.servlet.http.HttpServlet
>>>>>> .service(HttpServlet.java:707)
>>>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>>>            at javax.servlet.http.HttpServlet
>>>>>> .service(HttpServlet.java:790)
>>>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>>> lter(ApplicationFilterChain.java:231)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>>> licationFilterChain.java:166)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilte
>>>>>> r.java:52)
>>>>>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>>> lter(ApplicationFilterChain.java:193)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>>> licationFilterChain.java:166)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(Conte
>>>>>> xtFilter.java:196)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>>> lter(ApplicationFilterChain.java:193)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>>> licationFilterChain.java:166)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(Contr
>>>>>> olFilter.java:157)
>>>>>> [ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>>> lter(ApplicationFilterChain.java:193)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>>> licationFilterChain.java:166)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>>>>>> dWrapperValve.java:198)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.StandardContextValve.invoke(Standar
>>>>>> dContextValve.java:96)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>>>>>> uthenticatorBase.java:478)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>>>>>> stValve.java:140)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>>>>>> rtValve.java:80)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.core.StandardEngineValve.invoke(Standard
>>>>>> EngineValve.java:87)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.valves.AbstractAccessLogValve.invoke(Abs
>>>>>> tractAccessLogValve.java:624)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>>>>>> apter.java:342)
>>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.coyote.http11.Http11Processor.service(Http11Proce
>>>>>> ssor.java:799)
>>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.coyote.AbstractProcessorLight.process(AbstractPro
>>>>>> cessorLight.java:66)
>>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.coyote.AbstractProtocol$ConnectionHandler.process
>>>>>> (AbstractProtocol.java:868)
>>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>>>>>> (NioEndpoint.java:1455)
>>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>>>>>> cessorBase.java:49)
>>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>>            at
>>>>>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>>>>>> Executor.java:1142)
>>>>>> [?:1.8.0_66]
>>>>>>            at
>>>>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>>>>>> lExecutor.java:617)
>>>>>> [?:1.8.0_66]
>>>>>>            at
>>>>>> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.r
>>>>>> un(TaskThread.java:61)
>>>>>> [tomcat-util-8.5.16.jar:8.5.16]
>>>>>>            at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>>>>>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException:
>>>>>> Cannot
>>>>>> serialize object of class org.apache.ofbiz.widget.render
>>>>>> er.VisualTheme
>>>>>>            at
>>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCus
>>>>>> tom(XmlSerializer.java:273)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>>>>> gle(XmlSerializer.java:257)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>>>>> gle(XmlSerializer.java:252)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(Xm
>>>>>> lSerializer.java:78)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            at
>>>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>>>> GenericAsyncEngine.java:94)
>>>>>> ~[ofbiz.jar:?]
>>>>>>            ... 40 more
>>>>>> 2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
>>>>>> |RequestHandler                |E| Request runMrpGo caused an error
>>>>>> with
>>>>>> the following message: Error calling event:
>>>>>> org.apache.ofbiz.webapp.event.EventHandlerException: Service
>>>>>> invocation
>>>>>> error (Cannot serialize object of class
>>>>>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>>>>> 2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
>>>>>> |RequestHandler                |I| Rendering View [MrpExecution].
>>>>>> Hidden
>>>>>> sessionId by default.
>>>>>> 2017-09-23 11:44:24,465 |jsse-nio-8443-exec-6
>>>>>> |ServiceDispatcher             |T| Sync service
>>>>>> [manufacturing/getUserPreferenceGroup] finished in [1] milliseconds
>>>>>>
>>>>>> ========= Console log end =========
>>>>>>
>>>>>>
>>>>>> - Best Regards,
>>>>>> Swapnil M Mane
>>>>>>
>>>>>>
>>>>>> On Sun, Sep 10, 2017 at 4:21 PM, Michael Brohl <
>>>>>> michael.brohl@ecomify.de>
>>>>>> wrote:
>>>>>>
>>>>>> Thank you, Nicolas, for the great effort you put on this.
>>>>>>
>>>>>> I'll hope to soon reactivate my work on the bootstrap theme, using the
>>>>>>> new
>>>>>>> structure, and see how it will work out.
>>>>>>>
>>>>>>> I'll have some more qualified feedback (and propably questions ;-) )
>>>>>>> then...
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Michael
>>>>>>>
>>>>>>>
>>>>>>> Am 25.08.17 um 12:15 schrieb Nicolas Malin:
>>>>>>>
>>>>>>> I loaded all my local :)
>>>>>>>
>>>>>>> Le 25/08/2017 à 00:03, Nicolas Malin a écrit :
>>>>>>>
>>>>>>>> I started to load common-theme on trunk, at this time to resume :
>>>>>>>>
>>>>>>>> r1806075, r1806076 : I loaded engine and documentation
>>>>>>>>> r1806084 : I moved all images folder to common-theme
>>>>>>>>> r1806091, r1806093: I moved all ftl template from common to
>>>>>>>>> common-theme
>>>>>>>>> and all macro ftl libraries.
>>>>>>>>>
>>>>>>>>> 1806134 : load VisualTheme and ModelTheme on different session and
>>>>>>>>>
>>>>>>>>> context
>>>>>>>> 1806137, 180614[0-9] : Migrate themes, common screens, handler to
>>>>>>>> exploit
>>>>>>>> values from the theme definition
>>>>>>>> 1806150 : migrate all other screen and scripts  to exploit values
>>>>>>>> from
>>>>>>>> the theme definition
>>>>>>>> 180615 : improve error message and announce the commit end :)
>>>>>>>>
>>>>>>>> Cheers,
>>>>>>>> Nicolas
>>>>>>>>
>>>>>>>> I hope to break nothing at this time.
>>>>>>>>
>>>>>>>> The next steps will load the dynamic theme load on session
>>>>>>>>>
>>>>>>>>> Cheers,
>>>>>>>>>
>>>>>>>>> Nicolas
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
>>>>>>>>>
>>>>>>>>> Hi Taher,
>>>>>>>>>
>>>>>>>>> If you have few time to have a look on these three class :
>>>>>>>>>>
>>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>>>>>> model/ModelTheme.java
>>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>>>>>> model/ThemeFactory.java
>>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>>>>>> renderer/VisualTheme.java
>>>>>>>>>>
>>>>>>>>>> ModelTheme is java class to load all Theme definition who interact
>>>>>>>>>> with
>>>>>>>>>> the system
>>>>>>>>>>
>>>>>>>>>> VisualTheme is java class regards the VisualTheme entity who
>>>>>>>>>> interact
>>>>>>>>>> with the user to exploit the modelTheme
>>>>>>>>>>
>>>>>>>>>> ThemeFactory is the factory to create both.
>>>>>>>>>>
>>>>>>>>>> I prepare my commits, but I need to separate properly each code
>>>>>>>>>> modification to help other learn the work.
>>>>>>>>>>
>>>>>>>>>> Cheers,
>>>>>>>>>> Nicolas
>>>>>>>>>>
>>>>>>>>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>>>>>>>>>>
>>>>>>>>>> Hi Nicolas,
>>>>>>>>>>
>>>>>>>>>> If it helps you, I suggest to isolate files / code where you are
>>>>>>>>>>> not
>>>>>>>>>>> very comfortable and put them in a separate patch (not the full
>>>>>>>>>>> patch)
>>>>>>>>>>> with an explanation of what you've done and where you feel a
>>>>>>>>>>> little
>>>>>>>>>>> hesitant or uneasy. I think if you make us focus with you on very
>>>>>>>>>>> specific pieces of code then our review will be faster and your
>>>>>>>>>>> confidence of the review will be better.
>>>>>>>>>>>
>>>>>>>>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>>>>>>>>>>> <ni...@nereide.fr> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>>
>>>>>>>>>>> I will commit on trunk after a second review of my code because i
>>>>>>>>>>>> was
>>>>>>>>>>>> concentrated to increase the flexibility with macro and screen
>>>>>>>>>>>> but
>>>>>>>>>>>> not
>>>>>>>>>>>> manage correctly the VisualTheme concept.
>>>>>>>>>>>>
>>>>>>>>>>>> So I will take care about this, complete the documentation and
>>>>>>>>>>>> commit
>>>>>>>>>>>> on
>>>>>>>>>>>> trunk.
>>>>>>>>>>>>
>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>>>>>>>>>>
>>>>>>>>>>>> Like Michael, I also prefer to include the work into the code
>>>>>>>>>>>> base
>>>>>>>>>>>>
>>>>>>>>>>>> and
>>>>>>>>>>>>> test it over there. It seems like you put a lot of effort into
>>>>>>>>>>>>> this
>>>>>>>>>>>>> code so thank you! I like the fact that you brought all the
>>>>>>>>>>>>> artifacts
>>>>>>>>>>>>> into the theme along with the FTL macros. This is a good first
>>>>>>>>>>>>> step,
>>>>>>>>>>>>> and I believe continuing on this direction is where we need to
>>>>>>>>>>>>> go.
>>>>>>>>>>>>>
>>>>>>>>>>>>> +1 to committing into the code base and testing over there.
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>>>>>>>>>>> <ja...@les7arts.com> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>> That sounds great,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks Nicolas!
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Jacques
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hello,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I started the documentation here
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>>>>>>>> themes/README.md
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> It's a begging, I hope improve it quickly
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Hello;
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> To continue the common-theme subject, I haven't see negative
>>>>>>>>>>>>>>>> return to
>>>>>>>>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on
>>>>>>>>>>>>>>>> threads
>>>>>>>>>>>>>>>> on the
>>>>>>>>>>>>>>>> same
>>>>>>>>>>>>>>>> subject [2] and the additional theme xml definition [3], I
>>>>>>>>>>>>>>>> suggest to
>>>>>>>>>>>>>>>> create
>>>>>>>>>>>>>>>> a documentation on the wiki how work the "theme engine" and
>>>>>>>>>>>>>>>> commit the
>>>>>>>>>>>>>>>> current git branch [4] [5] on trunk
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> After that, the engine will be present on the trunk and we
>>>>>>>>>>>>>>>> continue the
>>>>>>>>>>>>>>>> work to :
>>>>>>>>>>>>>>>> * Clean the common-theme and create a real theme
>>>>>>>>>>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>>>>>>>>>>> * Analyze more how organize the screen api
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> But don't panic, before that I'm listening to all suggest or
>>>>>>>>>>>>>>>> remarks ;)
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>>>>>>>>>>> [2]
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> https://lists.apache.org/threa
>>>>>>>>>>>>>>>> d.html/6ab61eb5ddeb4669f6e8e15
>>>>>>>>>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org
>>>>>>>>>>>>>>>> %3E
>>>>>>>>>>>>>>>> [3]
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> https://lists.apache.org/threa
>>>>>>>>>>>>>>>> d.html/8c40f261d2d818aed6f38ab
>>>>>>>>>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org
>>>>>>>>>>>>>>>> %3E
>>>>>>>>>>>>>>>> [4] https://github.com/nmalin/ofbi
>>>>>>>>>>>>>>>> z-framework/tree/common-theme
>>>>>>>>>>>>>>>> [5]
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...
>>>>>>>>>>>>>>>> nmalin:common-theme?expand=1
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>
>
>

Re: Common-theme next step

Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Swapnil,

Could you please open a Jira for your case?

I'll double check mine and will add it also

Thanks

Jacques


Le 26/09/2017 à 10:46, Swapnil Mane a écrit :
> Yes Jacques, thanks for looking into this.
>
>
> - Best Regards,
> Swapnil M Mane
>
> On Tue, Sep 26, 2017 at 2:08 PM, Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
>
>> Hi Swapnil, All,
>>
>> This is a real problem, I just crossed it also with
>>
>> 2017-09-26 10:03:34,730 |jsse-nio-8443-exec-6
>> |ServiceDispatcher             |T| [[ASync service failed...-
>> total:0.004,since last(ASync service sta...):0.004]] - 'ecommerce /
>> sendOrderConfirmation'
>> 2017-09-26 10:03:34,730 |jsse-nio-8443-exec-6
>> |ServiceDispatcher             |E| Service [sendOrderConfirmation] threw an
>> unexpected exception/error
>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>> service attributes (Cannot serialize object of class
>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>
>> and
>>
>> 2017-09-26 10:03:40,283 |jsse-nio-8443-exec-6
>> |ScreenFactory                 |I| Got 2 screens in 0.005s from:
>> file:/C:/projectsASF/ofbiz/plugins/ecommerce/widget/Shopping
>> ListScreens.xml
>> 2017-09-26 10:03:40,578 |jsse-nio-8443-exec-6
>> |ScriptUtil                    |W| Error running script at location
>> [component://ecommerce/groovyScripts/shoppinglist/EditShoppingList.groovy]:
>> org.codehaus.groov
>> y.runtime.typehandling.GroovyCastException: Cannot cast object 'USD' with
>> class 'java.lang.String' to class 'org.apache.ofbiz.widget.rende
>> rer.VisualTheme'
>> org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast
>> object 'USD' with class 'java.lang.String' to class
>> 'org.apache.ofbiz.widget.renderer.VisualTheme'
>>
>> I have no other ideas yet (working on something else). But I'll have a
>> look ASAP
>>
>> Jacques
>>
>>
>>
>> Le 23/09/2017 à 11:11, Swapnil Mane a écrit :
>>
>>> Thanks Jacques for your timings and suggestion.
>>> @SuppressWarnings("serial") doesn't work for me.
>>>
>>> ========= Console Log start =========
>>>
>>> 2017-09-23 14:38:25,610 |jsse-nio-8443-exec-8
>>> |ServiceDispatcher             |T| [[ASync service started...-
>>> total:0.0,since last(Begin):0.0]] - 'manufacturing / executeMrp'
>>> 2017-09-23 14:38:25,630 |jsse-nio-8443-exec-8
>>> |SequenceUtil                  |I| Got bank of sequenced IDs for
>>> [RuntimeData]; curSeqId=10600, maxSeqId=10700, bankSize=100
>>> 2017-09-23 14:38:25,649 |jsse-nio-8443-exec-8
>>> |UtilObject                    |E| null
>>> java.io.NotSerializableException: org.apache.ofbiz.widget.model.
>>> ModelTheme$ModelTemplate
>>>           at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.
>>> java:1184)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.
>>> java:348)
>>> ~[?:1.8.0_66]
>>>           at java.util.HashMap.internalWriteEntries(HashMap.java:1777)
>>> ~[?:1.8.0_66]
>>>           at java.util.HashMap.writeObject(HashMap.java:1354)
>>> ~[?:1.8.0_66]
>>>           at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>> ~[?:1.8.0_66]
>>>           at sun.reflect.NativeMethodAccessorImpl.invoke(
>>> NativeMethodAccessorImpl.java:62) ~[?:1.8.0_66]
>>>           at sun.reflect.DelegatingMethodAccessorImpl.invoke(
>>> DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_66]
>>>           at java.lang.reflect.Method.invoke(Method.java:497)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClas
>>> s.java:1028)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStrea
>>> m.java:1496)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputS
>>> tream.java:1432)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.
>>> java:1178)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputSt
>>> ream.java:1548)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStrea
>>> m.java:1509)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputS
>>> tream.java:1432)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.
>>> java:1178)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputSt
>>> ream.java:1548)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStrea
>>> m.java:1509)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputS
>>> tream.java:1432)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.
>>> java:1178)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputSt
>>> ream.java:1548)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStrea
>>> m.java:1509)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputS
>>> tream.java:1432)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.
>>> java:1178)
>>> ~[?:1.8.0_66]
>>>           at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.
>>> java:348)
>>> ~[?:1.8.0_66]
>>>           at org.apache.ofbiz.base.util.UtilObject.getBytes(UtilObject.
>>> java:82)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>> serializeCustom(XmlSerializer.java:262) [ofbiz.jar:?]
>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>> serializeSingle(XmlSerializer.java:257) [ofbiz.jar:?]
>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>> serializeSingle(XmlSerializer.java:252) [ofbiz.jar:?]
>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>> serialize(XmlSerializer.java:78) [ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>> runAsync(GenericAsyncEngine.java:94) [ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>> runAsync(GenericAsyncEngine.java:70) [ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>> ispatcher.java:715)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>> ispatcher.java:780)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.GenericDispatcherFactory$
>>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.GenericDispatcherFactory$
>>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>>> viceEventHandler.java:348)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.control.RequestHandler.
>>> runEvent(RequestHandler.java:730) [ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.control.RequestHandler.
>>> doRequest(RequestHandler.java:454) [ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>>> Servlet.java:212)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>>> lServlet.java:87)
>>> [ofbiz.jar:?]
>>>           at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>           at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>           at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(
>>> ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilte
>>> r.java:52)
>>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>>           at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(
>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.ofbiz.webapp.control.ContextFilter.
>>> doFilter(ContextFilter.java:196) [ofbiz.jar:?]
>>>           at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(
>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.ofbiz.webapp.control.ControlFilter.
>>> doFilter(ControlFilter.java:157) [ofbiz.jar:?]
>>>           at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(
>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>>> dWrapperValve.java:198)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.StandardContextValve.invoke(Standar
>>> dContextValve.java:96)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>>> uthenticatorBase.java:478)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>>> stValve.java:140)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>>> rtValve.java:80)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.StandardEngineValve.invoke(Standard
>>> EngineValve.java:87)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
>>> AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>>> apter.java:342)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.coyote.http11.Http11Processor.service(Http11Proce
>>> ssor.java:799)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at org.apache.coyote.AbstractProcessorLight.process(
>>> AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at org.apache.coyote.AbstractProtocol$ConnectionHandler.
>>> process(AbstractProtocol.java:868)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>>> (NioEndpoint.java:1455)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>>> cessorBase.java:49)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>>> Executor.java:1142)
>>> [?:1.8.0_66]
>>>           at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>>> lExecutor.java:617)
>>> [?:1.8.0_66]
>>>           at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.
>>> run(TaskThread.java:61)
>>> [tomcat-util-8.5.16.jar:8.5.16]
>>>           at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>>> 2017-09-23 14:38:25,653 |jsse-nio-8443-exec-8
>>> |ServiceDispatcher             |T| [[ASync service failed...-
>>> total:0.043,since last(ASync service sta...):0.043]] - 'manufacturing /
>>> executeMrp'
>>> 2017-09-23 14:38:25,653 |jsse-nio-8443-exec-8
>>> |ServiceDispatcher             |E| Service [executeMrp] threw an
>>> unexpected
>>> exception/error
>>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>>> service attributes (Unable to serialize object; null byte array returned)
>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>> runAsync(GenericAsyncEngine.java:124) ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>> runAsync(GenericAsyncEngine.java:70) ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>> ispatcher.java:715)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>> ispatcher.java:780)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.GenericDispatcherFactory$
>>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.GenericDispatcherFactory$
>>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>>> viceEventHandler.java:348)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.control.RequestHandler.
>>> runEvent(RequestHandler.java:730) [ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.control.RequestHandler.
>>> doRequest(RequestHandler.java:454) [ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>>> Servlet.java:212)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>>> lServlet.java:87)
>>> [ofbiz.jar:?]
>>>           at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>           at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>           at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(
>>> ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilte
>>> r.java:52)
>>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>>           at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(
>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.ofbiz.webapp.control.ContextFilter.
>>> doFilter(ContextFilter.java:196) [ofbiz.jar:?]
>>>           at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(
>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.ofbiz.webapp.control.ControlFilter.
>>> doFilter(ControlFilter.java:157) [ofbiz.jar:?]
>>>           at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(
>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>>> dWrapperValve.java:198)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.StandardContextValve.invoke(Standar
>>> dContextValve.java:96)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>>> uthenticatorBase.java:478)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>>> stValve.java:140)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>>> rtValve.java:80)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.StandardEngineValve.invoke(Standard
>>> EngineValve.java:87)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
>>> AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>>> apter.java:342)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.coyote.http11.Http11Processor.service(Http11Proce
>>> ssor.java:799)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at org.apache.coyote.AbstractProcessorLight.process(
>>> AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at org.apache.coyote.AbstractProtocol$ConnectionHandler.
>>> process(AbstractProtocol.java:868)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>>> (NioEndpoint.java:1455)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>>> cessorBase.java:49)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>>> Executor.java:1142)
>>> [?:1.8.0_66]
>>>           at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>>> lExecutor.java:617)
>>> [?:1.8.0_66]
>>>           at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.
>>> run(TaskThread.java:61)
>>> [tomcat-util-8.5.16.jar:8.5.16]
>>>           at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Unable
>>> to
>>> serialize object; null byte array returned
>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>> serializeCustom(XmlSerializer.java:264) ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>> serializeSingle(XmlSerializer.java:257) ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>> serializeSingle(XmlSerializer.java:252) ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>> serialize(XmlSerializer.java:78) ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>> runAsync(GenericAsyncEngine.java:94) ~[ofbiz.jar:?]
>>>           ... 40 more
>>> 2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
>>> |TransactionUtil               |I| Transaction rolled back
>>> 2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
>>> |TransactionUtil               |W| Not committing transaction, status is
>>> No
>>> Transaction (6)
>>> 2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
>>> |ServiceEventHandler           |E| Service invocation error
>>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>>> service attributes (Unable to serialize object; null byte array returned)
>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>> runAsync(GenericAsyncEngine.java:124) ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>> runAsync(GenericAsyncEngine.java:70) ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>> ispatcher.java:715)
>>> ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>> ispatcher.java:780)
>>> ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.GenericDispatcherFactory$
>>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
>>> ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.GenericDispatcherFactory$
>>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
>>> ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>>> viceEventHandler.java:348)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.control.RequestHandler.
>>> runEvent(RequestHandler.java:730) [ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.control.RequestHandler.
>>> doRequest(RequestHandler.java:454) [ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>>> Servlet.java:212)
>>> [ofbiz.jar:?]
>>>           at org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>>> lServlet.java:87)
>>> [ofbiz.jar:?]
>>>           at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>           at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>           at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(
>>> ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilte
>>> r.java:52)
>>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>>           at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(
>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.ofbiz.webapp.control.ContextFilter.
>>> doFilter(ContextFilter.java:196) [ofbiz.jar:?]
>>>           at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(
>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.ofbiz.webapp.control.ControlFilter.
>>> doFilter(ControlFilter.java:157) [ofbiz.jar:?]
>>>           at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(
>>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>>> dWrapperValve.java:198)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.StandardContextValve.invoke(Standar
>>> dContextValve.java:96)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>>> uthenticatorBase.java:478)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>>> stValve.java:140)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>>> rtValve.java:80)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.core.StandardEngineValve.invoke(Standard
>>> EngineValve.java:87)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
>>> AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>>> apter.java:342)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at org.apache.coyote.http11.Http11Processor.service(Http11Proce
>>> ssor.java:799)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at org.apache.coyote.AbstractProcessorLight.process(
>>> AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at org.apache.coyote.AbstractProtocol$ConnectionHandler.
>>> process(AbstractProtocol.java:868)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>>> (NioEndpoint.java:1455)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>>> cessorBase.java:49)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>>> Executor.java:1142)
>>> [?:1.8.0_66]
>>>           at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>>> lExecutor.java:617)
>>> [?:1.8.0_66]
>>>           at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.
>>> run(TaskThread.java:61)
>>> [tomcat-util-8.5.16.jar:8.5.16]
>>>           at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Unable
>>> to
>>> serialize object; null byte array returned
>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>> serializeCustom(XmlSerializer.java:264) ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>> serializeSingle(XmlSerializer.java:257) ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>> serializeSingle(XmlSerializer.java:252) ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.entity.serialize.XmlSerializer.
>>> serialize(XmlSerializer.java:78) ~[ofbiz.jar:?]
>>>           at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>>> runAsync(GenericAsyncEngine.java:94) ~[ofbiz.jar:?]
>>>           ... 40 more
>>>
>>> ========= Console Log end =========
>>>
>>>
>>> - Best Regards,
>>> Swapnil
>>>
>>> On Sat, Sep 23, 2017 at 1:33 PM, Jacques Le Roux <
>>> jacques.le.roux@les7arts.com> wrote:
>>>
>>> Hi Swapnil,
>>>> Did you try?
>>>>
>>>> @SuppressWarnings("serial")
>>>> public final class VisualTheme implements Serializable {
>>>>
>>>> Jacques
>>>>
>>>>
>>>>
>>>> Le 23/09/2017 à 08:29, Swapnil Mane a écrit :
>>>>
>>>> Thank you Nicolas and team for this great work.
>>>>> Highly appreciated!!
>>>>>
>>>>> I am facing some Exception related to VisualTheme while running the MRP.
>>>>> https://demo-trunk.ofbiz.apache.org/manufacturing/control/RunMrp
>>>>>
>>>>> I guess it is related to theme work we have done, please let me know,
>>>>> if I
>>>>> am missing anything.
>>>>>
>>>>>
>>>>> ========= Console Log start =========
>>>>> [[ASync service failed...- total:0.012,since last(ASync service
>>>>> sta...):0.012]] - 'manufacturing / executeMrp'
>>>>> 2017-09-23 11:44:24,458 |jsse-nio-8443-exec-6
>>>>> |ServiceDispatcher             |E| Service [executeMrp] threw an
>>>>> unexpected
>>>>> exception/error
>>>>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>>>>> service attributes (Cannot serialize object of class
>>>>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>>>>            at
>>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>>> GenericAsyncEngine.java:124)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>>> GenericAsyncEngine.java:70)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>>>> ispatcher.java:715)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>>>> ispatcher.java:780)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>>>> patcher.runAsync(GenericDispatcherFactory.java:181)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>>>> patcher.runAsync(GenericDispatcherFactory.java:191)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>>>>> viceEventHandler.java:348)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(Requ
>>>>> estHandler.java:730)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(Req
>>>>> uestHandler.java:454)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>>>>> Servlet.java:212)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>>>>> lServlet.java:87)
>>>>> [ofbiz.jar:?]
>>>>>            at javax.servlet.http.HttpServlet
>>>>> .service(HttpServlet.java:707)
>>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>>            at javax.servlet.http.HttpServlet
>>>>> .service(HttpServlet.java:790)
>>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>> lter(ApplicationFilterChain.java:231)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>> licationFilterChain.java:166)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>>>>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>> lter(ApplicationFilterChain.java:193)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>> licationFilterChain.java:166)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(Conte
>>>>> xtFilter.java:196)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>> lter(ApplicationFilterChain.java:193)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>> licationFilterChain.java:166)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(Contr
>>>>> olFilter.java:157)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>> lter(ApplicationFilterChain.java:193)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>> licationFilterChain.java:166)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>>>>> dWrapperValve.java:198)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.StandardContextValve.invoke(Standar
>>>>> dContextValve.java:96)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>>>>> uthenticatorBase.java:478)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>>>>> stValve.java:140)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>>>>> rtValve.java:80)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.StandardEngineValve.invoke(Standard
>>>>> EngineValve.java:87)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.valves.AbstractAccessLogValve.invoke(Abs
>>>>> tractAccessLogValve.java:624)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>>>>> apter.java:342)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.coyote.http11.Http11Processor.service(Http11Proce
>>>>> ssor.java:799)
>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.coyote.AbstractProcessorLight.process(AbstractPro
>>>>> cessorLight.java:66)
>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.coyote.AbstractProtocol$ConnectionHandler.process
>>>>> (AbstractProtocol.java:868)
>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>>>>> (NioEndpoint.java:1455)
>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>>>>> cessorBase.java:49)
>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>>>>> Executor.java:1142)
>>>>> [?:1.8.0_66]
>>>>>            at
>>>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>>>>> lExecutor.java:617)
>>>>> [?:1.8.0_66]
>>>>>            at
>>>>> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.r
>>>>> un(TaskThread.java:61)
>>>>> [tomcat-util-8.5.16.jar:8.5.16]
>>>>>            at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>>>>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Cannot
>>>>> serialize object of class org.apache.ofbiz.widget.renderer.VisualTheme
>>>>>            at
>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCus
>>>>> tom(XmlSerializer.java:273)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>>>> gle(XmlSerializer.java:257)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>>>> gle(XmlSerializer.java:252)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(Xm
>>>>> lSerializer.java:78)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>>> GenericAsyncEngine.java:94)
>>>>> ~[ofbiz.jar:?]
>>>>>            ... 40 more
>>>>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>>>>> |TransactionUtil               |I| Transaction rolled back
>>>>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>>>>> |TransactionUtil               |W| Not committing transaction, status is
>>>>> No
>>>>> Transaction (6)
>>>>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>>>>> |ServiceEventHandler           |E| Service invocation error
>>>>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>>>>> service attributes (Cannot serialize object of class
>>>>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>>>>            at
>>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>>> GenericAsyncEngine.java:124)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>>> GenericAsyncEngine.java:70)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>>>> ispatcher.java:715)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>>>> ispatcher.java:780)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>>>> patcher.runAsync(GenericDispatcherFactory.java:181)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>>>> patcher.runAsync(GenericDispatcherFactory.java:191)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>>>>> viceEventHandler.java:348)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(Requ
>>>>> estHandler.java:730)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(Req
>>>>> uestHandler.java:454)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>>>>> Servlet.java:212)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>>>>> lServlet.java:87)
>>>>> [ofbiz.jar:?]
>>>>>            at javax.servlet.http.HttpServlet
>>>>> .service(HttpServlet.java:707)
>>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>>            at javax.servlet.http.HttpServlet
>>>>> .service(HttpServlet.java:790)
>>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>> lter(ApplicationFilterChain.java:231)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>> licationFilterChain.java:166)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>>>>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>> lter(ApplicationFilterChain.java:193)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>> licationFilterChain.java:166)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(Conte
>>>>> xtFilter.java:196)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>> lter(ApplicationFilterChain.java:193)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>> licationFilterChain.java:166)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(Contr
>>>>> olFilter.java:157)
>>>>> [ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>>> lter(ApplicationFilterChain.java:193)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>>> licationFilterChain.java:166)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>>>>> dWrapperValve.java:198)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.StandardContextValve.invoke(Standar
>>>>> dContextValve.java:96)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>>>>> uthenticatorBase.java:478)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>>>>> stValve.java:140)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>>>>> rtValve.java:80)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.core.StandardEngineValve.invoke(Standard
>>>>> EngineValve.java:87)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.valves.AbstractAccessLogValve.invoke(Abs
>>>>> tractAccessLogValve.java:624)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>>>>> apter.java:342)
>>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.coyote.http11.Http11Processor.service(Http11Proce
>>>>> ssor.java:799)
>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.coyote.AbstractProcessorLight.process(AbstractPro
>>>>> cessorLight.java:66)
>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.coyote.AbstractProtocol$ConnectionHandler.process
>>>>> (AbstractProtocol.java:868)
>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>>>>> (NioEndpoint.java:1455)
>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>>>>> cessorBase.java:49)
>>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>>            at
>>>>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>>>>> Executor.java:1142)
>>>>> [?:1.8.0_66]
>>>>>            at
>>>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>>>>> lExecutor.java:617)
>>>>> [?:1.8.0_66]
>>>>>            at
>>>>> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.r
>>>>> un(TaskThread.java:61)
>>>>> [tomcat-util-8.5.16.jar:8.5.16]
>>>>>            at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>>>>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Cannot
>>>>> serialize object of class org.apache.ofbiz.widget.renderer.VisualTheme
>>>>>            at
>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCus
>>>>> tom(XmlSerializer.java:273)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>>>> gle(XmlSerializer.java:257)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>>>> gle(XmlSerializer.java:252)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(Xm
>>>>> lSerializer.java:78)
>>>>> ~[ofbiz.jar:?]
>>>>>            at
>>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>>> GenericAsyncEngine.java:94)
>>>>> ~[ofbiz.jar:?]
>>>>>            ... 40 more
>>>>> 2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
>>>>> |RequestHandler                |E| Request runMrpGo caused an error with
>>>>> the following message: Error calling event:
>>>>> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation
>>>>> error (Cannot serialize object of class
>>>>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>>>> 2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
>>>>> |RequestHandler                |I| Rendering View [MrpExecution].
>>>>> Hidden
>>>>> sessionId by default.
>>>>> 2017-09-23 11:44:24,465 |jsse-nio-8443-exec-6
>>>>> |ServiceDispatcher             |T| Sync service
>>>>> [manufacturing/getUserPreferenceGroup] finished in [1] milliseconds
>>>>>
>>>>> ========= Console log end =========
>>>>>
>>>>>
>>>>> - Best Regards,
>>>>> Swapnil M Mane
>>>>>
>>>>>
>>>>> On Sun, Sep 10, 2017 at 4:21 PM, Michael Brohl <
>>>>> michael.brohl@ecomify.de>
>>>>> wrote:
>>>>>
>>>>> Thank you, Nicolas, for the great effort you put on this.
>>>>>
>>>>>> I'll hope to soon reactivate my work on the bootstrap theme, using the
>>>>>> new
>>>>>> structure, and see how it will work out.
>>>>>>
>>>>>> I'll have some more qualified feedback (and propably questions ;-) )
>>>>>> then...
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Michael
>>>>>>
>>>>>>
>>>>>> Am 25.08.17 um 12:15 schrieb Nicolas Malin:
>>>>>>
>>>>>> I loaded all my local :)
>>>>>>
>>>>>> Le 25/08/2017 à 00:03, Nicolas Malin a écrit :
>>>>>>> I started to load common-theme on trunk, at this time to resume :
>>>>>>>
>>>>>>>> r1806075, r1806076 : I loaded engine and documentation
>>>>>>>> r1806084 : I moved all images folder to common-theme
>>>>>>>> r1806091, r1806093: I moved all ftl template from common to
>>>>>>>> common-theme
>>>>>>>> and all macro ftl libraries.
>>>>>>>>
>>>>>>>> 1806134 : load VisualTheme and ModelTheme on different session and
>>>>>>>>
>>>>>>> context
>>>>>>> 1806137, 180614[0-9] : Migrate themes, common screens, handler to
>>>>>>> exploit
>>>>>>> values from the theme definition
>>>>>>> 1806150 : migrate all other screen and scripts  to exploit values from
>>>>>>> the theme definition
>>>>>>> 180615 : improve error message and announce the commit end :)
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Nicolas
>>>>>>>
>>>>>>> I hope to break nothing at this time.
>>>>>>>
>>>>>>>> The next steps will load the dynamic theme load on session
>>>>>>>>
>>>>>>>> Cheers,
>>>>>>>>
>>>>>>>> Nicolas
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
>>>>>>>>
>>>>>>>> Hi Taher,
>>>>>>>>
>>>>>>>>> If you have few time to have a look on these three class :
>>>>>>>>>
>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>>>>> model/ModelTheme.java
>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>>>>> model/ThemeFactory.java
>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>>>>> renderer/VisualTheme.java
>>>>>>>>>
>>>>>>>>> ModelTheme is java class to load all Theme definition who interact
>>>>>>>>> with
>>>>>>>>> the system
>>>>>>>>>
>>>>>>>>> VisualTheme is java class regards the VisualTheme entity who
>>>>>>>>> interact
>>>>>>>>> with the user to exploit the modelTheme
>>>>>>>>>
>>>>>>>>> ThemeFactory is the factory to create both.
>>>>>>>>>
>>>>>>>>> I prepare my commits, but I need to separate properly each code
>>>>>>>>> modification to help other learn the work.
>>>>>>>>>
>>>>>>>>> Cheers,
>>>>>>>>> Nicolas
>>>>>>>>>
>>>>>>>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>>>>>>>>>
>>>>>>>>> Hi Nicolas,
>>>>>>>>>
>>>>>>>>>> If it helps you, I suggest to isolate files / code where you are
>>>>>>>>>> not
>>>>>>>>>> very comfortable and put them in a separate patch (not the full
>>>>>>>>>> patch)
>>>>>>>>>> with an explanation of what you've done and where you feel a little
>>>>>>>>>> hesitant or uneasy. I think if you make us focus with you on very
>>>>>>>>>> specific pieces of code then our review will be faster and your
>>>>>>>>>> confidence of the review will be better.
>>>>>>>>>>
>>>>>>>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>>>>>>>>>> <ni...@nereide.fr> wrote:
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>>
>>>>>>>>>>> I will commit on trunk after a second review of my code because i
>>>>>>>>>>> was
>>>>>>>>>>> concentrated to increase the flexibility with macro and screen but
>>>>>>>>>>> not
>>>>>>>>>>> manage correctly the VisualTheme concept.
>>>>>>>>>>>
>>>>>>>>>>> So I will take care about this, complete the documentation and
>>>>>>>>>>> commit
>>>>>>>>>>> on
>>>>>>>>>>> trunk.
>>>>>>>>>>>
>>>>>>>>>>> Nicolas
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>>>>>>>>>
>>>>>>>>>>> Like Michael, I also prefer to include the work into the code base
>>>>>>>>>>>
>>>>>>>>>>>> and
>>>>>>>>>>>> test it over there. It seems like you put a lot of effort into
>>>>>>>>>>>> this
>>>>>>>>>>>> code so thank you! I like the fact that you brought all the
>>>>>>>>>>>> artifacts
>>>>>>>>>>>> into the theme along with the FTL macros. This is a good first
>>>>>>>>>>>> step,
>>>>>>>>>>>> and I believe continuing on this direction is where we need to
>>>>>>>>>>>> go.
>>>>>>>>>>>>
>>>>>>>>>>>> +1 to committing into the code base and testing over there.
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>>>>>>>>>> <ja...@les7arts.com> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> That sounds great,
>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks Nicolas!
>>>>>>>>>>>>>
>>>>>>>>>>>>> Jacques
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>>>>>>>>>
>>>>>>>>>>>>> Hello,
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I started the documentation here
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>>>>>>> themes/README.md
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> It's a begging, I hope improve it quickly
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hello;
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> To continue the common-theme subject, I haven't see negative
>>>>>>>>>>>>>>> return to
>>>>>>>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on
>>>>>>>>>>>>>>> threads
>>>>>>>>>>>>>>> on the
>>>>>>>>>>>>>>> same
>>>>>>>>>>>>>>> subject [2] and the additional theme xml definition [3], I
>>>>>>>>>>>>>>> suggest to
>>>>>>>>>>>>>>> create
>>>>>>>>>>>>>>> a documentation on the wiki how work the "theme engine" and
>>>>>>>>>>>>>>> commit the
>>>>>>>>>>>>>>> current git branch [4] [5] on trunk
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> After that, the engine will be present on the trunk and we
>>>>>>>>>>>>>>> continue the
>>>>>>>>>>>>>>> work to :
>>>>>>>>>>>>>>> * Clean the common-theme and create a real theme
>>>>>>>>>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>>>>>>>>>> * Analyze more how organize the screen api
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> But don't panic, before that I'm listening to all suggest or
>>>>>>>>>>>>>>> remarks ;)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>>>>>>>>>> [2]
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15
>>>>>>>>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>>>>>>> [3]
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38ab
>>>>>>>>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>>>>>>> [4] https://github.com/nmalin/ofbi
>>>>>>>>>>>>>>> z-framework/tree/common-theme
>>>>>>>>>>>>>>> [5]
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...
>>>>>>>>>>>>>>> nmalin:common-theme?expand=1
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>



Re: Common-theme next step

Posted by Swapnil Mane <sw...@hotwaxsystems.com>.
Yes Jacques, thanks for looking into this.


- Best Regards,
Swapnil M Mane

On Tue, Sep 26, 2017 at 2:08 PM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:

> Hi Swapnil, All,
>
> This is a real problem, I just crossed it also with
>
> 2017-09-26 10:03:34,730 |jsse-nio-8443-exec-6
> |ServiceDispatcher             |T| [[ASync service failed...-
> total:0.004,since last(ASync service sta...):0.004]] - 'ecommerce /
> sendOrderConfirmation'
> 2017-09-26 10:03:34,730 |jsse-nio-8443-exec-6
> |ServiceDispatcher             |E| Service [sendOrderConfirmation] threw an
> unexpected exception/error
> org.apache.ofbiz.service.GenericServiceException: Problem serializing
> service attributes (Cannot serialize object of class
> org.apache.ofbiz.widget.renderer.VisualTheme)
>
> and
>
> 2017-09-26 10:03:40,283 |jsse-nio-8443-exec-6
> |ScreenFactory                 |I| Got 2 screens in 0.005s from:
> file:/C:/projectsASF/ofbiz/plugins/ecommerce/widget/Shopping
> ListScreens.xml
> 2017-09-26 10:03:40,578 |jsse-nio-8443-exec-6
> |ScriptUtil                    |W| Error running script at location
> [component://ecommerce/groovyScripts/shoppinglist/EditShoppingList.groovy]:
> org.codehaus.groov
> y.runtime.typehandling.GroovyCastException: Cannot cast object 'USD' with
> class 'java.lang.String' to class 'org.apache.ofbiz.widget.rende
> rer.VisualTheme'
> org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast
> object 'USD' with class 'java.lang.String' to class
> 'org.apache.ofbiz.widget.renderer.VisualTheme'
>
> I have no other ideas yet (working on something else). But I'll have a
> look ASAP
>
> Jacques
>
>
>
> Le 23/09/2017 à 11:11, Swapnil Mane a écrit :
>
>> Thanks Jacques for your timings and suggestion.
>> @SuppressWarnings("serial") doesn't work for me.
>>
>> ========= Console Log start =========
>>
>> 2017-09-23 14:38:25,610 |jsse-nio-8443-exec-8
>> |ServiceDispatcher             |T| [[ASync service started...-
>> total:0.0,since last(Begin):0.0]] - 'manufacturing / executeMrp'
>> 2017-09-23 14:38:25,630 |jsse-nio-8443-exec-8
>> |SequenceUtil                  |I| Got bank of sequenced IDs for
>> [RuntimeData]; curSeqId=10600, maxSeqId=10700, bankSize=100
>> 2017-09-23 14:38:25,649 |jsse-nio-8443-exec-8
>> |UtilObject                    |E| null
>> java.io.NotSerializableException: org.apache.ofbiz.widget.model.
>> ModelTheme$ModelTemplate
>>          at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.
>> java:1184)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.
>> java:348)
>> ~[?:1.8.0_66]
>>          at java.util.HashMap.internalWriteEntries(HashMap.java:1777)
>> ~[?:1.8.0_66]
>>          at java.util.HashMap.writeObject(HashMap.java:1354)
>> ~[?:1.8.0_66]
>>          at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> ~[?:1.8.0_66]
>>          at sun.reflect.NativeMethodAccessorImpl.invoke(
>> NativeMethodAccessorImpl.java:62) ~[?:1.8.0_66]
>>          at sun.reflect.DelegatingMethodAccessorImpl.invoke(
>> DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_66]
>>          at java.lang.reflect.Method.invoke(Method.java:497)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClas
>> s.java:1028)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStrea
>> m.java:1496)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputS
>> tream.java:1432)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.
>> java:1178)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputSt
>> ream.java:1548)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStrea
>> m.java:1509)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputS
>> tream.java:1432)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.
>> java:1178)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputSt
>> ream.java:1548)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStrea
>> m.java:1509)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputS
>> tream.java:1432)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.
>> java:1178)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputSt
>> ream.java:1548)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStrea
>> m.java:1509)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputS
>> tream.java:1432)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.
>> java:1178)
>> ~[?:1.8.0_66]
>>          at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.
>> java:348)
>> ~[?:1.8.0_66]
>>          at org.apache.ofbiz.base.util.UtilObject.getBytes(UtilObject.
>> java:82)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
>> serializeCustom(XmlSerializer.java:262) [ofbiz.jar:?]
>>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
>> serializeSingle(XmlSerializer.java:257) [ofbiz.jar:?]
>>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
>> serializeSingle(XmlSerializer.java:252) [ofbiz.jar:?]
>>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
>> serialize(XmlSerializer.java:78) [ofbiz.jar:?]
>>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>> runAsync(GenericAsyncEngine.java:94) [ofbiz.jar:?]
>>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>> runAsync(GenericAsyncEngine.java:70) [ofbiz.jar:?]
>>          at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>> ispatcher.java:715)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>> ispatcher.java:780)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.service.GenericDispatcherFactory$
>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.service.GenericDispatcherFactory$
>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>> viceEventHandler.java:348)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.control.RequestHandler.
>> runEvent(RequestHandler.java:730) [ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.control.RequestHandler.
>> doRequest(RequestHandler.java:454) [ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>> Servlet.java:212)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>> lServlet.java:87)
>> [ofbiz.jar:?]
>>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(
>> ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilte
>> r.java:52)
>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(
>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.ofbiz.webapp.control.ContextFilter.
>> doFilter(ContextFilter.java:196) [ofbiz.jar:?]
>>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(
>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.ofbiz.webapp.control.ControlFilter.
>> doFilter(ControlFilter.java:157) [ofbiz.jar:?]
>>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(
>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>> dWrapperValve.java:198)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.StandardContextValve.invoke(Standar
>> dContextValve.java:96)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>> uthenticatorBase.java:478)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>> stValve.java:140)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>> rtValve.java:80)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.StandardEngineValve.invoke(Standard
>> EngineValve.java:87)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
>> AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>> apter.java:342)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.coyote.http11.Http11Processor.service(Http11Proce
>> ssor.java:799)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at org.apache.coyote.AbstractProcessorLight.process(
>> AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at org.apache.coyote.AbstractProtocol$ConnectionHandler.
>> process(AbstractProtocol.java:868)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>> (NioEndpoint.java:1455)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>> cessorBase.java:49)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>> Executor.java:1142)
>> [?:1.8.0_66]
>>          at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>> lExecutor.java:617)
>> [?:1.8.0_66]
>>          at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.
>> run(TaskThread.java:61)
>> [tomcat-util-8.5.16.jar:8.5.16]
>>          at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>> 2017-09-23 14:38:25,653 |jsse-nio-8443-exec-8
>> |ServiceDispatcher             |T| [[ASync service failed...-
>> total:0.043,since last(ASync service sta...):0.043]] - 'manufacturing /
>> executeMrp'
>> 2017-09-23 14:38:25,653 |jsse-nio-8443-exec-8
>> |ServiceDispatcher             |E| Service [executeMrp] threw an
>> unexpected
>> exception/error
>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>> service attributes (Unable to serialize object; null byte array returned)
>>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>> runAsync(GenericAsyncEngine.java:124) ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>> runAsync(GenericAsyncEngine.java:70) ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>> ispatcher.java:715)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>> ispatcher.java:780)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.service.GenericDispatcherFactory$
>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.service.GenericDispatcherFactory$
>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>> viceEventHandler.java:348)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.control.RequestHandler.
>> runEvent(RequestHandler.java:730) [ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.control.RequestHandler.
>> doRequest(RequestHandler.java:454) [ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>> Servlet.java:212)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>> lServlet.java:87)
>> [ofbiz.jar:?]
>>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(
>> ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilte
>> r.java:52)
>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(
>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.ofbiz.webapp.control.ContextFilter.
>> doFilter(ContextFilter.java:196) [ofbiz.jar:?]
>>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(
>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.ofbiz.webapp.control.ControlFilter.
>> doFilter(ControlFilter.java:157) [ofbiz.jar:?]
>>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(
>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>> dWrapperValve.java:198)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.StandardContextValve.invoke(Standar
>> dContextValve.java:96)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>> uthenticatorBase.java:478)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>> stValve.java:140)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>> rtValve.java:80)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.StandardEngineValve.invoke(Standard
>> EngineValve.java:87)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
>> AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>> apter.java:342)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.coyote.http11.Http11Processor.service(Http11Proce
>> ssor.java:799)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at org.apache.coyote.AbstractProcessorLight.process(
>> AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at org.apache.coyote.AbstractProtocol$ConnectionHandler.
>> process(AbstractProtocol.java:868)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>> (NioEndpoint.java:1455)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>> cessorBase.java:49)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>> Executor.java:1142)
>> [?:1.8.0_66]
>>          at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>> lExecutor.java:617)
>> [?:1.8.0_66]
>>          at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.
>> run(TaskThread.java:61)
>> [tomcat-util-8.5.16.jar:8.5.16]
>>          at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Unable
>> to
>> serialize object; null byte array returned
>>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
>> serializeCustom(XmlSerializer.java:264) ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
>> serializeSingle(XmlSerializer.java:257) ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
>> serializeSingle(XmlSerializer.java:252) ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
>> serialize(XmlSerializer.java:78) ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>> runAsync(GenericAsyncEngine.java:94) ~[ofbiz.jar:?]
>>          ... 40 more
>> 2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
>> |TransactionUtil               |I| Transaction rolled back
>> 2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
>> |TransactionUtil               |W| Not committing transaction, status is
>> No
>> Transaction (6)
>> 2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
>> |ServiceEventHandler           |E| Service invocation error
>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>> service attributes (Unable to serialize object; null byte array returned)
>>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>> runAsync(GenericAsyncEngine.java:124) ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>> runAsync(GenericAsyncEngine.java:70) ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>> ispatcher.java:715)
>> ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>> ispatcher.java:780)
>> ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.service.GenericDispatcherFactory$
>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
>> ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.service.GenericDispatcherFactory$
>> GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
>> ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>> viceEventHandler.java:348)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.control.RequestHandler.
>> runEvent(RequestHandler.java:730) [ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.control.RequestHandler.
>> doRequest(RequestHandler.java:454) [ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>> Servlet.java:212)
>> [ofbiz.jar:?]
>>          at org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>> lServlet.java:87)
>> [ofbiz.jar:?]
>>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(
>> ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilte
>> r.java:52)
>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(
>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.ofbiz.webapp.control.ContextFilter.
>> doFilter(ContextFilter.java:196) [ofbiz.jar:?]
>>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(
>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.ofbiz.webapp.control.ControlFilter.
>> doFilter(ControlFilter.java:157) [ofbiz.jar:?]
>>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(
>> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
>> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>> dWrapperValve.java:198)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.StandardContextValve.invoke(Standar
>> dContextValve.java:96)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>> uthenticatorBase.java:478)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>> stValve.java:140)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>> rtValve.java:80)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.core.StandardEngineValve.invoke(Standard
>> EngineValve.java:87)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
>> AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>> apter.java:342)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at org.apache.coyote.http11.Http11Processor.service(Http11Proce
>> ssor.java:799)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at org.apache.coyote.AbstractProcessorLight.process(
>> AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at org.apache.coyote.AbstractProtocol$ConnectionHandler.
>> process(AbstractProtocol.java:868)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>> (NioEndpoint.java:1455)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>> cessorBase.java:49)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>> Executor.java:1142)
>> [?:1.8.0_66]
>>          at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>> lExecutor.java:617)
>> [?:1.8.0_66]
>>          at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.
>> run(TaskThread.java:61)
>> [tomcat-util-8.5.16.jar:8.5.16]
>>          at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Unable
>> to
>> serialize object; null byte array returned
>>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
>> serializeCustom(XmlSerializer.java:264) ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
>> serializeSingle(XmlSerializer.java:257) ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
>> serializeSingle(XmlSerializer.java:252) ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
>> serialize(XmlSerializer.java:78) ~[ofbiz.jar:?]
>>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
>> runAsync(GenericAsyncEngine.java:94) ~[ofbiz.jar:?]
>>          ... 40 more
>>
>> ========= Console Log end =========
>>
>>
>> - Best Regards,
>> Swapnil
>>
>> On Sat, Sep 23, 2017 at 1:33 PM, Jacques Le Roux <
>> jacques.le.roux@les7arts.com> wrote:
>>
>> Hi Swapnil,
>>>
>>> Did you try?
>>>
>>> @SuppressWarnings("serial")
>>> public final class VisualTheme implements Serializable {
>>>
>>> Jacques
>>>
>>>
>>>
>>> Le 23/09/2017 à 08:29, Swapnil Mane a écrit :
>>>
>>> Thank you Nicolas and team for this great work.
>>>> Highly appreciated!!
>>>>
>>>> I am facing some Exception related to VisualTheme while running the MRP.
>>>> https://demo-trunk.ofbiz.apache.org/manufacturing/control/RunMrp
>>>>
>>>> I guess it is related to theme work we have done, please let me know,
>>>> if I
>>>> am missing anything.
>>>>
>>>>
>>>> ========= Console Log start =========
>>>> [[ASync service failed...- total:0.012,since last(ASync service
>>>> sta...):0.012]] - 'manufacturing / executeMrp'
>>>> 2017-09-23 11:44:24,458 |jsse-nio-8443-exec-6
>>>> |ServiceDispatcher             |E| Service [executeMrp] threw an
>>>> unexpected
>>>> exception/error
>>>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>>>> service attributes (Cannot serialize object of class
>>>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>>>           at
>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>> GenericAsyncEngine.java:124)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>> GenericAsyncEngine.java:70)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>>> ispatcher.java:715)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>>> ispatcher.java:780)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>>> patcher.runAsync(GenericDispatcherFactory.java:181)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>>> patcher.runAsync(GenericDispatcherFactory.java:191)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>>>> viceEventHandler.java:348)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(Requ
>>>> estHandler.java:730)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(Req
>>>> uestHandler.java:454)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>>>> Servlet.java:212)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>>>> lServlet.java:87)
>>>> [ofbiz.jar:?]
>>>>           at javax.servlet.http.HttpServlet
>>>> .service(HttpServlet.java:707)
>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>           at javax.servlet.http.HttpServlet
>>>> .service(HttpServlet.java:790)
>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>> lter(ApplicationFilterChain.java:231)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>> licationFilterChain.java:166)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>>>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>> lter(ApplicationFilterChain.java:193)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>> licationFilterChain.java:166)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(Conte
>>>> xtFilter.java:196)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>> lter(ApplicationFilterChain.java:193)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>> licationFilterChain.java:166)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(Contr
>>>> olFilter.java:157)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>> lter(ApplicationFilterChain.java:193)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>> licationFilterChain.java:166)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>>>> dWrapperValve.java:198)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.StandardContextValve.invoke(Standar
>>>> dContextValve.java:96)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>>>> uthenticatorBase.java:478)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>>>> stValve.java:140)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>>>> rtValve.java:80)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.StandardEngineValve.invoke(Standard
>>>> EngineValve.java:87)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.valves.AbstractAccessLogValve.invoke(Abs
>>>> tractAccessLogValve.java:624)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>>>> apter.java:342)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.coyote.http11.Http11Processor.service(Http11Proce
>>>> ssor.java:799)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.coyote.AbstractProcessorLight.process(AbstractPro
>>>> cessorLight.java:66)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.coyote.AbstractProtocol$ConnectionHandler.process
>>>> (AbstractProtocol.java:868)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>>>> (NioEndpoint.java:1455)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>>>> cessorBase.java:49)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at
>>>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>>>> Executor.java:1142)
>>>> [?:1.8.0_66]
>>>>           at
>>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>>>> lExecutor.java:617)
>>>> [?:1.8.0_66]
>>>>           at
>>>> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.r
>>>> un(TaskThread.java:61)
>>>> [tomcat-util-8.5.16.jar:8.5.16]
>>>>           at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>>>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Cannot
>>>> serialize object of class org.apache.ofbiz.widget.renderer.VisualTheme
>>>>           at
>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCus
>>>> tom(XmlSerializer.java:273)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>>> gle(XmlSerializer.java:257)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>>> gle(XmlSerializer.java:252)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(Xm
>>>> lSerializer.java:78)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>> GenericAsyncEngine.java:94)
>>>> ~[ofbiz.jar:?]
>>>>           ... 40 more
>>>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>>>> |TransactionUtil               |I| Transaction rolled back
>>>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>>>> |TransactionUtil               |W| Not committing transaction, status is
>>>> No
>>>> Transaction (6)
>>>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>>>> |ServiceEventHandler           |E| Service invocation error
>>>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>>>> service attributes (Cannot serialize object of class
>>>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>>>           at
>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>> GenericAsyncEngine.java:124)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>> GenericAsyncEngine.java:70)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>>> ispatcher.java:715)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>>> ispatcher.java:780)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>>> patcher.runAsync(GenericDispatcherFactory.java:181)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>>> patcher.runAsync(GenericDispatcherFactory.java:191)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>>>> viceEventHandler.java:348)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(Requ
>>>> estHandler.java:730)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(Req
>>>> uestHandler.java:454)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>>>> Servlet.java:212)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>>>> lServlet.java:87)
>>>> [ofbiz.jar:?]
>>>>           at javax.servlet.http.HttpServlet
>>>> .service(HttpServlet.java:707)
>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>           at javax.servlet.http.HttpServlet
>>>> .service(HttpServlet.java:790)
>>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>> lter(ApplicationFilterChain.java:231)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>> licationFilterChain.java:166)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>>>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>> lter(ApplicationFilterChain.java:193)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>> licationFilterChain.java:166)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(Conte
>>>> xtFilter.java:196)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>> lter(ApplicationFilterChain.java:193)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>> licationFilterChain.java:166)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(Contr
>>>> olFilter.java:157)
>>>> [ofbiz.jar:?]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>>> lter(ApplicationFilterChain.java:193)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>>> licationFilterChain.java:166)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>>>> dWrapperValve.java:198)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.StandardContextValve.invoke(Standar
>>>> dContextValve.java:96)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>>>> uthenticatorBase.java:478)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>>>> stValve.java:140)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>>>> rtValve.java:80)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.core.StandardEngineValve.invoke(Standard
>>>> EngineValve.java:87)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.valves.AbstractAccessLogValve.invoke(Abs
>>>> tractAccessLogValve.java:624)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>>>> apter.java:342)
>>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.coyote.http11.Http11Processor.service(Http11Proce
>>>> ssor.java:799)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.coyote.AbstractProcessorLight.process(AbstractPro
>>>> cessorLight.java:66)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.coyote.AbstractProtocol$ConnectionHandler.process
>>>> (AbstractProtocol.java:868)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>>>> (NioEndpoint.java:1455)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at
>>>> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>>>> cessorBase.java:49)
>>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>>           at
>>>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>>>> Executor.java:1142)
>>>> [?:1.8.0_66]
>>>>           at
>>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>>>> lExecutor.java:617)
>>>> [?:1.8.0_66]
>>>>           at
>>>> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.r
>>>> un(TaskThread.java:61)
>>>> [tomcat-util-8.5.16.jar:8.5.16]
>>>>           at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>>>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Cannot
>>>> serialize object of class org.apache.ofbiz.widget.renderer.VisualTheme
>>>>           at
>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCus
>>>> tom(XmlSerializer.java:273)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>>> gle(XmlSerializer.java:257)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>>> gle(XmlSerializer.java:252)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(Xm
>>>> lSerializer.java:78)
>>>> ~[ofbiz.jar:?]
>>>>           at
>>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>>> GenericAsyncEngine.java:94)
>>>> ~[ofbiz.jar:?]
>>>>           ... 40 more
>>>> 2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
>>>> |RequestHandler                |E| Request runMrpGo caused an error with
>>>> the following message: Error calling event:
>>>> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation
>>>> error (Cannot serialize object of class
>>>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>>> 2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
>>>> |RequestHandler                |I| Rendering View [MrpExecution].
>>>> Hidden
>>>> sessionId by default.
>>>> 2017-09-23 11:44:24,465 |jsse-nio-8443-exec-6
>>>> |ServiceDispatcher             |T| Sync service
>>>> [manufacturing/getUserPreferenceGroup] finished in [1] milliseconds
>>>>
>>>> ========= Console log end =========
>>>>
>>>>
>>>> - Best Regards,
>>>> Swapnil M Mane
>>>>
>>>>
>>>> On Sun, Sep 10, 2017 at 4:21 PM, Michael Brohl <
>>>> michael.brohl@ecomify.de>
>>>> wrote:
>>>>
>>>> Thank you, Nicolas, for the great effort you put on this.
>>>>
>>>>> I'll hope to soon reactivate my work on the bootstrap theme, using the
>>>>> new
>>>>> structure, and see how it will work out.
>>>>>
>>>>> I'll have some more qualified feedback (and propably questions ;-) )
>>>>> then...
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Michael
>>>>>
>>>>>
>>>>> Am 25.08.17 um 12:15 schrieb Nicolas Malin:
>>>>>
>>>>> I loaded all my local :)
>>>>>
>>>>> Le 25/08/2017 à 00:03, Nicolas Malin a écrit :
>>>>>>
>>>>>> I started to load common-theme on trunk, at this time to resume :
>>>>>>
>>>>>>> r1806075, r1806076 : I loaded engine and documentation
>>>>>>> r1806084 : I moved all images folder to common-theme
>>>>>>> r1806091, r1806093: I moved all ftl template from common to
>>>>>>> common-theme
>>>>>>> and all macro ftl libraries.
>>>>>>>
>>>>>>> 1806134 : load VisualTheme and ModelTheme on different session and
>>>>>>>
>>>>>> context
>>>>>> 1806137, 180614[0-9] : Migrate themes, common screens, handler to
>>>>>> exploit
>>>>>> values from the theme definition
>>>>>> 1806150 : migrate all other screen and scripts  to exploit values from
>>>>>> the theme definition
>>>>>> 180615 : improve error message and announce the commit end :)
>>>>>>
>>>>>> Cheers,
>>>>>> Nicolas
>>>>>>
>>>>>> I hope to break nothing at this time.
>>>>>>
>>>>>>> The next steps will load the dynamic theme load on session
>>>>>>>
>>>>>>> Cheers,
>>>>>>>
>>>>>>> Nicolas
>>>>>>>
>>>>>>>
>>>>>>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
>>>>>>>
>>>>>>> Hi Taher,
>>>>>>>
>>>>>>>> If you have few time to have a look on these three class :
>>>>>>>>
>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>>>> model/ModelTheme.java
>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>>>> model/ThemeFactory.java
>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>>>> renderer/VisualTheme.java
>>>>>>>>
>>>>>>>> ModelTheme is java class to load all Theme definition who interact
>>>>>>>> with
>>>>>>>> the system
>>>>>>>>
>>>>>>>> VisualTheme is java class regards the VisualTheme entity who
>>>>>>>> interact
>>>>>>>> with the user to exploit the modelTheme
>>>>>>>>
>>>>>>>> ThemeFactory is the factory to create both.
>>>>>>>>
>>>>>>>> I prepare my commits, but I need to separate properly each code
>>>>>>>> modification to help other learn the work.
>>>>>>>>
>>>>>>>> Cheers,
>>>>>>>> Nicolas
>>>>>>>>
>>>>>>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>>>>>>>>
>>>>>>>> Hi Nicolas,
>>>>>>>>
>>>>>>>>> If it helps you, I suggest to isolate files / code where you are
>>>>>>>>> not
>>>>>>>>> very comfortable and put them in a separate patch (not the full
>>>>>>>>> patch)
>>>>>>>>> with an explanation of what you've done and where you feel a little
>>>>>>>>> hesitant or uneasy. I think if you make us focus with you on very
>>>>>>>>> specific pieces of code then our review will be faster and your
>>>>>>>>> confidence of the review will be better.
>>>>>>>>>
>>>>>>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>>>>>>>>> <ni...@nereide.fr> wrote:
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>>
>>>>>>>>>> I will commit on trunk after a second review of my code because i
>>>>>>>>>> was
>>>>>>>>>> concentrated to increase the flexibility with macro and screen but
>>>>>>>>>> not
>>>>>>>>>> manage correctly the VisualTheme concept.
>>>>>>>>>>
>>>>>>>>>> So I will take care about this, complete the documentation and
>>>>>>>>>> commit
>>>>>>>>>> on
>>>>>>>>>> trunk.
>>>>>>>>>>
>>>>>>>>>> Nicolas
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>>>>>>>>
>>>>>>>>>> Like Michael, I also prefer to include the work into the code base
>>>>>>>>>>
>>>>>>>>>>> and
>>>>>>>>>>> test it over there. It seems like you put a lot of effort into
>>>>>>>>>>> this
>>>>>>>>>>> code so thank you! I like the fact that you brought all the
>>>>>>>>>>> artifacts
>>>>>>>>>>> into the theme along with the FTL macros. This is a good first
>>>>>>>>>>> step,
>>>>>>>>>>> and I believe continuing on this direction is where we need to
>>>>>>>>>>> go.
>>>>>>>>>>>
>>>>>>>>>>> +1 to committing into the code base and testing over there.
>>>>>>>>>>>
>>>>>>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>>>>>>>>> <ja...@les7arts.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>> That sounds great,
>>>>>>>>>>>
>>>>>>>>>>>> Thanks Nicolas!
>>>>>>>>>>>>
>>>>>>>>>>>> Jacques
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>>>>>>>>
>>>>>>>>>>>> Hello,
>>>>>>>>>>>>
>>>>>>>>>>>>> I started the documentation here
>>>>>>>>>>>>>
>>>>>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>>>>>> themes/README.md
>>>>>>>>>>>>>
>>>>>>>>>>>>> It's a begging, I hope improve it quickly
>>>>>>>>>>>>>
>>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>>>>>>>>
>>>>>>>>>>>>> Hello;
>>>>>>>>>>>>>
>>>>>>>>>>>>>> To continue the common-theme subject, I haven't see negative
>>>>>>>>>>>>>> return to
>>>>>>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on
>>>>>>>>>>>>>> threads
>>>>>>>>>>>>>> on the
>>>>>>>>>>>>>> same
>>>>>>>>>>>>>> subject [2] and the additional theme xml definition [3], I
>>>>>>>>>>>>>> suggest to
>>>>>>>>>>>>>> create
>>>>>>>>>>>>>> a documentation on the wiki how work the "theme engine" and
>>>>>>>>>>>>>> commit the
>>>>>>>>>>>>>> current git branch [4] [5] on trunk
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> After that, the engine will be present on the trunk and we
>>>>>>>>>>>>>> continue the
>>>>>>>>>>>>>> work to :
>>>>>>>>>>>>>> * Clean the common-theme and create a real theme
>>>>>>>>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>>>>>>>>> * Analyze more how organize the screen api
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> But don't panic, before that I'm listening to all suggest or
>>>>>>>>>>>>>> remarks ;)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>>>>>>>>> [2]
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15
>>>>>>>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>>>>>> [3]
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38ab
>>>>>>>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>>>>>> [4] https://github.com/nmalin/ofbi
>>>>>>>>>>>>>> z-framework/tree/common-theme
>>>>>>>>>>>>>> [5]
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...
>>>>>>>>>>>>>> nmalin:common-theme?expand=1
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>
>

Re: Common-theme next step

Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 26/09/2017 à 10:38, Jacques Le Roux a écrit :
> 2017-09-26 10:03:40,283 |jsse-nio-8443-exec-6 |ScreenFactory                 |I| Got 2 screens in 0.005s from: 
> file:/C:/projectsASF/ofbiz/plugins/ecommerce/widget/ShoppingListScreens.xml
> 2017-09-26 10:03:40,578 |jsse-nio-8443-exec-6 |ScriptUtil                    |W| Error running script at location 
> [component://ecommerce/groovyScripts/shoppinglist/EditShoppingList.groovy]: org.codehaus.groov
> y.runtime.typehandling.GroovyCastException: Cannot cast object 'USD' with class 'java.lang.String' to class 
> 'org.apache.ofbiz.widget.renderer.VisualTheme'
> org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast object 'USD' with class 'java.lang.String' to class 
> 'org.apache.ofbiz.widget.renderer.VisualTheme'
This one was because I did no update plugins after Deepak fixed it at r1807330

Jacques


Re: Common-theme next step

Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Swapnil, All,

This is a real problem, I just crossed it also with

2017-09-26 10:03:34,730 |jsse-nio-8443-exec-6 |ServiceDispatcher             |T| [[ASync service failed...- total:0.004,since last(ASync service 
sta...):0.004]] - 'ecommerce / sendOrderConfirmation'
2017-09-26 10:03:34,730 |jsse-nio-8443-exec-6 |ServiceDispatcher             |E| Service [sendOrderConfirmation] threw an unexpected exception/error
org.apache.ofbiz.service.GenericServiceException: Problem serializing service attributes (Cannot serialize object of class 
org.apache.ofbiz.widget.renderer.VisualTheme)

and

2017-09-26 10:03:40,283 |jsse-nio-8443-exec-6 |ScreenFactory                 |I| Got 2 screens in 0.005s from: 
file:/C:/projectsASF/ofbiz/plugins/ecommerce/widget/ShoppingListScreens.xml
2017-09-26 10:03:40,578 |jsse-nio-8443-exec-6 |ScriptUtil                    |W| Error running script at location 
[component://ecommerce/groovyScripts/shoppinglist/EditShoppingList.groovy]: org.codehaus.groov
y.runtime.typehandling.GroovyCastException: Cannot cast object 'USD' with class 'java.lang.String' to class 'org.apache.ofbiz.widget.renderer.VisualTheme'
org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast object 'USD' with class 'java.lang.String' to class 
'org.apache.ofbiz.widget.renderer.VisualTheme'

I have no other ideas yet (working on something else). But I'll have a look ASAP

Jacques


Le 23/09/2017 à 11:11, Swapnil Mane a écrit :
> Thanks Jacques for your timings and suggestion.
> @SuppressWarnings("serial") doesn't work for me.
>
> ========= Console Log start =========
>
> 2017-09-23 14:38:25,610 |jsse-nio-8443-exec-8
> |ServiceDispatcher             |T| [[ASync service started...-
> total:0.0,since last(Begin):0.0]] - 'manufacturing / executeMrp'
> 2017-09-23 14:38:25,630 |jsse-nio-8443-exec-8
> |SequenceUtil                  |I| Got bank of sequenced IDs for
> [RuntimeData]; curSeqId=10600, maxSeqId=10700, bankSize=100
> 2017-09-23 14:38:25,649 |jsse-nio-8443-exec-8
> |UtilObject                    |E| null
> java.io.NotSerializableException: org.apache.ofbiz.widget.model.
> ModelTheme$ModelTemplate
>          at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1184)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
> ~[?:1.8.0_66]
>          at java.util.HashMap.internalWriteEntries(HashMap.java:1777)
> ~[?:1.8.0_66]
>          at java.util.HashMap.writeObject(HashMap.java:1354) ~[?:1.8.0_66]
>          at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[?:1.8.0_66]
>          at sun.reflect.NativeMethodAccessorImpl.invoke(
> NativeMethodAccessorImpl.java:62) ~[?:1.8.0_66]
>          at sun.reflect.DelegatingMethodAccessorImpl.invoke(
> DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_66]
>          at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
>          at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:1028)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1496)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
> ~[?:1.8.0_66]
>          at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
> ~[?:1.8.0_66]
>          at org.apache.ofbiz.base.util.UtilObject.getBytes(UtilObject.java:82)
> [ofbiz.jar:?]
>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
> serializeCustom(XmlSerializer.java:262) [ofbiz.jar:?]
>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
> serializeSingle(XmlSerializer.java:257) [ofbiz.jar:?]
>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
> serializeSingle(XmlSerializer.java:252) [ofbiz.jar:?]
>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
> serialize(XmlSerializer.java:78) [ofbiz.jar:?]
>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
> runAsync(GenericAsyncEngine.java:94) [ofbiz.jar:?]
>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
> runAsync(GenericAsyncEngine.java:70) [ofbiz.jar:?]
>          at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:715)
> [ofbiz.jar:?]
>          at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:780)
> [ofbiz.jar:?]
>          at org.apache.ofbiz.service.GenericDispatcherFactory$
> GenericDispatcher.runAsync(GenericDispatcherFactory.java:181) [ofbiz.jar:?]
>          at org.apache.ofbiz.service.GenericDispatcherFactory$
> GenericDispatcher.runAsync(GenericDispatcherFactory.java:191) [ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:348)
> [ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.control.RequestHandler.
> runEvent(RequestHandler.java:730) [ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.control.RequestHandler.
> doRequest(RequestHandler.java:454) [ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
> [ofbiz.jar:?]
>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
> [javax.servlet-api-3.1.0.jar:3.1.0]
>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> [javax.servlet-api-3.1.0.jar:3.1.0]
>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.ofbiz.webapp.control.ContextFilter.
> doFilter(ContextFilter.java:196) [ofbiz.jar:?]
>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.ofbiz.webapp.control.ControlFilter.
> doFilter(ControlFilter.java:157) [ofbiz.jar:?]
>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
> AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at org.apache.coyote.AbstractProcessorLight.process(
> AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
>          at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [?:1.8.0_66]
>          at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [?:1.8.0_66]
>          at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> [tomcat-util-8.5.16.jar:8.5.16]
>          at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> 2017-09-23 14:38:25,653 |jsse-nio-8443-exec-8
> |ServiceDispatcher             |T| [[ASync service failed...-
> total:0.043,since last(ASync service sta...):0.043]] - 'manufacturing /
> executeMrp'
> 2017-09-23 14:38:25,653 |jsse-nio-8443-exec-8
> |ServiceDispatcher             |E| Service [executeMrp] threw an unexpected
> exception/error
> org.apache.ofbiz.service.GenericServiceException: Problem serializing
> service attributes (Unable to serialize object; null byte array returned)
>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
> runAsync(GenericAsyncEngine.java:124) ~[ofbiz.jar:?]
>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
> runAsync(GenericAsyncEngine.java:70) ~[ofbiz.jar:?]
>          at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:715)
> [ofbiz.jar:?]
>          at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:780)
> [ofbiz.jar:?]
>          at org.apache.ofbiz.service.GenericDispatcherFactory$
> GenericDispatcher.runAsync(GenericDispatcherFactory.java:181) [ofbiz.jar:?]
>          at org.apache.ofbiz.service.GenericDispatcherFactory$
> GenericDispatcher.runAsync(GenericDispatcherFactory.java:191) [ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:348)
> [ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.control.RequestHandler.
> runEvent(RequestHandler.java:730) [ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.control.RequestHandler.
> doRequest(RequestHandler.java:454) [ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
> [ofbiz.jar:?]
>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
> [javax.servlet-api-3.1.0.jar:3.1.0]
>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> [javax.servlet-api-3.1.0.jar:3.1.0]
>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.ofbiz.webapp.control.ContextFilter.
> doFilter(ContextFilter.java:196) [ofbiz.jar:?]
>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.ofbiz.webapp.control.ControlFilter.
> doFilter(ControlFilter.java:157) [ofbiz.jar:?]
>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
> AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at org.apache.coyote.AbstractProcessorLight.process(
> AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
>          at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [?:1.8.0_66]
>          at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [?:1.8.0_66]
>          at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> [tomcat-util-8.5.16.jar:8.5.16]
>          at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Unable to
> serialize object; null byte array returned
>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
> serializeCustom(XmlSerializer.java:264) ~[ofbiz.jar:?]
>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
> serializeSingle(XmlSerializer.java:257) ~[ofbiz.jar:?]
>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
> serializeSingle(XmlSerializer.java:252) ~[ofbiz.jar:?]
>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
> serialize(XmlSerializer.java:78) ~[ofbiz.jar:?]
>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
> runAsync(GenericAsyncEngine.java:94) ~[ofbiz.jar:?]
>          ... 40 more
> 2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
> |TransactionUtil               |I| Transaction rolled back
> 2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
> |TransactionUtil               |W| Not committing transaction, status is No
> Transaction (6)
> 2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
> |ServiceEventHandler           |E| Service invocation error
> org.apache.ofbiz.service.GenericServiceException: Problem serializing
> service attributes (Unable to serialize object; null byte array returned)
>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
> runAsync(GenericAsyncEngine.java:124) ~[ofbiz.jar:?]
>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
> runAsync(GenericAsyncEngine.java:70) ~[ofbiz.jar:?]
>          at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:715)
> ~[ofbiz.jar:?]
>          at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:780)
> ~[ofbiz.jar:?]
>          at org.apache.ofbiz.service.GenericDispatcherFactory$
> GenericDispatcher.runAsync(GenericDispatcherFactory.java:181) ~[ofbiz.jar:?]
>          at org.apache.ofbiz.service.GenericDispatcherFactory$
> GenericDispatcher.runAsync(GenericDispatcherFactory.java:191) ~[ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:348)
> [ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.control.RequestHandler.
> runEvent(RequestHandler.java:730) [ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.control.RequestHandler.
> doRequest(RequestHandler.java:454) [ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
>          at org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
> [ofbiz.jar:?]
>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
> [javax.servlet-api-3.1.0.jar:3.1.0]
>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> [javax.servlet-api-3.1.0.jar:3.1.0]
>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.ofbiz.webapp.control.ContextFilter.
> doFilter(ContextFilter.java:196) [ofbiz.jar:?]
>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.ofbiz.webapp.control.ControlFilter.
> doFilter(ControlFilter.java:157) [ofbiz.jar:?]
>          at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
> ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.ApplicationFilterChain.doFilter(
> ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
> AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at org.apache.coyote.AbstractProcessorLight.process(
> AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
>          at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [?:1.8.0_66]
>          at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [?:1.8.0_66]
>          at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> [tomcat-util-8.5.16.jar:8.5.16]
>          at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Unable to
> serialize object; null byte array returned
>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
> serializeCustom(XmlSerializer.java:264) ~[ofbiz.jar:?]
>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
> serializeSingle(XmlSerializer.java:257) ~[ofbiz.jar:?]
>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
> serializeSingle(XmlSerializer.java:252) ~[ofbiz.jar:?]
>          at org.apache.ofbiz.entity.serialize.XmlSerializer.
> serialize(XmlSerializer.java:78) ~[ofbiz.jar:?]
>          at org.apache.ofbiz.service.engine.GenericAsyncEngine.
> runAsync(GenericAsyncEngine.java:94) ~[ofbiz.jar:?]
>          ... 40 more
>
> ========= Console Log end =========
>
>
> - Best Regards,
> Swapnil
>
> On Sat, Sep 23, 2017 at 1:33 PM, Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
>
>> Hi Swapnil,
>>
>> Did you try?
>>
>> @SuppressWarnings("serial")
>> public final class VisualTheme implements Serializable {
>>
>> Jacques
>>
>>
>>
>> Le 23/09/2017 à 08:29, Swapnil Mane a écrit :
>>
>>> Thank you Nicolas and team for this great work.
>>> Highly appreciated!!
>>>
>>> I am facing some Exception related to VisualTheme while running the MRP.
>>> https://demo-trunk.ofbiz.apache.org/manufacturing/control/RunMrp
>>>
>>> I guess it is related to theme work we have done, please let me know, if I
>>> am missing anything.
>>>
>>>
>>> ========= Console Log start =========
>>> [[ASync service failed...- total:0.012,since last(ASync service
>>> sta...):0.012]] - 'manufacturing / executeMrp'
>>> 2017-09-23 11:44:24,458 |jsse-nio-8443-exec-6
>>> |ServiceDispatcher             |E| Service [executeMrp] threw an
>>> unexpected
>>> exception/error
>>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>>> service attributes (Cannot serialize object of class
>>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>>           at
>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>> GenericAsyncEngine.java:124)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>> GenericAsyncEngine.java:70)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>> ispatcher.java:715)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>> ispatcher.java:780)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>> patcher.runAsync(GenericDispatcherFactory.java:181)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>> patcher.runAsync(GenericDispatcherFactory.java:191)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>>> viceEventHandler.java:348)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(Requ
>>> estHandler.java:730)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(Req
>>> uestHandler.java:454)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>>> Servlet.java:212)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>>> lServlet.java:87)
>>> [ofbiz.jar:?]
>>>           at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>           at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(ApplicationFilterChain.java:231)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>> licationFilterChain.java:166)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(ApplicationFilterChain.java:193)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>> licationFilterChain.java:166)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(Conte
>>> xtFilter.java:196)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(ApplicationFilterChain.java:193)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>> licationFilterChain.java:166)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(Contr
>>> olFilter.java:157)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(ApplicationFilterChain.java:193)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>> licationFilterChain.java:166)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>>> dWrapperValve.java:198)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.StandardContextValve.invoke(Standar
>>> dContextValve.java:96)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>>> uthenticatorBase.java:478)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>>> stValve.java:140)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>>> rtValve.java:80)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.StandardEngineValve.invoke(Standard
>>> EngineValve.java:87)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.valves.AbstractAccessLogValve.invoke(Abs
>>> tractAccessLogValve.java:624)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>>> apter.java:342)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.coyote.http11.Http11Processor.service(Http11Proce
>>> ssor.java:799)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.coyote.AbstractProcessorLight.process(AbstractPro
>>> cessorLight.java:66)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.coyote.AbstractProtocol$ConnectionHandler.process
>>> (AbstractProtocol.java:868)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>>> (NioEndpoint.java:1455)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>>> cessorBase.java:49)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at
>>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>>> Executor.java:1142)
>>> [?:1.8.0_66]
>>>           at
>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>>> lExecutor.java:617)
>>> [?:1.8.0_66]
>>>           at
>>> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.r
>>> un(TaskThread.java:61)
>>> [tomcat-util-8.5.16.jar:8.5.16]
>>>           at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Cannot
>>> serialize object of class org.apache.ofbiz.widget.renderer.VisualTheme
>>>           at
>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCus
>>> tom(XmlSerializer.java:273)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>> gle(XmlSerializer.java:257)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>> gle(XmlSerializer.java:252)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(Xm
>>> lSerializer.java:78)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>> GenericAsyncEngine.java:94)
>>> ~[ofbiz.jar:?]
>>>           ... 40 more
>>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>>> |TransactionUtil               |I| Transaction rolled back
>>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>>> |TransactionUtil               |W| Not committing transaction, status is
>>> No
>>> Transaction (6)
>>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>>> |ServiceEventHandler           |E| Service invocation error
>>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>>> service attributes (Cannot serialize object of class
>>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>>           at
>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>> GenericAsyncEngine.java:124)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>> GenericAsyncEngine.java:70)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>> ispatcher.java:715)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>>> ispatcher.java:780)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>> patcher.runAsync(GenericDispatcherFactory.java:181)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>>> patcher.runAsync(GenericDispatcherFactory.java:191)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>>> viceEventHandler.java:348)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(Requ
>>> estHandler.java:730)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(Req
>>> uestHandler.java:454)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>>> Servlet.java:212)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>>> lServlet.java:87)
>>> [ofbiz.jar:?]
>>>           at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>           at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(ApplicationFilterChain.java:231)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>> licationFilterChain.java:166)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(ApplicationFilterChain.java:193)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>> licationFilterChain.java:166)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(Conte
>>> xtFilter.java:196)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(ApplicationFilterChain.java:193)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>> licationFilterChain.java:166)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(Contr
>>> olFilter.java:157)
>>> [ofbiz.jar:?]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>>> lter(ApplicationFilterChain.java:193)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>>> licationFilterChain.java:166)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>>> dWrapperValve.java:198)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.StandardContextValve.invoke(Standar
>>> dContextValve.java:96)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>>> uthenticatorBase.java:478)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>>> stValve.java:140)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>>> rtValve.java:80)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.core.StandardEngineValve.invoke(Standard
>>> EngineValve.java:87)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.valves.AbstractAccessLogValve.invoke(Abs
>>> tractAccessLogValve.java:624)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>>> apter.java:342)
>>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.coyote.http11.Http11Processor.service(Http11Proce
>>> ssor.java:799)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.coyote.AbstractProcessorLight.process(AbstractPro
>>> cessorLight.java:66)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.coyote.AbstractProtocol$ConnectionHandler.process
>>> (AbstractProtocol.java:868)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>>> (NioEndpoint.java:1455)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at
>>> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>>> cessorBase.java:49)
>>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>>           at
>>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>>> Executor.java:1142)
>>> [?:1.8.0_66]
>>>           at
>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>>> lExecutor.java:617)
>>> [?:1.8.0_66]
>>>           at
>>> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.r
>>> un(TaskThread.java:61)
>>> [tomcat-util-8.5.16.jar:8.5.16]
>>>           at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Cannot
>>> serialize object of class org.apache.ofbiz.widget.renderer.VisualTheme
>>>           at
>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCus
>>> tom(XmlSerializer.java:273)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>> gle(XmlSerializer.java:257)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>>> gle(XmlSerializer.java:252)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(Xm
>>> lSerializer.java:78)
>>> ~[ofbiz.jar:?]
>>>           at
>>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>>> GenericAsyncEngine.java:94)
>>> ~[ofbiz.jar:?]
>>>           ... 40 more
>>> 2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
>>> |RequestHandler                |E| Request runMrpGo caused an error with
>>> the following message: Error calling event:
>>> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation
>>> error (Cannot serialize object of class
>>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>> 2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
>>> |RequestHandler                |I| Rendering View [MrpExecution].  Hidden
>>> sessionId by default.
>>> 2017-09-23 11:44:24,465 |jsse-nio-8443-exec-6
>>> |ServiceDispatcher             |T| Sync service
>>> [manufacturing/getUserPreferenceGroup] finished in [1] milliseconds
>>>
>>> ========= Console log end =========
>>>
>>>
>>> - Best Regards,
>>> Swapnil M Mane
>>>
>>>
>>> On Sun, Sep 10, 2017 at 4:21 PM, Michael Brohl <mi...@ecomify.de>
>>> wrote:
>>>
>>> Thank you, Nicolas, for the great effort you put on this.
>>>> I'll hope to soon reactivate my work on the bootstrap theme, using the
>>>> new
>>>> structure, and see how it will work out.
>>>>
>>>> I'll have some more qualified feedback (and propably questions ;-) )
>>>> then...
>>>>
>>>> Thanks,
>>>>
>>>> Michael
>>>>
>>>>
>>>> Am 25.08.17 um 12:15 schrieb Nicolas Malin:
>>>>
>>>> I loaded all my local :)
>>>>
>>>>> Le 25/08/2017 à 00:03, Nicolas Malin a écrit :
>>>>>
>>>>> I started to load common-theme on trunk, at this time to resume :
>>>>>> r1806075, r1806076 : I loaded engine and documentation
>>>>>> r1806084 : I moved all images folder to common-theme
>>>>>> r1806091, r1806093: I moved all ftl template from common to
>>>>>> common-theme
>>>>>> and all macro ftl libraries.
>>>>>>
>>>>>> 1806134 : load VisualTheme and ModelTheme on different session and
>>>>> context
>>>>> 1806137, 180614[0-9] : Migrate themes, common screens, handler to
>>>>> exploit
>>>>> values from the theme definition
>>>>> 1806150 : migrate all other screen and scripts  to exploit values from
>>>>> the theme definition
>>>>> 180615 : improve error message and announce the commit end :)
>>>>>
>>>>> Cheers,
>>>>> Nicolas
>>>>>
>>>>> I hope to break nothing at this time.
>>>>>> The next steps will load the dynamic theme load on session
>>>>>>
>>>>>> Cheers,
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>>
>>>>>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
>>>>>>
>>>>>> Hi Taher,
>>>>>>> If you have few time to have a look on these three class :
>>>>>>>
>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>>> model/ModelTheme.java
>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>>> model/ThemeFactory.java
>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>>> renderer/VisualTheme.java
>>>>>>>
>>>>>>> ModelTheme is java class to load all Theme definition who interact
>>>>>>> with
>>>>>>> the system
>>>>>>>
>>>>>>> VisualTheme is java class regards the VisualTheme entity who interact
>>>>>>> with the user to exploit the modelTheme
>>>>>>>
>>>>>>> ThemeFactory is the factory to create both.
>>>>>>>
>>>>>>> I prepare my commits, but I need to separate properly each code
>>>>>>> modification to help other learn the work.
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Nicolas
>>>>>>>
>>>>>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>>>>>>>
>>>>>>> Hi Nicolas,
>>>>>>>> If it helps you, I suggest to isolate files / code where you are not
>>>>>>>> very comfortable and put them in a separate patch (not the full
>>>>>>>> patch)
>>>>>>>> with an explanation of what you've done and where you feel a little
>>>>>>>> hesitant or uneasy. I think if you make us focus with you on very
>>>>>>>> specific pieces of code then our review will be faster and your
>>>>>>>> confidence of the review will be better.
>>>>>>>>
>>>>>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>>>>>>>> <ni...@nereide.fr> wrote:
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>> I will commit on trunk after a second review of my code because i
>>>>>>>>> was
>>>>>>>>> concentrated to increase the flexibility with macro and screen but
>>>>>>>>> not
>>>>>>>>> manage correctly the VisualTheme concept.
>>>>>>>>>
>>>>>>>>> So I will take care about this, complete the documentation and
>>>>>>>>> commit
>>>>>>>>> on
>>>>>>>>> trunk.
>>>>>>>>>
>>>>>>>>> Nicolas
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>>>>>>>
>>>>>>>>> Like Michael, I also prefer to include the work into the code base
>>>>>>>>>> and
>>>>>>>>>> test it over there. It seems like you put a lot of effort into this
>>>>>>>>>> code so thank you! I like the fact that you brought all the
>>>>>>>>>> artifacts
>>>>>>>>>> into the theme along with the FTL macros. This is a good first
>>>>>>>>>> step,
>>>>>>>>>> and I believe continuing on this direction is where we need to go.
>>>>>>>>>>
>>>>>>>>>> +1 to committing into the code base and testing over there.
>>>>>>>>>>
>>>>>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>>>>>>>> <ja...@les7arts.com> wrote:
>>>>>>>>>>
>>>>>>>>>> That sounds great,
>>>>>>>>>>> Thanks Nicolas!
>>>>>>>>>>>
>>>>>>>>>>> Jacques
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>>>>>>>
>>>>>>>>>>> Hello,
>>>>>>>>>>>> I started the documentation here
>>>>>>>>>>>>
>>>>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>>>>> themes/README.md
>>>>>>>>>>>>
>>>>>>>>>>>> It's a begging, I hope improve it quickly
>>>>>>>>>>>>
>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>>>>>>>
>>>>>>>>>>>> Hello;
>>>>>>>>>>>>> To continue the common-theme subject, I haven't see negative
>>>>>>>>>>>>> return to
>>>>>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads
>>>>>>>>>>>>> on the
>>>>>>>>>>>>> same
>>>>>>>>>>>>> subject [2] and the additional theme xml definition [3], I
>>>>>>>>>>>>> suggest to
>>>>>>>>>>>>> create
>>>>>>>>>>>>> a documentation on the wiki how work the "theme engine" and
>>>>>>>>>>>>> commit the
>>>>>>>>>>>>> current git branch [4] [5] on trunk
>>>>>>>>>>>>>
>>>>>>>>>>>>> After that, the engine will be present on the trunk and we
>>>>>>>>>>>>> continue the
>>>>>>>>>>>>> work to :
>>>>>>>>>>>>> * Clean the common-theme and create a real theme
>>>>>>>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>>>>>>>> * Analyze more how organize the screen api
>>>>>>>>>>>>>
>>>>>>>>>>>>> But don't panic, before that I'm listening to all suggest or
>>>>>>>>>>>>> remarks ;)
>>>>>>>>>>>>>
>>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>>
>>>>>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>>>>>>>> [2]
>>>>>>>>>>>>>
>>>>>>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15
>>>>>>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>>>>> [3]
>>>>>>>>>>>>>
>>>>>>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38ab
>>>>>>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>>>>>>>>>> [5]
>>>>>>>>>>>>>
>>>>>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...
>>>>>>>>>>>>> nmalin:common-theme?expand=1
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>



Re: Common-theme next step

Posted by Swapnil Mane <sw...@hotwaxsystems.com>.
Thanks Jacques for your timings and suggestion.
@SuppressWarnings("serial") doesn't work for me.

========= Console Log start =========

2017-09-23 14:38:25,610 |jsse-nio-8443-exec-8
|ServiceDispatcher             |T| [[ASync service started...-
total:0.0,since last(Begin):0.0]] - 'manufacturing / executeMrp'
2017-09-23 14:38:25,630 |jsse-nio-8443-exec-8
|SequenceUtil                  |I| Got bank of sequenced IDs for
[RuntimeData]; curSeqId=10600, maxSeqId=10700, bankSize=100
2017-09-23 14:38:25,649 |jsse-nio-8443-exec-8
|UtilObject                    |E| null
java.io.NotSerializableException: org.apache.ofbiz.widget.model.
ModelTheme$ModelTemplate
        at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1184)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
~[?:1.8.0_66]
        at java.util.HashMap.internalWriteEntries(HashMap.java:1777)
~[?:1.8.0_66]
        at java.util.HashMap.writeObject(HashMap.java:1354) ~[?:1.8.0_66]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_66]
        at sun.reflect.NativeMethodAccessorImpl.invoke(
NativeMethodAccessorImpl.java:62) ~[?:1.8.0_66]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(
DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_66]
        at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
        at java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:1028)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1496)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
~[?:1.8.0_66]
        at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
~[?:1.8.0_66]
        at org.apache.ofbiz.base.util.UtilObject.getBytes(UtilObject.java:82)
[ofbiz.jar:?]
        at org.apache.ofbiz.entity.serialize.XmlSerializer.
serializeCustom(XmlSerializer.java:262) [ofbiz.jar:?]
        at org.apache.ofbiz.entity.serialize.XmlSerializer.
serializeSingle(XmlSerializer.java:257) [ofbiz.jar:?]
        at org.apache.ofbiz.entity.serialize.XmlSerializer.
serializeSingle(XmlSerializer.java:252) [ofbiz.jar:?]
        at org.apache.ofbiz.entity.serialize.XmlSerializer.
serialize(XmlSerializer.java:78) [ofbiz.jar:?]
        at org.apache.ofbiz.service.engine.GenericAsyncEngine.
runAsync(GenericAsyncEngine.java:94) [ofbiz.jar:?]
        at org.apache.ofbiz.service.engine.GenericAsyncEngine.
runAsync(GenericAsyncEngine.java:70) [ofbiz.jar:?]
        at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:715)
[ofbiz.jar:?]
        at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:780)
[ofbiz.jar:?]
        at org.apache.ofbiz.service.GenericDispatcherFactory$
GenericDispatcher.runAsync(GenericDispatcherFactory.java:181) [ofbiz.jar:?]
        at org.apache.ofbiz.service.GenericDispatcherFactory$
GenericDispatcher.runAsync(GenericDispatcherFactory.java:191) [ofbiz.jar:?]
        at org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:348)
[ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.RequestHandler.
runEvent(RequestHandler.java:730) [ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.RequestHandler.
doRequest(RequestHandler.java:454) [ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
[ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
[ofbiz.jar:?]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
[javax.servlet-api-3.1.0.jar:3.1.0]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
[javax.servlet-api-3.1.0.jar:3.1.0]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
[tomcat-embed-websocket-8.0.39.jar:8.0.39]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.ofbiz.webapp.control.ContextFilter.
doFilter(ContextFilter.java:196) [ofbiz.jar:?]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.ofbiz.webapp.control.ControlFilter.
doFilter(ControlFilter.java:157) [ofbiz.jar:?]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at org.apache.coyote.AbstractProcessorLight.process(
AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
        at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[?:1.8.0_66]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[?:1.8.0_66]
        at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
[tomcat-util-8.5.16.jar:8.5.16]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
2017-09-23 14:38:25,653 |jsse-nio-8443-exec-8
|ServiceDispatcher             |T| [[ASync service failed...-
total:0.043,since last(ASync service sta...):0.043]] - 'manufacturing /
executeMrp'
2017-09-23 14:38:25,653 |jsse-nio-8443-exec-8
|ServiceDispatcher             |E| Service [executeMrp] threw an unexpected
exception/error
org.apache.ofbiz.service.GenericServiceException: Problem serializing
service attributes (Unable to serialize object; null byte array returned)
        at org.apache.ofbiz.service.engine.GenericAsyncEngine.
runAsync(GenericAsyncEngine.java:124) ~[ofbiz.jar:?]
        at org.apache.ofbiz.service.engine.GenericAsyncEngine.
runAsync(GenericAsyncEngine.java:70) ~[ofbiz.jar:?]
        at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:715)
[ofbiz.jar:?]
        at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:780)
[ofbiz.jar:?]
        at org.apache.ofbiz.service.GenericDispatcherFactory$
GenericDispatcher.runAsync(GenericDispatcherFactory.java:181) [ofbiz.jar:?]
        at org.apache.ofbiz.service.GenericDispatcherFactory$
GenericDispatcher.runAsync(GenericDispatcherFactory.java:191) [ofbiz.jar:?]
        at org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:348)
[ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.RequestHandler.
runEvent(RequestHandler.java:730) [ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.RequestHandler.
doRequest(RequestHandler.java:454) [ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
[ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
[ofbiz.jar:?]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
[javax.servlet-api-3.1.0.jar:3.1.0]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
[javax.servlet-api-3.1.0.jar:3.1.0]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
[tomcat-embed-websocket-8.0.39.jar:8.0.39]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.ofbiz.webapp.control.ContextFilter.
doFilter(ContextFilter.java:196) [ofbiz.jar:?]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.ofbiz.webapp.control.ControlFilter.
doFilter(ControlFilter.java:157) [ofbiz.jar:?]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at org.apache.coyote.AbstractProcessorLight.process(
AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
        at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[?:1.8.0_66]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[?:1.8.0_66]
        at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
[tomcat-util-8.5.16.jar:8.5.16]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Unable to
serialize object; null byte array returned
        at org.apache.ofbiz.entity.serialize.XmlSerializer.
serializeCustom(XmlSerializer.java:264) ~[ofbiz.jar:?]
        at org.apache.ofbiz.entity.serialize.XmlSerializer.
serializeSingle(XmlSerializer.java:257) ~[ofbiz.jar:?]
        at org.apache.ofbiz.entity.serialize.XmlSerializer.
serializeSingle(XmlSerializer.java:252) ~[ofbiz.jar:?]
        at org.apache.ofbiz.entity.serialize.XmlSerializer.
serialize(XmlSerializer.java:78) ~[ofbiz.jar:?]
        at org.apache.ofbiz.service.engine.GenericAsyncEngine.
runAsync(GenericAsyncEngine.java:94) ~[ofbiz.jar:?]
        ... 40 more
2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
|TransactionUtil               |I| Transaction rolled back
2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
|TransactionUtil               |W| Not committing transaction, status is No
Transaction (6)
2017-09-23 14:38:25,655 |jsse-nio-8443-exec-8
|ServiceEventHandler           |E| Service invocation error
org.apache.ofbiz.service.GenericServiceException: Problem serializing
service attributes (Unable to serialize object; null byte array returned)
        at org.apache.ofbiz.service.engine.GenericAsyncEngine.
runAsync(GenericAsyncEngine.java:124) ~[ofbiz.jar:?]
        at org.apache.ofbiz.service.engine.GenericAsyncEngine.
runAsync(GenericAsyncEngine.java:70) ~[ofbiz.jar:?]
        at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:715)
~[ofbiz.jar:?]
        at org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:780)
~[ofbiz.jar:?]
        at org.apache.ofbiz.service.GenericDispatcherFactory$
GenericDispatcher.runAsync(GenericDispatcherFactory.java:181) ~[ofbiz.jar:?]
        at org.apache.ofbiz.service.GenericDispatcherFactory$
GenericDispatcher.runAsync(GenericDispatcherFactory.java:191) ~[ofbiz.jar:?]
        at org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:348)
[ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.RequestHandler.
runEvent(RequestHandler.java:730) [ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.RequestHandler.
doRequest(RequestHandler.java:454) [ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
[ofbiz.jar:?]
        at org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
[ofbiz.jar:?]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
[javax.servlet-api-3.1.0.jar:3.1.0]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
[javax.servlet-api-3.1.0.jar:3.1.0]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:231) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
[tomcat-embed-websocket-8.0.39.jar:8.0.39]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.ofbiz.webapp.control.ContextFilter.
doFilter(ContextFilter.java:196) [ofbiz.jar:?]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.ofbiz.webapp.control.ControlFilter.
doFilter(ControlFilter.java:157) [ofbiz.jar:?]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(
ApplicationFilterChain.java:193) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(
ApplicationFilterChain.java:166) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.valves.AbstractAccessLogValve.invoke(
AbstractAccessLogValve.java:624) [tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at org.apache.coyote.AbstractProcessorLight.process(
AbstractProcessorLight.java:66) [tomcat-coyote-8.5.16.jar:8.5.16]
        at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[?:1.8.0_66]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[?:1.8.0_66]
        at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
[tomcat-util-8.5.16.jar:8.5.16]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Unable to
serialize object; null byte array returned
        at org.apache.ofbiz.entity.serialize.XmlSerializer.
serializeCustom(XmlSerializer.java:264) ~[ofbiz.jar:?]
        at org.apache.ofbiz.entity.serialize.XmlSerializer.
serializeSingle(XmlSerializer.java:257) ~[ofbiz.jar:?]
        at org.apache.ofbiz.entity.serialize.XmlSerializer.
serializeSingle(XmlSerializer.java:252) ~[ofbiz.jar:?]
        at org.apache.ofbiz.entity.serialize.XmlSerializer.
serialize(XmlSerializer.java:78) ~[ofbiz.jar:?]
        at org.apache.ofbiz.service.engine.GenericAsyncEngine.
runAsync(GenericAsyncEngine.java:94) ~[ofbiz.jar:?]
        ... 40 more

========= Console Log end =========


- Best Regards,
Swapnil

On Sat, Sep 23, 2017 at 1:33 PM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:

> Hi Swapnil,
>
> Did you try?
>
> @SuppressWarnings("serial")
> public final class VisualTheme implements Serializable {
>
> Jacques
>
>
>
> Le 23/09/2017 à 08:29, Swapnil Mane a écrit :
>
>> Thank you Nicolas and team for this great work.
>> Highly appreciated!!
>>
>> I am facing some Exception related to VisualTheme while running the MRP.
>> https://demo-trunk.ofbiz.apache.org/manufacturing/control/RunMrp
>>
>> I guess it is related to theme work we have done, please let me know, if I
>> am missing anything.
>>
>>
>> ========= Console Log start =========
>> [[ASync service failed...- total:0.012,since last(ASync service
>> sta...):0.012]] - 'manufacturing / executeMrp'
>> 2017-09-23 11:44:24,458 |jsse-nio-8443-exec-6
>> |ServiceDispatcher             |E| Service [executeMrp] threw an
>> unexpected
>> exception/error
>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>> service attributes (Cannot serialize object of class
>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>          at
>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>> GenericAsyncEngine.java:124)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>> GenericAsyncEngine.java:70)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>> ispatcher.java:715)
>> [ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>> ispatcher.java:780)
>> [ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>> patcher.runAsync(GenericDispatcherFactory.java:181)
>> [ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>> patcher.runAsync(GenericDispatcherFactory.java:191)
>> [ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>> viceEventHandler.java:348)
>> [ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(Requ
>> estHandler.java:730)
>> [ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(Req
>> uestHandler.java:454)
>> [ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>> Servlet.java:212)
>> [ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>> lServlet.java:87)
>> [ofbiz.jar:?]
>>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(ApplicationFilterChain.java:231)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>> licationFilterChain.java:166)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(ApplicationFilterChain.java:193)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>> licationFilterChain.java:166)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(Conte
>> xtFilter.java:196)
>> [ofbiz.jar:?]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(ApplicationFilterChain.java:193)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>> licationFilterChain.java:166)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(Contr
>> olFilter.java:157)
>> [ofbiz.jar:?]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(ApplicationFilterChain.java:193)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>> licationFilterChain.java:166)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>> dWrapperValve.java:198)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.StandardContextValve.invoke(Standar
>> dContextValve.java:96)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>> uthenticatorBase.java:478)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>> stValve.java:140)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>> rtValve.java:80)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.StandardEngineValve.invoke(Standard
>> EngineValve.java:87)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.valves.AbstractAccessLogValve.invoke(Abs
>> tractAccessLogValve.java:624)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>> apter.java:342)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.coyote.http11.Http11Processor.service(Http11Proce
>> ssor.java:799)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at
>> org.apache.coyote.AbstractProcessorLight.process(AbstractPro
>> cessorLight.java:66)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at
>> org.apache.coyote.AbstractProtocol$ConnectionHandler.process
>> (AbstractProtocol.java:868)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at
>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>> (NioEndpoint.java:1455)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at
>> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>> cessorBase.java:49)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at
>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>> Executor.java:1142)
>> [?:1.8.0_66]
>>          at
>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>> lExecutor.java:617)
>> [?:1.8.0_66]
>>          at
>> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.r
>> un(TaskThread.java:61)
>> [tomcat-util-8.5.16.jar:8.5.16]
>>          at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Cannot
>> serialize object of class org.apache.ofbiz.widget.renderer.VisualTheme
>>          at
>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCus
>> tom(XmlSerializer.java:273)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>> gle(XmlSerializer.java:257)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>> gle(XmlSerializer.java:252)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(Xm
>> lSerializer.java:78)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>> GenericAsyncEngine.java:94)
>> ~[ofbiz.jar:?]
>>          ... 40 more
>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>> |TransactionUtil               |I| Transaction rolled back
>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>> |TransactionUtil               |W| Not committing transaction, status is
>> No
>> Transaction (6)
>> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
>> |ServiceEventHandler           |E| Service invocation error
>> org.apache.ofbiz.service.GenericServiceException: Problem serializing
>> service attributes (Cannot serialize object of class
>> org.apache.ofbiz.widget.renderer.VisualTheme)
>>          at
>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>> GenericAsyncEngine.java:124)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>> GenericAsyncEngine.java:70)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>> ispatcher.java:715)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceD
>> ispatcher.java:780)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>> patcher.runAsync(GenericDispatcherFactory.java:181)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDis
>> patcher.runAsync(GenericDispatcherFactory.java:191)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(Ser
>> viceEventHandler.java:348)
>> [ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(Requ
>> estHandler.java:730)
>> [ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(Req
>> uestHandler.java:454)
>> [ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.webapp.control.ControlServlet.doGet(Control
>> Servlet.java:212)
>> [ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.webapp.control.ControlServlet.doPost(Contro
>> lServlet.java:87)
>> [ofbiz.jar:?]
>>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
>> [javax.servlet-api-3.1.0.jar:3.1.0]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(ApplicationFilterChain.java:231)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>> licationFilterChain.java:166)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(ApplicationFilterChain.java:193)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>> licationFilterChain.java:166)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(Conte
>> xtFilter.java:196)
>> [ofbiz.jar:?]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(ApplicationFilterChain.java:193)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>> licationFilterChain.java:166)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(Contr
>> olFilter.java:157)
>> [ofbiz.jar:?]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.internalDoFi
>> lter(ApplicationFilterChain.java:193)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.ApplicationFilterChain.doFilter(App
>> licationFilterChain.java:166)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.StandardWrapperValve.invoke(Standar
>> dWrapperValve.java:198)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.StandardContextValve.invoke(Standar
>> dContextValve.java:96)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.authenticator.AuthenticatorBase.invoke(A
>> uthenticatorBase.java:478)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.StandardHostValve.invoke(StandardHo
>> stValve.java:140)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorRepo
>> rtValve.java:80)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.core.StandardEngineValve.invoke(Standard
>> EngineValve.java:87)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.valves.AbstractAccessLogValve.invoke(Abs
>> tractAccessLogValve.java:624)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAd
>> apter.java:342)
>> [tomcat-catalina-8.5.16.jar:8.5.16]
>>          at
>> org.apache.coyote.http11.Http11Processor.service(Http11Proce
>> ssor.java:799)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at
>> org.apache.coyote.AbstractProcessorLight.process(AbstractPro
>> cessorLight.java:66)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at
>> org.apache.coyote.AbstractProtocol$ConnectionHandler.process
>> (AbstractProtocol.java:868)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at
>> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun
>> (NioEndpoint.java:1455)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at
>> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketPro
>> cessorBase.java:49)
>> [tomcat-coyote-8.5.16.jar:8.5.16]
>>          at
>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>> Executor.java:1142)
>> [?:1.8.0_66]
>>          at
>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>> lExecutor.java:617)
>> [?:1.8.0_66]
>>          at
>> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.r
>> un(TaskThread.java:61)
>> [tomcat-util-8.5.16.jar:8.5.16]
>>          at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
>> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Cannot
>> serialize object of class org.apache.ofbiz.widget.renderer.VisualTheme
>>          at
>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCus
>> tom(XmlSerializer.java:273)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>> gle(XmlSerializer.java:257)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSin
>> gle(XmlSerializer.java:252)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(Xm
>> lSerializer.java:78)
>> ~[ofbiz.jar:?]
>>          at
>> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(
>> GenericAsyncEngine.java:94)
>> ~[ofbiz.jar:?]
>>          ... 40 more
>> 2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
>> |RequestHandler                |E| Request runMrpGo caused an error with
>> the following message: Error calling event:
>> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation
>> error (Cannot serialize object of class
>> org.apache.ofbiz.widget.renderer.VisualTheme)
>> 2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
>> |RequestHandler                |I| Rendering View [MrpExecution].  Hidden
>> sessionId by default.
>> 2017-09-23 11:44:24,465 |jsse-nio-8443-exec-6
>> |ServiceDispatcher             |T| Sync service
>> [manufacturing/getUserPreferenceGroup] finished in [1] milliseconds
>>
>> ========= Console log end =========
>>
>>
>> - Best Regards,
>> Swapnil M Mane
>>
>>
>> On Sun, Sep 10, 2017 at 4:21 PM, Michael Brohl <mi...@ecomify.de>
>> wrote:
>>
>> Thank you, Nicolas, for the great effort you put on this.
>>>
>>> I'll hope to soon reactivate my work on the bootstrap theme, using the
>>> new
>>> structure, and see how it will work out.
>>>
>>> I'll have some more qualified feedback (and propably questions ;-) )
>>> then...
>>>
>>> Thanks,
>>>
>>> Michael
>>>
>>>
>>> Am 25.08.17 um 12:15 schrieb Nicolas Malin:
>>>
>>> I loaded all my local :)
>>>
>>>> Le 25/08/2017 à 00:03, Nicolas Malin a écrit :
>>>>
>>>> I started to load common-theme on trunk, at this time to resume :
>>>>>
>>>>> r1806075, r1806076 : I loaded engine and documentation
>>>>> r1806084 : I moved all images folder to common-theme
>>>>> r1806091, r1806093: I moved all ftl template from common to
>>>>> common-theme
>>>>> and all macro ftl libraries.
>>>>>
>>>>> 1806134 : load VisualTheme and ModelTheme on different session and
>>>> context
>>>> 1806137, 180614[0-9] : Migrate themes, common screens, handler to
>>>> exploit
>>>> values from the theme definition
>>>> 1806150 : migrate all other screen and scripts  to exploit values from
>>>> the theme definition
>>>> 180615 : improve error message and announce the commit end :)
>>>>
>>>> Cheers,
>>>> Nicolas
>>>>
>>>> I hope to break nothing at this time.
>>>>> The next steps will load the dynamic theme load on session
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Nicolas
>>>>>
>>>>>
>>>>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
>>>>>
>>>>> Hi Taher,
>>>>>>
>>>>>> If you have few time to have a look on these three class :
>>>>>>
>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>> model/ModelTheme.java
>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>> model/ThemeFactory.java
>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>>> renderer/VisualTheme.java
>>>>>>
>>>>>> ModelTheme is java class to load all Theme definition who interact
>>>>>> with
>>>>>> the system
>>>>>>
>>>>>> VisualTheme is java class regards the VisualTheme entity who interact
>>>>>> with the user to exploit the modelTheme
>>>>>>
>>>>>> ThemeFactory is the factory to create both.
>>>>>>
>>>>>> I prepare my commits, but I need to separate properly each code
>>>>>> modification to help other learn the work.
>>>>>>
>>>>>> Cheers,
>>>>>> Nicolas
>>>>>>
>>>>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>>>>>>
>>>>>> Hi Nicolas,
>>>>>>>
>>>>>>> If it helps you, I suggest to isolate files / code where you are not
>>>>>>> very comfortable and put them in a separate patch (not the full
>>>>>>> patch)
>>>>>>> with an explanation of what you've done and where you feel a little
>>>>>>> hesitant or uneasy. I think if you make us focus with you on very
>>>>>>> specific pieces of code then our review will be faster and your
>>>>>>> confidence of the review will be better.
>>>>>>>
>>>>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>>>>>>> <ni...@nereide.fr> wrote:
>>>>>>>
>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> I will commit on trunk after a second review of my code because i
>>>>>>>> was
>>>>>>>> concentrated to increase the flexibility with macro and screen but
>>>>>>>> not
>>>>>>>> manage correctly the VisualTheme concept.
>>>>>>>>
>>>>>>>> So I will take care about this, complete the documentation and
>>>>>>>> commit
>>>>>>>> on
>>>>>>>> trunk.
>>>>>>>>
>>>>>>>> Nicolas
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>>>>>>
>>>>>>>> Like Michael, I also prefer to include the work into the code base
>>>>>>>>> and
>>>>>>>>> test it over there. It seems like you put a lot of effort into this
>>>>>>>>> code so thank you! I like the fact that you brought all the
>>>>>>>>> artifacts
>>>>>>>>> into the theme along with the FTL macros. This is a good first
>>>>>>>>> step,
>>>>>>>>> and I believe continuing on this direction is where we need to go.
>>>>>>>>>
>>>>>>>>> +1 to committing into the code base and testing over there.
>>>>>>>>>
>>>>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>>>>>>> <ja...@les7arts.com> wrote:
>>>>>>>>>
>>>>>>>>> That sounds great,
>>>>>>>>>>
>>>>>>>>>> Thanks Nicolas!
>>>>>>>>>>
>>>>>>>>>> Jacques
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>>>>>>
>>>>>>>>>> Hello,
>>>>>>>>>>>
>>>>>>>>>>> I started the documentation here
>>>>>>>>>>>
>>>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>>>> themes/README.md
>>>>>>>>>>>
>>>>>>>>>>> It's a begging, I hope improve it quickly
>>>>>>>>>>>
>>>>>>>>>>> Nicolas
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>>>>>>
>>>>>>>>>>> Hello;
>>>>>>>>>>>>
>>>>>>>>>>>> To continue the common-theme subject, I haven't see negative
>>>>>>>>>>>> return to
>>>>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads
>>>>>>>>>>>> on the
>>>>>>>>>>>> same
>>>>>>>>>>>> subject [2] and the additional theme xml definition [3], I
>>>>>>>>>>>> suggest to
>>>>>>>>>>>> create
>>>>>>>>>>>> a documentation on the wiki how work the "theme engine" and
>>>>>>>>>>>> commit the
>>>>>>>>>>>> current git branch [4] [5] on trunk
>>>>>>>>>>>>
>>>>>>>>>>>> After that, the engine will be present on the trunk and we
>>>>>>>>>>>> continue the
>>>>>>>>>>>> work to :
>>>>>>>>>>>> * Clean the common-theme and create a real theme
>>>>>>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>>>>>>> * Analyze more how organize the screen api
>>>>>>>>>>>>
>>>>>>>>>>>> But don't panic, before that I'm listening to all suggest or
>>>>>>>>>>>> remarks ;)
>>>>>>>>>>>>
>>>>>>>>>>>> Nicolas
>>>>>>>>>>>>
>>>>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>>>>>>> [2]
>>>>>>>>>>>>
>>>>>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15
>>>>>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>>>> [3]
>>>>>>>>>>>>
>>>>>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38ab
>>>>>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>>>>>>>>> [5]
>>>>>>>>>>>>
>>>>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...
>>>>>>>>>>>> nmalin:common-theme?expand=1
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>
>>>>>
>>>
>

Re: Common-theme next step

Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Swapnil,

Did you try?

@SuppressWarnings("serial")
public final class VisualTheme implements Serializable {

Jacques


Le 23/09/2017 à 08:29, Swapnil Mane a écrit :
> Thank you Nicolas and team for this great work.
> Highly appreciated!!
>
> I am facing some Exception related to VisualTheme while running the MRP.
> https://demo-trunk.ofbiz.apache.org/manufacturing/control/RunMrp
>
> I guess it is related to theme work we have done, please let me know, if I
> am missing anything.
>
>
> ========= Console Log start =========
> [[ASync service failed...- total:0.012,since last(ASync service
> sta...):0.012]] - 'manufacturing / executeMrp'
> 2017-09-23 11:44:24,458 |jsse-nio-8443-exec-6
> |ServiceDispatcher             |E| Service [executeMrp] threw an unexpected
> exception/error
> org.apache.ofbiz.service.GenericServiceException: Problem serializing
> service attributes (Cannot serialize object of class
> org.apache.ofbiz.widget.renderer.VisualTheme)
>          at
> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:124)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:70)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:715)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:780)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:348)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:730)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:454)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
> [ofbiz.jar:?]
>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
> [javax.servlet-api-3.1.0.jar:3.1.0]
>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> [javax.servlet-api-3.1.0.jar:3.1.0]
>          at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>          at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:196)
> [ofbiz.jar:?]
>          at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:157)
> [ofbiz.jar:?]
>          at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:624)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [?:1.8.0_66]
>          at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [?:1.8.0_66]
>          at
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> [tomcat-util-8.5.16.jar:8.5.16]
>          at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Cannot
> serialize object of class org.apache.ofbiz.widget.renderer.VisualTheme
>          at
> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCustom(XmlSerializer.java:273)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSingle(XmlSerializer.java:257)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSingle(XmlSerializer.java:252)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(XmlSerializer.java:78)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:94)
> ~[ofbiz.jar:?]
>          ... 40 more
> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
> |TransactionUtil               |I| Transaction rolled back
> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
> |TransactionUtil               |W| Not committing transaction, status is No
> Transaction (6)
> 2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
> |ServiceEventHandler           |E| Service invocation error
> org.apache.ofbiz.service.GenericServiceException: Problem serializing
> service attributes (Cannot serialize object of class
> org.apache.ofbiz.widget.renderer.VisualTheme)
>          at
> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:124)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:70)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:715)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:780)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:348)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:730)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:454)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
>          at
> org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
> [ofbiz.jar:?]
>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
> [javax.servlet-api-3.1.0.jar:3.1.0]
>          at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> [javax.servlet-api-3.1.0.jar:3.1.0]
>          at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
> [tomcat-embed-websocket-8.0.39.jar:8.0.39]
>          at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:196)
> [ofbiz.jar:?]
>          at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:157)
> [ofbiz.jar:?]
>          at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:624)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
> [tomcat-catalina-8.5.16.jar:8.5.16]
>          at
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
> [tomcat-coyote-8.5.16.jar:8.5.16]
>          at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [?:1.8.0_66]
>          at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [?:1.8.0_66]
>          at
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> [tomcat-util-8.5.16.jar:8.5.16]
>          at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
> Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Cannot
> serialize object of class org.apache.ofbiz.widget.renderer.VisualTheme
>          at
> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCustom(XmlSerializer.java:273)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSingle(XmlSerializer.java:257)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSingle(XmlSerializer.java:252)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(XmlSerializer.java:78)
> ~[ofbiz.jar:?]
>          at
> org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:94)
> ~[ofbiz.jar:?]
>          ... 40 more
> 2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
> |RequestHandler                |E| Request runMrpGo caused an error with
> the following message: Error calling event:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation
> error (Cannot serialize object of class
> org.apache.ofbiz.widget.renderer.VisualTheme)
> 2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
> |RequestHandler                |I| Rendering View [MrpExecution].  Hidden
> sessionId by default.
> 2017-09-23 11:44:24,465 |jsse-nio-8443-exec-6
> |ServiceDispatcher             |T| Sync service
> [manufacturing/getUserPreferenceGroup] finished in [1] milliseconds
>
> ========= Console log end =========
>
>
> - Best Regards,
> Swapnil M Mane
>
>
> On Sun, Sep 10, 2017 at 4:21 PM, Michael Brohl <mi...@ecomify.de>
> wrote:
>
>> Thank you, Nicolas, for the great effort you put on this.
>>
>> I'll hope to soon reactivate my work on the bootstrap theme, using the new
>> structure, and see how it will work out.
>>
>> I'll have some more qualified feedback (and propably questions ;-) )
>> then...
>>
>> Thanks,
>>
>> Michael
>>
>>
>> Am 25.08.17 um 12:15 schrieb Nicolas Malin:
>>
>> I loaded all my local :)
>>> Le 25/08/2017 à 00:03, Nicolas Malin a écrit :
>>>
>>>> I started to load common-theme on trunk, at this time to resume :
>>>>
>>>> r1806075, r1806076 : I loaded engine and documentation
>>>> r1806084 : I moved all images folder to common-theme
>>>> r1806091, r1806093: I moved all ftl template from common to common-theme
>>>> and all macro ftl libraries.
>>>>
>>> 1806134 : load VisualTheme and ModelTheme on different session and context
>>> 1806137, 180614[0-9] : Migrate themes, common screens, handler to exploit
>>> values from the theme definition
>>> 1806150 : migrate all other screen and scripts  to exploit values from
>>> the theme definition
>>> 180615 : improve error message and announce the commit end :)
>>>
>>> Cheers,
>>> Nicolas
>>>
>>>> I hope to break nothing at this time.
>>>> The next steps will load the dynamic theme load on session
>>>>
>>>> Cheers,
>>>>
>>>> Nicolas
>>>>
>>>>
>>>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
>>>>
>>>>> Hi Taher,
>>>>>
>>>>> If you have few time to have a look on these three class :
>>>>>
>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>> model/ModelTheme.java
>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>> model/ThemeFactory.java
>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>>> renderer/VisualTheme.java
>>>>>
>>>>> ModelTheme is java class to load all Theme definition who interact with
>>>>> the system
>>>>>
>>>>> VisualTheme is java class regards the VisualTheme entity who interact
>>>>> with the user to exploit the modelTheme
>>>>>
>>>>> ThemeFactory is the factory to create both.
>>>>>
>>>>> I prepare my commits, but I need to separate properly each code
>>>>> modification to help other learn the work.
>>>>>
>>>>> Cheers,
>>>>> Nicolas
>>>>>
>>>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>>>>>
>>>>>> Hi Nicolas,
>>>>>>
>>>>>> If it helps you, I suggest to isolate files / code where you are not
>>>>>> very comfortable and put them in a separate patch (not the full patch)
>>>>>> with an explanation of what you've done and where you feel a little
>>>>>> hesitant or uneasy. I think if you make us focus with you on very
>>>>>> specific pieces of code then our review will be faster and your
>>>>>> confidence of the review will be better.
>>>>>>
>>>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>>>>>> <ni...@nereide.fr> wrote:
>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> I will commit on trunk after a second review of my code because i was
>>>>>>> concentrated to increase the flexibility with macro and screen but not
>>>>>>> manage correctly the VisualTheme concept.
>>>>>>>
>>>>>>> So I will take care about this, complete the documentation and commit
>>>>>>> on
>>>>>>> trunk.
>>>>>>>
>>>>>>> Nicolas
>>>>>>>
>>>>>>>
>>>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>>>>>
>>>>>>>> Like Michael, I also prefer to include the work into the code base
>>>>>>>> and
>>>>>>>> test it over there. It seems like you put a lot of effort into this
>>>>>>>> code so thank you! I like the fact that you brought all the artifacts
>>>>>>>> into the theme along with the FTL macros. This is a good first step,
>>>>>>>> and I believe continuing on this direction is where we need to go.
>>>>>>>>
>>>>>>>> +1 to committing into the code base and testing over there.
>>>>>>>>
>>>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>>>>>> <ja...@les7arts.com> wrote:
>>>>>>>>
>>>>>>>>> That sounds great,
>>>>>>>>>
>>>>>>>>> Thanks Nicolas!
>>>>>>>>>
>>>>>>>>> Jacques
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>>>>>
>>>>>>>>>> Hello,
>>>>>>>>>>
>>>>>>>>>> I started the documentation here
>>>>>>>>>>
>>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>>> themes/README.md
>>>>>>>>>>
>>>>>>>>>> It's a begging, I hope improve it quickly
>>>>>>>>>>
>>>>>>>>>> Nicolas
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>>>>>
>>>>>>>>>>> Hello;
>>>>>>>>>>>
>>>>>>>>>>> To continue the common-theme subject, I haven't see negative
>>>>>>>>>>> return to
>>>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads
>>>>>>>>>>> on the
>>>>>>>>>>> same
>>>>>>>>>>> subject [2] and the additional theme xml definition [3], I
>>>>>>>>>>> suggest to
>>>>>>>>>>> create
>>>>>>>>>>> a documentation on the wiki how work the "theme engine" and
>>>>>>>>>>> commit the
>>>>>>>>>>> current git branch [4] [5] on trunk
>>>>>>>>>>>
>>>>>>>>>>> After that, the engine will be present on the trunk and we
>>>>>>>>>>> continue the
>>>>>>>>>>> work to :
>>>>>>>>>>> * Clean the common-theme and create a real theme
>>>>>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>>>>>> * Analyze more how organize the screen api
>>>>>>>>>>>
>>>>>>>>>>> But don't panic, before that I'm listening to all suggest or
>>>>>>>>>>> remarks ;)
>>>>>>>>>>>
>>>>>>>>>>> Nicolas
>>>>>>>>>>>
>>>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>>>>>> [2]
>>>>>>>>>>>
>>>>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15
>>>>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>>> [3]
>>>>>>>>>>>
>>>>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38ab
>>>>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>>>>>>>> [5]
>>>>>>>>>>>
>>>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...
>>>>>>>>>>> nmalin:common-theme?expand=1
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>
>>>>
>>


Re: Common-theme next step

Posted by Swapnil Mane <sw...@hotwaxsystems.com>.
Thank you Nicolas and team for this great work.
Highly appreciated!!

I am facing some Exception related to VisualTheme while running the MRP.
https://demo-trunk.ofbiz.apache.org/manufacturing/control/RunMrp

I guess it is related to theme work we have done, please let me know, if I
am missing anything.


========= Console Log start =========
[[ASync service failed...- total:0.012,since last(ASync service
sta...):0.012]] - 'manufacturing / executeMrp'
2017-09-23 11:44:24,458 |jsse-nio-8443-exec-6
|ServiceDispatcher             |E| Service [executeMrp] threw an unexpected
exception/error
org.apache.ofbiz.service.GenericServiceException: Problem serializing
service attributes (Cannot serialize object of class
org.apache.ofbiz.widget.renderer.VisualTheme)
        at
org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:124)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:70)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:715)
[ofbiz.jar:?]
        at
org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:780)
[ofbiz.jar:?]
        at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
[ofbiz.jar:?]
        at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
[ofbiz.jar:?]
        at
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:348)
[ofbiz.jar:?]
        at
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:730)
[ofbiz.jar:?]
        at
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:454)
[ofbiz.jar:?]
        at
org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
[ofbiz.jar:?]
        at
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
[ofbiz.jar:?]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
[javax.servlet-api-3.1.0.jar:3.1.0]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
[javax.servlet-api-3.1.0.jar:3.1.0]
        at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
[tomcat-embed-websocket-8.0.39.jar:8.0.39]
        at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:196)
[ofbiz.jar:?]
        at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:157)
[ofbiz.jar:?]
        at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:624)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[?:1.8.0_66]
        at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[?:1.8.0_66]
        at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
[tomcat-util-8.5.16.jar:8.5.16]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Cannot
serialize object of class org.apache.ofbiz.widget.renderer.VisualTheme
        at
org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCustom(XmlSerializer.java:273)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSingle(XmlSerializer.java:257)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSingle(XmlSerializer.java:252)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(XmlSerializer.java:78)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:94)
~[ofbiz.jar:?]
        ... 40 more
2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
|TransactionUtil               |I| Transaction rolled back
2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
|TransactionUtil               |W| Not committing transaction, status is No
Transaction (6)
2017-09-23 11:44:24,460 |jsse-nio-8443-exec-6
|ServiceEventHandler           |E| Service invocation error
org.apache.ofbiz.service.GenericServiceException: Problem serializing
service attributes (Cannot serialize object of class
org.apache.ofbiz.widget.renderer.VisualTheme)
        at
org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:124)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:70)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:715)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:780)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:348)
[ofbiz.jar:?]
        at
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:730)
[ofbiz.jar:?]
        at
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:454)
[ofbiz.jar:?]
        at
org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
[ofbiz.jar:?]
        at
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
[ofbiz.jar:?]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
[javax.servlet-api-3.1.0.jar:3.1.0]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
[javax.servlet-api-3.1.0.jar:3.1.0]
        at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
[tomcat-embed-websocket-8.0.39.jar:8.0.39]
        at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:196)
[ofbiz.jar:?]
        at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:157)
[ofbiz.jar:?]
        at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:624)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
[tomcat-catalina-8.5.16.jar:8.5.16]
        at
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:799)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1455)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
[tomcat-coyote-8.5.16.jar:8.5.16]
        at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[?:1.8.0_66]
        at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[?:1.8.0_66]
        at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
[tomcat-util-8.5.16.jar:8.5.16]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
Caused by: org.apache.ofbiz.entity.serialize.SerializeException: Cannot
serialize object of class org.apache.ofbiz.widget.renderer.VisualTheme
        at
org.apache.ofbiz.entity.serialize.XmlSerializer.serializeCustom(XmlSerializer.java:273)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSingle(XmlSerializer.java:257)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.entity.serialize.XmlSerializer.serializeSingle(XmlSerializer.java:252)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.entity.serialize.XmlSerializer.serialize(XmlSerializer.java:78)
~[ofbiz.jar:?]
        at
org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:94)
~[ofbiz.jar:?]
        ... 40 more
2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
|RequestHandler                |E| Request runMrpGo caused an error with
the following message: Error calling event:
org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation
error (Cannot serialize object of class
org.apache.ofbiz.widget.renderer.VisualTheme)
2017-09-23 11:44:24,463 |jsse-nio-8443-exec-6
|RequestHandler                |I| Rendering View [MrpExecution].  Hidden
sessionId by default.
2017-09-23 11:44:24,465 |jsse-nio-8443-exec-6
|ServiceDispatcher             |T| Sync service
[manufacturing/getUserPreferenceGroup] finished in [1] milliseconds

========= Console log end =========


- Best Regards,
Swapnil M Mane


On Sun, Sep 10, 2017 at 4:21 PM, Michael Brohl <mi...@ecomify.de>
wrote:

> Thank you, Nicolas, for the great effort you put on this.
>
> I'll hope to soon reactivate my work on the bootstrap theme, using the new
> structure, and see how it will work out.
>
> I'll have some more qualified feedback (and propably questions ;-) )
> then...
>
> Thanks,
>
> Michael
>
>
> Am 25.08.17 um 12:15 schrieb Nicolas Malin:
>
> I loaded all my local :)
>>
>> Le 25/08/2017 à 00:03, Nicolas Malin a écrit :
>>
>>> I started to load common-theme on trunk, at this time to resume :
>>>
>>> r1806075, r1806076 : I loaded engine and documentation
>>> r1806084 : I moved all images folder to common-theme
>>> r1806091, r1806093: I moved all ftl template from common to common-theme
>>> and all macro ftl libraries.
>>>
>> 1806134 : load VisualTheme and ModelTheme on different session and context
>> 1806137, 180614[0-9] : Migrate themes, common screens, handler to exploit
>> values from the theme definition
>> 1806150 : migrate all other screen and scripts  to exploit values from
>> the theme definition
>> 180615 : improve error message and announce the commit end :)
>>
>> Cheers,
>> Nicolas
>>
>>>
>>> I hope to break nothing at this time.
>>> The next steps will load the dynamic theme load on session
>>>
>>> Cheers,
>>>
>>> Nicolas
>>>
>>>
>>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
>>>
>>>> Hi Taher,
>>>>
>>>> If you have few time to have a look on these three class :
>>>>
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> model/ModelTheme.java
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> model/ThemeFactory.java
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>> framework/widget/src/main/java/org/apache/ofbiz/widget/
>>>> renderer/VisualTheme.java
>>>>
>>>> ModelTheme is java class to load all Theme definition who interact with
>>>> the system
>>>>
>>>> VisualTheme is java class regards the VisualTheme entity who interact
>>>> with the user to exploit the modelTheme
>>>>
>>>> ThemeFactory is the factory to create both.
>>>>
>>>> I prepare my commits, but I need to separate properly each code
>>>> modification to help other learn the work.
>>>>
>>>> Cheers,
>>>> Nicolas
>>>>
>>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>>>>
>>>>> Hi Nicolas,
>>>>>
>>>>> If it helps you, I suggest to isolate files / code where you are not
>>>>> very comfortable and put them in a separate patch (not the full patch)
>>>>> with an explanation of what you've done and where you feel a little
>>>>> hesitant or uneasy. I think if you make us focus with you on very
>>>>> specific pieces of code then our review will be faster and your
>>>>> confidence of the review will be better.
>>>>>
>>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>>>>> <ni...@nereide.fr> wrote:
>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> I will commit on trunk after a second review of my code because i was
>>>>>> concentrated to increase the flexibility with macro and screen but not
>>>>>> manage correctly the VisualTheme concept.
>>>>>>
>>>>>> So I will take care about this, complete the documentation and commit
>>>>>> on
>>>>>> trunk.
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>>
>>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>>>>
>>>>>>> Like Michael, I also prefer to include the work into the code base
>>>>>>> and
>>>>>>> test it over there. It seems like you put a lot of effort into this
>>>>>>> code so thank you! I like the fact that you brought all the artifacts
>>>>>>> into the theme along with the FTL macros. This is a good first step,
>>>>>>> and I believe continuing on this direction is where we need to go.
>>>>>>>
>>>>>>> +1 to committing into the code base and testing over there.
>>>>>>>
>>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>>>>> <ja...@les7arts.com> wrote:
>>>>>>>
>>>>>>>> That sounds great,
>>>>>>>>
>>>>>>>> Thanks Nicolas!
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>>>>
>>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> I started the documentation here
>>>>>>>>>
>>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/
>>>>>>>>> themes/README.md
>>>>>>>>>
>>>>>>>>> It's a begging, I hope improve it quickly
>>>>>>>>>
>>>>>>>>> Nicolas
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>>>>
>>>>>>>>>> Hello;
>>>>>>>>>>
>>>>>>>>>> To continue the common-theme subject, I haven't see negative
>>>>>>>>>> return to
>>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads
>>>>>>>>>> on the
>>>>>>>>>> same
>>>>>>>>>> subject [2] and the additional theme xml definition [3], I
>>>>>>>>>> suggest to
>>>>>>>>>> create
>>>>>>>>>> a documentation on the wiki how work the "theme engine" and
>>>>>>>>>> commit the
>>>>>>>>>> current git branch [4] [5] on trunk
>>>>>>>>>>
>>>>>>>>>> After that, the engine will be present on the trunk and we
>>>>>>>>>> continue the
>>>>>>>>>> work to :
>>>>>>>>>> * Clean the common-theme and create a real theme
>>>>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>>>>> * Analyze more how organize the screen api
>>>>>>>>>>
>>>>>>>>>> But don't panic, before that I'm listening to all suggest or
>>>>>>>>>> remarks ;)
>>>>>>>>>>
>>>>>>>>>> Nicolas
>>>>>>>>>>
>>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>>>>> [2]
>>>>>>>>>>
>>>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15
>>>>>>>>>> fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>> [3]
>>>>>>>>>>
>>>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38ab
>>>>>>>>>> e231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>>>>>>> [5]
>>>>>>>>>>
>>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...
>>>>>>>>>> nmalin:common-theme?expand=1
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>
>>>>
>>>
>>>
>>
>
>

Re: Common-theme next step

Posted by Michael Brohl <mi...@ecomify.de>.
Thank you, Nicolas, for the great effort you put on this.

I'll hope to soon reactivate my work on the bootstrap theme, using the 
new structure, and see how it will work out.

I'll have some more qualified feedback (and propably questions ;-) ) then...

Thanks,

Michael


Am 25.08.17 um 12:15 schrieb Nicolas Malin:
> I loaded all my local :)
>
> Le 25/08/2017 à 00:03, Nicolas Malin a écrit :
>> I started to load common-theme on trunk, at this time to resume :
>>
>> r1806075, r1806076 : I loaded engine and documentation
>> r1806084 : I moved all images folder to common-theme
>> r1806091, r1806093: I moved all ftl template from common to 
>> common-theme and all macro ftl libraries.
> 1806134 : load VisualTheme and ModelTheme on different session and 
> context
> 1806137, 180614[0-9] : Migrate themes, common screens, handler to 
> exploit values from the theme definition
> 1806150 : migrate all other screen and scripts  to exploit values from 
> the theme definition
> 180615 : improve error message and announce the commit end :)
>
> Cheers,
> Nicolas
>>
>> I hope to break nothing at this time.
>> The next steps will load the dynamic theme load on session
>>
>> Cheers,
>>
>> Nicolas
>>
>>
>> Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
>>> Hi Taher,
>>>
>>> If you have few time to have a look on these three class :
>>>
>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelTheme.java 
>>>
>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ThemeFactory.java 
>>>
>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/VisualTheme.java 
>>>
>>>
>>> ModelTheme is java class to load all Theme definition who interact 
>>> with the system
>>>
>>> VisualTheme is java class regards the VisualTheme entity who 
>>> interact with the user to exploit the modelTheme
>>>
>>> ThemeFactory is the factory to create both.
>>>
>>> I prepare my commits, but I need to separate properly each code 
>>> modification to help other learn the work.
>>>
>>> Cheers,
>>> Nicolas
>>>
>>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>>>> Hi Nicolas,
>>>>
>>>> If it helps you, I suggest to isolate files / code where you are not
>>>> very comfortable and put them in a separate patch (not the full patch)
>>>> with an explanation of what you've done and where you feel a little
>>>> hesitant or uneasy. I think if you make us focus with you on very
>>>> specific pieces of code then our review will be faster and your
>>>> confidence of the review will be better.
>>>>
>>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>>>> <ni...@nereide.fr> wrote:
>>>>> Thanks,
>>>>>
>>>>> I will commit on trunk after a second review of my code because i was
>>>>> concentrated to increase the flexibility with macro and screen but 
>>>>> not
>>>>> manage correctly the VisualTheme concept.
>>>>>
>>>>> So I will take care about this, complete the documentation and 
>>>>> commit on
>>>>> trunk.
>>>>>
>>>>> Nicolas
>>>>>
>>>>>
>>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>>>> Like Michael, I also prefer to include the work into the code 
>>>>>> base and
>>>>>> test it over there. It seems like you put a lot of effort into this
>>>>>> code so thank you! I like the fact that you brought all the 
>>>>>> artifacts
>>>>>> into the theme along with the FTL macros. This is a good first step,
>>>>>> and I believe continuing on this direction is where we need to go.
>>>>>>
>>>>>> +1 to committing into the code base and testing over there.
>>>>>>
>>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>>>> <ja...@les7arts.com> wrote:
>>>>>>> That sounds great,
>>>>>>>
>>>>>>> Thanks Nicolas!
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>>
>>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> I started the documentation here
>>>>>>>>
>>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md 
>>>>>>>>
>>>>>>>>
>>>>>>>> It's a begging, I hope improve it quickly
>>>>>>>>
>>>>>>>> Nicolas
>>>>>>>>
>>>>>>>>
>>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>>>> Hello;
>>>>>>>>>
>>>>>>>>> To continue the common-theme subject, I haven't see negative 
>>>>>>>>> return to
>>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on 
>>>>>>>>> threads on the
>>>>>>>>> same
>>>>>>>>> subject [2] and the additional theme xml definition [3], I 
>>>>>>>>> suggest to
>>>>>>>>> create
>>>>>>>>> a documentation on the wiki how work the "theme engine" and 
>>>>>>>>> commit the
>>>>>>>>> current git branch [4] [5] on trunk
>>>>>>>>>
>>>>>>>>> After that, the engine will be present on the trunk and we 
>>>>>>>>> continue the
>>>>>>>>> work to :
>>>>>>>>> * Clean the common-theme and create a real theme
>>>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>>>> * Analyze more how organize the screen api
>>>>>>>>>
>>>>>>>>> But don't panic, before that I'm listening to all suggest or 
>>>>>>>>> remarks ;)
>>>>>>>>>
>>>>>>>>> Nicolas
>>>>>>>>>
>>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>>>> [2]
>>>>>>>>>
>>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E 
>>>>>>>>>
>>>>>>>>> [3]
>>>>>>>>>
>>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E 
>>>>>>>>>
>>>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>>>>>> [5]
>>>>>>>>>
>>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>
>>>
>>
>>
>



Re: Common-theme next step

Posted by Nicolas Malin <ni...@nereide.fr>.
I loaded all my local :)

Le 25/08/2017 à 00:03, Nicolas Malin a écrit :
> I started to load common-theme on trunk, at this time to resume :
>
> r1806075, r1806076 : I loaded engine and documentation
> r1806084 : I moved all images folder to common-theme
> r1806091, r1806093: I moved all ftl template from common to 
> common-theme and all macro ftl libraries.
1806134 : load VisualTheme and ModelTheme on different session and context
1806137, 180614[0-9] : Migrate themes, common screens, handler to 
exploit values from the theme definition
1806150 : migrate all other screen and scripts  to exploit values from 
the theme definition
180615 : improve error message and announce the commit end :)

Cheers,
Nicolas
>
> I hope to break nothing at this time.
> The next steps will load the dynamic theme load on session
>
> Cheers,
>
> Nicolas
>
>
> Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
>> Hi Taher,
>>
>> If you have few time to have a look on these three class :
>>
>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelTheme.java 
>>
>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ThemeFactory.java 
>>
>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/VisualTheme.java 
>>
>>
>> ModelTheme is java class to load all Theme definition who interact 
>> with the system
>>
>> VisualTheme is java class regards the VisualTheme entity who interact 
>> with the user to exploit the modelTheme
>>
>> ThemeFactory is the factory to create both.
>>
>> I prepare my commits, but I need to separate properly each code 
>> modification to help other learn the work.
>>
>> Cheers,
>> Nicolas
>>
>> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>>> Hi Nicolas,
>>>
>>> If it helps you, I suggest to isolate files / code where you are not
>>> very comfortable and put them in a separate patch (not the full patch)
>>> with an explanation of what you've done and where you feel a little
>>> hesitant or uneasy. I think if you make us focus with you on very
>>> specific pieces of code then our review will be faster and your
>>> confidence of the review will be better.
>>>
>>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>>> <ni...@nereide.fr> wrote:
>>>> Thanks,
>>>>
>>>> I will commit on trunk after a second review of my code because i was
>>>> concentrated to increase the flexibility with macro and screen but not
>>>> manage correctly the VisualTheme concept.
>>>>
>>>> So I will take care about this, complete the documentation and 
>>>> commit on
>>>> trunk.
>>>>
>>>> Nicolas
>>>>
>>>>
>>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>>> Like Michael, I also prefer to include the work into the code base 
>>>>> and
>>>>> test it over there. It seems like you put a lot of effort into this
>>>>> code so thank you! I like the fact that you brought all the artifacts
>>>>> into the theme along with the FTL macros. This is a good first step,
>>>>> and I believe continuing on this direction is where we need to go.
>>>>>
>>>>> +1 to committing into the code base and testing over there.
>>>>>
>>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>>> <ja...@les7arts.com> wrote:
>>>>>> That sounds great,
>>>>>>
>>>>>> Thanks Nicolas!
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>>> Hello,
>>>>>>>
>>>>>>> I started the documentation here
>>>>>>>
>>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md 
>>>>>>>
>>>>>>>
>>>>>>> It's a begging, I hope improve it quickly
>>>>>>>
>>>>>>> Nicolas
>>>>>>>
>>>>>>>
>>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>>> Hello;
>>>>>>>>
>>>>>>>> To continue the common-theme subject, I haven't see negative 
>>>>>>>> return to
>>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads 
>>>>>>>> on the
>>>>>>>> same
>>>>>>>> subject [2] and the additional theme xml definition [3], I 
>>>>>>>> suggest to
>>>>>>>> create
>>>>>>>> a documentation on the wiki how work the "theme engine" and 
>>>>>>>> commit the
>>>>>>>> current git branch [4] [5] on trunk
>>>>>>>>
>>>>>>>> After that, the engine will be present on the trunk and we 
>>>>>>>> continue the
>>>>>>>> work to :
>>>>>>>> * Clean the common-theme and create a real theme
>>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>>> * Analyze more how organize the screen api
>>>>>>>>
>>>>>>>> But don't panic, before that I'm listening to all suggest or 
>>>>>>>> remarks ;)
>>>>>>>>
>>>>>>>> Nicolas
>>>>>>>>
>>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>>> [2]
>>>>>>>>
>>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E 
>>>>>>>>
>>>>>>>> [3]
>>>>>>>>
>>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E 
>>>>>>>>
>>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>>>>> [5]
>>>>>>>>
>>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>
>>
>
>


Re: Common-theme next step

Posted by Nicolas Malin <ni...@nereide.fr>.
I started to load common-theme on trunk, at this time to resume :

r1806075, r1806076 : I loaded engine and documentation
r1806084 : I moved all images folder to common-theme
r1806091, r1806093: I moved all ftl template from common to common-theme 
and all macro ftl libraries.

I hope to break nothing at this time.
The next steps will load the dynamic theme load on session

Cheers,

Nicolas


Le 22/08/2017 à 14:07, Nicolas Malin a écrit :
> Hi Taher,
>
> If you have few time to have a look on these three class :
>
> https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelTheme.java 
>
> https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ThemeFactory.java 
>
> https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/VisualTheme.java 
>
>
> ModelTheme is java class to load all Theme definition who interact 
> with the system
>
> VisualTheme is java class regards the VisualTheme entity who interact 
> with the user to exploit the modelTheme
>
> ThemeFactory is the factory to create both.
>
> I prepare my commits, but I need to separate properly each code 
> modification to help other learn the work.
>
> Cheers,
> Nicolas
>
> Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
>> Hi Nicolas,
>>
>> If it helps you, I suggest to isolate files / code where you are not
>> very comfortable and put them in a separate patch (not the full patch)
>> with an explanation of what you've done and where you feel a little
>> hesitant or uneasy. I think if you make us focus with you on very
>> specific pieces of code then our review will be faster and your
>> confidence of the review will be better.
>>
>> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
>> <ni...@nereide.fr> wrote:
>>> Thanks,
>>>
>>> I will commit on trunk after a second review of my code because i was
>>> concentrated to increase the flexibility with macro and screen but not
>>> manage correctly the VisualTheme concept.
>>>
>>> So I will take care about this, complete the documentation and 
>>> commit on
>>> trunk.
>>>
>>> Nicolas
>>>
>>>
>>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>>> Like Michael, I also prefer to include the work into the code base and
>>>> test it over there. It seems like you put a lot of effort into this
>>>> code so thank you! I like the fact that you brought all the artifacts
>>>> into the theme along with the FTL macros. This is a good first step,
>>>> and I believe continuing on this direction is where we need to go.
>>>>
>>>> +1 to committing into the code base and testing over there.
>>>>
>>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>>> <ja...@les7arts.com> wrote:
>>>>> That sounds great,
>>>>>
>>>>> Thanks Nicolas!
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>>> Hello,
>>>>>>
>>>>>> I started the documentation here
>>>>>>
>>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md 
>>>>>>
>>>>>>
>>>>>> It's a begging, I hope improve it quickly
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>>
>>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>>> Hello;
>>>>>>>
>>>>>>> To continue the common-theme subject, I haven't see negative 
>>>>>>> return to
>>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads 
>>>>>>> on the
>>>>>>> same
>>>>>>> subject [2] and the additional theme xml definition [3], I 
>>>>>>> suggest to
>>>>>>> create
>>>>>>> a documentation on the wiki how work the "theme engine" and 
>>>>>>> commit the
>>>>>>> current git branch [4] [5] on trunk
>>>>>>>
>>>>>>> After that, the engine will be present on the trunk and we 
>>>>>>> continue the
>>>>>>> work to :
>>>>>>> * Clean the common-theme and create a real theme
>>>>>>> * Migrate properly the current theme with the new structure
>>>>>>> * Analyze more how organize the screen api
>>>>>>>
>>>>>>> But don't panic, before that I'm listening to all suggest or 
>>>>>>> remarks ;)
>>>>>>>
>>>>>>> Nicolas
>>>>>>>
>>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>>> [2]
>>>>>>>
>>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E 
>>>>>>>
>>>>>>> [3]
>>>>>>>
>>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E 
>>>>>>>
>>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>>>> [5]
>>>>>>>
>>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 
>>>>>>>
>>>>>>>
>>>>>>>
>
>


Re: Common-theme next step

Posted by Nicolas Malin <ni...@nereide.fr>.
Hi Taher,

If you have few time to have a look on these three class :

https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelTheme.java
https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ThemeFactory.java
https://github.com/nmalin/ofbiz-framework/blob/common-theme/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/VisualTheme.java 


ModelTheme is java class to load all Theme definition who interact with 
the system

VisualTheme is java class regards the VisualTheme entity who interact 
with the user to exploit the modelTheme

ThemeFactory is the factory to create both.

I prepare my commits, but I need to separate properly each code 
modification to help other learn the work.

Cheers,
Nicolas

Le 21/08/2017 à 10:13, Taher Alkhateeb a écrit :
> Hi Nicolas,
>
> If it helps you, I suggest to isolate files / code where you are not
> very comfortable and put them in a separate patch (not the full patch)
> with an explanation of what you've done and where you feel a little
> hesitant or uneasy. I think if you make us focus with you on very
> specific pieces of code then our review will be faster and your
> confidence of the review will be better.
>
> On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
> <ni...@nereide.fr> wrote:
>> Thanks,
>>
>> I will commit on trunk after a second review of my code because i was
>> concentrated to increase the flexibility with macro and screen but not
>> manage correctly the VisualTheme concept.
>>
>> So I will take care about this, complete the documentation and commit on
>> trunk.
>>
>> Nicolas
>>
>>
>> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>> Like Michael, I also prefer to include the work into the code base and
>>> test it over there. It seems like you put a lot of effort into this
>>> code so thank you! I like the fact that you brought all the artifacts
>>> into the theme along with the FTL macros. This is a good first step,
>>> and I believe continuing on this direction is where we need to go.
>>>
>>> +1 to committing into the code base and testing over there.
>>>
>>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>>> <ja...@les7arts.com> wrote:
>>>> That sounds great,
>>>>
>>>> Thanks Nicolas!
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>> Hello,
>>>>>
>>>>> I started the documentation here
>>>>>
>>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md
>>>>>
>>>>> It's a begging, I hope improve it quickly
>>>>>
>>>>> Nicolas
>>>>>
>>>>>
>>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>> Hello;
>>>>>>
>>>>>> To continue the common-theme subject, I haven't see negative return to
>>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on the
>>>>>> same
>>>>>> subject [2] and the additional theme xml definition [3], I suggest to
>>>>>> create
>>>>>> a documentation on the wiki how work the "theme engine" and commit the
>>>>>> current git branch [4] [5] on trunk
>>>>>>
>>>>>> After that, the engine will be present on the trunk and we continue the
>>>>>> work to :
>>>>>> * Clean the common-theme and create a real theme
>>>>>> * Migrate properly the current theme with the new structure
>>>>>> * Analyze more how organize the screen api
>>>>>>
>>>>>> But don't panic, before that I'm listening to all suggest or remarks ;)
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>>> [2]
>>>>>>
>>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>>>> [3]
>>>>>>
>>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>>> [5]
>>>>>>
>>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1
>>>>>>
>>>>>>


Re: Common-theme next step

Posted by Taher Alkhateeb <sl...@gmail.com>.
Hi Nicolas,

If it helps you, I suggest to isolate files / code where you are not
very comfortable and put them in a separate patch (not the full patch)
with an explanation of what you've done and where you feel a little
hesitant or uneasy. I think if you make us focus with you on very
specific pieces of code then our review will be faster and your
confidence of the review will be better.

On Mon, Aug 21, 2017 at 10:55 AM, Nicolas Malin
<ni...@nereide.fr> wrote:
> Thanks,
>
> I will commit on trunk after a second review of my code because i was
> concentrated to increase the flexibility with macro and screen but not
> manage correctly the VisualTheme concept.
>
> So I will take care about this, complete the documentation and commit on
> trunk.
>
> Nicolas
>
>
> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>
>> Like Michael, I also prefer to include the work into the code base and
>> test it over there. It seems like you put a lot of effort into this
>> code so thank you! I like the fact that you brought all the artifacts
>> into the theme along with the FTL macros. This is a good first step,
>> and I believe continuing on this direction is where we need to go.
>>
>> +1 to committing into the code base and testing over there.
>>
>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>> <ja...@les7arts.com> wrote:
>>>
>>> That sounds great,
>>>
>>> Thanks Nicolas!
>>>
>>> Jacques
>>>
>>>
>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>>
>>>> Hello,
>>>>
>>>> I started the documentation here
>>>>
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md
>>>>
>>>> It's a begging, I hope improve it quickly
>>>>
>>>> Nicolas
>>>>
>>>>
>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>>
>>>>> Hello;
>>>>>
>>>>> To continue the common-theme subject, I haven't see negative return to
>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on the
>>>>> same
>>>>> subject [2] and the additional theme xml definition [3], I suggest to
>>>>> create
>>>>> a documentation on the wiki how work the "theme engine" and commit the
>>>>> current git branch [4] [5] on trunk
>>>>>
>>>>> After that, the engine will be present on the trunk and we continue the
>>>>> work to :
>>>>> * Clean the common-theme and create a real theme
>>>>> * Migrate properly the current theme with the new structure
>>>>> * Analyze more how organize the screen api
>>>>>
>>>>> But don't panic, before that I'm listening to all suggest or remarks ;)
>>>>>
>>>>> Nicolas
>>>>>
>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>> [2]
>>>>>
>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>>> [3]
>>>>>
>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>> [5]
>>>>>
>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1
>>>>>
>>>>>
>>>>
>

Re: Common-theme next step

Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Nicolas,

Looking forward

Jacques

Le 21/08/2017 à 09:55, Nicolas Malin a écrit :
> Thanks,
>
> I will commit on trunk after a second review of my code because i was concentrated to increase the flexibility with macro and screen but not manage 
> correctly the VisualTheme concept.
>
> So I will take care about this, complete the documentation and commit on trunk.
>
> Nicolas
>
> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>> Like Michael, I also prefer to include the work into the code base and
>> test it over there. It seems like you put a lot of effort into this
>> code so thank you! I like the fact that you brought all the artifacts
>> into the theme along with the FTL macros. This is a good first step,
>> and I believe continuing on this direction is where we need to go.
>>
>> +1 to committing into the code base and testing over there.
>>
>> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
>> <ja...@les7arts.com> wrote:
>>> That sounds great,
>>>
>>> Thanks Nicolas!
>>>
>>> Jacques
>>>
>>>
>>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>>> Hello,
>>>>
>>>> I started the documentation here
>>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md
>>>>
>>>> It's a begging, I hope improve it quickly
>>>>
>>>> Nicolas
>>>>
>>>>
>>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>>> Hello;
>>>>>
>>>>> To continue the common-theme subject, I haven't see negative return to
>>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on the same
>>>>> subject [2] and the additional theme xml definition [3], I suggest to create
>>>>> a documentation on the wiki how work the "theme engine" and commit the
>>>>> current git branch [4] [5] on trunk
>>>>>
>>>>> After that, the engine will be present on the trunk and we continue the
>>>>> work to :
>>>>> * Clean the common-theme and create a real theme
>>>>> * Migrate properly the current theme with the new structure
>>>>> * Analyze more how organize the screen api
>>>>>
>>>>> But don't panic, before that I'm listening to all suggest or remarks ;)
>>>>>
>>>>> Nicolas
>>>>>
>>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>>> [2]
>>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>>> [3]
>>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>>> [5]
>>>>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1
>>>>>
>>>>>
>>>>
>
>


Re: Common-theme next step

Posted by Nicolas Malin <ni...@nereide.fr>.
Thanks,

I will commit on trunk after a second review of my code because i was 
concentrated to increase the flexibility with macro and screen but not 
manage correctly the VisualTheme concept.

So I will take care about this, complete the documentation and commit on 
trunk.

Nicolas

Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
> Like Michael, I also prefer to include the work into the code base and
> test it over there. It seems like you put a lot of effort into this
> code so thank you! I like the fact that you brought all the artifacts
> into the theme along with the FTL macros. This is a good first step,
> and I believe continuing on this direction is where we need to go.
>
> +1 to committing into the code base and testing over there.
>
> On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
> <ja...@les7arts.com> wrote:
>> That sounds great,
>>
>> Thanks Nicolas!
>>
>> Jacques
>>
>>
>> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>> Hello,
>>>
>>> I started the documentation here
>>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md
>>>
>>> It's a begging, I hope improve it quickly
>>>
>>> Nicolas
>>>
>>>
>>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>> Hello;
>>>>
>>>> To continue the common-theme subject, I haven't see negative return to
>>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on the same
>>>> subject [2] and the additional theme xml definition [3], I suggest to create
>>>> a documentation on the wiki how work the "theme engine" and commit the
>>>> current git branch [4] [5] on trunk
>>>>
>>>> After that, the engine will be present on the trunk and we continue the
>>>> work to :
>>>> * Clean the common-theme and create a real theme
>>>> * Migrate properly the current theme with the new structure
>>>> * Analyze more how organize the screen api
>>>>
>>>> But don't panic, before that I'm listening to all suggest or remarks ;)
>>>>
>>>> Nicolas
>>>>
>>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>>> [2]
>>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>>> [3]
>>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>>> [5]
>>>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1
>>>>
>>>>
>>>


Re: Common-theme next step

Posted by Taher Alkhateeb <sl...@gmail.com>.
Like Michael, I also prefer to include the work into the code base and
test it over there. It seems like you put a lot of effort into this
code so thank you! I like the fact that you brought all the artifacts
into the theme along with the FTL macros. This is a good first step,
and I believe continuing on this direction is where we need to go.

+1 to committing into the code base and testing over there.

On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux
<ja...@les7arts.com> wrote:
> That sounds great,
>
> Thanks Nicolas!
>
> Jacques
>
>
> Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
>>
>> Hello,
>>
>> I started the documentation here
>> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md
>>
>> It's a begging, I hope improve it quickly
>>
>> Nicolas
>>
>>
>> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>>>
>>> Hello;
>>>
>>> To continue the common-theme subject, I haven't see negative return to
>>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on the same
>>> subject [2] and the additional theme xml definition [3], I suggest to create
>>> a documentation on the wiki how work the "theme engine" and commit the
>>> current git branch [4] [5] on trunk
>>>
>>> After that, the engine will be present on the trunk and we continue the
>>> work to :
>>> * Clean the common-theme and create a real theme
>>> * Migrate properly the current theme with the new structure
>>> * Analyze more how organize the screen api
>>>
>>> But don't panic, before that I'm listening to all suggest or remarks ;)
>>>
>>> Nicolas
>>>
>>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>>> [2]
>>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>>> [3]
>>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>>> [5]
>>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1
>>>
>>>
>>
>>
>

Re: Common-theme next step

Posted by Jacques Le Roux <ja...@les7arts.com>.
That sounds great,

Thanks Nicolas!

Jacques

Le 17/08/2017 à 22:00, Nicolas Malin a écrit :
> Hello,
>
> I started the documentation here https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md
>
> It's a begging, I hope improve it quickly
>
> Nicolas
>
>
> Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
>> Hello;
>>
>> To continue the common-theme subject, I haven't see negative return to the issue Create a common theme (OFBIZ-9138) [1] and on threads on the same 
>> subject [2] and the additional theme xml definition [3], I suggest to create a documentation on the wiki how work the "theme engine" and commit the 
>> current git branch [4] [5] on trunk
>>
>> After that, the engine will be present on the trunk and we continue the work to :
>> * Clean the common-theme and create a real theme
>> * Migrate properly the current theme with the new structure
>> * Analyze more how organize the screen api
>>
>> But don't panic, before that I'm listening to all suggest or remarks ;)
>>
>> Nicolas
>>
>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>> [2] https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>> [3] https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>> [5] https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1
>>
>>
>
>


Re: Common-theme next step

Posted by Nicolas Malin <ni...@nereide.fr>.
Hello,

I started the documentation here 
https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md

It's a begging, I hope improve it quickly

Nicolas


Le 16/08/2017 à 13:49, Nicolas Malin a écrit :
> Hello;
>
> To continue the common-theme subject, I haven't see negative return to 
> the issue Create a common theme (OFBIZ-9138) [1] and on threads on the 
> same subject [2] and the additional theme xml definition [3], I 
> suggest to create a documentation on the wiki how work the "theme 
> engine" and commit the current git branch [4] [5] on trunk
>
> After that, the engine will be present on the trunk and we continue 
> the work to :
> * Clean the common-theme and create a real theme
> * Migrate properly the current theme with the new structure
> * Analyze more how organize the screen api
>
> But don't panic, before that I'm listening to all suggest or remarks ;)
>
> Nicolas
>
> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
> [2] 
> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
> [3] 
> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
> [5] 
> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1
>
>


Re: common-theme questions, was: Re: Common-theme next step

Posted by Nicolas Malin <ni...@nereide.fr>.
Hello Michael

Nice questions :) in line

Le 17/08/2017 à 11:06, Michael Brohl a écrit :
> Hi Nicolas,
>
> During my work on the bootstrap theme [1] (which got stuck due to 
> other tasks) I stumbled upon some problems which possibly get solved 
> by your approach or we can consider a solution for it during the work.
>
> In detail, I'm referring to [2] where you had the same problem I'm 
> facing: Instead of displaying the application menu bar when it is 
> active I want to have the menu items as sub level items in a global 
> navigation sidebar. It does not seem to be possible completely 
> dynamically because of the configuration inside the screen definitions 
> but it might be better doable if we would have a configuration 
> standard for the menus, using always the same patterns (convention 
> over configuration).
>
> Do you already have an idea how to solve this/ will the new approach 
> help with this?
With this problematic we have two aspects :
* access to the model
* rendering the model
The first aspect isn't manage by themes, we need to understand what 
missed on the modelScreen to improve it by technology or by convention.
But for the second it's completely cover by themes. To do that, you can 
surcharge just the decorator definition or the macro ftl library that 
you need.
> Another base question is how we can provide different style classes 
> and ids to the base html code so that we can reuse the html but use 
> different UI frameworks with their specific style class terminology. 
> It would be great if users can choose their preferred UI framework 
> like Bootstrap, Foundation & Co. to build new themes. Will this be 
> covered by your approach?
The screen definition need to embed the minimum css set as convention 
and maximum ids element. After that, you can define your own decorator 
to load needed library or something like that and rewrite the macro ftl 
to adapt the rendering.

With the theme dependency, you can also create a base theme like 
boostrap-base that implement common-theme for all non html macro, 
surchage all html macro library. Each new boostrap-theme can be 
implement boostrap-base for all specific technical rendering and just 
import their own class

Cheers,
Nicolas
>
> [1] 
> https://lists.apache.org/thread.html/de49bb2fd2f9c82ab99bd08e603e9625c9c5a532a80b5226ccd5a4fc@%3Cdev.ofbiz.apache.org%3E
>
> [2] 
> https://lists.apache.org/thread.html/91e3e5cab3b233f9587d69f0419eb652744cc5afcd39bc97df269ace@1444926106@%3Cuser.ofbiz.apache.org%3E
>
> Thanks,
> Michael
>
>
> Am 16.08.17 um 13:49 schrieb Nicolas Malin:
>> Hello;
>>
>> To continue the common-theme subject, I haven't see negative return 
>> to the issue Create a common theme (OFBIZ-9138) [1] and on threads on 
>> the same subject [2] and the additional theme xml definition [3], I 
>> suggest to create a documentation on the wiki how work the "theme 
>> engine" and commit the current git branch [4] [5] on trunk
>>
>> After that, the engine will be present on the trunk and we continue 
>> the work to :
>> * Clean the common-theme and create a real theme
>> * Migrate properly the current theme with the new structure
>> * Analyze more how organize the screen api
>>
>> But don't panic, before that I'm listening to all suggest or remarks ;)
>>
>> Nicolas
>>
>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>> [2] 
>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>> [3] 
>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>> [5] 
>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1
>>
>>
>
>


common-theme questions, was: Re: Common-theme next step

Posted by Michael Brohl <mi...@ecomify.de>.
Hi Nicolas,

During my work on the bootstrap theme [1] (which got stuck due to other 
tasks) I stumbled upon some problems which possibly get solved by your 
approach or we can consider a solution for it during the work.

In detail, I'm referring to [2] where you had the same problem I'm 
facing: Instead of displaying the application menu bar when it is active 
I want to have the menu items as sub level items in a global navigation 
sidebar. It does not seem to be possible completely dynamically because 
of the configuration inside the screen definitions but it might be 
better doable if we would have a configuration standard for the menus, 
using always the same patterns (convention over configuration).

Do you already have an idea how to solve this/ will the new approach 
help with this?

Another base question is how we can provide different style classes and 
ids to the base html code so that we can reuse the html but use 
different UI frameworks with their specific style class terminology. It 
would be great if users can choose their preferred UI framework like 
Bootstrap, Foundation & Co. to build new themes. Will this be covered by 
your approach?

[1] 
https://lists.apache.org/thread.html/de49bb2fd2f9c82ab99bd08e603e9625c9c5a532a80b5226ccd5a4fc@%3Cdev.ofbiz.apache.org%3E

[2] 
https://lists.apache.org/thread.html/91e3e5cab3b233f9587d69f0419eb652744cc5afcd39bc97df269ace@1444926106@%3Cuser.ofbiz.apache.org%3E

Thanks,
Michael


Am 16.08.17 um 13:49 schrieb Nicolas Malin:
> Hello;
>
> To continue the common-theme subject, I haven't see negative return to 
> the issue Create a common theme (OFBIZ-9138) [1] and on threads on the 
> same subject [2] and the additional theme xml definition [3], I 
> suggest to create a documentation on the wiki how work the "theme 
> engine" and commit the current git branch [4] [5] on trunk
>
> After that, the engine will be present on the trunk and we continue 
> the work to :
> * Clean the common-theme and create a real theme
> * Migrate properly the current theme with the new structure
> * Analyze more how organize the screen api
>
> But don't panic, before that I'm listening to all suggest or remarks ;)
>
> Nicolas
>
> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
> [2] 
> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
> [3] 
> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
> [5] 
> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1
>
>



Re: Common-theme next step

Posted by Nicolas Malin <ni...@nereide.fr>.
Hi Michael,

Le 17/08/2017 à 10:44, Michael Brohl a écrit :
> Hi Nicolas,
>
> thank you very much for your ongoing work on this topic, I greatly 
> appreciate it :-)
:) thanks, you escape me from the loneliness
>
> I'm looking forward to have a deeper look into your solutions but have 
> to wait until my return on end of August. The concept, as I understand 
> it, provides an extendable mechanism to build themes on base of other 
> themes, which seems very flexible.
It's exactly the purpose with keep in mind to separate the model and 
convention on framework and all surcharge for the rendering or structure 
page in themes
>
> I'm in favor to have you commit the changes to trunk as long as they 
> don't break existing functionality and themes. It would be much easier 
> to work together then.
Normally I haven't detected a major regression. Just detect a problem 
when you have some sessions already enabled, when you change your theme, 
it's updated only on the current session where you did it and the newer. 
But the others enabled session keep the previous theme.

If some people are feedback on some regression, I'm really happy to 
understand and resolve it but I'm fear that we need to wait the commit 
in trunk.

Cheers
Nicolas
>
> I'll have some detailed questions which I will put in another message 
> to prevent confusion.
>
> Again, thank you very much for your efforts,
>
> Best regards,
>
> Michael
>
>
>
> Am 16.08.17 um 13:49 schrieb Nicolas Malin:
>> Hello;
>>
>> To continue the common-theme subject, I haven't see negative return 
>> to the issue Create a common theme (OFBIZ-9138) [1] and on threads on 
>> the same subject [2] and the additional theme xml definition [3], I 
>> suggest to create a documentation on the wiki how work the "theme 
>> engine" and commit the current git branch [4] [5] on trunk
>>
>> After that, the engine will be present on the trunk and we continue 
>> the work to :
>> * Clean the common-theme and create a real theme
>> * Migrate properly the current theme with the new structure
>> * Analyze more how organize the screen api
>>
>> But don't panic, before that I'm listening to all suggest or remarks ;)
>>
>> Nicolas
>>
>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
>> [2] 
>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
>> [3] 
>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
>> [5] 
>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1
>>
>>
>
>


Re: Common-theme next step

Posted by Michael Brohl <mi...@ecomify.de>.
Hi Nicolas,

thank you very much for your ongoing work on this topic, I greatly 
appreciate it :-)

I'm looking forward to have a deeper look into your solutions but have 
to wait until my return on end of August. The concept, as I understand 
it, provides an extendable mechanism to build themes on base of other 
themes, which seems very flexible.

I'm in favor to have you commit the changes to trunk as long as they 
don't break existing functionality and themes. It would be much easier 
to work together then.

I'll have some detailed questions which I will put in another message to 
prevent confusion.

Again, thank you very much for your efforts,

Best regards,

Michael



Am 16.08.17 um 13:49 schrieb Nicolas Malin:
> Hello;
>
> To continue the common-theme subject, I haven't see negative return to 
> the issue Create a common theme (OFBIZ-9138) [1] and on threads on the 
> same subject [2] and the additional theme xml definition [3], I 
> suggest to create a documentation on the wiki how work the "theme 
> engine" and commit the current git branch [4] [5] on trunk
>
> After that, the engine will be present on the trunk and we continue 
> the work to :
> * Clean the common-theme and create a real theme
> * Migrate properly the current theme with the new structure
> * Analyze more how organize the screen api
>
> But don't panic, before that I'm listening to all suggest or remarks ;)
>
> Nicolas
>
> [1] https://issues.apache.org/jira/browse/OFBIZ-9138
> [2] 
> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E
> [3] 
> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E
> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme
> [5] 
> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1
>
>