You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/08 08:27:13 UTC
[GitHub] [tvm] wrongtest opened a new pull request #9678: Fix for tvm.build()'s name warning
wrongtest opened a new pull request #9678:
URL: https://github.com/apache/tvm/pull/9678
This is a follow-up fix of problem bring by https://github.com/apache/tvm/pull/9602
I temporarily raise an error for non-none name with IRModule build, to get a knowledge about influence range of previous PR9602.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9678: Fix for tvm.build()'s name warning
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9678:
URL: https://github.com/apache/tvm/pull/9678#issuecomment-989568064
hmm looks like it's unfortunate that we cannot add this warning for now, given there are too many dependency and assumptions in the codebase...I'm open to reverting the change, and get a more systematic fix in the long run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9678: Fix for tvm.build()'s name warning
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9678:
URL: https://github.com/apache/tvm/pull/9678#issuecomment-994109149
Sorry for the late reply! was a bit swamped last week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest commented on a change in pull request #9678: Fix for tvm.build()'s name warning
Posted by GitBox <gi...@apache.org>.
wrongtest commented on a change in pull request #9678:
URL: https://github.com/apache/tvm/pull/9678#discussion_r765385770
##########
File path: python/tvm/driver/build_module.py
##########
@@ -93,7 +93,7 @@ def schedule_to_module(
def lower(
inp: Union[schedule.Schedule, PrimFunc, IRModule],
args: Optional[List[Union[Buffer, tensor.Tensor, Var]]] = None,
- name: str = "main",
+ name: str = None,
Review comment:
Yeal, you are right. I finally fail to resolve all name errors related to unittests with a minor change. Is it acceptable if the PR only remove the name warning of #9602?
If the default name is changed, currently broken testcases I have seen are:
- Test in microtvm require the function name `not` be `main` because of c code compilation.
- While a various set of tests use "main" as the expected IR function name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on a change in pull request #9678: Fix for tvm.build()'s name warning
Posted by GitBox <gi...@apache.org>.
jwfromm commented on a change in pull request #9678:
URL: https://github.com/apache/tvm/pull/9678#discussion_r765274865
##########
File path: python/tvm/driver/build_module.py
##########
@@ -93,7 +93,7 @@ def schedule_to_module(
def lower(
inp: Union[schedule.Schedule, PrimFunc, IRModule],
args: Optional[List[Union[Buffer, tensor.Tensor, Var]]] = None,
- name: str = "main",
+ name: str = None,
Review comment:
I think this might break a lot of things. "main" is used quite often as the default Function name in IRModules and I expect it'll show up in a lot of tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #9678: Fix for tvm.build()'s name warning
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #9678:
URL: https://github.com/apache/tvm/pull/9678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org