You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/08/13 08:18:50 UTC
[GitHub] [thrift] emmenlau opened a new pull request #2437: Several diverse improvements
emmenlau opened a new pull request #2437:
URL: https://github.com/apache/thrift/pull/2437
This PR contains a number of small, self-contained improvements. The changes are:
- lib/cpp/src/thrift/transport/TBufferTransports.h: Minor whitespace changes
- TSocket.cpp: Print THRIFT_EAGAIN (timed out) to global error
- build/cmake/DefineOptions.cmake: Minor improvement in logging for 'WITH_MT'
- lib/cpp/test/CMakeLists.txt: Added missing boost::chrono
- build/cmake/BoostMacros.cmake: Removed 'Boost_NO_BOOST_CMAKE' and minor cleanup
- TCompactProtocol.tcc: add missing include cstdlib
- Include signal.h depending on HAVE_SIGNAL_H, not depending on __linux__
- Added new method isUnixDomainSocket() to check type of socket
- [x] No [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket for trivial changes
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Changes are not squashed, to keep the consistency of each change
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on pull request #2437: Several diverse improvements
Posted by GitBox <gi...@apache.org>.
emmenlau commented on pull request #2437:
URL: https://github.com/apache/thrift/pull/2437#issuecomment-908759930
> Any possibility that we can squash commits before merge again?
Yes! Sorry if the number of commits was excessive. My intention was to have relatively self-contained changes in each commit. And since the different commits add completely unrelated changes, I left them as individual commits. But I can squash next time if its preferred!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau merged pull request #2437: Several diverse improvements
Posted by GitBox <gi...@apache.org>.
emmenlau merged pull request #2437:
URL: https://github.com/apache/thrift/pull/2437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2437: Several diverse improvements
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2437:
URL: https://github.com/apache/thrift/pull/2437#issuecomment-908959202
Well its not a strict law, you know, but sort of good practice. And if it really is thematically three things, then three commits it is. If its three larger topics then it should probably be also three individual PRs. Whatever makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on pull request #2437: Several diverse improvements
Posted by GitBox <gi...@apache.org>.
emmenlau commented on pull request #2437:
URL: https://github.com/apache/thrift/pull/2437#issuecomment-908759930
> Any possibility that we can squash commits before merge again?
Yes! Sorry if the number of commits was excessive. My intention was to have relatively self-contained changes in each commit. And since the different commits add completely unrelated changes, I left them as individual commits. But I can squash next time if its preferred!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2437: Several diverse improvements
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2437:
URL: https://github.com/apache/thrift/pull/2437#issuecomment-908640146
Any possibility that we can squash commits before merge again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2437: Several diverse improvements
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2437:
URL: https://github.com/apache/thrift/pull/2437#issuecomment-908640146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org