You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "rostskadat (via GitHub)" <gi...@apache.org> on 2025/02/27 16:28:01 UTC
[PR] Amazon rdshook invalid waiter [airflow]
rostskadat opened a new pull request, #47156:
URL: https://github.com/apache/airflow/pull/47156
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
The latest boto3 Amazon RDS documentation states that only the following waiters are available for RDS clusters and instances:
* DBClusterAvailable
* DBClusterDeleted
* DBInstanceAvailable
* DBInstanceDeleted
The RdsHook, tries to create a waiter for the `target_state` `stopped`. This gives the following error:
```
...
File "/usr/local/airflow/.local/lib/python3.11/site-packages/airflow/providers/amazon/aws/hooks/rds.py", line 263, in wait_for_db_instance_state
waiter = self.conn.get_waiter(f"db_instance_{target_state}") # type: ignore
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/airflow/.local/lib/python3.11/site-packages/botocore/client.py", line 1267, in get_waiter
raise ValueError(f"Waiter does not exist: {waiter_name}")
ValueError: Waiter does not exist: db_instance_stopped
```
This PR aims to correct this error by making sure that no waiter is created for that `target_state`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Amazon rdshook invalid waiter [airflow]
Posted by "rostskadat (via GitHub)" <gi...@apache.org>.
rostskadat commented on PR #47156:
URL: https://github.com/apache/airflow/pull/47156#issuecomment-2689856342
> `db_instance_stopped` is a custom waiter defined in https://github.com/apache/airflow/blob/main/providers/amazon/src/airflow/providers/amazon/aws/waiters/rds.json#L4. You can find more information custom waiters [here](https://github.com/apache/airflow/tree/main/providers/amazon/src/airflow/providers/amazon/aws/waiters). However, I do not understand why it cannot find the waiter `db_instance_stopped`
Thanks @vincbeck for your answer. I did not know about custom waiters. Now, I guess question is to trace until I can figure out why the custom waiter is ignored. In the mean time, I'll close the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Amazon rdshook invalid waiter [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #47156:
URL: https://github.com/apache/airflow/pull/47156#issuecomment-2688528098
`db_instance_stopped` is a custom waiter defined in https://github.com/apache/airflow/blob/main/providers/amazon/src/airflow/providers/amazon/aws/waiters/rds.json#L4. You can find more information custom waiters [here](https://github.com/apache/airflow/tree/main/providers/amazon/src/airflow/providers/amazon/aws/waiters). However, I do not understand why it cannot find the waiter `db_instance_stopped`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Amazon rdshook invalid waiter [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #47156:
URL: https://github.com/apache/airflow/pull/47156#issuecomment-2688481884
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Amazon rdshook invalid waiter [airflow]
Posted by "rostskadat (via GitHub)" <gi...@apache.org>.
rostskadat closed pull request #47156: Amazon rdshook invalid waiter
URL: https://github.com/apache/airflow/pull/47156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org