You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ozone.apache.org by Kaijie Chen <ck...@apache.org> on 2023/02/01 07:02:22 UTC
Re: [DISCUSS] How many days to wait if no response from reviewer?
+1
Thanks Uma for bring up this discussion.
Personally I think this should be a convention instead of a rule.
---- On Wed, 01 Feb 2023 07:16:37 +0800 Ritesh Shukla wrote ---
> +1 for this.
> We can wait to gather a broader consensus for certain rare cases where we
> add new APIs or public changes but if the reviewer's original review
> comments were addressed then it should be ok to go ahead and merge post a
> timeout value.
>
> On Tue, Jan 31, 2023 at 2:51 PM Uma Maheswara Rao Gangumalla <
> umamahesh@apache.org> wrote:
>
> > Dear Ozone Devs,
> >
> > This has been brought up by Ritesh in community sync. I thought we could
> > discuss this more broadly and set up some path forwarding options.
> >
> > With my past experience, when a reviewer does not respond for a long time
> > and if another reviewer helped to review, we will just give a few days'
> > wait for the old reviewer to confirm his comments. If no further responses
> > from the old reviewer, we used to move ahead.
> >
> > I think we can follow the similar approach:
> >
> > When the reviewer does not respond for a long time (say 15days? ):
> > The Author can freely ping other reviewers to help if no one else
> > reviewed it yet.
> > If the other reviewer is a committer and got +1 from him, then we can
> > give a 3-7days time window for the old reviewer to check as a final
> > friendly reminder. If still no responses, then we can just move ahead for
> > commit based new committer reviewer's +1.
> >
> > Thoughts?
> >
> > Regards,
> > Uma
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
For additional commands, e-mail: dev-help@ozone.apache.org
Re: [DISCUSS] How many days to wait if no response from reviewer?
Posted by Sumit Agrawal <su...@cloudera.com.INVALID>.
+1
Regards
Sumit
On Wed, Feb 1, 2023 at 2:25 PM mingchao zhao <ca...@apache.org> wrote:
> +1
> Thanks Uma. Good idea.
>
> On Wed, Feb 1, 2023 at 4:35 PM Ayush Saxena <ay...@gmail.com> wrote:
>
> > +1,
> > Makes sense,
> > Thanx Uma for bringing this up. Maybe the number of days to wait can vary
> > depending on the time of the year (vacations/weekends or so) and the
> > criticality of the Jira (release blocker or so), just give enough
> > opportunity to the reviewer to come back and that should be fine.
> >
> > -Ayush
> >
> > On Wed, 1 Feb 2023 at 12:32, Kaijie Chen <ck...@apache.org> wrote:
> >
> > > +1
> > >
> > > Thanks Uma for bring up this discussion.
> > > Personally I think this should be a convention instead of a rule.
> > >
> > > ---- On Wed, 01 Feb 2023 07:16:37 +0800 Ritesh Shukla wrote ---
> > > > +1 for this.
> > > > We can wait to gather a broader consensus for certain rare cases
> where
> > > we
> > > > add new APIs or public changes but if the reviewer's original review
> > > > comments were addressed then it should be ok to go ahead and merge
> > post
> > > a
> > > > timeout value.
> > > >
> > > > On Tue, Jan 31, 2023 at 2:51 PM Uma Maheswara Rao Gangumalla <
> > > > umamahesh@apache.org> wrote:
> > > >
> > > > > Dear Ozone Devs,
> > > > >
> > > > > This has been brought up by Ritesh in community sync. I thought we
> > > could
> > > > > discuss this more broadly and set up some path forwarding options.
> > > > >
> > > > > With my past experience, when a reviewer does not respond for a
> long
> > > time
> > > > > and if another reviewer helped to review, we will just give a few
> > > days'
> > > > > wait for the old reviewer to confirm his comments. If no further
> > > responses
> > > > > from the old reviewer, we used to move ahead.
> > > > >
> > > > > I think we can follow the similar approach:
> > > > >
> > > > > When the reviewer does not respond for a long time (say 15days? ):
> > > > > The Author can freely ping other reviewers to help if no one
> > else
> > > > > reviewed it yet.
> > > > > If the other reviewer is a committer and got +1 from him, then
> > we
> > > can
> > > > > give a 3-7days time window for the old reviewer to check as a
> final
> > > > > friendly reminder. If still no responses, then we can just move
> > ahead
> > > for
> > > > > commit based new committer reviewer's +1.
> > > > >
> > > > > Thoughts?
> > > > >
> > > > > Regards,
> > > > > Uma
> > > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> > > For additional commands, e-mail: dev-help@ozone.apache.org
> > >
> > >
> >
>
>
> --
> Thanks
> MingChao
>
--
*Sumit Agrawal* | Senior Staff Engineer
cloudera.com <https://www.cloudera.com>
[image: Cloudera] <https://www.cloudera.com/>
[image: Cloudera on Twitter] <https://twitter.com/cloudera> [image:
Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera
on LinkedIn] <https://www.linkedin.com/company/cloudera>
------------------------------
Re: [DISCUSS] How many days to wait if no response from reviewer?
Posted by mingchao zhao <ca...@apache.org>.
+1
Thanks Uma. Good idea.
On Wed, Feb 1, 2023 at 4:35 PM Ayush Saxena <ay...@gmail.com> wrote:
> +1,
> Makes sense,
> Thanx Uma for bringing this up. Maybe the number of days to wait can vary
> depending on the time of the year (vacations/weekends or so) and the
> criticality of the Jira (release blocker or so), just give enough
> opportunity to the reviewer to come back and that should be fine.
>
> -Ayush
>
> On Wed, 1 Feb 2023 at 12:32, Kaijie Chen <ck...@apache.org> wrote:
>
> > +1
> >
> > Thanks Uma for bring up this discussion.
> > Personally I think this should be a convention instead of a rule.
> >
> > ---- On Wed, 01 Feb 2023 07:16:37 +0800 Ritesh Shukla wrote ---
> > > +1 for this.
> > > We can wait to gather a broader consensus for certain rare cases where
> > we
> > > add new APIs or public changes but if the reviewer's original review
> > > comments were addressed then it should be ok to go ahead and merge
> post
> > a
> > > timeout value.
> > >
> > > On Tue, Jan 31, 2023 at 2:51 PM Uma Maheswara Rao Gangumalla <
> > > umamahesh@apache.org> wrote:
> > >
> > > > Dear Ozone Devs,
> > > >
> > > > This has been brought up by Ritesh in community sync. I thought we
> > could
> > > > discuss this more broadly and set up some path forwarding options.
> > > >
> > > > With my past experience, when a reviewer does not respond for a long
> > time
> > > > and if another reviewer helped to review, we will just give a few
> > days'
> > > > wait for the old reviewer to confirm his comments. If no further
> > responses
> > > > from the old reviewer, we used to move ahead.
> > > >
> > > > I think we can follow the similar approach:
> > > >
> > > > When the reviewer does not respond for a long time (say 15days? ):
> > > > The Author can freely ping other reviewers to help if no one
> else
> > > > reviewed it yet.
> > > > If the other reviewer is a committer and got +1 from him, then
> we
> > can
> > > > give a 3-7days time window for the old reviewer to check as a final
> > > > friendly reminder. If still no responses, then we can just move
> ahead
> > for
> > > > commit based new committer reviewer's +1.
> > > >
> > > > Thoughts?
> > > >
> > > > Regards,
> > > > Uma
> > > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> > For additional commands, e-mail: dev-help@ozone.apache.org
> >
> >
>
--
Thanks
MingChao
Re: [DISCUSS] How many days to wait if no response from reviewer?
Posted by Ayush Saxena <ay...@gmail.com>.
+1,
Makes sense,
Thanx Uma for bringing this up. Maybe the number of days to wait can vary
depending on the time of the year (vacations/weekends or so) and the
criticality of the Jira (release blocker or so), just give enough
opportunity to the reviewer to come back and that should be fine.
-Ayush
On Wed, 1 Feb 2023 at 12:32, Kaijie Chen <ck...@apache.org> wrote:
> +1
>
> Thanks Uma for bring up this discussion.
> Personally I think this should be a convention instead of a rule.
>
> ---- On Wed, 01 Feb 2023 07:16:37 +0800 Ritesh Shukla wrote ---
> > +1 for this.
> > We can wait to gather a broader consensus for certain rare cases where
> we
> > add new APIs or public changes but if the reviewer's original review
> > comments were addressed then it should be ok to go ahead and merge post
> a
> > timeout value.
> >
> > On Tue, Jan 31, 2023 at 2:51 PM Uma Maheswara Rao Gangumalla <
> > umamahesh@apache.org> wrote:
> >
> > > Dear Ozone Devs,
> > >
> > > This has been brought up by Ritesh in community sync. I thought we
> could
> > > discuss this more broadly and set up some path forwarding options.
> > >
> > > With my past experience, when a reviewer does not respond for a long
> time
> > > and if another reviewer helped to review, we will just give a few
> days'
> > > wait for the old reviewer to confirm his comments. If no further
> responses
> > > from the old reviewer, we used to move ahead.
> > >
> > > I think we can follow the similar approach:
> > >
> > > When the reviewer does not respond for a long time (say 15days? ):
> > > The Author can freely ping other reviewers to help if no one else
> > > reviewed it yet.
> > > If the other reviewer is a committer and got +1 from him, then we
> can
> > > give a 3-7days time window for the old reviewer to check as a final
> > > friendly reminder. If still no responses, then we can just move ahead
> for
> > > commit based new committer reviewer's +1.
> > >
> > > Thoughts?
> > >
> > > Regards,
> > > Uma
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
> For additional commands, e-mail: dev-help@ozone.apache.org
>
>