Re: Dataset Select Does Not Load

[mi...@gmail.com]

Ahhhh spotted it! 

When the variable is set, it is a Boolean. 

$scope.fileLoadFailed = true;

or

$scope.fileLoadFailed = false;

When it does the comparison, it does so on a string. 

if($scope.fileLoadFailed === 'false')

So it always fails.   

I'll put in a patch for this.  I also noticed the knmi bias example fails on a small bug in dataset_processor "global name size is not defined". I'll patch that at the same time. 

Sent from my iPhone

> On Jan 31, 2016, at 10:37, Omkar Reddy <om...@gmail.com> wrote:
> 
> Hello Michael,
>             What kind of local file did you try to load?? Because
> 'fileLoadFailed === false'  is the right condition because it suggests that
> file loading hasn't failed and only then it is queued. Please take a look
> at the code again.
> 
> Omkar.
> 
> 
>> On 31 January 2016 at 20:55, Omkar Reddy <om...@gmail.com> wrote:
>> 
>> Hello Michael,
>>    This patch was submitted by me last month. I have overlooked this
>> condition while submitting it. I will solve it ASAP.
>> Thanks for pointing it out.
>> 
>> Omkar.
>> 
>>> On 31 January 2016 at 18:43, <mi...@gmail.com> wrote:
>>> 
>>> The Dataset Select will not load my local data files. It just silently
>>> does nothing.
>>> 
>>> I notice that observations elect.js at line 182 says if file load failed
>>> === false.  This was added with Climate 407 last month.  This section of
>>> the code has the load of the file.
>>> 
>>> If I change this to file load failed !== false the file loads into the
>>> main page as expected.
>>> 
>>> Is this the correct reading of the conditional?
>>> 
>>> Sent from my iPhone
>> 
>> 
>>