You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/05/19 09:49:19 UTC

[GitHub] [ignite] korlov42 commented on a change in pull request #9109: IGNITE-14737 Equals predicate with multiple results from subqueries m…

korlov42 commented on a change in pull request #9109:
URL: https://github.com/apache/ignite/pull/9109#discussion_r635084669



##########
File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/FunctionsTest.java
##########
@@ -100,6 +100,9 @@ public void testRangeWithCache() throws Exception {
 
         awaitPartitionMapExchange();
 
+        GridTestUtils.assertThrowsWithCause(() -> checkQuery("SELECT t._key, (SELECT x FROM TABLE(system_range(1, 5))) FROM \"test\".Integer t").check(),

Review comment:
       I would prefer not to extend a random test with an additional check.
   
   It's better to extend `org.apache.ignite.internal.processors.query.calcite.exec.rel.BaseAggregateTest` with a few additional tests to verify singe_value accumulator behaviour.
   
   For integration tests there is `org.apache.ignite.internal.processors.query.calcite.AggregatesIntegrationTest`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org