You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jonaschn (via GitHub)" <gi...@apache.org> on 2024/08/27 10:59:10 UTC
[PR] fix(chords): display correct tooltip (fixes #3342) [superset]
jonaschn opened a new pull request, #30023:
URL: https://github.com/apache/superset/pull/30023
### SUMMARY
Fix #3342
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #3342
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(plugins): display correct tooltip (fixes #3342) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30023:
URL: https://github.com/apache/superset/pull/30023#issuecomment-2313362301
Agreed that it was wrong and that this fixes _the display_ of the chart, but I'm _so_ confused by the meaning of the diff. I mean, yes - swapping it swaps it, and that works. But now the code (modified by the diff) is
`${nodes[d.target.index]} → ${nodes[d.source.index]}` which displays the `source` column then `→` then the `target` column. How is this now _displaying_ correctly but with the items _named_ incorrectly? 🤯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(plugins): display correct tooltip (fixes #3342) [superset]
Posted by "jonaschn (via GitHub)" <gi...@apache.org>.
jonaschn commented on code in PR #30023:
URL: https://github.com/apache/superset/pull/30023#discussion_r1732988537
##########
superset-frontend/plugins/legacy-plugin-chart-chord/src/Chord.js:
##########
@@ -130,9 +130,9 @@ function Chord(element, props) {
.text(
d =>
`${nodes[d.source.index]} → ${nodes[d.target.index]}: ${f(
Review Comment:
The diff looks a bit misleading.
I simply swapped `d.source.value` and `d.target.value` (line 133 and 135)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(plugins): display correct tooltip (fixes #3342) [superset]
Posted by "jonaschn (via GitHub)" <gi...@apache.org>.
jonaschn commented on PR #30023:
URL: https://github.com/apache/superset/pull/30023#issuecomment-2314441290
Thanks for merging. When do you expect to release this change?
Will it be part of 4.1.0?
I would really appreciate it because our users were constantly confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(plugins): display correct tooltip (fixes #3342) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #30023:
URL: https://github.com/apache/superset/pull/30023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org