[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10123: style: replace broken glyphs with font-awesome

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #10123:
URL: https://github.com/apache/incubator-superset/pull/10123#discussion_r443245260



##########
File path: superset-frontend/src/explore/components/AdhocMetricOption.jsx
##########
@@ -53,7 +53,7 @@ export default class AdhocMetricOption extends React.PureComponent {
     // once the overlay has been opened, the metric/filter will never be
     // considered new again.
     this.props.adhocMetric.isNew = false;
-    this.setState({ overlayShown: false });
+    this.setState({ overlayShown: true });

Review comment:
       Is this related to the glyph changes? is it intentional?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org