You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/12/12 22:32:51 UTC

[GitHub] jon-wei opened a new pull request #6729: Use @Coordinator leader client in CoordinatorRuleManager

jon-wei opened a new pull request #6729: Use @Coordinator leader client in CoordinatorRuleManager
URL: https://github.com/apache/incubator-druid/pull/6729
 
 
   This changes the router's `CoordinatorRuleManager` to use the `DruidLeaderClient` annotated with `@Coordinator` for fetching rules, instead of a separate coordinator `DruidLeaderClient` created in `CliRouter`.
   
   This removes the `coordinatorServiceName` and `rulesEndpoint` properties from the router which were only used for that separate leader client:
   - coordinatorServiceName is redundant since we already have `druid.selectors.coordinator.serviceName`
   - I don't think the rules endpoint needs to be configurable, since it cannot be changed from the coordinator side
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org