You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ha...@apache.org on 2020/01/01 17:30:23 UTC
[royale-asjs] 05/08: Added sendEvent
This is an automated email from the ASF dual-hosted git repository.
harbs pushed a commit to branch feature/bead-base
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit 160087ae4b2ae0134c212cbe270fbc63246b9d6d
Author: Harbs <ha...@in-tools.com>
AuthorDate: Wed Jan 1 17:58:21 2020 +0200
Added sendEvent
---
frameworks/projects/Core/src/main/royale/CoreClasses.as | 3 ++-
.../src/main/royale/org/apache/royale/utils/sendBeadEvent.as | 4 +++-
.../org/apache/royale/utils/{sendBeadEvent.as => sendEvent.as} | 10 +++++-----
.../src/main/royale/org/apache/royale/utils/sendStrandEvent.as | 2 ++
4 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/frameworks/projects/Core/src/main/royale/CoreClasses.as b/frameworks/projects/Core/src/main/royale/CoreClasses.as
index 6fa00f4..6a6590e 100644
--- a/frameworks/projects/Core/src/main/royale/CoreClasses.as
+++ b/frameworks/projects/Core/src/main/royale/CoreClasses.as
@@ -318,8 +318,9 @@ internal class CoreClasses
import org.apache.royale.utils.date.addYears; addYears;
import org.apache.royale.utils.event.hasPlatformModifier; hasPlatformModifier;
- import org.apache.royale.utils.sendStrandEvent; sendStrandEvent;
+ import org.apache.royale.utils.sendEvent; sendEvent;
import org.apache.royale.utils.sendBeadEvent; sendBeadEvent;
+ import org.apache.royale.utils.sendStrandEvent; sendStrandEvent;
import org.apache.royale.utils.async.CompoundAsyncTask; CompoundAsyncTask;
import org.apache.royale.utils.async.SequentialAsyncTask; SequentialAsyncTask;
diff --git a/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/sendBeadEvent.as b/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/sendBeadEvent.as
index e7a3585..81dea3a 100644
--- a/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/sendBeadEvent.as
+++ b/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/sendBeadEvent.as
@@ -27,7 +27,9 @@ package org.apache.royale.utils
import org.apache.royale.events.IEventDispatcher;
/**
- * Helper function for dispatching events from the strand
+ * Helper function for dispatching events from the bead
+ * Using this function prevent the need to cast IBead objects
+ * It also allows better minification
* @royaleignorecoercion org.apache.royale.events.IEventDispatcher
*/
public function sendBeadEvent(bead:IBead,event:Object):void
diff --git a/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/sendBeadEvent.as b/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/sendEvent.as
similarity index 78%
copy from frameworks/projects/Core/src/main/royale/org/apache/royale/utils/sendBeadEvent.as
copy to frameworks/projects/Core/src/main/royale/org/apache/royale/utils/sendEvent.as
index e7a3585..fa4e3d2 100644
--- a/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/sendBeadEvent.as
+++ b/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/sendEvent.as
@@ -23,23 +23,23 @@ package org.apache.royale.utils
import flash.events.Event;
}
- import org.apache.royale.core.IBead;
import org.apache.royale.events.IEventDispatcher;
/**
- * Helper function for dispatching events from the strand
+ * Helper function for dispatching events
+ * Using this helper function enables better minification because `dispatchEvent` cannot be minified
* @royaleignorecoercion org.apache.royale.events.IEventDispatcher
*/
- public function sendBeadEvent(bead:IBead,event:Object):void
+ public function sendEvent(dispatcher:IEventDispatcher,event:Object):void
{
COMPILE::SWF{
if(event is String)
event = new flash.events.Event(event as String);
- (bead as IEventDispatcher).dispatchEvent(event as flash.events.Event);
+ (dispatcher as IEventDispatcher).dispatchEvent(event as flash.events.Event);
}
COMPILE::JS
{
- (bead as IEventDispatcher).dispatchEvent(event);
+ (dispatcher as IEventDispatcher).dispatchEvent(event);
}
}
}
\ No newline at end of file
diff --git a/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/sendStrandEvent.as b/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/sendStrandEvent.as
index 0fae94f..4b80671 100644
--- a/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/sendStrandEvent.as
+++ b/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/sendStrandEvent.as
@@ -28,6 +28,8 @@ package org.apache.royale.utils
/**
* Helper function for dispatching events from the strand
+ * Using this function prevent the need to cast IStrand objects
+ * It also allows better minification
* @royaleignorecoercion org.apache.royale.events.IEventDispatcher
*/
public function sendStrandEvent(strand:IStrand,event:Object):void