[GitHub] [pulsar] eolivelli commented on a change in pull request #12674: [pulsar-client] add pending-queue size metrics to producer stats

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #12674:
URL: https://github.com/apache/pulsar/pull/12674#discussion_r745087873



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerStatTest.java
##########
@@ -424,4 +424,22 @@ public void testAddBrokerLatencyStats() throws Exception {
         producer.close();
         log.info("-- Exiting {} test --", methodName);
     }
+
+    @Test
+    public void testProducerPendingQueueSizeStats() throws Exception {
+        log.info("-- Starting {} test --", methodName);
+        ProducerBuilder<byte[]> producerBuilder = pulsarClient.newProducer()
+                .topic("persistent://my-property/tp1/my-ns/my-topic1");
+
+        Producer<byte[]> producer = producerBuilder.enableBatching(false).create();

Review comment:
       What about adding @Cleanup ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org