You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mehul Parikh <xs...@gmail.com> on 2021/07/13 04:22:57 UTC

Re: Review Request 73437: RANGER-3324: Best Practices: Make optimised db schema script idempotent for all DB Flavors.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73437/#review223217
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On June 30, 2021, 8:27 a.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73437/
> -----------------------------------------------------------
> 
> (Updated June 30, 2021, 8:27 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, Vishal Suvagia, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3324
>     https://issues.apache.org/jira/browse/RANGER-3324
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> **Problem Statement:** Currently Ranger core db schema is not idempotent for all db flavors. Ranger core DB schema for MySQL and MS-SQL flavor may fail to execute if we execute them again.
> 
> Few identifier names have more than 30 characters which is not allowed in oracle 11G, so we have to trim the name of index/identifier.
> 
> **Proposed solution:** Changed the statements of schema script as per their dependencies on other table.
> have to trim the name of index/identifier for oracle db flavor.
> 
> 
> Diffs
> -----
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql c16a189dd 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql e92f5cc48 
>   security-admin/db/oracle/patches/052-add-unique-constraint-on-change-logs.sql 8c0672074 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 91751a27d 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 4a1d5f44c 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 4535b68b7 
> 
> 
> Diff: https://reviews.apache.org/r/73437/diff/1/
> 
> 
> Testing
> -------
> 
> Tested fresh installation of ranger with all DB flavors(except sql-anywhere)
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>