You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/11/21 17:21:00 UTC
[jira] [Work logged] (AMQ-9398) Fix Jakarta EE 10 support via xml wiring for activmeq-ra
[ https://issues.apache.org/jira/browse/AMQ-9398?focusedWorklogId=891617&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891617 ]
ASF GitHub Bot logged work on AMQ-9398:
---------------------------------------
Author: ASF GitHub Bot
Created on: 21/Nov/23 17:20
Start Date: 21/Nov/23 17:20
Worklog Time Spent: 10m
Work Description: cshannon commented on code in PR #1123:
URL: https://github.com/apache/activemq/pull/1123#discussion_r1400927133
##########
activemq-ra/src/main/java/org/apache/activemq/ra/ActiveMQActivationSpec.java:
##########
@@ -147,25 +147,19 @@ public void validate() throws InvalidPropertyException {
}
public boolean isValidUseRAManagedTransaction(List<String> errorMessages) {
- try {
- new Boolean(useRAManagedTransaction);
- return true;
- } catch (Throwable e) {
- //
+ boolean retVal = Boolean.valueOf(useRAManagedTransaction);
+ if(!retVal) {
+ errorMessages.add("useRAManagedTransaction must be set to: true or false.");
}
- errorMessages.add("useRAManagedTransaction must be set to: true or false.");
Review Comment:
This seems wrong as this will add an error message even for "false"
Issue Time Tracking
-------------------
Worklog Id: (was: 891617)
Time Spent: 20m (was: 10m)
> Fix Jakarta EE 10 support via xml wiring for activmeq-ra
> --------------------------------------------------------
>
> Key: AMQ-9398
> URL: https://issues.apache.org/jira/browse/AMQ-9398
> Project: ActiveMQ
> Issue Type: New Feature
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Minor
> Fix For: 6.0.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I did a simple test by placing the files in the deployments directory on a Wildfly 28 server (since that is how the resource adapter is deployed on my older Wildfly server) but I got the following errors:
> 2023-11-21 10:08:21,890 INFO [org.jboss.as.server.deployment] (MSC service thread 1-4) WFLYSRV0027: Starting deployment of "activemq-rar-6.0.0.rar" (runtime-name: "activemq-rar-6.0.0.rar")
> 2023-11-21 10:08:23,425 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-2) MSC000001: Failed to start service jboss.deployment.unit."activemq-rar-6.0.0.rar".PARSE: org.jboss.msc.service.StartException in service jboss.deployment.unit."activemq-rar-6.0.0.rar".PARSE: WFLYSRV0153: Failed to process phase PARSE of deployment "activemq-rar-6.0.0.rar"
> at org.jboss.as.server@20.0.1.Final//org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:189)
> at org.jboss.msc@1.5.0.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1590)
> at org.jboss.msc@1.5.0.Final//org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1553)
> at org.jboss.msc@1.5.0.Final//org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1411)
> at org.jboss.threads@2.4.0.Final//org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
> at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990)
> at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486)
> at org.jboss.threads@2.4.0.Final//org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377)
> at java.base/java.lang.Thread.run(Thread.java:833)
> Caused by: org.jboss.as.server.deployment.DeploymentUnitProcessingException: WFLYJCA0043: Failed to parse service xml ["/content/activemq-rar-6.0.0.rar/META-INF/ra.xml"]
> at org.jboss.as.connector@28.0.0.Final//org.jboss.as.connector.deployers.ra.processors.RaDeploymentParsingProcessor.process(RaDeploymentParsingProcessor.java:123)
> at org.jboss.as.connector@28.0.0.Final//org.jboss.as.connector.deployers.ra.processors.RaDeploymentParsingProcessor.deploy(RaDeploymentParsingProcessor.java:91)
> at org.jboss.as.server@20.0.1.Final//org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:182)
> ... 8 more
> Caused by: java.lang.IllegalArgumentException: fullQualifiedName should be one of jakarta.resource.spi.security.PasswordCredential; org.ietf.jgss.GSSCredential;jakarta.resource.spi.security.GenericCredential
> at org.jboss.ironjacamar.api@3.0.2.Final//org.jboss.jca.common.api.metadata.spec.CredentialInterfaceEnum.forName(CredentialInterfaceEnum.java:89)
> at org.jboss.ironjacamar.impl@3.0.2.Final//org.jboss.jca.common.metadata.spec.RaParser.parseAuthenticationMechanism(RaParser.java:1451)
> at org.jboss.ironjacamar.impl@3.0.2.Final//org.jboss.jca.common.metadata.spec.RaParser.parseOutboundResourceadapter(RaParser.java:1308)
> at org.jboss.ironjacamar.impl@3.0.2.Final//org.jboss.jca.common.metadata.spec.RaParser.parseResourceAdapter(RaParser.java:868)
> at org.jboss.ironjacamar.impl@3.0.2.Final//org.jboss.jca.common.metadata.spec.RaParser.parseConnector15(RaParser.java:360)
> at org.jboss.ironjacamar.impl@3.0.2.Final//org.jboss.jca.common.metadata.spec.RaParser.parse(RaParser.java:173)
> at org.jboss.ironjacamar.impl@3.0.2.Final//org.jboss.jca.common.metadata.spec.RaParser.parse(RaParser.java:86)
> at org.jboss.as.connector@28.0.0.Final//org.jboss.as.connector.deployers.ra.processors.RaDeploymentParsingProcessor.process(RaDeploymentParsingProcessor.java:114)
> ... 10 more
> When looking inside ra.xml I see several references to javax classes (e.g. javax.resource.spi.security.PasswordCredential). According to earlier answers, the next release of ActiveMQ 5.x should have full jakarta support, including the resource adapter. Is this still true or have there been some change in planning? Or do I need to do something else to be able to use the resource adapter?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)