You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/23 14:53:41 UTC
[GitHub] [rocketmq-client-go] wysobj opened a new pull request, #978: fix issue #977
wysobj opened a new pull request, #978:
URL: https://github.com/apache/rocketmq-client-go/pull/978
## What is the purpose of the change
bugfix
## Brief changelog
when consume failed in broadcasting mode, we still update the offset by the correct message list.
## Verifying this change
offset is correctly updated for broadcasting mode when consume failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #978: [ISSUE #977] update offset for broadcasting mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #978:
URL: https://github.com/apache/rocketmq-client-go/pull/978#issuecomment-1364034951
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/978?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#978](https://codecov.io/gh/apache/rocketmq-client-go/pull/978?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4f09e5) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/896a8a3453be4bcfcb5bfb5bb9139c4df6d4cdab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (896a8a3) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #978 +/- ##
==========================================
- Coverage 23.32% 23.32% -0.01%
==========================================
Files 52 52
Lines 7266 7267 +1
==========================================
Hits 1695 1695
- Misses 5339 5340 +1
Partials 232 232
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/978?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/978/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `12.54% <0.00%> (-0.02%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org