You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2017/05/12 22:41:21 UTC
Review Request 59247: Ranger plugins should use default service-def
when it fails to obtain from Ranger Admin or cache
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59247/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-1578
https://issues.apache.org/jira/browse/RANGER-1578
Repository: ranger
Description
-------
If the plugin fails to obtain the service-def from Ranger Admin (or from local-cache), plugin is initialized with a default version of service-def - against which the plugin was developed.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java 508ef93
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 5b13a2f
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 295272d
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java c5a4244
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 8f6311e
Diff: https://reviews.apache.org/r/59247/diff/1/
Testing
-------
In an Ambari deployed cluster: enabled Ranger for hive, and ensured that the hive component cannot download policies from Ranger-admin. Tested ranger-plugin by executing hive commands through beeline command-line tool and verified that a. access to hive resource was denied, and b. audit log records were created, and viewable through ranger-admin GUI.
Thanks,
Abhay Kulkarni
Re: Review Request 59247: Ranger plugins should use default
service-def when it fails to obtain from Ranger Admin or cache
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59247/#review174870
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
Lines 198 (patched)
<https://reviews.apache.org/r/59247/#comment248084>
Consider moving this to "default" case above.
- Madhan Neethiraj
On May 12, 2017, 10:41 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59247/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 10:41 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-1578
> https://issues.apache.org/jira/browse/RANGER-1578
>
>
> Repository: ranger
>
>
> Description
> -------
>
> If the plugin fails to obtain the service-def from Ranger Admin (or from local-cache), plugin is initialized with a default version of service-def - against which the plugin was developed.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java 508ef93
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 5b13a2f
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 295272d
> agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java c5a4244
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 8f6311e
>
>
> Diff: https://reviews.apache.org/r/59247/diff/1/
>
>
> Testing
> -------
>
> In an Ambari deployed cluster: enabled Ranger for hive, and ensured that the hive component cannot download policies from Ranger-admin. Tested ranger-plugin by executing hive commands through beeline command-line tool and verified that a. access to hive resource was denied, and b. audit log records were created, and viewable through ranger-admin GUI.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 59247: Ranger plugins should use default
service-def when it fails to obtain from Ranger Admin or cache
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59247/#review174872
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On May 12, 2017, 11:54 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59247/
> -----------------------------------------------------------
>
> (Updated May 12, 2017, 11:54 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-1578
> https://issues.apache.org/jira/browse/RANGER-1578
>
>
> Repository: ranger
>
>
> Description
> -------
>
> If the plugin fails to obtain the service-def from Ranger Admin (or from local-cache), plugin is initialized with a default version of service-def - against which the plugin was developed.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java 508ef93
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 5b13a2f
> agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 295272d
> agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java c5a4244
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 8f6311e
>
>
> Diff: https://reviews.apache.org/r/59247/diff/2/
>
>
> Testing
> -------
>
> In an Ambari deployed cluster: enabled Ranger for hive, and ensured that the hive component cannot download policies from Ranger-admin. Tested ranger-plugin by executing hive commands through beeline command-line tool and verified that a. access to hive resource was denied, and b. audit log records were created, and viewable through ranger-admin GUI.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 59247: Ranger plugins should use default
service-def when it fails to obtain from Ranger Admin or cache
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59247/
-----------------------------------------------------------
(Updated May 12, 2017, 11:54 p.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
Addressed review comment.
Bugs: RANGER-1578
https://issues.apache.org/jira/browse/RANGER-1578
Repository: ranger
Description
-------
If the plugin fails to obtain the service-def from Ranger Admin (or from local-cache), plugin is initialized with a default version of service-def - against which the plugin was developed.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java 508ef93
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 5b13a2f
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java 295272d
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java c5a4244
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java 8f6311e
Diff: https://reviews.apache.org/r/59247/diff/2/
Changes: https://reviews.apache.org/r/59247/diff/1-2/
Testing
-------
In an Ambari deployed cluster: enabled Ranger for hive, and ensured that the hive component cannot download policies from Ranger-admin. Tested ranger-plugin by executing hive commands through beeline command-line tool and verified that a. access to hive resource was denied, and b. audit log records were created, and viewable through ranger-admin GUI.
Thanks,
Abhay Kulkarni