You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@click.apache.org by "Bob Schellink (JIRA)" <ji...@apache.org> on 2009/12/28 06:40:29 UTC
[jira] Created: (CLK-599) Support private and protected bindable
variables
Support private and protected bindable variables
------------------------------------------------
Key: CLK-599
URL: https://issues.apache.org/jira/browse/CLK-599
Project: Click
Issue Type: Improvement
Components: core
Affects Versions: 2.1.0 RC1
Reporter: Bob Schellink
Assignee: Malcolm Edgar
Fix For: 2.1.0
A common complaint against Apache Click is its use of public bindable variables.
Would be good if Click supports binding of private and protected variables as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (CLK-599) Support private and protected bindable
variables
Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Schellink reopened CLK-599:
-------------------------------
I received the following exception when trying to edit a customer in the advanced-form example:
java.lang.IllegalAccessException: Class ognl.OgnlRuntime can not access a member of class org.apache.click.examples.page.EditCustomer with modifiers "protected"
at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:65)
at java.lang.reflect.Field.doSecurityCheck(Field.java:960)
at java.lang.reflect.Field.getFieldAccessor(Field.java:896)
at java.lang.reflect.Field.set(Field.java:657)
at ognl.OgnlRuntime.setFieldValue(OgnlRuntime.java:1154)
at ognl.ObjectPropertyAccessor.setPossibleProperty(ObjectPropertyAccessor.java:76)
at ognl.ObjectPropertyAccessor.setProperty(ObjectPropertyAccessor.java:131)
at ognl.OgnlRuntime.setProperty(OgnlRuntime.java:1670)
at ognl.ASTProperty.setValueBody(ASTProperty.java:101)
at ognl.SimpleNode.evaluateSetValueBody(SimpleNode.java:177)
at ognl.SimpleNode.setValue(SimpleNode.java:246)
at ognl.Ognl.setValue(Ognl.java:476)
at org.apache.click.util.PropertyUtils.setValueOgnl(PropertyUtils.java:170)
at org.apache.click.ClickServlet.processPageRequestParams(ClickServlet.java:1167)
at org.apache.click.ClickServlet.initPage(ClickServlet.java:1107)
at org.apache.click.ClickServlet.createPage(ClickServlet.java:928)
at org.apache.click.ClickServlet.handleRequest(ClickServlet.java:347)
at org.apache.click.ClickServlet.doGet(ClickServlet.java:261)
> Support private and protected bindable variables
> ------------------------------------------------
>
> Key: CLK-599
> URL: https://issues.apache.org/jira/browse/CLK-599
> Project: Click
> Issue Type: Improvement
> Components: core
> Affects Versions: 2.1.0 RC1
> Reporter: Bob Schellink
> Assignee: Malcolm Edgar
> Fix For: 2.1.0
>
>
> A common complaint against Apache Click is its use of public bindable variables.
> Would be good if Click supports binding of private and protected variables as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLK-599) Support private and protected bindable
variables
Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804069#action_12804069 ]
Bob Schellink commented on CLK-599:
-----------------------------------
Fix checked in.
@Malcolm, you might want to double check this fix for thread safety. You can view the changes here:
http://svn.apache.org/viewvc/incubator/click/trunk/click/framework/src/org/apache/click/ClickServlet.java?r1=900775&r2=902382&diff_format=h
I've also made a slight change to XmlConfigService to only load parent classes up to but excluding Page.class.
http://svn.apache.org/viewvc/incubator/click/trunk/click/framework/src/org/apache/click/service/XmlConfigService.java?r1=893922&r2=902382&diff_format=h
> Support private and protected bindable variables
> ------------------------------------------------
>
> Key: CLK-599
> URL: https://issues.apache.org/jira/browse/CLK-599
> Project: Click
> Issue Type: Improvement
> Components: core
> Affects Versions: 2.1.0 RC1
> Reporter: Bob Schellink
> Assignee: Malcolm Edgar
> Fix For: 2.1.0
>
>
> A common complaint against Apache Click is its use of public bindable variables.
> Would be good if Click supports binding of private and protected variables as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CLK-599) Support private and protected bindable
variables
Posted by "Malcolm Edgar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Malcolm Edgar resolved CLK-599.
-------------------------------
Resolution: Fixed
Have updated examples and documentation to use protected visibility bindable fields
> Support private and protected bindable variables
> ------------------------------------------------
>
> Key: CLK-599
> URL: https://issues.apache.org/jira/browse/CLK-599
> Project: Click
> Issue Type: Improvement
> Components: core
> Affects Versions: 2.1.0 RC1
> Reporter: Bob Schellink
> Assignee: Malcolm Edgar
> Fix For: 2.1.0
>
>
> A common complaint against Apache Click is its use of public bindable variables.
> Would be good if Click supports binding of private and protected variables as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CLK-599) Support private and
protected bindable variables
Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802804#action_12802804 ]
Bob Schellink edited comment on CLK-599 at 1/20/10 12:14 PM:
-------------------------------------------------------------
I received the following exception when trying to edit a customer in the advanced-table example:
java.lang.IllegalAccessException: Class ognl.OgnlRuntime can not access a member of class org.apache.click.examples.page.EditCustomer with modifiers "protected"
at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:65)
at java.lang.reflect.Field.doSecurityCheck(Field.java:960)
at java.lang.reflect.Field.getFieldAccessor(Field.java:896)
at java.lang.reflect.Field.set(Field.java:657)
at ognl.OgnlRuntime.setFieldValue(OgnlRuntime.java:1154)
at ognl.ObjectPropertyAccessor.setPossibleProperty(ObjectPropertyAccessor.java:76)
at ognl.ObjectPropertyAccessor.setProperty(ObjectPropertyAccessor.java:131)
at ognl.OgnlRuntime.setProperty(OgnlRuntime.java:1670)
at ognl.ASTProperty.setValueBody(ASTProperty.java:101)
at ognl.SimpleNode.evaluateSetValueBody(SimpleNode.java:177)
at ognl.SimpleNode.setValue(SimpleNode.java:246)
at ognl.Ognl.setValue(Ognl.java:476)
at org.apache.click.util.PropertyUtils.setValueOgnl(PropertyUtils.java:170)
at org.apache.click.ClickServlet.processPageRequestParams(ClickServlet.java:1167)
at org.apache.click.ClickServlet.initPage(ClickServlet.java:1107)
at org.apache.click.ClickServlet.createPage(ClickServlet.java:928)
at org.apache.click.ClickServlet.handleRequest(ClickServlet.java:347)
at org.apache.click.ClickServlet.doGet(ClickServlet.java:261)
was (Author: sabob):
I received the following exception when trying to edit a customer in the advanced-form example:
java.lang.IllegalAccessException: Class ognl.OgnlRuntime can not access a member of class org.apache.click.examples.page.EditCustomer with modifiers "protected"
at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:65)
at java.lang.reflect.Field.doSecurityCheck(Field.java:960)
at java.lang.reflect.Field.getFieldAccessor(Field.java:896)
at java.lang.reflect.Field.set(Field.java:657)
at ognl.OgnlRuntime.setFieldValue(OgnlRuntime.java:1154)
at ognl.ObjectPropertyAccessor.setPossibleProperty(ObjectPropertyAccessor.java:76)
at ognl.ObjectPropertyAccessor.setProperty(ObjectPropertyAccessor.java:131)
at ognl.OgnlRuntime.setProperty(OgnlRuntime.java:1670)
at ognl.ASTProperty.setValueBody(ASTProperty.java:101)
at ognl.SimpleNode.evaluateSetValueBody(SimpleNode.java:177)
at ognl.SimpleNode.setValue(SimpleNode.java:246)
at ognl.Ognl.setValue(Ognl.java:476)
at org.apache.click.util.PropertyUtils.setValueOgnl(PropertyUtils.java:170)
at org.apache.click.ClickServlet.processPageRequestParams(ClickServlet.java:1167)
at org.apache.click.ClickServlet.initPage(ClickServlet.java:1107)
at org.apache.click.ClickServlet.createPage(ClickServlet.java:928)
at org.apache.click.ClickServlet.handleRequest(ClickServlet.java:347)
at org.apache.click.ClickServlet.doGet(ClickServlet.java:261)
> Support private and protected bindable variables
> ------------------------------------------------
>
> Key: CLK-599
> URL: https://issues.apache.org/jira/browse/CLK-599
> Project: Click
> Issue Type: Improvement
> Components: core
> Affects Versions: 2.1.0 RC1
> Reporter: Bob Schellink
> Assignee: Malcolm Edgar
> Fix For: 2.1.0
>
>
> A common complaint against Apache Click is its use of public bindable variables.
> Would be good if Click supports binding of private and protected variables as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.