You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "mayya-sharipova (via GitHub)" <gi...@apache.org> on 2024/07/11 13:07:23 UTC
[PR] Add IntervalsSource for range and regexp queries [lucene]
mayya-sharipova opened a new pull request, #13562:
URL: https://github.com/apache/lucene/pull/13562
We already have convenient functions for contructing IntervalsSource for wildcard and fuzzy functions. This adds functions for regexp and range as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add IntervalsSource for range and regexp queries [lucene]
Posted by "romseygeek (via GitHub)" <gi...@apache.org>.
romseygeek commented on code in PR #13562:
URL: https://github.com/apache/lucene/pull/13562#discussion_r1674172561
##########
lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java:
##########
@@ -206,6 +210,91 @@ public static IntervalsSource wildcard(BytesRef wildcard, int maxExpansions) {
return new MultiTermIntervalsSource(ca, maxExpansions, wildcard.utf8ToString());
}
+ /**
+ * Return an {@link IntervalsSource} over the disjunction of all terms that match a regular
+ * expression
+ *
+ * <p>WARNING: Setting {@code maxExpansions} to higher than the default value of {@link
Review Comment:
This line doesn't need to be on this method
##########
lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java:
##########
@@ -206,6 +210,91 @@ public static IntervalsSource wildcard(BytesRef wildcard, int maxExpansions) {
return new MultiTermIntervalsSource(ca, maxExpansions, wildcard.utf8ToString());
}
+ /**
+ * Return an {@link IntervalsSource} over the disjunction of all terms that match a regular
+ * expression
+ *
+ * <p>WARNING: Setting {@code maxExpansions} to higher than the default value of {@link
+ * #DEFAULT_MAX_EXPANSIONS} can be both slow and memory-intensive
+ *
+ * @param regexp regula expression
+ * @throws IllegalStateException if the regex expands to more than {@link #DEFAULT_MAX_EXPANSIONS}
+ * terms
+ * @see RegexpQuery for regexp format
+ */
+ public static IntervalsSource regexp(BytesRef regexp) {
+ return regexp(regexp, DEFAULT_MAX_EXPANSIONS);
+ }
+
+ /**
+ * Expert: Return an {@link IntervalsSource} over the disjunction of all terms that match a
+ * regular expression
+ *
+ * <p>WARNING: Setting {@code maxExpansions} to higher than the default value of {@link
+ * #DEFAULT_MAX_EXPANSIONS} can be both slow and memory-intensive
+ *
+ * @param regexp regula expression
Review Comment:
```suggestion
* @param regexp regular expression
```
##########
lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java:
##########
@@ -206,6 +210,91 @@ public static IntervalsSource wildcard(BytesRef wildcard, int maxExpansions) {
return new MultiTermIntervalsSource(ca, maxExpansions, wildcard.utf8ToString());
}
+ /**
+ * Return an {@link IntervalsSource} over the disjunction of all terms that match a regular
+ * expression
+ *
+ * <p>WARNING: Setting {@code maxExpansions} to higher than the default value of {@link
+ * #DEFAULT_MAX_EXPANSIONS} can be both slow and memory-intensive
+ *
+ * @param regexp regula expression
Review Comment:
```suggestion
* @param regexp regular expression
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add IntervalsSource for range and regexp queries [lucene]
Posted by "mayya-sharipova (via GitHub)" <gi...@apache.org>.
mayya-sharipova commented on code in PR #13562:
URL: https://github.com/apache/lucene/pull/13562#discussion_r1677132855
##########
lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java:
##########
@@ -206,6 +210,91 @@ public static IntervalsSource wildcard(BytesRef wildcard, int maxExpansions) {
return new MultiTermIntervalsSource(ca, maxExpansions, wildcard.utf8ToString());
}
+ /**
+ * Return an {@link IntervalsSource} over the disjunction of all terms that match a regular
+ * expression
+ *
+ * <p>WARNING: Setting {@code maxExpansions} to higher than the default value of {@link
Review Comment:
@romseygeek Thanks for feedback. Very nice to see you again. Addressed in bdc43c7256da8dc178ec33d307d18d47de80ebeb
##########
lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java:
##########
@@ -206,6 +210,91 @@ public static IntervalsSource wildcard(BytesRef wildcard, int maxExpansions) {
return new MultiTermIntervalsSource(ca, maxExpansions, wildcard.utf8ToString());
}
+ /**
+ * Return an {@link IntervalsSource} over the disjunction of all terms that match a regular
+ * expression
+ *
+ * <p>WARNING: Setting {@code maxExpansions} to higher than the default value of {@link
+ * #DEFAULT_MAX_EXPANSIONS} can be both slow and memory-intensive
+ *
+ * @param regexp regula expression
+ * @throws IllegalStateException if the regex expands to more than {@link #DEFAULT_MAX_EXPANSIONS}
+ * terms
+ * @see RegexpQuery for regexp format
+ */
+ public static IntervalsSource regexp(BytesRef regexp) {
+ return regexp(regexp, DEFAULT_MAX_EXPANSIONS);
+ }
+
+ /**
+ * Expert: Return an {@link IntervalsSource} over the disjunction of all terms that match a
+ * regular expression
+ *
+ * <p>WARNING: Setting {@code maxExpansions} to higher than the default value of {@link
+ * #DEFAULT_MAX_EXPANSIONS} can be both slow and memory-intensive
+ *
+ * @param regexp regula expression
Review Comment:
Addressed in bdc43c7256da8dc178ec33d307d18d47de80ebebbdc43c7256da8dc178ec33d307d18d47de80ebeb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add IntervalsSource for range and regexp queries [lucene]
Posted by "mayya-sharipova (via GitHub)" <gi...@apache.org>.
mayya-sharipova commented on PR #13562:
URL: https://github.com/apache/lucene/pull/13562#issuecomment-2227356227
@romseygeek @dweiss Thank you for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add IntervalsSource for range and regexp queries [lucene]
Posted by "mayya-sharipova (via GitHub)" <gi...@apache.org>.
mayya-sharipova commented on code in PR #13562:
URL: https://github.com/apache/lucene/pull/13562#discussion_r1677132919
##########
lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java:
##########
@@ -206,6 +210,91 @@ public static IntervalsSource wildcard(BytesRef wildcard, int maxExpansions) {
return new MultiTermIntervalsSource(ca, maxExpansions, wildcard.utf8ToString());
}
+ /**
+ * Return an {@link IntervalsSource} over the disjunction of all terms that match a regular
+ * expression
+ *
+ * <p>WARNING: Setting {@code maxExpansions} to higher than the default value of {@link
+ * #DEFAULT_MAX_EXPANSIONS} can be both slow and memory-intensive
+ *
+ * @param regexp regula expression
+ * @throws IllegalStateException if the regex expands to more than {@link #DEFAULT_MAX_EXPANSIONS}
+ * terms
+ * @see RegexpQuery for regexp format
+ */
+ public static IntervalsSource regexp(BytesRef regexp) {
+ return regexp(regexp, DEFAULT_MAX_EXPANSIONS);
+ }
+
+ /**
+ * Expert: Return an {@link IntervalsSource} over the disjunction of all terms that match a
+ * regular expression
+ *
+ * <p>WARNING: Setting {@code maxExpansions} to higher than the default value of {@link
+ * #DEFAULT_MAX_EXPANSIONS} can be both slow and memory-intensive
+ *
+ * @param regexp regula expression
Review Comment:
Addressed in bdc43c7256da8dc178ec33d307d18d47de80ebeb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add IntervalsSource for range and regexp queries [lucene]
Posted by "mayya-sharipova (via GitHub)" <gi...@apache.org>.
mayya-sharipova merged PR #13562:
URL: https://github.com/apache/lucene/pull/13562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org