[jira] [Resolved] (VELTOOLS-168) LinkTool doesn't handle appending params properly

["Claude Brisson (JIRA)" <de...@velocity.apache.org>]

     [ https://issues.apache.org/jira/browse/VELTOOLS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claude Brisson resolved VELTOOLS-168.
-------------------------------------
       Resolution: Fixed
         Assignee: Claude Brisson
    Fix Version/s: 3.0

LinkTool's internal query Map should never contain arrays.

Fixed by commit 1834387.

> LinkTool doesn't handle appending params properly
> -------------------------------------------------
>
>                 Key: VELTOOLS-168
>                 URL: https://issues.apache.org/jira/browse/VELTOOLS-168
>             Project: Velocity Tools
>          Issue Type: Bug
>            Reporter: Hudson S
>            Assignee: Claude Brisson
>            Priority: Major
>             Fix For: 3.0
>
>
> When using the LinkTool (generic) to append parameters, the call to appendParam(String, key, String value) uses instanceof to see if the parameter to append to is a List object, but the query is populated with Array objects from request.getParameterMap(). 
> Just need to change generic.LinkTool.java:547 from 'if (cur instanceof List)' to 'if (cur instanceof List || cur instanceof Array)'. 
> Call to addToList already handles List vs Arrays, so I don't think any other changes need to be put in place.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org