You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/21 19:49:34 UTC

[GitHub] [incubator-nuttx] fjpanag opened a new pull request, #6682: Fixed path calculation in BBS RAM.

fjpanag opened a new pull request, #6682:
URL: https://github.com/apache/incubator-nuttx/pull/6682

   ## Summary
   
   Various improvements in calculation of the device path for the backup-RAM.  
   The same algorithm was used in STM32, STM32F7, STM32H7 & RX65N.
   
   * The maximum size calculation was wrong, and allowed for a buffer overflow.
   * The whole trick with `strncpy` and `strcat`, was unnecessary and dangerous.
   * Fixes a compiler warning (about `strncpy`).
   * We also got rid of 32 bytes of stack usage :)
   
   ## Impact
   
   Usage of the backup RAM is safer now.
   
   ## Testing
   
   Tested on a custom target using the STM32F427.
   I checked the produced path with my debugger, and it is correct.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6682: Fixed path calculation in BBS RAM.

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6682:
URL: https://github.com/apache/incubator-nuttx/pull/6682


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org