[GitHub] [arrow-rs] tustvold commented on pull request #1555: fix infinite loop in not fully packed bit-packed runs

[GitBox <gi...@apache.org>]

tustvold commented on PR #1555:
URL: https://github.com/apache/arrow-rs/pull/1555#issuecomment-1100107482

   > I found one in the DeltaBitPackedEncoder that maybe has a similar problem:
   
   In this case the specification is very clear that the miniblock can't be truncated
   
   > If there are not enough values to fill the last miniblock, we pad the miniblock so that its length is always the number of values in a full miniblock multiplied by the bit width. The values of the padding bits should be zero, but readers must accept paddings consisting of arbitrary bits as well.
   
   And we return an error a line below if it is, so I think we should be ok.
   
   Good shout to check though :+1: 
   
   The other cases don't appear to have loops, and GenericColumnReader which drives them will bail out if a page is truncated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org