You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2020/04/23 23:24:38 UTC
[Impala-ASF-CR] IMPALA-9609: Minimize Frontend activity in executor only impalads
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15793
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads
......................................................................
IMPALA-9609: Minimize Frontend activity in executor only impalads
Until now the Frontend started fully regardless of flag is_coordinator,
e.g. created connections to the HMS, which is both error prone and can
DoS the metastore.
Executor only impalads still need a JVM as queries can contain
java calls (HDFS/Hbase API calls, Hive UDFs).
Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M tests/custom_cluster/test_coordinators.py
3 files changed, 29 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/15793/1
--
To view, visit http://gerrit.cloudera.org:8080/15793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Gerrit-Change-Number: 15793
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-9609: Minimize Frontend activity in executor only impalads
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads
......................................................................
Patch Set 3: Code-Review+1
Changes LGTM.
--
To view, visit http://gerrit.cloudera.org:8080/15793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Gerrit-Change-Number: 15793
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2020 15:46:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9609: Minimize Frontend activity in executor only impalads
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads
......................................................................
IMPALA-9609: Minimize Frontend activity in executor only impalads
Until now the Frontend started fully regardless of flag is_coordinator,
e.g. created connections to the HMS, which is both error prone and can
DoS the metastore. (note that even coordinators started to connect to
HMS only in the recent past, related to local catalog mode and ACID
transactions)
Executor only impalads still need a JVM as queries can contain
java calls (HDFS/Hbase API calls, Hive UDFs), but most of the JNI API
provided by JniFrontend shouldn't be called by executors. It seems
that the whole Frontend object is needed only by coordinators.
Testing:
- generally executor only mode doesn't seem to be well covered
- ran test_coordinators.py which has some tests with executor only
impalads
- added new test for HBase tables (Hive UDFs and HDFS were already
covered)
Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
---
M be/src/runtime/exec-env.cc
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M tests/custom_cluster/test_coordinators.py
4 files changed, 63 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/15793/3
--
To view, visit http://gerrit.cloudera.org:8080/15793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Gerrit-Change-Number: 15793
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9609: Minimize Frontend activity in executor only impalads
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads
......................................................................
Patch Set 2:
(1 comment)
Thanks for fixing this, it should help a lot.
http://gerrit.cloudera.org:8080/#/c/15793/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java
File fe/src/main/java/org/apache/impala/service/JniFrontend.java:
http://gerrit.cloudera.org:8080/#/c/15793/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@191
PS2, Line 191: ExecutorMembershipSnapshot.update(req);
Removing the indirection makes sense. Can we go further and just not do the JNI call at all when it's not a coordinator (i.e. skip calling SendClusterMembershipToFrontend()) be/src/runtime/exec-env.cc
--
To view, visit http://gerrit.cloudera.org:8080/15793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Gerrit-Change-Number: 15793
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2020 00:30:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9609: Minimize Frontend activity in executor only impalads
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15793/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java
File fe/src/main/java/org/apache/impala/service/JniFrontend.java:
http://gerrit.cloudera.org:8080/#/c/15793/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@146
PS2, Line 146: frontend_ = null;
With this set to null, to be safe it would be good to add Preconditions not null check for references to frontend_. The downside is it makes the code ugly since there are lot of references. It almost seems like you need a coordinator-only CoordJniFrontEnd that extends a BaseJniFrontEnd. The executors could only instantiate the BaseJniFrontend.
--
To view, visit http://gerrit.cloudera.org:8080/15793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Gerrit-Change-Number: 15793
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2020 00:44:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9609: Minimize Frontend activity in executor only impalads
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5869/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Gerrit-Change-Number: 15793
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2020 15:26:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9609: Minimize Frontend activity in executor only impalads
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15793
to look at the new patch set (#2).
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads
......................................................................
IMPALA-9609: Minimize Frontend activity in executor only impalads
Until now the Frontend started fully regardless of flag is_coordinator,
e.g. created connections to the HMS, which is both error prone and can
DoS the metastore. (note that even coordinators started to connect to
HMS only in the recent past, related to local catalog mode and ACID
transactions)
Executor only impalads still need a JVM as queries can contain
java calls (HDFS/Hbase API calls, Hive UDFs), but most of the JNI API
provided by JniFrontend shouldn't be called by executors. It seems
that the whole Frontend object is needed only by coordinators.
Testing:
- generally executor only mode doesn't seem to be well covered
- ran test_coordinators.py which has some tests with executor only
impalads
- added new test for HBase tables (Hive UDFs and HDFS were already
covered)
Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M tests/custom_cluster/test_coordinators.py
3 files changed, 29 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/15793/2
--
To view, visit http://gerrit.cloudera.org:8080/15793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Gerrit-Change-Number: 15793
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9609: Minimize Frontend activity in executor only impalads
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15793/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java
File fe/src/main/java/org/apache/impala/service/JniFrontend.java:
http://gerrit.cloudera.org:8080/#/c/15793/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@146
PS2, Line 146: frontend_ = null;
> With this set to null, to be safe it would be good to add Preconditions not
Added the Preconditions.
My idea for making this class nicer was to make all functions needed by executors static and create a JniFrontend in backend only for coordinators. I didn't do this change because I wanted to minimize the size and risks of this patch to make it easily backportable.
http://gerrit.cloudera.org:8080/#/c/15793/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@191
PS2, Line 191: ExecutorMembershipSnapshot.update(req);
> Removing the indirection makes sense. Can we go further and just not do the
Done
--
To view, visit http://gerrit.cloudera.org:8080/15793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Gerrit-Change-Number: 15793
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2020 14:49:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9609: Minimize Frontend activity in executor only impalads
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5861/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Gerrit-Change-Number: 15793
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2020 00:06:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9609: Minimize Frontend activity in executor only impalads
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Gerrit-Change-Number: 15793
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2020 17:17:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9609: Minimize Frontend activity in executor only impalads
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5704/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Gerrit-Change-Number: 15793
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2020 17:17:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9609: Minimize Frontend activity in executor only impalads
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads
......................................................................
IMPALA-9609: Minimize Frontend activity in executor only impalads
Until now the Frontend started fully regardless of flag is_coordinator,
e.g. created connections to the HMS, which is both error prone and can
DoS the metastore. (note that even coordinators started to connect to
HMS only in the recent past, related to local catalog mode and ACID
transactions)
Executor only impalads still need a JVM as queries can contain
java calls (HDFS/Hbase API calls, Hive UDFs), but most of the JNI API
provided by JniFrontend shouldn't be called by executors. It seems
that the whole Frontend object is needed only by coordinators.
Testing:
- generally executor only mode doesn't seem to be well covered
- ran test_coordinators.py which has some tests with executor only
impalads
- added new test for HBase tables (Hive UDFs and HDFS were already
covered)
Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Reviewed-on: http://gerrit.cloudera.org:8080/15793
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/exec-env.cc
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
M tests/custom_cluster/test_coordinators.py
4 files changed, 63 insertions(+), 17 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Gerrit-Change-Number: 15793
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9609: Minimize Frontend activity in executor only impalads
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15793/3/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:
http://gerrit.cloudera.org:8080/#/c/15793/3/be/src/runtime/exec-env.cc@287
PS3, Line 287: // TODO: Consider removing AdmissionController from executor only impalads.
We do actually need this on executors at the moment because they add the memory used locally to the admission control updates - see UpdatePoolStats() -> AddPoolUpdates() -> UpdateMemTrackerStats().
It could be refactored but for now it's harmless.
--
To view, visit http://gerrit.cloudera.org:8080/15793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Gerrit-Change-Number: 15793
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2020 16:52:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9609: Minimize Frontend activity in executor only impalads
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15793 )
Change subject: IMPALA-9609: Minimize Frontend activity in executor only impalads
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15793
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4627e5e3520175153cb49e24fd480815dfefdae1
Gerrit-Change-Number: 15793
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2020 21:43:52 +0000
Gerrit-HasComments: No