You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ableegoldman (via GitHub)" <gi...@apache.org> on 2023/01/23 23:32:42 UTC
[GitHub] [kafka] ableegoldman opened a new pull request, #13155: [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest
ableegoldman opened a new pull request, #13155:
URL: https://github.com/apache/kafka/pull/13155
Doing the PR to re-enable the test build that I temporarily disabled in https://github.com/apache/kafka/pull/13147 in order to help with debugging and to stabilize the 3.4 release branch.
I'm still debugging this so we should not merge this PR just yet, but I wanted to at least open it now so it's not forgotten
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on PR #13155:
URL: https://github.com/apache/kafka/pull/13155#issuecomment-1760671049
re-enabled already in https://github.com/apache/kafka/commit/beb0be5fe45d08ff45d6cdddfd86feac8500a7d7#diff-26010bb30ef947a13d4d6d35866c892258dc59dad4d5e2d40c9bb6059fb35381R99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a diff in pull request #13155: [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #13155:
URL: https://github.com/apache/kafka/pull/13155#discussion_r1084789144
##########
streams/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java:
##########
@@ -96,9 +96,8 @@ SmokeTestDriver.VerificationResult result() {
private static Stream<Boolean> parameters() {
return Stream.of(
- // TODO KAFKA-14533: debug and re-enable both parameters
- Boolean.TRUE
- //Boolean.FALSE
+ Boolean.FALSE,
Review Comment:
Good idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13155: [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13155:
URL: https://github.com/apache/kafka/pull/13155#issuecomment-1585813288
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch)
If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #13155: [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on PR #13155:
URL: https://github.com/apache/kafka/pull/13155#issuecomment-1401152718
cc @lucasbru @mjsax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a diff in pull request #13155: [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on code in PR #13155:
URL: https://github.com/apache/kafka/pull/13155#discussion_r1084678438
##########
streams/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java:
##########
@@ -96,9 +96,8 @@ SmokeTestDriver.VerificationResult result() {
private static Stream<Boolean> parameters() {
return Stream.of(
- // TODO KAFKA-14533: debug and re-enable both parameters
- Boolean.TRUE
- //Boolean.FALSE
+ Boolean.FALSE,
Review Comment:
For some additional data I also swapped the order of the two parameters, in case that happens to reveal something about the underlying source of failure here 🤷♀️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman closed pull request #13155: [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest
URL: https://github.com/apache/kafka/pull/13155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org