[GitHub] [trafficserver] shinrich commented on a change in pull request #7578: Adapt to continuation changes in write event handling

[GitBox <gi...@apache.org>]

shinrich commented on a change in pull request #7578:
URL: https://github.com/apache/trafficserver/pull/7578#discussion_r625387481



##########
File path: iocore/net/UnixNetVConnection.cc
##########
@@ -431,6 +432,9 @@ write_to_net_io(NetHandler *nh, UnixNetVConnection *vc, EThread *thread)
   if (towrite != ntodo && buf.writer()->write_avail()) {
     if (write_signal_and_update(VC_EVENT_WRITE_READY, vc) != EVENT_CONT) {
       return;
+    } else if (c != s->vio.cont) { /* The write vio was updated in the handler */
+      write_reschedule(nh, vc);
+      return;
     }

Review comment:
       Good point, I see another call in this function that should be checked.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org