You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Amruta Borkar <ar...@us.ibm.com> on 2016/03/17 19:10:10 UTC

Review Request 44972: Improve error logging for install errors during blueprint deployments.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44972/
-----------------------------------------------------------

Review request for Ambari, Di Li and Sumit Mohanty.


Bugs: AMBARI-15412
    https://issues.apache.org/jira/browse/AMBARI-15412


Repository: ambari


Description
-------

Improve error logging for install errors during blueprint deployments. 

Currently a severe error during install of a service component gets logged as a WARNing.

E.g.:

09 Mar 2016 12:11:45,881 WARN [qtp-ambari-agent-146] HeartBeatHandler:603 - Operation failed - may be retried. Service component host: KAFKA_BROKER, host: hdtest159.svl.ibm.com Action id12-0


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 24fea22 

Diff: https://reviews.apache.org/r/44972/diff/


Testing
-------

There are no JUnit test cases, but attached the screenshot which shows modified output.


File Attachments
----------------

Patch
  https://reviews.apache.org/media/uploaded/files/2016/03/17/2110d517-0cf4-4477-87e7-935c963e04de__AMBARI-15412.patch
Output
  https://reviews.apache.org/media/uploaded/files/2016/03/17/923d218f-7ca4-4439-b42f-743511936f94__AMBARI-15412_output.png


Thanks,

Amruta Borkar


Re: Review Request 44972: Improve error logging for install errors during blueprint deployments.

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44972/#review124176
-----------------------------------------------------------


Ship it!




Ship It!

- Di Li


On March 17, 2016, 6:11 p.m., Amruta Borkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44972/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 6:11 p.m.)
> 
> 
> Review request for Ambari, Di Li and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15412
>     https://issues.apache.org/jira/browse/AMBARI-15412
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Improve error logging for install errors during blueprint deployments. 
> 
> Currently a severe error during install of a service component gets logged as a WARNing
> 
> E.g.:
> 
> 09 Mar 2016 12:11:45,881 WARN [qtp-ambari-agent-146] HeartBeatHandler:603 - Operation failed - may be retried. Service component host: KAFKA_BROKER, host: hdtest159.svl.ibm.com Action id12-0
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 24fea22 
> 
> Diff: https://reviews.apache.org/r/44972/diff/
> 
> 
> Testing
> -------
> 
> There are no JUnit test cases, but attached the screenshot which shows modified output.
> 
> 
> File Attachments
> ----------------
> 
> Patch
>   https://reviews.apache.org/media/uploaded/files/2016/03/17/2110d517-0cf4-4477-87e7-935c963e04de__AMBARI-15412.patch
> Output
>   https://reviews.apache.org/media/uploaded/files/2016/03/17/923d218f-7ca4-4439-b42f-743511936f94__AMBARI-15412_output.png
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>


Re: Review Request 44972: Improve error logging for install errors during blueprint deployments.

Posted by Amruta Borkar <ar...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44972/
-----------------------------------------------------------

(Updated March 17, 2016, 6:11 p.m.)


Review request for Ambari, Di Li and Sumit Mohanty.


Bugs: AMBARI-15412
    https://issues.apache.org/jira/browse/AMBARI-15412


Repository: ambari


Description (updated)
-------

Improve error logging for install errors during blueprint deployments. 

Currently a severe error during install of a service component gets logged as a WARNing

E.g.:

09 Mar 2016 12:11:45,881 WARN [qtp-ambari-agent-146] HeartBeatHandler:603 - Operation failed - may be retried. Service component host: KAFKA_BROKER, host: hdtest159.svl.ibm.com Action id12-0


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 24fea22 

Diff: https://reviews.apache.org/r/44972/diff/


Testing
-------

There are no JUnit test cases, but attached the screenshot which shows modified output.


File Attachments
----------------

Patch
  https://reviews.apache.org/media/uploaded/files/2016/03/17/2110d517-0cf4-4477-87e7-935c963e04de__AMBARI-15412.patch
Output
  https://reviews.apache.org/media/uploaded/files/2016/03/17/923d218f-7ca4-4439-b42f-743511936f94__AMBARI-15412_output.png


Thanks,

Amruta Borkar