You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/01/19 16:58:27 UTC
[GitHub] [couchdb-config] bessbd opened a new pull request #34: Fix CI
bessbd opened a new pull request #34:
URL: https://github.com/apache/couchdb-config/pull/34
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-config] bessbd commented on pull request #34: Fix CI
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #34:
URL: https://github.com/apache/couchdb-config/pull/34#issuecomment-763008026
Hi @wohali ,
I have no idea whether this fixes it or not. I just wanted to see if it's really a (hopefully a) singe-line change. (Hence the `draft`.)
Thank you for the review and +1 though!
Also, I wasn't sure this is the right course of action - going for `3.x` in `couchdb` or if we should figure out the fdb issue fix here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-config] bessbd commented on pull request #34: Fix CI
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #34:
URL: https://github.com/apache/couchdb-config/pull/34#issuecomment-766821520
Good call, thank you for that @mtenrero .
Still, I think we should do a version of this change as well so that we have better confidence of `couchdb-config`'s CouchDB 3.x compatibility.
I'll push a commit here to enable matrix builds (3.x and `main`) and to remove erlang 19 support ( https://lists.apache.org/thread.html/r82bf3ef66fe359a3ff72d8a9f9cf3a97918a867129b1aab3fa4d1f41%40%3Cdev.couchdb.apache.org%3E )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-config] mtenrero commented on pull request #34: Fix CI
Posted by GitBox <gi...@apache.org>.
mtenrero commented on pull request #34:
URL: https://github.com/apache/couchdb-config/pull/34#issuecomment-765582379
The current CI issue can be solved with this PR[https://github.com/apache/couchdb-config/pull/33](https://github.com/apache/couchdb-config/pull/33)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-config] bessbd commented on pull request #34: Fix CI
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #34:
URL: https://github.com/apache/couchdb-config/pull/34#issuecomment-767465935
Thank you all for the collaboration on this. I'm about to merge the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-config] bessbd commented on pull request #34: Fix CI
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #34:
URL: https://github.com/apache/couchdb-config/pull/34#issuecomment-766821520
Good call, thank you for that @mtenrero .
Still, I think we should do a version of this change as well so that we have better confidence of `couchdb-config`'s CouchDB 3.x compatibility.
I'll push a commit here to enable matrix builds (3.x and `main`) and to remove erlang 19 support ( https://lists.apache.org/thread.html/r82bf3ef66fe359a3ff72d8a9f9cf3a97918a867129b1aab3fa4d1f41%40%3Cdev.couchdb.apache.org%3E )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-config] bessbd merged pull request #34: Fix CI
Posted by GitBox <gi...@apache.org>.
bessbd merged pull request #34:
URL: https://github.com/apache/couchdb-config/pull/34
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-config] wohali commented on pull request #34: Fix CI
Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #34:
URL: https://github.com/apache/couchdb-config/pull/34#issuecomment-762986093
@bessbd FYI if you're fixing CI and you're not doing a major change, it's acceptable to not need a +1.
But here's a +1 for you anyway if this fixes it 😉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org