You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/20 17:35:10 UTC
[GitHub] [superset] EugeneTorap opened a new pull request, #21532: chore: refactor AceEditorWrapper to functional component
EugeneTorap opened a new pull request, #21532:
URL: https://github.com/apache/superset/pull/21532
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Converted AceEditorWrapper class component into functional component.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #21532:
URL: https://github.com/apache/superset/pull/21532#issuecomment-1256290907
SQL Lab editor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on code in PR #21532:
URL: https://github.com/apache/superset/pull/21532#discussion_r981146645
##########
superset-frontend/src/SqlLab/components/AceEditorWrapper/AceEditorWrapper.test.tsx:
##########
@@ -83,6 +73,9 @@ describe('AceEditorWrapper', () => {
});
it('renders sql from unsaved change', () => {
+ // TODO: need to rewrite the test because we retrieve 'currentQueryEditor' in SqlEditor
Review Comment:
@michael-s-molina Can I do it in the next PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21532:
URL: https://github.com/apache/superset/pull/21532#issuecomment-1260197431
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #21532:
URL: https://github.com/apache/superset/pull/21532#issuecomment-1257908338
@andrey-zayats If the issue is already in master then we need to create GitHub issue and fix in a separate PR. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on PR #21532:
URL: https://github.com/apache/superset/pull/21532#issuecomment-1256366350
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21532:
URL: https://github.com/apache/superset/pull/21532#issuecomment-1252759948
# [Codecov](https://codecov.io/gh/apache/superset/pull/21532?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21532](https://codecov.io/gh/apache/superset/pull/21532?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4ee7922) into [master](https://codecov.io/gh/apache/superset/commit/2224ebecfe7af0a4fa3736c33d697f6f41a07e46?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2224ebe) will **increase** coverage by `0.01%`.
> The diff coverage is `71.42%`.
```diff
@@ Coverage Diff @@
## master #21532 +/- ##
==========================================
+ Coverage 66.67% 66.68% +0.01%
==========================================
Files 1793 1793
Lines 68523 68537 +14
Branches 7281 7283 +2
==========================================
+ Hits 45688 45707 +19
+ Misses 20971 20969 -2
+ Partials 1864 1861 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.88% <71.42%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21532?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/SqlLab/components/AceEditorWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/21532/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIvaW5kZXgudHN4) | `59.74% <69.56%> (+12.04%)` | :arrow_up: |
| [...frontend/src/SqlLab/components/SqlEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/21532/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci9pbmRleC5qc3g=) | `53.26% <100.00%> (+0.51%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/21532/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.94% <0.00%> (+0.52%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on code in PR #21532:
URL: https://github.com/apache/superset/pull/21532#discussion_r981146645
##########
superset-frontend/src/SqlLab/components/AceEditorWrapper/AceEditorWrapper.test.tsx:
##########
@@ -83,6 +73,9 @@ describe('AceEditorWrapper', () => {
});
it('renders sql from unsaved change', () => {
+ // TODO: need to rewrite the test because we retrieve 'currentQueryEditor' in SqlEditor
Review Comment:
@michael-s-molina Can I do it in the next PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] andrey-zayats commented on pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
andrey-zayats commented on PR #21532:
URL: https://github.com/apache/superset/pull/21532#issuecomment-1258014014
PR LGTM, qa verified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21532:
URL: https://github.com/apache/superset/pull/21532#issuecomment-1256367886
@jinghua-qa Ephemeral environment spinning up at http://34.221.133.37:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] andrey-zayats commented on pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
andrey-zayats commented on PR #21532:
URL: https://github.com/apache/superset/pull/21532#issuecomment-1256272466
> @jinghua-qa @andrey-zayats Can you test it?
What area can this pr affect? (where should we run regression tests?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] andrey-zayats commented on pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
andrey-zayats commented on PR #21532:
URL: https://github.com/apache/superset/pull/21532#issuecomment-1256334407
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #21532:
URL: https://github.com/apache/superset/pull/21532#issuecomment-1255384287
@jinghua-qa @andrey-zayats Can you test it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21532:
URL: https://github.com/apache/superset/pull/21532#issuecomment-1256334747
@andrey-zayats Ephemeral environment creation is currently limited to committers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] andrey-zayats commented on pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
andrey-zayats commented on PR #21532:
URL: https://github.com/apache/superset/pull/21532#issuecomment-1257895544
User sees an empty page when trying to open a new tab in SQL lab. The same thing happens when the user follows the link of the saved query.
The issue is already in master
https://user-images.githubusercontent.com/90777564/192266513-119b132d-810a-4e73-98ea-0b9765206d78.mp4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] andrey-zayats commented on pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
andrey-zayats commented on PR #21532:
URL: https://github.com/apache/superset/pull/21532#issuecomment-1257921103
> @andrey-zayats If the issue is already in master then we need to create GitHub issue and fix in a separate PR. Right?
Yeap, you're right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] andrey-zayats commented on pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
andrey-zayats commented on PR #21532:
URL: https://github.com/apache/superset/pull/21532#issuecomment-1256333129
> SQL Lab editor
Okay, I'll take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on code in PR #21532:
URL: https://github.com/apache/superset/pull/21532#discussion_r981139893
##########
superset-frontend/src/SqlLab/components/AceEditorWrapper/AceEditorWrapper.test.tsx:
##########
@@ -83,6 +73,9 @@ describe('AceEditorWrapper', () => {
});
it('renders sql from unsaved change', () => {
+ // TODO: need to rewrite the test because we retrieve 'currentQueryEditor' in SqlEditor
Review Comment:
@EugeneTorap Can you rewrite the test? It's important to have a test case for this scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #21532: chore: refactor AceEditorWrapper to functional component
Posted by GitBox <gi...@apache.org>.
rusackas merged PR #21532:
URL: https://github.com/apache/superset/pull/21532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org