You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by bs...@apache.org on 2020/01/21 23:39:21 UTC

[geode] branch feature/GEODE-7700 created (now e8bdf59)

This is an automated email from the ASF dual-hosted git repository.

bschuchardt pushed a change to branch feature/GEODE-7700
in repository https://gitbox.apache.org/repos/asf/geode.git.


      at e8bdf59  GEODE-7700 AbstractExecutorGroupJUnitTest lockOwnerThreadStackIsReported

This branch includes the following new commits:

     new e8bdf59  GEODE-7700 AbstractExecutorGroupJUnitTest lockOwnerThreadStackIsReported

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[geode] 01/01: GEODE-7700 AbstractExecutorGroupJUnitTest lockOwnerThreadStackIsReported

Posted by bs...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

bschuchardt pushed a commit to branch feature/GEODE-7700
in repository https://gitbox.apache.org/repos/asf/geode.git

commit e8bdf59bb5ea34e736f4fdd7f4599215228c5e71
Author: Bruce Schuchardt <bs...@pivotal.io>
AuthorDate: Tue Jan 21 15:37:07 2020 -0800

    GEODE-7700 AbstractExecutorGroupJUnitTest lockOwnerThreadStackIsReported
    
    added awaits & better assertions
---
 .../monitoring/executor/AbstractExecutorGroupJUnitTest.java  | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/geode-core/src/test/java/org/apache/geode/internal/monitoring/executor/AbstractExecutorGroupJUnitTest.java b/geode-core/src/test/java/org/apache/geode/internal/monitoring/executor/AbstractExecutorGroupJUnitTest.java
index ece6c95..4c61195 100644
--- a/geode-core/src/test/java/org/apache/geode/internal/monitoring/executor/AbstractExecutorGroupJUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/internal/monitoring/executor/AbstractExecutorGroupJUnitTest.java
@@ -14,8 +14,10 @@
  */
 package org.apache.geode.internal.monitoring.executor;
 
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
 import static org.junit.Assert.assertTrue;
 
+import org.assertj.core.api.Assertions;
 import org.junit.Test;
 
 import org.apache.geode.test.awaitility.GeodeAwaitility;
@@ -85,9 +87,9 @@ public class AbstractExecutorGroupJUnitTest {
       }
     };
     blockingThread.start();
-    GeodeAwaitility.await().until(() -> blockingThreadWaiting[0]);
+    await().until(() -> blockingThreadWaiting[0]);
     blockedThread.start();
-    GeodeAwaitility.await().until(() -> blockedThreadWaiting[0]);
+    await().until(() -> blockedThreadWaiting[0]);
     try {
       AbstractExecutor executor = new AbstractExecutor(null, blockedThread.getId()) {
         @Override
@@ -95,8 +97,10 @@ public class AbstractExecutorGroupJUnitTest {
           // no-op
         }
       };
-      String threadReport = executor.createThreadReport(60000);
-      assertTrue(threadReport.contains(AbstractExecutor.LOCK_OWNER_THREAD_STACK));
+      await().untilAsserted(() -> {
+        String threadReport = executor.createThreadReport(60000);
+        Assertions.assertThat(threadReport).contains(AbstractExecutor.LOCK_OWNER_THREAD_STACK);
+      });
     } finally {
       blockingThread.interrupt();
       blockedThread.interrupt();