You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2025/06/14 14:42:04 UTC
[PR] Prevent legacy hybrid executors to be running in Airflow 3 [airflow]
jscheffl opened a new pull request, #51733:
URL: https://github.com/apache/airflow/pull/51733
In Slack we had multiple chats/threads/discussions about broken executors in Airflow 3 (e.g. https://apache-airflow.slack.com/archives/C07813CNKA8/p1749747275499659) and as in #51715 docs were updated this PR also prevents running them in Airflow 3++. See also https://github.com/apache/airflow/pull/47322
This PR also adds a safeguard into the executor code to block execution if somebody still does not read docs.
@eladkal do you think this would be able to slip into preparation of provider cuts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prevent legacy hybrid executors to be running in Airflow 3 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #51733:
URL: https://github.com/apache/airflow/pull/51733#discussion_r2146976050
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/local_kubernetes_executor.py:
##########
@@ -119,6 +120,9 @@ def job_id(self, value: int | str | None) -> None:
def start(self) -> None:
"""Start local and kubernetes executor."""
+ if AIRFLOW_V_3_0_PLUS:
+ raise RuntimeError(f"{self.__class__.__name__} does not support Airflow 3.0+.")
Review Comment:
Good point! Adjusted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prevent legacy hybrid executors to be running in Airflow 3 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #51733:
URL: https://github.com/apache/airflow/pull/51733#discussion_r2146973838
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/local_kubernetes_executor.py:
##########
@@ -119,6 +120,9 @@ def job_id(self, value: int | str | None) -> None:
def start(self) -> None:
"""Start local and kubernetes executor."""
+ if AIRFLOW_V_3_0_PLUS:
+ raise RuntimeError(f"{self.__class__.__name__} does not support Airflow 3.0+.")
Review Comment:
I think we should add "Use Hybrid executors instead http://linktodochere".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prevent legacy hybrid executors to be running in Airflow 3 [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #51733:
URL: https://github.com/apache/airflow/pull/51733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org