[jira] [Closed] (FLINK-16619) Misleading SlotManagerImpl logging for slot reports of unknown task manager

["Chesnay Schepler (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chesnay Schepler closed FLINK-16619.
------------------------------------
    Fix Version/s: 1.11.2
                   1.12.0
                   1.10.2
       Resolution: Fixed

master: 7d39a2c7cd23c990800671787916751e04720252
1.11: 79e33e619612a7e91778ab18c181630e9d6a0ff0 
1.10: 7627f5414a5e06f1ae465df9021c37c04b7ee553 

> Misleading SlotManagerImpl logging for slot reports of unknown task manager
> ---------------------------------------------------------------------------
>
>                 Key: FLINK-16619
>                 URL: https://issues.apache.org/jira/browse/FLINK-16619
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>    Affects Versions: 1.10.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.10.2, 1.12.0, 1.11.2
>
>
> If the SlotManager receives a slot report from an unknown task manager it logs 2 messages:
> {code}
> public boolean reportSlotStatus(InstanceID instanceId, SlotReport slotReport) {
> 	[...]
> 	LOG.debug("Received slot report from instance {}: {}.", instanceId, slotReport);
> 	TaskManagerRegistration taskManagerRegistration = taskManagerRegistrations.get(instanceId);
> 	if (null != taskManagerRegistration) {
> 		[...]
> 	} else {
> 		LOG.debug("Received slot report for unknown task manager with instance id {}. Ignoring this report.", instanceId);
> 		[...]
> 	}
> }
> {code}
> This leads to misleading output since it appears like the slot manager received 2 separate slot reports, with the first being for a known instance, the latter for an unknown one. This cost some time as I couldn't figure out why the "latter" report was suddenly being rejected.
> I propose moving the first debug message into the non-null branch.
> [~trohrmann] WDYT?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)