You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "liugddx (via GitHub)" <gi...@apache.org> on 2024/01/31 14:15:38 UTC

[PR] [function](url_decode)add url_decode function [doris]

liugddx opened a new pull request, #30667:
URL: https://github.com/apache/doris/pull/30667

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1923280813

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925013531

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.22 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit ffc11beedfe8b760e5fb2a69a37fc78a20cd350f, data reload: false
   
   query1	0.03	0.03	0.03
   query2	0.06	0.02	0.02
   query3	0.23	0.06	0.06
   query4	1.68	0.09	0.10
   query5	0.53	0.52	0.51
   query6	1.18	0.66	0.64
   query7	0.02	0.01	0.01
   query8	0.03	0.02	0.03
   query9	0.54	0.50	0.50
   query10	0.53	0.55	0.52
   query11	0.11	0.09	0.09
   query12	0.12	0.09	0.09
   query13	0.60	0.61	0.60
   query14	0.77	0.79	0.81
   query15	0.80	0.78	0.78
   query16	0.39	0.39	0.39
   query17	1.04	1.05	1.02
   query18	0.21	0.27	0.23
   query19	1.92	1.79	1.77
   query20	0.01	0.01	0.02
   query21	15.40	0.60	0.57
   query22	2.76	2.19	1.59
   query23	17.45	0.78	0.74
   query24	2.44	1.19	0.53
   query25	0.34	0.30	0.15
   query26	0.45	0.14	0.14
   query27	0.05	0.05	0.05
   query28	12.23	0.85	0.86
   query29	12.61	3.15	3.08
   query30	0.63	0.54	0.52
   query31	2.79	0.34	0.35
   query32	3.34	0.48	0.49
   query33	3.21	3.22	3.19
   query34	15.75	4.27	4.24
   query35	4.31	4.34	4.29
   query36	1.10	1.04	1.05
   query37	0.06	0.04	0.04
   query38	0.04	0.03	0.02
   query39	0.02	0.02	0.01
   query40	0.16	0.17	0.13
   query41	0.07	0.02	0.02
   query42	0.03	0.01	0.02
   query43	0.03	0.02	0.02
   Total cold run time: 106.07 s
   Total hot run time: 30.22 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925569537

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1476192330


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/UrlDecode.java:
##########
@@ -0,0 +1,70 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.functions.scalar;
+
+import org.apache.doris.catalog.FunctionSignature;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.functions.AlwaysNullable;
+import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature;
+import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
+import org.apache.doris.nereids.types.StringType;
+import org.apache.doris.nereids.types.VarcharType;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableList;
+
+import java.util.List;
+
+/**
+ * ScalarFunction 'url_decode'. This class is generated by GenerateFunction.
+ */
+public class UrlDecode extends ScalarFunction
+        implements ExplicitlyCastableSignature, AlwaysNullable {

Review Comment:
   ```suggestion
           implements ExplicitlyCastableSignature, PropagateNullable {
   ```



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/UrlDecode.java:
##########
@@ -0,0 +1,70 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.functions.scalar;
+
+import org.apache.doris.catalog.FunctionSignature;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.functions.AlwaysNullable;
+import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature;
+import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
+import org.apache.doris.nereids.types.StringType;
+import org.apache.doris.nereids.types.VarcharType;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableList;
+
+import java.util.List;
+
+/**
+ * ScalarFunction 'url_decode'. This class is generated by GenerateFunction.
+ */
+public class UrlDecode extends ScalarFunction
+        implements ExplicitlyCastableSignature, AlwaysNullable {
+
+    public static final List<FunctionSignature> SIGNATURES = ImmutableList.of(
+            FunctionSignature.ret(VarcharType.SYSTEM_DEFAULT).args(VarcharType.SYSTEM_DEFAULT),
+            FunctionSignature.ret(VarcharType.SYSTEM_DEFAULT).args(StringType.INSTANCE)

Review Comment:
   ```suggestion
               FunctionSignature.ret(StringType.INSTANCE).args(StringType.INSTANCE)
   ```



##########
gensrc/script/doris_builtins_functions.py:
##########
@@ -1661,7 +1662,9 @@
         [['money_format'], 'STRING', ['DECIMAL64'], ''],
         [['money_format'], 'STRING', ['DECIMAL128'], ''],
         [['split_part'], 'STRING', ['STRING', 'STRING', 'INT'], 'ALWAYS_NULLABLE'],
-        [['substring_index'], 'STRING', ['STRING', 'STRING', 'INT'], 'DEPEND_ON_ARGUMENT']
+        [['substring_index'], 'STRING', ['STRING', 'STRING', 'INT'], 'ALWAYS_NULLABLE'],
+        [['substring_index'], 'STRING', ['STRING', 'STRING', 'INT'], 'DEPEND_ON_ARGUMENT'],

Review Comment:
   why substring_index is both ALWAYS_NULLABLE and DEPEND_ON_ARGUMENT



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1472901807


##########
be/src/vec/functions/function_string.h:
##########
@@ -2602,6 +2603,57 @@
     }
 };
 
+class FunctionUrlDecode : public IFunction {
+public:
+    static constexpr auto name = "url_decode";
+    static FunctionPtr create() { return std::make_shared<FunctionUrlDecode>(); }
+    String get_name() const override { return name; }
+    size_t get_number_of_arguments() const override { return 1; }
+    bool is_variadic() const override { return false; }
+
+    DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+            return std::make_shared<DataTypeString>();
+        }
+    bool use_default_implementation_for_nulls() const override { return true; }
+
+    Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+                            size_t result, size_t input_rows_count) const override {

Review Comment:
   warning: method 'execute_impl' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
       static Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
                               size_t result, size_t input_rows_count) override {
   ```
   



##########
be/src/vec/functions/function_string.h:
##########
@@ -2602,6 +2603,57 @@ class FunctionStringParseUrl : public IFunction {
     }
 };
 
+class FunctionUrlDecode : public IFunction {
+public:
+    static constexpr auto name = "url_decode";
+    static FunctionPtr create() { return std::make_shared<FunctionUrlDecode>(); }
+    String get_name() const override { return name; }
+    size_t get_number_of_arguments() const override { return 1; }
+    bool is_variadic() const override { return false; }
+
+    DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {

Review Comment:
   warning: method 'get_return_type_impl' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
       static DataTypePtr get_return_type_impl(const DataTypes& arguments) override {
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1920336897

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477172340


##########
be/src/vec/functions/function_string.h:
##########
@@ -2740,6 +2741,51 @@ class FunctionStringParseUrl : public IFunction {
     }
 };
 
+class FunctionUrlDecode : public IFunction {
+public:
+    static constexpr auto name = "url_decode";
+    static FunctionPtr create() { return std::make_shared<FunctionUrlDecode>(); }
+    String get_name() const override { return name; }
+    size_t get_number_of_arguments() const override { return 1; }
+    bool is_variadic() const override { return false; }
+
+    DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+        return std::make_shared<DataTypeString>();
+    }
+
+    Status execute_impl(FunctionContext* context, Block& block,
+
+                        const ColumnNumbers& arguments, size_t result,
+                        size_t input_rows_count) const override {
+        auto res = ColumnString::create();
+        auto& res_offsets = res->get_offsets();
+        auto& res_chars = res->get_chars();
+        res_offsets.resize(input_rows_count);
+
+        ColumnPtr argument_column =
+                block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+        const auto* url_col = check_and_get_column<ColumnString>(argument_column.get());
+
+        if (!url_col) {
+            return Status::InternalError("Not supported input argument type");
+        }
+
+        for (size_t i = 0; i < input_rows_count; ++i) {
+            auto source = url_col->get_data_at(i);
+            StringRef url_val(const_cast<char*>(source.data), source.size);
+
+            std::string decoded_url;

Review Comment:
   reuse the string mem



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925577265

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 0b09df9f6b3c2867db2a64fa8a0e0c22897fe3d2 with default session variables
   Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       13.8 seconds inserted 10000000 Rows, about 724K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925606725

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173883 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 4fb7abd31f099ab60fcdc55a4367c1949efc49ac, data reload: false
   
   query1	910	347	326	326
   query2	6563	1861	1825	1825
   query3	6700	213	203	203
   query4	32456	22082	22113	22082
   query5	4265	361	350	350
   query6	260	166	166	166
   query7	4603	280	280	280
   query8	247	180	173	173
   query9	8955	2314	2303	2303
   query10	413	210	207	207
   query11	18961	15464	15277	15277
   query12	132	76	75	75
   query13	1642	406	429	406
   query14	9409	7107	7046	7046
   query15	273	177	179	177
   query16	8143	251	248	248
   query17	2072	534	503	503
   query18	2110	274	262	262
   query19	355	137	144	137
   query20	80	77	80	77
   query21	195	132	124	124
   query22	4904	4477	4466	4466
   query23	31138	29981	29891	29891
   query24	10165	2744	2779	2744
   query25	541	341	345	341
   query26	713	147	143	143
   query27	2193	305	294	294
   query28	5766	1893	1862	1862
   query29	867	615	617	615
   query30	284	133	146	133
   query31	928	714	710	710
   query32	91	56	51	51
   query33	634	214	211	211
   query34	861	459	458	458
   query35	847	774	773	773
   query36	1046	917	839	839
   query37	93	54	58	54
   query38	3217	3164	3111	3111
   query39	1290	1266	1243	1243
   query40	185	95	89	89
   query41	37	35	35	35
   query42	99	84	89	84
   query43	512	479	473	473
   query44	1014	696	709	696
   query45	197	174	171	171
   query46	1047	650	630	630
   query47	1625	1510	1518	1510
   query48	413	354	350	350
   query49	1041	284	279	279
   query50	763	370	377	370
   query51	5260	5117	5216	5117
   query52	105	80	85	80
   query53	336	270	264	264
   query54	283	217	216	216
   query55	76	72	77	72
   query56	207	191	200	191
   query57	960	901	915	901
   query58	209	178	181	178
   query59	2507	2378	2374	2374
   query60	239	216	223	216
   query61	85	83	83	83
   query62	617	345	359	345
   query63	284	274	274	274
   query64	4640	3344	3641	3344
   query65	3241	3233	3223	3223
   query66	828	306	303	303
   query67	14438	14154	13940	13940
   query68	5426	556	514	514
   query69	465	312	317	312
   query70	1252	1136	1254	1136
   query71	311	256	248	248
   query72	6196	2841	2666	2666
   query73	703	325	322	322
   query74	6576	6201	6189	6189
   query75	3046	2385	2295	2295
   query76	2959	951	984	951
   query77	374	222	226	222
   query78	9263	8834	8702	8702
   query79	3397	491	485	485
   query80	2142	351	354	351
   query81	545	195	200	195
   query82	793	82	83	82
   query83	378	125	125	125
   query84	282	86	79	79
   query85	1697	330	330	330
   query86	483	294	291	291
   query87	3376	3224	3181	3181
   query88	4425	2328	2291	2291
   query89	475	365	348	348
   query90	1937	163	165	163
   query91	146	127	126	126
   query92	57	41	42	41
   query93	4956	470	482	470
   query94	1297	172	172	172
   query95	7912	7614	365	365
   query96	595	279	286	279
   query97	4257	4099	4136	4099
   query98	220	196	197	196
   query99	1137	678	663	663
   Total cold run time: 292648 ms
   Total hot run time: 173883 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1926268295

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1923268025

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477246864


##########
be/src/vec/functions/function_string.h:
##########
@@ -2740,6 +2741,53 @@ class FunctionStringParseUrl : public IFunction {
     }
 };
 
+class FunctionUrlDecode : public IFunction {
+public:
+    static constexpr auto name = "url_decode";
+    static FunctionPtr create() { return std::make_shared<FunctionUrlDecode>(); }
+    String get_name() const override { return name; }
+    size_t get_number_of_arguments() const override { return 1; }
+    bool is_variadic() const override { return false; }

Review Comment:
   no need override, remove



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925574182

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 37293 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0b09df9f6b3c2867db2a64fa8a0e0c22897fe3d2, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	18234	4633	4456	4456
   q2	2050	141	135	135
   q3	10597	930	917	917
   q4	4651	816	759	759
   q5	7718	2832	2855	2832
   q6	185	121	120	120
   q7	1175	747	745	745
   q8	9297	2024	2041	2024
   q9	7304	6379	6393	6379
   q10	8125	2455	2449	2449
   q11	421	219	214	214
   q12	764	288	275	275
   q13	18015	3347	3305	3305
   q14	276	275	250	250
   q15	538	490	488	488
   q16	476	405	424	405
   q17	941	525	526	525
   q18	6816	6044	5903	5903
   q19	1561	1498	1379	1379
   q20	581	323	332	323
   q21	6753	3105	3168	3105
   q22	814	314	305	305
   Total cold run time: 107292 ms
   Total hot run time: 37293 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4476	4508	4421	4421
   q2	334	237	240	237
   q3	3008	2879	2818	2818
   q4	1863	1627	1652	1627
   q5	5242	5282	5303	5282
   q6	191	113	117	113
   q7	2121	1834	1771	1771
   q8	3103	3246	3274	3246
   q9	8323	8322	8315	8315
   q10	5837	3593	3562	3562
   q11	549	462	458	458
   q12	752	600	588	588
   q13	8090	3102	3064	3064
   q14	286	240	265	240
   q15	542	491	489	489
   q16	505	492	477	477
   q17	1867	1685	1690	1685
   q18	8076	7739	7680	7680
   q19	8298	1513	1543	1513
   q20	2137	1900	1904	1900
   q21	4887	4572	4645	4572
   q22	584	502	446	446
   Total cold run time: 71071 ms
   Total hot run time: 54504 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477332320


##########
be/src/vec/functions/function_string.h:
##########
@@ -2740,6 +2741,48 @@ class FunctionStringParseUrl : public IFunction {
     }
 };
 
+class FunctionUrlDecode : public IFunction {
+public:
+    static constexpr auto name = "url_decode";
+    DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+        return std::make_shared<DataTypeString>();
+    }
+
+    Status execute_impl(FunctionContext* context, Block& block,

Review Comment:
   warning: method 'execute_impl' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
       static Status execute_impl(FunctionContext* context, Block& block,
   ```
   
   be/src/vec/functions/function_string.h:2753:
   ```diff
   -                         size_t input_rows_count) const override {
   +                         size_t input_rows_count) override {
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1924074403

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 175886 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 12d5f981337f488a8184818a7780cc69c2521764, data reload: false
   
   query1	1213	344	334	334
   query2	6587	2088	2098	2088
   query3	6710	217	207	207
   query4	32214	22341	22442	22341
   query5	4354	429	376	376
   query6	266	164	172	164
   query7	4681	298	308	298
   query8	1386	200	239	200
   query9	10359	2335	2328	2328
   query10	416	227	225	225
   query11	18791	15344	15240	15240
   query12	124	79	72	72
   query13	1638	413	420	413
   query14	8922	7243	7208	7208
   query15	262	178	181	178
   query16	8129	251	251	251
   query17	2334	556	523	523
   query18	2225	264	255	255
   query19	357	143	137	137
   query20	80	77	78	77
   query21	205	130	131	130
   query22	5192	5000	5009	5000
   query23	30947	30065	30115	30065
   query24	10504	2772	2733	2733
   query25	575	352	349	349
   query26	1243	141	141	141
   query27	2342	302	299	299
   query28	6831	1854	1862	1854
   query29	883	593	598	593
   query30	277	131	139	131
   query31	921	712	699	699
   query32	92	60	57	57
   query33	710	213	215	213
   query34	1114	449	451	449
   query35	891	754	734	734
   query36	985	910	889	889
   query37	122	57	58	57
   query38	3226	3111	3059	3059
   query39	1302	1240	1246	1240
   query40	179	96	95	95
   query41	38	36	34	34
   query42	103	95	91	91
   query43	528	519	467	467
   query44	1064	700	713	700
   query45	191	180	180	180
   query46	1058	650	643	643
   query47	1588	1507	1499	1499
   query48	436	381	355	355
   query49	1073	288	276	276
   query50	745	372	374	372
   query51	5202	5120	5179	5120
   query52	102	81	85	81
   query53	337	265	275	265
   query54	302	218	222	218
   query55	73	78	77	77
   query56	227	201	198	198
   query57	984	934	912	912
   query58	199	177	181	177
   query59	2416	2464	2336	2336
   query60	237	213	214	213
   query61	85	84	84	84
   query62	649	356	348	348
   query63	300	275	272	272
   query64	5038	3693	3358	3358
   query65	3252	3237	3238	3237
   query66	808	325	308	308
   query67	14520	14385	14272	14272
   query68	5460	528	530	528
   query69	481	333	322	322
   query70	1194	1211	1241	1211
   query71	332	254	247	247
   query72	6460	2834	2661	2661
   query73	698	316	310	310
   query74	6841	6244	6215	6215
   query75	3063	2354	2301	2301
   query76	3527	971	989	971
   query77	348	226	226	226
   query78	9450	8979	8761	8761
   query79	3529	486	481	481
   query80	2071	341	337	337
   query81	543	194	208	194
   query82	902	87	80	80
   query83	251	120	127	120
   query84	285	75	82	75
   query85	2233	335	318	318
   query86	480	300	317	300
   query87	3379	3218	3281	3218
   query88	4614	2283	2295	2283
   query89	459	361	368	361
   query90	1982	160	160	160
   query91	165	120	123	120
   query92	52	40	42	40
   query93	5647	494	491	491
   query94	1260	174	166	166
   query95	461	357	7891	357
   query96	604	265	262	262
   query97	4189	4110	4110	4110
   query98	221	194	189	189
   query99	1172	676	705	676
   Total cold run time: 293497 ms
   Total hot run time: 175886 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #30667:
URL: https://github.com/apache/doris/pull/30667


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1923069038

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1924011123

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925090521

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit dc34bd12ce0a332d26c8566bf05d72ffda562e82 with default session variables
   Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       13.4 seconds inserted 10000000 Rows, about 746K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1924088882

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 12d5f981337f488a8184818a7780cc69c2521764 with default session variables
   Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       13.7 seconds inserted 10000000 Rows, about 729K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925005850

   TeamCity be ut coverage result:
    Function Coverage: 36.16% (8628/23863) 
    Line Coverage: 28.22% (70541/249986)
    Region Coverage: 27.23% (36406/133674)
    Branch Coverage: 24.02% (18643/77620)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/ffc11beedfe8b760e5fb2a69a37fc78a20cd350f_ffc11beedfe8b760e5fb2a69a37fc78a20cd350f/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925154263

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 36598 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 99ca84ba14030743fd042bd488cb00480d2fce06, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17657	4671	4425	4425
   q2	2031	140	129	129
   q3	10613	895	941	895
   q4	4646	722	688	688
   q5	7706	2729	2795	2729
   q6	179	118	120	118
   q7	1159	735	720	720
   q8	9310	1988	1995	1988
   q9	7261	6329	6347	6329
   q10	8101	2417	2406	2406
   q11	409	211	207	207
   q12	770	275	281	275
   q13	18009	3283	3309	3283
   q14	268	254	242	242
   q15	528	496	484	484
   q16	490	407	424	407
   q17	932	530	503	503
   q18	6757	5874	5809	5809
   q19	1566	1383	1380	1380
   q20	616	342	323	323
   q21	7200	3069	2961	2961
   q22	795	297	321	297
   Total cold run time: 107003 ms
   Total hot run time: 36598 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4476	4363	4403	4363
   q2	326	234	229	229
   q3	2946	2798	2804	2798
   q4	1873	1663	1684	1663
   q5	5144	5191	5215	5191
   q6	187	115	115	115
   q7	2173	1706	1755	1706
   q8	3054	3254	3220	3220
   q9	8324	8275	8253	8253
   q10	5905	3506	3576	3506
   q11	555	465	455	455
   q12	739	558	572	558
   q13	14226	3115	3133	3115
   q14	267	254	257	254
   q15	539	495	484	484
   q16	539	481	477	477
   q17	1814	1727	1720	1720
   q18	7917	7759	7387	7387
   q19	6457	1516	1493	1493
   q20	2126	1924	1883	1883
   q21	4727	4587	4583	4583
   q22	569	448	495	448
   Total cold run time: 74883 ms
   Total hot run time: 53901 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477171446


##########
be/src/vec/functions/function_string.h:
##########
@@ -2740,6 +2741,59 @@ class FunctionStringParseUrl : public IFunction {
     }
 };
 
+class FunctionUrlDecode : public IFunction {
+public:
+    static constexpr auto name = "url_decode";
+    static FunctionPtr create() { return std::make_shared<FunctionUrlDecode>(); }
+    String get_name() const override { return name; }
+    size_t get_number_of_arguments() const override { return 1; }
+    bool is_variadic() const override { return false; }
+
+    DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+        return std::make_shared<DataTypeString>();
+    }
+
+    Status execute_impl(FunctionContext* context, Block& block,
+
+                        const ColumnNumbers& arguments, size_t result,
+                        size_t input_rows_count) const override {
+        auto null_map = ColumnUInt8::create(input_rows_count, 0);
+        auto& null_map_data = null_map->get_data();
+
+        auto res = ColumnString::create();
+        auto& res_offsets = res->get_offsets();
+        auto& res_chars = res->get_chars();
+        res_offsets.resize(input_rows_count);
+
+        ColumnPtr argument_column =
+                block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+        const auto* url_col = check_and_get_column<ColumnString>(argument_column.get());
+
+        if (!url_col) {
+            return Status::InternalError("Not supported input argument type");
+        }
+
+        for (size_t i = 0; i < input_rows_count; ++i) {
+            if (null_map_data[i]) {

Review Comment:
   > this check is seems error: null_map_data it's from null_map, this is your create local variables and all data is 0?
   
   Yes, it was redundant and I got rid of it. Thank you for your review



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925594822

   run pipelinex_p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477262359


##########
regression-test/suites/nereids_function_p0/scalar_function/U.groovy:
##########
@@ -43,4 +43,5 @@ suite("nereids_scalar_fn_U") {
 	qt_sql_upper_String_notnull "select upper(kstr) from fn_test_not_nullable order by kstr"
 	sql "select user() from fn_test"
 	sql "select user() from fn_test_not_nullable"
+    qt_sql_url_decode "select url_decode('https%3A%2F%2Fdoris.apache.org%2Fzh-CN%2Fdocs%2Fsql-manual%2Fsql-functions%2Fstring-functions')"

Review Comment:
   > no display error,maybe you indented \t or ' '
   
   Emm... My fault.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925702317

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.19 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 72e40b082ecfee7ceda6b5190049294395c04b1a, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.05	0.02	0.02
   query3	0.22	0.06	0.06
   query4	1.68	0.10	0.10
   query5	0.54	0.51	0.52
   query6	1.19	0.64	0.64
   query7	0.02	0.01	0.02
   query8	0.04	0.03	0.02
   query9	0.53	0.49	0.49
   query10	0.54	0.58	0.54
   query11	0.12	0.09	0.09
   query12	0.11	0.08	0.09
   query13	0.61	0.61	0.60
   query14	0.79	0.78	0.82
   query15	0.79	0.78	0.77
   query16	0.35	0.40	0.39
   query17	1.02	1.01	1.01
   query18	0.26	0.26	0.26
   query19	1.88	1.71	1.77
   query20	0.01	0.00	0.00
   query21	15.40	0.57	0.59
   query22	2.50	2.40	1.58
   query23	17.21	0.82	0.76
   query24	2.45	1.25	1.44
   query25	0.33	0.22	0.18
   query26	0.57	0.15	0.14
   query27	0.06	0.04	0.05
   query28	11.20	0.84	0.83
   query29	12.53	3.31	3.22
   query30	0.66	0.53	0.54
   query31	2.79	0.34	0.35
   query32	3.38	0.48	0.48
   query33	3.21	3.20	3.25
   query34	15.93	4.31	4.32
   query35	4.31	4.40	4.33
   query36	1.12	1.05	1.07
   query37	0.06	0.05	0.05
   query38	0.04	0.03	0.03
   query39	0.02	0.01	0.02
   query40	0.16	0.13	0.13
   query41	0.08	0.02	0.02
   query42	0.02	0.02	0.01
   query43	0.03	0.02	0.02
   Total cold run time: 104.85 s
   Total hot run time: 31.19 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925685650

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925701014

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 174312 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 72e40b082ecfee7ceda6b5190049294395c04b1a, data reload: false
   
   query1	950	351	331	331
   query2	6546	1897	1850	1850
   query3	6708	212	201	201
   query4	31744	21982	21983	21982
   query5	4236	351	349	349
   query6	254	163	165	163
   query7	4611	288	284	284
   query8	249	170	174	170
   query9	9053	2341	2315	2315
   query10	417	216	197	197
   query11	19034	15293	15266	15266
   query12	135	74	74	74
   query13	1615	405	410	405
   query14	9769	6735	6886	6735
   query15	249	181	179	179
   query16	8093	259	240	240
   query17	1847	541	508	508
   query18	2097	278	260	260
   query19	366	137	140	137
   query20	81	75	75	75
   query21	194	124	125	124
   query22	5166	4982	4919	4919
   query23	30976	30076	29985	29985
   query24	11339	2751	2726	2726
   query25	618	346	344	344
   query26	1749	143	148	143
   query27	2929	296	307	296
   query28	7510	1868	1863	1863
   query29	970	604	614	604
   query30	287	135	139	135
   query31	936	708	709	708
   query32	89	53	48	48
   query33	732	213	234	213
   query34	1106	453	454	453
   query35	904	752	739	739
   query36	1055	910	888	888
   query37	141	61	57	57
   query38	3247	3097	3144	3097
   query39	1302	1251	1239	1239
   query40	265	92	92	92
   query41	36	35	35	35
   query42	98	93	85	85
   query43	468	476	481	476
   query44	1093	702	715	702
   query45	192	186	176	176
   query46	1053	627	652	627
   query47	1583	1551	1510	1510
   query48	432	369	351	351
   query49	1197	309	283	283
   query50	769	392	377	377
   query51	5273	5143	5205	5143
   query52	104	85	84	84
   query53	337	266	269	266
   query54	279	215	219	215
   query55	77	78	72	72
   query56	214	197	193	193
   query57	943	903	896	896
   query58	203	180	183	180
   query59	2558	2333	2393	2333
   query60	237	211	206	206
   query61	90	86	85	85
   query62	682	374	351	351
   query63	296	257	264	257
   query64	6457	3376	3500	3376
   query65	3251	3209	3237	3209
   query66	1208	312	305	305
   query67	14643	14392	14018	14018
   query68	3979	561	534	534
   query69	437	323	332	323
   query70	1250	1184	1236	1184
   query71	302	251	247	247
   query72	5815	2833	2641	2641
   query73	695	319	318	318
   query74	6616	6373	6353	6353
   query75	3049	2363	2370	2363
   query76	2535	897	886	886
   query77	345	230	216	216
   query78	9222	8941	8699	8699
   query79	3021	494	492	492
   query80	2045	347	339	339
   query81	526	193	201	193
   query82	824	82	78	78
   query83	250	122	124	122
   query84	287	79	88	79
   query85	2217	341	338	338
   query86	497	304	299	299
   query87	3416	3210	3230	3210
   query88	3936	2304	2312	2304
   query89	430	370	359	359
   query90	2038	161	161	161
   query91	149	137	124	124
   query92	56	42	41	41
   query93	3107	513	483	483
   query94	1294	173	171	171
   query95	7991	347	345	345
   query96	587	278	264	264
   query97	4237	4083	4113	4083
   query98	229	201	202	201
   query99	1134	657	670	657
   Total cold run time: 295858 ms
   Total hot run time: 174312 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925699154

   TeamCity be ut coverage result:
    Function Coverage: 36.15% (8628/23864) 
    Line Coverage: 28.22% (70547/250029)
    Region Coverage: 27.23% (36404/133690)
    Branch Coverage: 24.02% (18644/77624)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/72e40b082ecfee7ceda6b5190049294395c04b1a_72e40b082ecfee7ceda6b5190049294395c04b1a/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1926268264

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925047171

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1923022199

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925011878

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173889 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit ffc11beedfe8b760e5fb2a69a37fc78a20cd350f, data reload: false
   
   query1	931	345	331	331
   query2	6531	1896	1876	1876
   query3	6701	206	205	205
   query4	31819	22028	22017	22017
   query5	4273	376	363	363
   query6	251	172	164	164
   query7	4602	281	280	280
   query8	254	178	180	178
   query9	9079	2330	2304	2304
   query10	418	212	208	208
   query11	18391	15315	15448	15315
   query12	132	89	76	76
   query13	1611	425	412	412
   query14	9210	6804	6773	6773
   query15	234	171	191	171
   query16	8107	255	240	240
   query17	1883	549	499	499
   query18	2114	261	269	261
   query19	361	141	153	141
   query20	85	76	82	76
   query21	201	137	134	134
   query22	4905	4711	4612	4612
   query23	30662	30053	30034	30034
   query24	8627	2751	2768	2751
   query25	542	347	341	341
   query26	715	155	149	149
   query27	2149	300	300	300
   query28	5803	1862	1841	1841
   query29	871	630	602	602
   query30	285	132	142	132
   query31	922	700	731	700
   query32	88	56	49	49
   query33	553	224	220	220
   query34	837	458	458	458
   query35	851	753	745	745
   query36	1085	939	891	891
   query37	98	56	58	56
   query38	3232	3125	3133	3125
   query39	1290	1260	1254	1254
   query40	182	98	96	96
   query41	43	36	35	35
   query42	103	89	95	89
   query43	519	479	498	479
   query44	1038	685	690	685
   query45	192	185	178	178
   query46	1067	652	641	641
   query47	1591	1469	1496	1469
   query48	433	348	367	348
   query49	1051	298	289	289
   query50	794	395	378	378
   query51	5223	5129	5062	5062
   query52	93	91	86	86
   query53	347	273	281	273
   query54	250	219	220	219
   query55	78	70	74	70
   query56	213	207	200	200
   query57	982	910	902	902
   query58	217	184	184	184
   query59	2456	2371	2356	2356
   query60	243	211	215	211
   query61	96	94	84	84
   query62	624	369	368	368
   query63	299	270	273	270
   query64	4786	3704	3205	3205
   query65	3259	3257	3225	3225
   query66	811	318	306	306
   query67	14547	14039	14126	14039
   query68	4451	537	509	509
   query69	477	328	336	328
   query70	1261	1254	1269	1254
   query71	319	247	249	247
   query72	6022	2858	2694	2694
   query73	702	315	315	315
   query74	6657	6180	6171	6171
   query75	3107	2328	2361	2328
   query76	2933	926	912	912
   query77	370	239	224	224
   query78	9125	8859	8526	8526
   query79	2748	494	499	494
   query80	2092	360	351	351
   query81	545	198	197	197
   query82	852	80	86	80
   query83	247	127	123	123
   query84	285	86	78	78
   query85	2184	363	337	337
   query86	497	290	297	290
   query87	3378	3178	3176	3176
   query88	3746	2317	2308	2308
   query89	467	376	358	358
   query90	1988	164	163	163
   query91	151	125	142	125
   query92	57	43	44	43
   query93	3118	488	464	464
   query94	1303	176	176	176
   query95	481	356	7883	356
   query96	600	271	270	270
   query97	4239	4083	4115	4083
   query98	224	193	192	192
   query99	1145	730	686	686
   Total cold run time: 278011 ms
   Total hot run time: 173889 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1923995945

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1476206914


##########
gensrc/script/doris_builtins_functions.py:
##########
@@ -1661,7 +1662,9 @@
         [['money_format'], 'STRING', ['DECIMAL64'], ''],
         [['money_format'], 'STRING', ['DECIMAL128'], ''],
         [['split_part'], 'STRING', ['STRING', 'STRING', 'INT'], 'ALWAYS_NULLABLE'],
-        [['substring_index'], 'STRING', ['STRING', 'STRING', 'INT'], 'DEPEND_ON_ARGUMENT']
+        [['substring_index'], 'STRING', ['STRING', 'STRING', 'INT'], 'ALWAYS_NULLABLE'],
+        [['substring_index'], 'STRING', ['STRING', 'STRING', 'INT'], 'DEPEND_ON_ARGUMENT'],

Review Comment:
   > why substring_index is both ALWAYS_NULLABLE and DEPEND_ON_ARGUMENT
   
   Bad submission, fixed.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925005752

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 36691 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit ffc11beedfe8b760e5fb2a69a37fc78a20cd350f, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17669	4521	4475	4475
   q2	2043	143	133	133
   q3	10600	911	925	911
   q4	4646	762	722	722
   q5	7692	2800	2815	2800
   q6	184	120	119	119
   q7	1143	727	713	713
   q8	9285	1970	1989	1970
   q9	7198	6336	6322	6322
   q10	8101	2427	2430	2427
   q11	415	212	208	208
   q12	750	271	288	271
   q13	17987	3324	3309	3309
   q14	265	239	249	239
   q15	523	505	489	489
   q16	493	405	422	405
   q17	925	508	517	508
   q18	6621	5946	5815	5815
   q19	1563	1409	1265	1265
   q20	610	334	343	334
   q21	6746	3051	2966	2966
   q22	805	312	290	290
   Total cold run time: 106264 ms
   Total hot run time: 36691 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4441	4438	4332	4332
   q2	342	227	240	227
   q3	2981	2878	2804	2804
   q4	1812	1700	1598	1598
   q5	5148	5266	5265	5265
   q6	190	115	114	114
   q7	2153	1769	1746	1746
   q8	3128	3223	3256	3223
   q9	8342	8251	8310	8251
   q10	5841	3486	3561	3486
   q11	544	456	473	456
   q12	732	598	576	576
   q13	13488	3104	3080	3080
   q14	284	247	265	247
   q15	527	493	482	482
   q16	502	467	484	467
   q17	1838	1712	1694	1694
   q18	7989	7567	7449	7449
   q19	9910	1554	1549	1549
   q20	2102	1907	1890	1890
   q21	4748	4632	4649	4632
   q22	567	501	444	444
   Total cold run time: 77609 ms
   Total hot run time: 54012 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925087119

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173156 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit dc34bd12ce0a332d26c8566bf05d72ffda562e82, data reload: false
   
   query1	930	342	327	327
   query2	6563	1864	1871	1864
   query3	6697	209	209	209
   query4	31797	21971	22055	21971
   query5	4319	372	348	348
   query6	250	166	164	164
   query7	4609	276	275	275
   query8	254	172	170	170
   query9	8943	2324	2310	2310
   query10	415	214	210	210
   query11	18324	15245	15597	15245
   query12	129	76	74	74
   query13	1638	418	406	406
   query14	9405	6654	6623	6623
   query15	238	178	182	178
   query16	8034	254	251	251
   query17	1838	548	489	489
   query18	2094	271	251	251
   query19	183	142	138	138
   query20	84	77	74	74
   query21	191	131	123	123
   query22	4825	4633	4573	4573
   query23	30715	30171	29874	29874
   query24	8207	2755	2698	2698
   query25	537	334	345	334
   query26	710	146	145	145
   query27	2203	298	299	298
   query28	5468	1853	1834	1834
   query29	868	617	582	582
   query30	280	131	146	131
   query31	917	684	724	684
   query32	87	52	47	47
   query33	509	229	217	217
   query34	823	458	481	458
   query35	832	774	741	741
   query36	1004	938	915	915
   query37	90	56	57	56
   query38	3273	3135	3093	3093
   query39	1301	1259	1247	1247
   query40	179	95	92	92
   query41	38	35	34	34
   query42	98	90	91	90
   query43	529	479	488	479
   query44	1091	697	716	697
   query45	205	179	174	174
   query46	1054	647	649	647
   query47	1655	1479	1516	1479
   query48	438	350	348	348
   query49	1068	292	293	292
   query50	768	381	373	373
   query51	5237	5212	5146	5146
   query52	98	89	94	89
   query53	320	279	271	271
   query54	240	219	220	219
   query55	80	84	76	76
   query56	213	192	198	192
   query57	986	896	944	896
   query58	201	180	183	180
   query59	2557	2293	2220	2220
   query60	236	218	209	209
   query61	87	82	83	82
   query62	629	349	365	349
   query63	303	275	274	274
   query64	4734	3371	3637	3371
   query65	3260	3247	3216	3216
   query66	803	325	307	307
   query67	14400	14248	14057	14057
   query68	4367	540	525	525
   query69	465	327	331	327
   query70	1289	1175	1217	1175
   query71	315	264	260	260
   query72	6048	2831	2646	2646
   query73	705	319	317	317
   query74	6655	6168	6201	6168
   query75	3050	2386	2321	2321
   query76	2707	858	945	858
   query77	364	227	226	226
   query78	9200	8898	8584	8584
   query79	3781	492	496	492
   query80	1888	346	326	326
   query81	544	193	193	193
   query82	1310	76	78	76
   query83	234	129	123	123
   query84	290	79	85	79
   query85	2078	330	321	321
   query86	496	303	299	299
   query87	3340	3166	3244	3166
   query88	4418	2321	2333	2321
   query89	456	354	364	354
   query90	1937	162	159	159
   query91	148	140	120	120
   query92	54	39	40	39
   query93	5521	472	462	462
   query94	1300	172	170	170
   query95	7908	359	360	359
   query96	625	270	279	270
   query97	4242	4084	4109	4084
   query98	214	201	188	188
   query99	1146	662	687	662
   Total cold run time: 288186 ms
   Total hot run time: 173156 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925089459

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.54 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit dc34bd12ce0a332d26c8566bf05d72ffda562e82, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.06	0.03	0.02
   query3	0.23	0.06	0.06
   query4	1.69	0.10	0.10
   query5	0.54	0.51	0.51
   query6	1.20	0.67	0.63
   query7	0.02	0.01	0.01
   query8	0.03	0.02	0.02
   query9	0.56	0.50	0.50
   query10	0.55	0.53	0.54
   query11	0.12	0.09	0.09
   query12	0.11	0.08	0.09
   query13	0.60	0.60	0.60
   query14	0.77	0.80	0.80
   query15	0.80	0.76	0.79
   query16	0.39	0.37	0.38
   query17	1.01	1.03	1.02
   query18	0.21	0.28	0.24
   query19	1.88	1.76	1.78
   query20	0.01	0.01	0.02
   query21	15.43	0.57	0.56
   query22	2.76	2.31	1.59
   query23	17.32	0.83	0.81
   query24	2.39	1.06	0.90
   query25	0.29	0.17	0.07
   query26	0.58	0.14	0.13
   query27	0.06	0.05	0.04
   query28	11.61	0.84	0.83
   query29	12.55	3.13	3.22
   query30	0.64	0.50	0.52
   query31	2.78	0.34	0.35
   query32	3.37	0.48	0.48
   query33	3.22	3.24	3.18
   query34	15.72	4.27	4.30
   query35	4.32	4.26	4.29
   query36	1.10	1.05	1.06
   query37	0.06	0.04	0.04
   query38	0.04	0.03	0.03
   query39	0.02	0.02	0.02
   query40	0.17	0.13	0.13
   query41	0.08	0.02	0.01
   query42	0.03	0.01	0.02
   query43	0.03	0.02	0.02
   Total cold run time: 105.39 s
   Total hot run time: 30.54 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925111635

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925587719

   run pipelinex_p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1924054155

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 37227 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 12d5f981337f488a8184818a7780cc69c2521764, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17646	4568	4511	4511
   q2	2043	137	134	134
   q3	10602	957	936	936
   q4	4651	790	723	723
   q5	7726	2855	2854	2854
   q6	184	118	119	118
   q7	1150	729	726	726
   q8	9258	1981	2017	1981
   q9	7261	6339	6325	6325
   q10	8123	2454	2449	2449
   q11	410	209	207	207
   q12	736	264	296	264
   q13	18006	3315	3284	3284
   q14	278	249	247	247
   q15	525	493	485	485
   q16	487	397	401	397
   q17	935	569	521	521
   q18	6738	6039	5977	5977
   q19	1566	1378	1341	1341
   q20	572	350	352	350
   q21	6806	3100	3185	3100
   q22	812	297	307	297
   Total cold run time: 106515 ms
   Total hot run time: 37227 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4494	4407	4352	4352
   q2	331	236	231	231
   q3	2987	2891	2860	2860
   q4	1851	1710	1625	1625
   q5	5142	5211	5190	5190
   q6	189	113	115	113
   q7	2197	1774	1769	1769
   q8	3151	3234	3286	3234
   q9	8303	8306	8323	8306
   q10	5798	3578	3562	3562
   q11	542	463	464	463
   q12	721	571	573	571
   q13	15896	3125	3088	3088
   q14	293	261	258	258
   q15	549	489	490	489
   q16	517	469	464	464
   q17	1855	1697	1689	1689
   q18	7933	7805	7481	7481
   q19	5735	1502	1468	1468
   q20	2122	1918	1899	1899
   q21	4915	4571	4632	4571
   q22	559	480	454	454
   Total cold run time: 76080 ms
   Total hot run time: 54137 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925605161

   TeamCity be ut coverage result:
    Function Coverage: 36.18% (8634/23864) 
    Line Coverage: 28.23% (70585/250029)
    Region Coverage: 27.25% (36437/133690)
    Branch Coverage: 24.04% (18658/77624)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/4fb7abd31f099ab60fcdc55a4367c1949efc49ac_4fb7abd31f099ab60fcdc55a4367c1949efc49ac/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1923289813

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1475971752


##########
be/src/vec/functions/function_string.h:
##########
@@ -2740,6 +2741,59 @@ class FunctionStringParseUrl : public IFunction {
     }
 };
 
+class FunctionUrlDecode : public IFunction {
+public:
+    static constexpr auto name = "url_decode";
+    static FunctionPtr create() { return std::make_shared<FunctionUrlDecode>(); }
+    String get_name() const override { return name; }
+    size_t get_number_of_arguments() const override { return 1; }
+    bool is_variadic() const override { return false; }
+
+    DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+        return std::make_shared<DataTypeString>();
+    }
+
+    Status execute_impl(FunctionContext* context, Block& block,

Review Comment:
   warning: method 'execute_impl' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
       static Status execute_impl(FunctionContext* context, Block& block,
   ```
   
   be/src/vec/functions/function_string.h:2758:
   ```diff
   -                         size_t input_rows_count) const override {
   +                         size_t input_rows_count) override {
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1922988634

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1924991797

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477187443


##########
be/src/vec/functions/function_string.h:
##########
@@ -2740,6 +2741,51 @@ class FunctionStringParseUrl : public IFunction {
     }
 };
 
+class FunctionUrlDecode : public IFunction {
+public:
+    static constexpr auto name = "url_decode";
+    static FunctionPtr create() { return std::make_shared<FunctionUrlDecode>(); }
+    String get_name() const override { return name; }
+    size_t get_number_of_arguments() const override { return 1; }
+    bool is_variadic() const override { return false; }
+
+    DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+        return std::make_shared<DataTypeString>();
+    }
+
+    Status execute_impl(FunctionContext* context, Block& block,
+
+                        const ColumnNumbers& arguments, size_t result,
+                        size_t input_rows_count) const override {
+        auto res = ColumnString::create();
+        auto& res_offsets = res->get_offsets();
+        auto& res_chars = res->get_chars();
+        res_offsets.resize(input_rows_count);
+
+        ColumnPtr argument_column =
+                block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+        const auto* url_col = check_and_get_column<ColumnString>(argument_column.get());
+
+        if (!url_col) {
+            return Status::InternalError("Not supported input argument type");
+        }
+
+        for (size_t i = 0; i < input_rows_count; ++i) {
+            auto source = url_col->get_data_at(i);
+            StringRef url_val(const_cast<char*>(source.data), source.size);
+
+            std::string decoded_url;

Review Comment:
   > reuse the string mem
   
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477246512


##########
regression-test/suites/nereids_function_p0/scalar_function/U.groovy:
##########
@@ -43,4 +43,5 @@ suite("nereids_scalar_fn_U") {
 	qt_sql_upper_String_notnull "select upper(kstr) from fn_test_not_nullable order by kstr"
 	sql "select user() from fn_test"
 	sql "select user() from fn_test_not_nullable"
+    qt_sql_url_decode "select url_decode('https%3A%2F%2Fdoris.apache.org%2Fzh-CN%2Fdocs%2Fsql-manual%2Fsql-functions%2Fstring-functions')"

Review Comment:
   no display error,maybe you indented  \t or ' '



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925111788

   run pipelinex_p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925160202

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.95 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 99ca84ba14030743fd042bd488cb00480d2fce06, data reload: false
   
   query1	0.04	0.02	0.03
   query2	0.06	0.03	0.02
   query3	0.24	0.06	0.06
   query4	1.65	0.10	0.09
   query5	0.52	0.51	0.52
   query6	1.24	0.65	0.66
   query7	0.02	0.01	0.01
   query8	0.04	0.03	0.02
   query9	0.54	0.49	0.49
   query10	0.55	0.55	0.57
   query11	0.12	0.08	0.09
   query12	0.12	0.09	0.09
   query13	0.60	0.60	0.60
   query14	0.78	0.79	0.81
   query15	0.80	0.80	0.78
   query16	0.37	0.39	0.38
   query17	1.02	1.02	1.01
   query18	0.23	0.26	0.24
   query19	1.89	1.82	1.76
   query20	0.01	0.02	0.02
   query21	15.40	0.60	0.59
   query22	2.32	2.57	1.99
   query23	17.14	0.81	0.79
   query24	2.73	1.34	0.83
   query25	0.31	0.12	0.17
   query26	0.62	0.13	0.14
   query27	0.06	0.04	0.05
   query28	12.10	0.83	0.83
   query29	12.48	3.21	3.17
   query30	0.60	0.48	0.54
   query31	2.79	0.35	0.36
   query32	3.35	0.48	0.49
   query33	3.16	3.25	3.25
   query34	16.00	4.28	4.21
   query35	4.31	4.25	4.22
   query36	1.11	1.06	1.05
   query37	0.06	0.04	0.04
   query38	0.05	0.02	0.02
   query39	0.03	0.02	0.01
   query40	0.16	0.13	0.13
   query41	0.07	0.01	0.01
   query42	0.02	0.02	0.02
   query43	0.03	0.02	0.02
   Total cold run time: 105.74 s
   Total hot run time: 30.95 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925155271

   TeamCity be ut coverage result:
    Function Coverage: 36.14% (8625/23863) 
    Line Coverage: 28.21% (70516/249985)
    Region Coverage: 27.22% (36380/133674)
    Branch Coverage: 24.01% (18635/77620)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/99ca84ba14030743fd042bd488cb00480d2fce06_99ca84ba14030743fd042bd488cb00480d2fce06/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925138173

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1473699795


##########
be/src/vec/functions/function_string.h:
##########
@@ -2602,6 +2603,57 @@ class FunctionStringParseUrl : public IFunction {
     }
 };
 
+class FunctionUrlDecode : public IFunction {
+public:
+    static constexpr auto name = "url_decode";
+    static FunctionPtr create() { return std::make_shared<FunctionUrlDecode>(); }
+    String get_name() const override { return name; }
+    size_t get_number_of_arguments() const override { return 1; }
+    bool is_variadic() const override { return false; }
+
+    static DataTypePtr get_return_type_impl(const DataTypes& arguments) override {
+            return std::make_shared<DataTypeString>();
+        }
+    bool use_default_implementation_for_nulls() const override { return true; }
+
+    static Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+                            size_t result, size_t input_rows_count) override {

Review Comment:
   warning: method 'execute_impl' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
       static Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
                               size_t result, size_t input_rows_count) override {
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477349510


##########
regression-test/suites/nereids_function_p0/scalar_function/U.groovy:
##########
@@ -43,4 +43,5 @@ suite("nereids_scalar_fn_U") {
 	qt_sql_upper_String_notnull "select upper(kstr) from fn_test_not_nullable order by kstr"
 	sql "select user() from fn_test"
 	sql "select user() from fn_test_not_nullable"
-}
\ No newline at end of file
+	qt_sql_url_decode "select url_decode('https%3A%2F%2Fdoris.apache.org%2Fzh-CN%2Fdocs%2Fsql-manual%2Fsql-functions%2Fstring-functions')"

Review Comment:
   Add more cases, such as invalid input: null, empty string, invalid url, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925158325

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 174106 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 99ca84ba14030743fd042bd488cb00480d2fce06, data reload: false
   
   query1	935	348	326	326
   query2	6554	1889	1904	1889
   query3	6697	212	211	211
   query4	31990	22146	21990	21990
   query5	4290	356	424	356
   query6	253	158	159	158
   query7	4604	275	283	275
   query8	256	172	177	172
   query9	8836	2315	2286	2286
   query10	407	212	203	203
   query11	17428	15421	15263	15263
   query12	130	84	75	75
   query13	1614	406	413	406
   query14	9439	7210	7120	7120
   query15	271	187	185	185
   query16	8149	263	239	239
   query17	2011	532	508	508
   query18	2120	279	259	259
   query19	372	136	137	136
   query20	82	78	79	78
   query21	216	138	127	127
   query22	4943	4738	4705	4705
   query23	30729	30042	29979	29979
   query24	9419	2757	2814	2757
   query25	523	340	353	340
   query26	706	141	146	141
   query27	2179	292	295	292
   query28	5760	1850	1828	1828
   query29	841	601	597	597
   query30	280	133	139	133
   query31	945	694	725	694
   query32	86	51	47	47
   query33	587	224	225	224
   query34	836	446	472	446
   query35	827	764	752	752
   query36	1061	958	904	904
   query37	95	59	57	57
   query38	3233	3132	3106	3106
   query39	1310	1247	1235	1235
   query40	180	94	94	94
   query41	38	34	34	34
   query42	102	90	90	90
   query43	504	493	501	493
   query44	1021	679	697	679
   query45	187	185	175	175
   query46	1050	662	654	654
   query47	1571	1559	1496	1496
   query48	449	353	358	353
   query49	1040	283	299	283
   query50	760	378	389	378
   query51	5243	5155	5061	5061
   query52	100	90	84	84
   query53	340	270	273	270
   query54	247	220	213	213
   query55	75	79	73	73
   query56	226	196	198	196
   query57	1006	914	889	889
   query58	199	184	182	182
   query59	2452	2417	2225	2225
   query60	235	212	210	210
   query61	94	86	84	84
   query62	651	358	339	339
   query63	288	270	272	270
   query64	4754	3222	3168	3168
   query65	3235	3263	3213	3213
   query66	814	309	300	300
   query67	14489	14177	14217	14177
   query68	4865	523	532	523
   query69	472	325	329	325
   query70	1313	1278	1220	1220
   query71	316	251	254	251
   query72	6059	2879	2653	2653
   query73	686	322	316	316
   query74	6622	6182	6258	6182
   query75	3074	2349	2339	2339
   query76	3052	914	896	896
   query77	368	228	225	225
   query78	9173	8858	8629	8629
   query79	2739	508	512	508
   query80	2105	352	334	334
   query81	545	197	197	197
   query82	872	79	80	79
   query83	254	121	123	121
   query84	283	81	83	81
   query85	2210	358	324	324
   query86	491	314	306	306
   query87	3358	3210	3210	3210
   query88	3988	2325	2313	2313
   query89	437	343	366	343
   query90	1967	166	159	159
   query91	167	118	122	118
   query92	53	43	40	40
   query93	4174	486	468	468
   query94	1315	171	173	171
   query95	8093	345	7701	345
   query96	585	276	270	270
   query97	4247	4106	4108	4106
   query98	215	197	189	189
   query99	1184	720	683	683
   Total cold run time: 287646 ms
   Total hot run time: 174106 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1924083665

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.6 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 12d5f981337f488a8184818a7780cc69c2521764, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.06	0.03	0.02
   query3	0.23	0.06	0.06
   query4	1.68	0.10	0.09
   query5	0.52	0.52	0.52
   query6	1.19	0.65	0.63
   query7	0.02	0.01	0.01
   query8	0.04	0.03	0.02
   query9	0.56	0.50	0.50
   query10	0.55	0.55	0.60
   query11	0.12	0.08	0.09
   query12	0.11	0.09	0.10
   query13	0.60	0.62	0.61
   query14	0.78	0.80	0.79
   query15	0.80	0.77	0.76
   query16	0.38	0.38	0.40
   query17	1.05	1.02	1.04
   query18	0.22	0.27	0.24
   query19	1.86	1.81	1.79
   query20	0.01	0.02	0.01
   query21	15.41	0.59	0.58
   query22	2.31	2.22	2.16
   query23	17.80	0.93	0.81
   query24	2.28	1.14	1.70
   query25	0.36	0.21	0.10
   query26	0.57	0.15	0.15
   query27	0.05	0.06	0.05
   query28	11.20	0.83	0.82
   query29	12.48	3.13	3.25
   query30	0.64	0.55	0.54
   query31	2.79	0.36	0.37
   query32	3.34	0.50	0.48
   query33	3.19	3.26	3.25
   query34	15.67	4.28	4.25
   query35	4.35	4.26	4.30
   query36	1.10	1.06	1.05
   query37	0.06	0.05	0.05
   query38	0.03	0.03	0.03
   query39	0.02	0.02	0.02
   query40	0.17	0.13	0.13
   query41	0.06	0.01	0.02
   query42	0.02	0.01	0.01
   query43	0.03	0.02	0.02
   Total cold run time: 104.75 s
   Total hot run time: 31.6 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925017297

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit ffc11beedfe8b760e5fb2a69a37fc78a20cd350f with default session variables
   Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       14.5 seconds inserted 10000000 Rows, about 689K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1923314501

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1926107153

   TeamCity be ut coverage result:
    Function Coverage: 36.15% (8627/23867) 
    Line Coverage: 28.21% (70549/250090)
    Region Coverage: 27.22% (36412/133787)
    Branch Coverage: 24.00% (18648/77692)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/cdf1cc55c3b21ca40e1d84278855daa3621c830c_cdf1cc55c3b21ca40e1d84278855daa3621c830c/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1926108550

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 36748 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit cdf1cc55c3b21ca40e1d84278855daa3621c830c, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17665	4459	4387	4387
   q2	2035	137	135	135
   q3	10600	898	887	887
   q4	4647	701	721	701
   q5	7682	2881	2867	2867
   q6	180	119	118	118
   q7	1073	721	707	707
   q8	9302	1999	1968	1968
   q9	7194	6324	6337	6324
   q10	8069	2440	2444	2440
   q11	423	209	198	198
   q12	762	256	281	256
   q13	17993	3297	3334	3297
   q14	271	254	245	245
   q15	527	488	494	488
   q16	469	423	395	395
   q17	926	503	554	503
   q18	6833	5986	5845	5845
   q19	1578	1393	1439	1393
   q20	570	333	318	318
   q21	6868	2990	3182	2990
   q22	795	319	286	286
   Total cold run time: 106462 ms
   Total hot run time: 36748 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4529	4363	4327	4327
   q2	323	231	231	231
   q3	2985	2809	2804	2804
   q4	1854	1645	1628	1628
   q5	5114	5174	5214	5174
   q6	190	113	114	113
   q7	2151	1708	1710	1708
   q8	3101	3227	3268	3227
   q9	8333	8291	8313	8291
   q10	5939	3576	3540	3540
   q11	533	472	460	460
   q12	743	594	574	574
   q13	11866	3057	3030	3030
   q14	272	265	254	254
   q15	536	492	491	491
   q16	519	473	474	473
   q17	1840	1676	1669	1669
   q18	7940	7734	7503	7503
   q19	8544	1509	1466	1466
   q20	2110	1904	1917	1904
   q21	4725	4754	4468	4468
   q22	585	470	451	451
   Total cold run time: 74732 ms
   Total hot run time: 53786 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477172232


##########
be/src/vec/functions/function_string.h:
##########
@@ -2740,6 +2741,51 @@ class FunctionStringParseUrl : public IFunction {
     }
 };
 
+class FunctionUrlDecode : public IFunction {

Review Comment:
   the function should be in url/function_url.cpp



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925608612

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 4fb7abd31f099ab60fcdc55a4367c1949efc49ac with default session variables
   Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:          60 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       13.7 seconds inserted 10000000 Rows, about 729K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925773225

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925569200

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925576002

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173566 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0b09df9f6b3c2867db2a64fa8a0e0c22897fe3d2, data reload: false
   
   query1	955	344	333	333
   query2	6534	1981	1817	1817
   query3	6703	205	202	202
   query4	31597	22034	21966	21966
   query5	4213	357	416	357
   query6	251	187	165	165
   query7	4605	283	282	282
   query8	246	167	179	167
   query9	9138	2346	2311	2311
   query10	401	219	234	219
   query11	17482	15370	15301	15301
   query12	136	76	75	75
   query13	1629	410	439	410
   query14	9590	6884	7127	6884
   query15	235	171	193	171
   query16	8106	260	243	243
   query17	1865	534	510	510
   query18	2096	265	259	259
   query19	371	137	135	135
   query20	82	80	75	75
   query21	194	126	120	120
   query22	4966	4715	4503	4503
   query23	30902	30090	30051	30051
   query24	10557	2749	2724	2724
   query25	577	344	334	334
   query26	1445	138	143	138
   query27	2934	302	297	297
   query28	7514	1867	1843	1843
   query29	892	605	613	605
   query30	284	133	139	133
   query31	915	691	716	691
   query32	96	48	45	45
   query33	723	217	225	217
   query34	1100	451	464	451
   query35	855	759	738	738
   query36	977	926	925	925
   query37	114	58	57	57
   query38	3235	3115	3079	3079
   query39	1288	1252	1242	1242
   query40	260	95	92	92
   query41	37	39	35	35
   query42	96	87	87	87
   query43	529	459	490	459
   query44	1091	690	705	690
   query45	192	172	174	172
   query46	1043	663	666	663
   query47	1529	1499	1466	1466
   query48	426	342	351	342
   query49	1113	287	275	275
   query50	777	381	380	380
   query51	5257	5142	5123	5123
   query52	113	85	84	84
   query53	333	268	275	268
   query54	270	221	213	213
   query55	78	82	68	68
   query56	219	192	199	192
   query57	966	875	887	875
   query58	201	176	183	176
   query59	2409	2309	2365	2309
   query60	237	218	203	203
   query61	82	82	85	82
   query62	653	356	363	356
   query63	294	282	268	268
   query64	5958	3562	3301	3301
   query65	3260	3238	3233	3233
   query66	1062	317	301	301
   query67	14489	14082	14250	14082
   query68	4077	525	529	525
   query69	452	319	335	319
   query70	1275	1196	1224	1196
   query71	323	243	258	243
   query72	5812	2830	2665	2665
   query73	696	327	316	316
   query74	6504	6154	6176	6154
   query75	3005	2298	2308	2298
   query76	2532	900	975	900
   query77	334	234	226	226
   query78	9075	8712	8506	8506
   query79	3171	493	492	492
   query80	2065	350	332	332
   query81	528	192	197	192
   query82	864	86	77	77
   query83	255	134	130	130
   query84	283	81	83	81
   query85	2215	329	317	317
   query86	492	279	280	279
   query87	3349	3178	3171	3171
   query88	4433	2333	2315	2315
   query89	438	365	358	358
   query90	2089	165	162	162
   query91	154	120	123	120
   query92	59	45	45	45
   query93	4828	501	500	500
   query94	1275	175	169	169
   query95	8049	7719	356	356
   query96	596	276	271	271
   query97	4204	4140	4111	4111
   query98	220	213	193	193
   query99	1150	691	677	677
   Total cold run time: 293579 ms
   Total hot run time: 173566 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925703092

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 72e40b082ecfee7ceda6b5190049294395c04b1a with default session variables
   Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       13.7 seconds inserted 10000000 Rows, about 729K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477172802


##########
regression-test/suites/nereids_function_p0/scalar_function/U.groovy:
##########
@@ -43,4 +43,5 @@ suite("nereids_scalar_fn_U") {
 	qt_sql_upper_String_notnull "select upper(kstr) from fn_test_not_nullable order by kstr"
 	sql "select user() from fn_test"
 	sql "select user() from fn_test_not_nullable"
+    qt_sql_url_decode "select url_decode('https%3A%2F%2Fdoris.apache.org%2Fzh-CN%2Fdocs%2Fsql-manual%2Fsql-functions%2Fstring-functions')"

Review Comment:
   The indentation needs to be aligned like other SQL



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925604199

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 36921 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 4fb7abd31f099ab60fcdc55a4367c1949efc49ac, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17663	4465	4381	4381
   q2	2035	140	132	132
   q3	10605	943	904	904
   q4	4652	731	703	703
   q5	7696	2817	2828	2817
   q6	179	121	120	120
   q7	1135	724	711	711
   q8	9273	1993	2016	1993
   q9	7281	6319	6340	6319
   q10	8097	2454	2469	2454
   q11	408	209	204	204
   q12	783	286	273	273
   q13	17997	3268	3331	3268
   q14	271	252	242	242
   q15	530	497	485	485
   q16	470	408	401	401
   q17	929	561	516	516
   q18	6774	5932	5963	5932
   q19	1564	1352	1359	1352
   q20	611	336	342	336
   q21	6926	3088	3066	3066
   q22	817	322	312	312
   Total cold run time: 106696 ms
   Total hot run time: 36921 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4528	4412	4347	4347
   q2	334	227	245	227
   q3	3004	2847	2792	2792
   q4	1857	1574	1648	1574
   q5	5188	5257	5225	5225
   q6	187	113	115	113
   q7	2145	1807	1747	1747
   q8	3057	3247	3220	3220
   q9	8320	8276	8216	8216
   q10	5858	3606	3568	3568
   q11	536	467	484	467
   q12	730	573	582	573
   q13	12816	3092	3050	3050
   q14	279	247	260	247
   q15	520	487	497	487
   q16	525	477	471	471
   q17	1814	1658	1690	1658
   q18	8033	7782	7459	7459
   q19	9803	1547	1558	1547
   q20	2144	1940	1917	1917
   q21	4816	4641	4643	4641
   q22	521	456	485	456
   Total cold run time: 77015 ms
   Total hot run time: 54002 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925069676

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 36595 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit dc34bd12ce0a332d26c8566bf05d72ffda562e82, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17690	4490	4405	4405
   q2	2032	145	132	132
   q3	10595	902	928	902
   q4	4648	742	719	719
   q5	7714	2805	2764	2764
   q6	181	119	118	118
   q7	1142	728	711	711
   q8	9238	1989	1966	1966
   q9	7247	6294	6321	6294
   q10	8075	2423	2427	2423
   q11	421	201	204	201
   q12	722	277	272	272
   q13	18024	3333	3299	3299
   q14	282	262	253	253
   q15	532	493	488	488
   q16	481	402	418	402
   q17	917	448	523	448
   q18	6766	5999	5842	5842
   q19	1550	1442	1358	1358
   q20	579	345	345	345
   q21	6800	2950	3054	2950
   q22	814	326	303	303
   Total cold run time: 106450 ms
   Total hot run time: 36595 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4445	4330	4590	4330
   q2	327	235	239	235
   q3	3005	2789	2786	2786
   q4	1833	1619	1586	1586
   q5	5141	5155	5139	5139
   q6	190	114	115	114
   q7	2142	1759	1715	1715
   q8	3094	3243	3224	3224
   q9	8266	8236	8224	8224
   q10	5833	3540	3519	3519
   q11	548	453	462	453
   q12	731	560	563	560
   q13	15643	3086	3056	3056
   q14	263	247	254	247
   q15	535	481	491	481
   q16	524	473	474	473
   q17	1849	1656	1693	1656
   q18	7893	7568	7424	7424
   q19	6727	1519	1528	1519
   q20	2119	1914	1894	1894
   q21	4792	4544	4551	4544
   q22	580	463	450	450
   Total cold run time: 76480 ms
   Total hot run time: 53629 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925068637

   TeamCity be ut coverage result:
    Function Coverage: 36.16% (8628/23863) 
    Line Coverage: 28.22% (70535/249985)
    Region Coverage: 27.23% (36394/133674)
    Branch Coverage: 24.02% (18641/77620)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/dc34bd12ce0a332d26c8566bf05d72ffda562e82_dc34bd12ce0a332d26c8566bf05d72ffda562e82/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477558916


##########
regression-test/suites/nereids_function_p0/scalar_function/U.groovy:
##########
@@ -43,4 +43,5 @@ suite("nereids_scalar_fn_U") {
 	qt_sql_upper_String_notnull "select upper(kstr) from fn_test_not_nullable order by kstr"
 	sql "select user() from fn_test"
 	sql "select user() from fn_test_not_nullable"
-}
\ No newline at end of file
+	qt_sql_url_decode "select url_decode('https%3A%2F%2Fdoris.apache.org%2Fzh-CN%2Fdocs%2Fsql-manual%2Fsql-functions%2Fstring-functions')"

Review Comment:
   > Add more cases, such as invalid input: null, empty string, invalid url, etc.
   
   Done. PTAL



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1926076033

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1919190527

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1926126349

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit cdf1cc55c3b21ca40e1d84278855daa3621c830c with default session variables
   Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      33 seconds loaded 861443392 Bytes, about 24 MB/s
   Insert into select:       14.6 seconds inserted 10000000 Rows, about 684K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477167870


##########
be/src/vec/functions/function_string.h:
##########
@@ -2740,6 +2741,59 @@ class FunctionStringParseUrl : public IFunction {
     }
 };
 
+class FunctionUrlDecode : public IFunction {
+public:
+    static constexpr auto name = "url_decode";
+    static FunctionPtr create() { return std::make_shared<FunctionUrlDecode>(); }
+    String get_name() const override { return name; }
+    size_t get_number_of_arguments() const override { return 1; }
+    bool is_variadic() const override { return false; }
+
+    DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+        return std::make_shared<DataTypeString>();
+    }
+
+    Status execute_impl(FunctionContext* context, Block& block,
+
+                        const ColumnNumbers& arguments, size_t result,
+                        size_t input_rows_count) const override {
+        auto null_map = ColumnUInt8::create(input_rows_count, 0);
+        auto& null_map_data = null_map->get_data();
+
+        auto res = ColumnString::create();
+        auto& res_offsets = res->get_offsets();
+        auto& res_chars = res->get_chars();
+        res_offsets.resize(input_rows_count);
+
+        ColumnPtr argument_column =
+                block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+        const auto* url_col = check_and_get_column<ColumnString>(argument_column.get());
+
+        if (!url_col) {
+            return Status::InternalError("Not supported input argument type");
+        }
+
+        for (size_t i = 0; i < input_rows_count; ++i) {
+            if (null_map_data[i]) {

Review Comment:
   this check is seems error:
   null_map_data it's from null_map, this is your create local variables and all data is 0?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925576813

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.14 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 0b09df9f6b3c2867db2a64fa8a0e0c22897fe3d2, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.06	0.02	0.02
   query3	0.22	0.06	0.06
   query4	1.68	0.10	0.10
   query5	0.52	0.51	0.51
   query6	1.21	0.64	0.64
   query7	0.02	0.01	0.01
   query8	0.03	0.02	0.02
   query9	0.55	0.49	0.50
   query10	0.57	0.56	0.56
   query11	0.11	0.08	0.09
   query12	0.11	0.09	0.09
   query13	0.61	0.61	0.61
   query14	0.80	0.79	0.81
   query15	0.79	0.78	0.76
   query16	0.37	0.39	0.39
   query17	1.06	1.00	1.02
   query18	0.22	0.26	0.22
   query19	1.90	1.78	1.84
   query20	0.02	0.01	0.01
   query21	15.41	0.57	0.55
   query22	2.54	2.24	2.43
   query23	17.36	0.83	0.74
   query24	2.37	1.19	0.66
   query25	0.34	0.14	0.26
   query26	0.48	0.14	0.14
   query27	0.05	0.05	0.04
   query28	11.94	0.86	0.83
   query29	12.53	3.25	3.28
   query30	0.65	0.54	0.49
   query31	2.80	0.34	0.35
   query32	3.41	0.50	0.48
   query33	3.23	3.22	3.20
   query34	15.71	4.29	4.28
   query35	4.30	4.27	4.35
   query36	1.12	1.07	1.07
   query37	0.06	0.05	0.05
   query38	0.04	0.03	0.03
   query39	0.02	0.02	0.01
   query40	0.15	0.13	0.12
   query41	0.07	0.02	0.01
   query42	0.02	0.01	0.02
   query43	0.02	0.02	0.02
   Total cold run time: 105.51 s
   Total hot run time: 31.14 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925598894

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925599629

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925607936

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.21 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 4fb7abd31f099ab60fcdc55a4367c1949efc49ac, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.06	0.02	0.02
   query3	0.23	0.06	0.06
   query4	1.68	0.10	0.10
   query5	0.53	0.51	0.52
   query6	1.18	0.65	0.66
   query7	0.02	0.01	0.02
   query8	0.03	0.03	0.03
   query9	0.55	0.49	0.48
   query10	0.56	0.55	0.54
   query11	0.12	0.08	0.08
   query12	0.11	0.09	0.10
   query13	0.60	0.61	0.60
   query14	0.78	0.82	0.79
   query15	0.79	0.80	0.78
   query16	0.38	0.39	0.36
   query17	1.00	1.01	1.01
   query18	0.19	0.28	0.22
   query19	1.90	1.72	1.80
   query20	0.01	0.00	0.00
   query21	15.40	0.57	0.57
   query22	2.63	2.98	1.41
   query23	17.47	0.94	0.77
   query24	2.36	1.62	1.55
   query25	0.36	0.22	0.19
   query26	0.56	0.14	0.13
   query27	0.05	0.05	0.05
   query28	10.42	0.85	0.84
   query29	12.51	3.18	3.16
   query30	0.67	0.59	0.54
   query31	2.80	0.35	0.35
   query32	3.34	0.48	0.49
   query33	3.18	3.21	3.26
   query34	15.97	4.26	4.26
   query35	4.30	4.28	4.30
   query36	1.11	1.06	1.07
   query37	0.06	0.05	0.05
   query38	0.04	0.03	0.03
   query39	0.02	0.02	0.02
   query40	0.15	0.15	0.13
   query41	0.07	0.02	0.02
   query42	0.02	0.01	0.02
   query43	0.02	0.02	0.02
   Total cold run time: 104.27 s
   Total hot run time: 31.21 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925161229

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 99ca84ba14030743fd042bd488cb00480d2fce06 with default session variables
   Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
   Insert into select:       14.3 seconds inserted 10000000 Rows, about 699K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925693422

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 37185 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 72e40b082ecfee7ceda6b5190049294395c04b1a, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17639	4520	4439	4439
   q2	2046	142	134	134
   q3	10595	931	946	931
   q4	4645	746	707	707
   q5	7719	2805	2827	2805
   q6	185	118	119	118
   q7	1142	732	736	732
   q8	9276	2018	2014	2014
   q9	7296	6428	6413	6413
   q10	8139	2476	2459	2459
   q11	423	199	211	199
   q12	762	289	282	282
   q13	18010	3268	3297	3268
   q14	280	240	250	240
   q15	541	501	488	488
   q16	510	393	398	393
   q17	936	522	517	517
   q18	6908	6090	5914	5914
   q19	1546	1362	1425	1362
   q20	600	354	353	353
   q21	7073	3105	3139	3105
   q22	791	312	312	312
   Total cold run time: 107062 ms
   Total hot run time: 37185 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4438	4384	4467	4384
   q2	327	243	238	238
   q3	2995	2850	2829	2829
   q4	1867	1610	1577	1577
   q5	5167	5241	5286	5241
   q6	187	113	115	113
   q7	2212	1821	1778	1778
   q8	3077	3255	3269	3255
   q9	8334	8282	8302	8282
   q10	5836	3584	3569	3569
   q11	542	446	461	446
   q12	772	582	599	582
   q13	10812	3031	3086	3031
   q14	294	244	251	244
   q15	537	492	493	492
   q16	512	474	474	474
   q17	1845	1691	1685	1685
   q18	7918	7849	7712	7712
   q19	6946	1519	1553	1519
   q20	2115	1920	1880	1880
   q21	4755	4577	4554	4554
   q22	536	457	498	457
   Total cold run time: 72024 ms
   Total hot run time: 54342 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1926124108

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.14 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit cdf1cc55c3b21ca40e1d84278855daa3621c830c, data reload: false
   
   query1	0.03	0.03	0.03
   query2	0.06	0.02	0.02
   query3	0.23	0.06	0.06
   query4	1.66	0.10	0.10
   query5	0.52	0.51	0.51
   query6	1.22	0.65	0.65
   query7	0.02	0.01	0.02
   query8	0.04	0.03	0.03
   query9	0.54	0.49	0.49
   query10	0.55	0.56	0.55
   query11	0.12	0.08	0.08
   query12	0.11	0.09	0.09
   query13	0.60	0.59	0.60
   query14	0.80	0.81	0.79
   query15	0.79	0.77	0.77
   query16	0.38	0.39	0.40
   query17	1.02	1.03	1.00
   query18	0.21	0.28	0.25
   query19	1.88	1.77	1.81
   query20	0.01	0.00	0.01
   query21	15.42	0.60	0.56
   query22	2.26	2.38	2.52
   query23	17.22	0.96	0.90
   query24	2.80	1.23	0.36
   query25	0.31	0.23	0.16
   query26	0.49	0.13	0.13
   query27	0.04	0.06	0.03
   query28	12.23	0.88	0.83
   query29	12.54	3.27	3.12
   query30	0.64	0.54	0.55
   query31	2.78	0.35	0.34
   query32	3.34	0.48	0.49
   query33	3.23	3.20	3.25
   query34	15.79	4.31	4.30
   query35	4.29	4.35	4.33
   query36	1.12	1.06	1.06
   query37	0.06	0.04	0.05
   query38	0.04	0.03	0.03
   query39	0.03	0.01	0.01
   query40	0.17	0.13	0.14
   query41	0.07	0.01	0.02
   query42	0.03	0.02	0.01
   query43	0.03	0.02	0.01
   Total cold run time: 105.72 s
   Total hot run time: 31.14 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1925574421

   TeamCity be ut coverage result:
    Function Coverage: 36.16% (8629/23864) 
    Line Coverage: 28.22% (70557/250028)
    Region Coverage: 27.24% (36416/133690)
    Branch Coverage: 24.02% (18645/77624)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/0b09df9f6b3c2867db2a64fa8a0e0c22897fe3d2_0b09df9f6b3c2867db2a64fa8a0e0c22897fe3d2/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477186296


##########
regression-test/suites/nereids_function_p0/scalar_function/U.groovy:
##########
@@ -43,4 +43,5 @@ suite("nereids_scalar_fn_U") {
 	qt_sql_upper_String_notnull "select upper(kstr) from fn_test_not_nullable order by kstr"
 	sql "select user() from fn_test"
 	sql "select user() from fn_test_not_nullable"
+    qt_sql_url_decode "select url_decode('https%3A%2F%2Fdoris.apache.org%2Fzh-CN%2Fdocs%2Fsql-manual%2Fsql-functions%2Fstring-functions')"

Review Comment:
   > The indentation needs to be aligned like other SQL
   
   
   ![image](https://github.com/apache/doris/assets/48236177/34841cf7-ccaf-4c67-b5c6-ce6b6758a094)
   This may be a display error. Source files are indented normally



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1477186375


##########
be/src/vec/functions/function_string.h:
##########
@@ -2740,6 +2741,51 @@ class FunctionStringParseUrl : public IFunction {
     }
 };
 
+class FunctionUrlDecode : public IFunction {

Review Comment:
   > the function should be in url/function_url.cpp
   
   I will migrate it in the next PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30667:
URL: https://github.com/apache/doris/pull/30667#issuecomment-1926119265

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173254 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit cdf1cc55c3b21ca40e1d84278855daa3621c830c, data reload: false
   
   query1	965	337	329	329
   query2	6560	1937	1872	1872
   query3	6703	205	200	200
   query4	31845	21849	21974	21849
   query5	4301	355	412	355
   query6	252	163	172	163
   query7	4613	288	276	276
   query8	234	169	172	169
   query9	9045	2314	2297	2297
   query10	415	215	207	207
   query11	18486	15400	15226	15226
   query12	135	74	73	73
   query13	1615	424	414	414
   query14	9374	6634	6862	6634
   query15	228	182	175	175
   query16	8084	257	247	247
   query17	1851	532	498	498
   query18	2101	258	260	258
   query19	188	138	138	138
   query20	79	78	80	78
   query21	196	136	116	116
   query22	4714	4340	4559	4340
   query23	31156	30023	29914	29914
   query24	6571	2749	2720	2720
   query25	565	351	341	341
   query26	710	138	149	138
   query27	2322	287	296	287
   query28	4936	1855	1842	1842
   query29	842	619	599	599
   query30	282	129	139	129
   query31	938	699	713	699
   query32	90	52	53	52
   query33	481	220	215	215
   query34	832	456	458	456
   query35	869	783	745	745
   query36	1014	924	941	924
   query37	100	60	61	60
   query38	3310	3135	3109	3109
   query39	1320	1251	1247	1247
   query40	179	92	92	92
   query41	36	35	35	35
   query42	96	88	93	88
   query43	519	499	459	459
   query44	1019	679	695	679
   query45	197	184	174	174
   query46	1014	658	649	649
   query47	1465	1512	1522	1512
   query48	446	350	359	350
   query49	1073	289	283	283
   query50	747	363	365	363
   query51	5226	5141	5176	5141
   query52	101	83	91	83
   query53	339	268	272	268
   query54	245	209	222	209
   query55	78	76	73	73
   query56	225	195	201	195
   query57	970	902	906	902
   query58	208	176	181	176
   query59	2364	2215	2255	2215
   query60	238	214	211	211
   query61	95	86	85	85
   query62	638	358	368	358
   query63	292	273	260	260
   query64	4749	3579	3848	3579
   query65	3244	3213	3238	3213
   query66	798	312	305	305
   query67	14173	14028	13988	13988
   query68	4190	512	522	512
   query69	478	326	318	318
   query70	1268	1202	1201	1201
   query71	310	258	245	245
   query72	5931	2838	2683	2683
   query73	699	312	325	312
   query74	6448	6331	6284	6284
   query75	3007	2318	2319	2318
   query76	2570	966	988	966
   query77	341	236	240	236
   query78	9164	8677	8516	8516
   query79	4410	494	485	485
   query80	1767	356	341	341
   query81	505	193	196	193
   query82	1083	81	85	81
   query83	253	116	127	116
   query84	291	80	87	80
   query85	1863	341	330	330
   query86	488	305	302	302
   query87	3373	3165	3194	3165
   query88	4444	2309	2301	2301
   query89	475	363	364	363
   query90	1945	162	161	161
   query91	169	121	141	121
   query92	53	43	42	42
   query93	5600	468	475	468
   query94	1184	175	169	169
   query95	8217	363	7776	363
   query96	603	266	271	266
   query97	4213	4110	4095	4095
   query98	225	206	193	193
   query99	1154	694	692	692
   Total cold run time: 285817 ms
   Total hot run time: 173254 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [function](url_decode)add url_decode function [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #30667:
URL: https://github.com/apache/doris/pull/30667#discussion_r1475764846


##########
be/src/vec/functions/function_string.h:
##########
@@ -2740,6 +2741,59 @@ class FunctionStringParseUrl : public IFunction {
     }
 };
 
+class FunctionUrlDecode : public IFunction {
+public:
+    static constexpr auto name = "url_decode";
+    static FunctionPtr create() { return std::make_shared<FunctionUrlDecode>(); }
+    String get_name() const override { return name; }
+    size_t get_number_of_arguments() const override { return 1; }
+    bool is_variadic() const override { return false; }
+
+    DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+        return std::make_shared<DataTypeString>();
+    }
+
+    Status execute_impl(FunctionContext* context, Block& block,

Review Comment:
   warning: method 'execute_impl' can be made static [readability-convert-member-functions-to-static]
   
   ```suggestion
       static Status execute_impl(FunctionContext* context, Block& block,
   ```
   
   be/src/vec/functions/function_string.h:2758:
   ```diff
   -                                size_t input_rows_count) const override {
   +                                size_t input_rows_count) override {
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org