You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@whirr.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2010/06/28 19:28:52 UTC

[jira] Commented: (WHIRR-47) Create a Service factory

    [ https://issues.apache.org/jira/browse/WHIRR-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883225#action_12883225 ] 

Patrick Hunt commented on WHIRR-47:
-----------------------------------

lgtm, some issues:

1) good practice to have javadoc for main/test class/methods

2) service factory constructor needs to log something on error (currently just ignores)


> Create a Service factory
> ------------------------
>
>                 Key: WHIRR-47
>                 URL: https://issues.apache.org/jira/browse/WHIRR-47
>             Project: Whirr
>          Issue Type: Improvement
>          Components: core
>            Reporter: Tom White
>            Assignee: Tom White
>             Fix For: 0.1.0
>
>         Attachments: WHIRR-47.patch
>
>
> We need a uniform way of creating Service instances by name, for the CLI (WHIRR-33), for example.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.