You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/05/10 10:47:08 UTC

[GitHub] [drill] jnturton opened a new pull request, #2542: DRILL-8219: Handle null catalog names returned by DB2 in storage-jdbc

jnturton opened a new pull request, #2542:
URL: https://github.com/apache/drill/pull/2542

   # [DRILL-8219](https://issues.apache.org/jira/browse/DRILL-8219): Handle null catalog names returned by DB2 in storage-jdbc
   
   ## Description
   
   DB2 is another DBMS in which clients must connect to a named database, not just to the DBMS. A JDBC connection that does the same will receive a single record containing a null string from a call to Connection::getMetaData::getCatalogs. We need to ignore such a record in order to query DB2 correctly.
   
   ## Documentation
   N/A
   
   ## Testing
   Install DB2 using the Docker container ibmcom/db2. Create a test schema and table in the existing `testdb`. Configure a new Drill JDBC storage config to connect to the DB2 `testdb` database. Test info schema queries and direct querying of the test table.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #2542: DRILL-8219: Handle null catalog names returned by DB2 in storage-jdbc

Posted by GitBox <gi...@apache.org>.
cgivre commented on PR #2542:
URL: https://github.com/apache/drill/pull/2542#issuecomment-1122609657

   > 
   
   Ok... Let's just merge then. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre merged pull request #2542: DRILL-8219: Handle null catalog names returned by DB2 in storage-jdbc

Posted by GitBox <gi...@apache.org>.
cgivre merged PR #2542:
URL: https://github.com/apache/drill/pull/2542


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] jnturton commented on pull request #2542: DRILL-8219: Handle null catalog names returned by DB2 in storage-jdbc

Posted by GitBox <gi...@apache.org>.
jnturton commented on PR #2542:
URL: https://github.com/apache/drill/pull/2542#issuecomment-1122604719

   > LGTM +1
   > This is really a minor update, but is it worth adding a unit test?  We can skip it if it is a major hassle.
   
   I think a unit test would need a new DB2 testcontainer or a mocked JDBC Connection that returns a null like DB2 does. The cost/benefit of doing those to exercise a null test doesn't look good to me, but there may be some tricks I don't know. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org