You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aditivin <gi...@git.apache.org> on 2016/08/04 10:59:03 UTC

[GitHub] flink pull request #2333: [FLINK-4282] [streaming] Add Offset Parameter to W...

GitHub user aditivin opened a pull request:

    https://github.com/apache/flink/pull/2333

    [FLINK-4282] [streaming] Add Offset Parameter to WindowAssigners

    I seem to be getting all these changes however I rebase it :/ 
    It is currently rebased with the latest code of apache/master, and it says that it can be merged automatically. How can I get rid of all these changes? I can't think of how else to rebase it.
    
    These are the files I've changed:
    
    ProcessingTimeSessionWindows.java
    SlidingProcessingTimeWindows.java
    TumblingProcessingTimeWindows.java
    ProcessingTimeTrigger.java
    GlobalWindow.java
    TimeWindow.java
    Window.java
    WindowOperator.java
    WindowAssignerOffsetTest.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aditivin/flink FLINK-4282-streaming

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2333.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2333
    
----
commit 4bd51b31e454d6ee4abd11e5d2111f5369ebb06d
Author: zentol <ch...@apache.org>
Date:   2016-07-22T15:50:10Z

    [FLINK-4282] [streaming] Add Offset Parameter to WindowAssigners

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2333: [FLINK-4282] [streaming] Add Offset Parameter to WindowAs...

Posted by aditivin <gi...@git.apache.org>.
Github user aditivin commented on the issue:

    https://github.com/apache/flink/pull/2333
  
    Hi,
    Only the relevant changes are now visible. Pasting the details from the previous pull request (#2331) here:
    
    Added offset parameter for the following processing time window assigners:
    ProcessingTimeSessionWindows
    SlidingProcessingTimeWindows
    TumblingProcessingTimeWindows
    
    The offset is an optional parameter that can be added while creating these classes, and it can be supplied as a long value or a TimeZone.
    
    Test cases for the change are present in WindowAssignerOffsetTest. There are tests for positive, negative and TimeZone offsets for each of the classes.
    All Travis CI jobs passed.
    I haven't done it for the event time window assigners yet - I can add that if this is all right.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2333: [FLINK-4282] [streaming] Add Offset Parameter to W...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2333


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2333: [FLINK-4282] [streaming] Add Offset Parameter to WindowAs...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2333
  
    IMHO, the offset should not be added to `TimeWindow`. It is only the assigners that would shift the start time/end time of a window. This way, other parts of the code don't need to be aware of offsets, as they are in the current state of this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2333: [FLINK-4282] [streaming] Add Offset Parameter to WindowAs...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2333
  
    Hi,
    it doesn't help to just rebase it. I think you need to take the changes to the relevant files and create a new commit from that since the commit you have here contains a lot of other changes that don't go away by rebasing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---