You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ruslan Ostafiychuk <ro...@hortonworks.com> on 2014/10/24 16:03:17 UTC

Review Request 27135: Add tests for entities list api

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27135/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-836
    https://issues.apache.org/jira/browse/FALCON-836


Repository: falcon-git


Description
-------

Tests for EntityList api


Diffs
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 52f1bc1 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/EntityResult.java 45d4f8d 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java 3c5bd9e 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java 6b07589 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/27135/diff/


Testing
-------

Tested


Thanks,

Ruslan Ostafiychuk

Re: Review Request 27135: Add tests for entities list api

Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27135/#review58793
-----------------------------------------------------------

Ship it!



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java
<https://reviews.apache.org/r/27135/#comment99959>

    typo 'There is entity..." can be addressed post merge.


+1

- Paul Isaychuk


On Oct. 24, 2014, 2:08 p.m., Ruslan Ostafiychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27135/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2014, 2:08 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-836
>     https://issues.apache.org/jira/browse/FALCON-836
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Tests for EntityList api
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 52f1bc1 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/EntityResult.java 45d4f8d 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java 6b07589 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27135/diff/
> 
> 
> Testing
> -------
> 
> Tested
> 
> 
> Thanks,
> 
> Ruslan Ostafiychuk
> 
>

Re: Review Request 27135: Add tests for entities list api

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27135/#review58808
-----------------------------------------------------------


@raghav: Please add documentation to your tests

- Ruslan Ostafiychuk


On Oct. 28, 2014, 3:10 p.m., Ruslan Ostafiychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27135/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 3:10 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-836
>     https://issues.apache.org/jira/browse/FALCON-836
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Tests for EntityList api
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 2f588ef 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/EntityResult.java 45d4f8d 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java 6b07589 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27135/diff/
> 
> 
> Testing
> -------
> 
> Tested
> 
> 
> Thanks,
> 
> Ruslan Ostafiychuk
> 
>

Re: Review Request 27135: Add tests for entities list api

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27135/
-----------------------------------------------------------

(Updated Oct. 29, 2014, 3:50 p.m.)


Review request for Falcon.


Bugs: FALCON-836
    https://issues.apache.org/jira/browse/FALCON-836


Repository: falcon-git


Description
-------

Tests for EntityList api


Diffs (updated)
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 2f588ef 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/EntityResult.java 45d4f8d 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java 6b07589 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/27135/diff/


Testing
-------

Tested


Thanks,

Ruslan Ostafiychuk

Re: Review Request 27135: Add tests for entities list api

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27135/
-----------------------------------------------------------

(Updated Oct. 28, 2014, 3:10 p.m.)


Review request for Falcon.


Changes
-------

typos fixed


Bugs: FALCON-836
    https://issues.apache.org/jira/browse/FALCON-836


Repository: falcon-git


Description
-------

Tests for EntityList api


Diffs (updated)
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 2f588ef 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/EntityResult.java 45d4f8d 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java 6b07589 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/27135/diff/


Testing
-------

Tested


Thanks,

Ruslan Ostafiychuk

Re: Review Request 27135: Add tests for entities list api

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27135/
-----------------------------------------------------------

(Updated Oct. 24, 2014, 2:08 p.m.)


Review request for Falcon.


Bugs: FALCON-836
    https://issues.apache.org/jira/browse/FALCON-836


Repository: falcon-git


Description
-------

Tests for EntityList api


Diffs (updated)
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 52f1bc1 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/EntityResult.java 45d4f8d 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java 6b07589 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/27135/diff/


Testing
-------

Tested


Thanks,

Ruslan Ostafiychuk