You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/04/29 14:56:38 UTC
[GitHub] [airflow] potiuk opened a new pull request, #30958: Upgrade the dev version of Airflow to 2.7.0
potiuk opened a new pull request, #30958:
URL: https://github.com/apache/airflow/pull/30958
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #30958: Upgrade the dev version of Airflow to 2.7.0
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #30958:
URL: https://github.com/apache/airflow/pull/30958#discussion_r1181110567
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -250,6 +250,13 @@ daemon_umask = 0o077
# Example: dataset_manager_kwargs = {{"some_param": "some_value"}}
# dataset_manager_kwargs =
+# (experimental) Whether components should use Airflow Internal API for DB connectivity.
Review Comment:
Why do we have this change, this seems unrelated ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30958: Upgrade the dev version of Airflow to 2.7.0
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30958:
URL: https://github.com/apache/airflow/pull/30958#issuecomment-1528807559
Not sure which part of the release process it is in, but it looks like it shoudl be done slightly earlier (i.e. when we cut-off the 2.6.0 branch).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30958: Upgrade the dev version of Airflow to 2.7.0
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30958:
URL: https://github.com/apache/airflow/pull/30958#issuecomment-1528806834
We already have a few PRs that have wrongly generated version (https://github.com/apache/airflow/pull/30827 for example) so likely it's a good time to merge 2.6.0.dev0 -> 2.7.0.dev0 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #30958: Upgrade the dev version of Airflow to 2.7.0
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #30958:
URL: https://github.com/apache/airflow/pull/30958#discussion_r1181117814
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -250,6 +250,13 @@ daemon_umask = 0o077
# Example: dataset_manager_kwargs = {{"some_param": "some_value"}}
# dataset_manager_kwargs =
+# (experimental) Whether components should use Airflow Internal API for DB connectivity.
Review Comment:
Quite the contrary. They are very much related. They were (correctly) automatically added by pre-commit.
Those parameters have min-version = 2.7. This was implemented as part of the feature flags for AIP-44 and AIP-52, but in order to not comploicate it further we restricted automated moving parameters from .yaml to config based on "version-added" > currrent version. We moved the related parameters that were scheduled for 2.7 to have "version-added=2.7.0" so they started to appear only when we moved the version to 2.7.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #30958: Upgrade the dev version of Airflow to 2.7.0
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #30958:
URL: https://github.com/apache/airflow/pull/30958#discussion_r1181117814
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -250,6 +250,13 @@ daemon_umask = 0o077
# Example: dataset_manager_kwargs = {{"some_param": "some_value"}}
# dataset_manager_kwargs =
+# (experimental) Whether components should use Airflow Internal API for DB connectivity.
Review Comment:
Quite the contrary. They are very much related. They were (correctly) automatically added by pre-commit.
Those parameters have version-added = 2.7.0. This was implemented as part of the feature flags for AIP-44 and AIP-52, but in order to not comploicate it further we restricted automated moving parameters from .yaml to config based on "version-added" > currrent version. We moved the related parameters that were scheduled for 2.7 to have "version-added=2.7.0" so they started to appear only when we moved the version to 2.7.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #30958: Upgrade the dev version of Airflow to 2.7.0
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham merged PR #30958:
URL: https://github.com/apache/airflow/pull/30958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org