You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/12/13 23:12:34 UTC
[GitHub] [tvm] mehrdadh opened a new pull request, #13610: [microTVM]Add default value to unspecified project options in project API
mehrdadh opened a new pull request, #13610:
URL: https://github.com/apache/tvm/pull/13610
In current TVM, project API ignores the default values that are set for each project option in a project API server. This results in extra function handlers to specify the default value for those options in runtime.
This PR searches through available ProjectOptions for a project API server and adds default values for unspecified options before sending the `options` to API call function handler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #13610: [microTVM]Add default value to unspecified project options in project API
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #13610:
URL: https://github.com/apache/tvm/pull/13610#discussion_r1061033556
##########
apps/microtvm/arduino/template_project/microtvm_api_server.py:
##########
@@ -337,7 +332,7 @@ def _copy_cmsis(self, project_path: pathlib.Path, cmsis_path: str):
However, the latest release does not include header files that are copied in this function.
"""
(project_path / "include" / "cmsis").mkdir()
- cmsis_path = get_cmsis_path(cmsis_path)
+ cmsis_path = pathlib.Path(cmsis_path)
Review Comment:
not it doesn't, the default value for cmsis_path is set by environment. Check `python/tvm/micro/project_api/server.py` where we defined the cmsis_path as a projectOption
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #13610: [microTVM]Add default value to unspecified project options in project API
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #13610:
URL: https://github.com/apache/tvm/pull/13610#discussion_r1061033556
##########
apps/microtvm/arduino/template_project/microtvm_api_server.py:
##########
@@ -337,7 +332,7 @@ def _copy_cmsis(self, project_path: pathlib.Path, cmsis_path: str):
However, the latest release does not include header files that are copied in this function.
"""
(project_path / "include" / "cmsis").mkdir()
- cmsis_path = get_cmsis_path(cmsis_path)
+ cmsis_path = pathlib.Path(cmsis_path)
Review Comment:
no it doesn't, the default value for cmsis_path is set by environment. Check `python/tvm/micro/project_api/server.py` where we defined the cmsis_path as a projectOption
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #13610: [microTVM]Add default value to unspecified project options in project API
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #13610:
URL: https://github.com/apache/tvm/pull/13610#discussion_r1061034862
##########
apps/microtvm/arduino/template_project/microtvm_api_server.py:
##########
@@ -337,7 +332,7 @@ def _copy_cmsis(self, project_path: pathlib.Path, cmsis_path: str):
However, the latest release does not include header files that are copied in this function.
"""
(project_path / "include" / "cmsis").mkdir()
- cmsis_path = get_cmsis_path(cmsis_path)
+ cmsis_path = pathlib.Path(cmsis_path)
Review Comment:
ah, gotcha, nevermind then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh merged pull request #13610: [microTVM]Add default value to unspecified project options in project API
Posted by GitBox <gi...@apache.org>.
mehrdadh merged PR #13610:
URL: https://github.com/apache/tvm/pull/13610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a diff in pull request #13610: [microTVM]Add default value to unspecified project options in project API
Posted by GitBox <gi...@apache.org>.
areusch commented on code in PR #13610:
URL: https://github.com/apache/tvm/pull/13610#discussion_r1061031013
##########
apps/microtvm/arduino/template_project/microtvm_api_server.py:
##########
@@ -337,7 +332,7 @@ def _copy_cmsis(self, project_path: pathlib.Path, cmsis_path: str):
However, the latest release does not include header files that are copied in this function.
"""
(project_path / "include" / "cmsis").mkdir()
- cmsis_path = get_cmsis_path(cmsis_path)
+ cmsis_path = pathlib.Path(cmsis_path)
Review Comment:
this one also removes the possibility of setting CMSIS_PATH through env right? can you add to PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13610: [microTVM]Add default value to unspecified project options in project API
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13610:
URL: https://github.com/apache/tvm/pull/13610#issuecomment-1350004134
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @alanmacd, @gromero, @leandron, @mkatanbaf <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org