You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@texera.apache.org by GitBox <gi...@apache.org> on 2026/06/01 03:06:05 UTC

[GH] (texera/chore/monaco-lsp-v10): Workflow run "Required Checks" is working again!

The GitHub Actions job "Required Checks" on texera.git/chore/monaco-lsp-v10 has succeeded.
Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).

Head commit for run:
03796ca6e444de54d5a1aa871d276c3533ae4a47 / Xinyuan Lin <xi...@uci.edu>
test(frontend): port code-editor browser spec to monaco-languageclient v10

The v10 upgrade replaced the single MonacoEditorLanguageClientWrapper (initAndStart) with a global MonacoVscodeApiWrapper + per-editor EditorApp, but code-editor.component.browser.spec.ts still swapped a fake `editorWrapper` and asserted on `wrapper.initAndStart(userConfig, host)` — so all 7 browser-mode tests failed with "called 0 times".

Drive the v10 seams instead: mock `monaco-languageclient/editorApp` to record the EditorAppConfig and start() host and hand back the fake editor, and stub the static `ensureVscodeApiStarted` so no real codingame worker / language extension loads. Assertions move off `userConfig.wrapperConfig.editorAppConfig.codeResources.main` to the EditorApp config's `codeResources.modified` (and `.original` on the diff path).

Report URL: https://github.com/apache/texera/actions/runs/26732718377

With regards,
GitHub Actions via GitBox