[GitHub] [maven-wrapper] sepe81 commented on a change in pull request #16: MWRAPPER-53 cygwin path fix for class like for source

[GitBox <gi...@apache.org>]

sepe81 commented on a change in pull request #16:
URL: https://github.com/apache/maven-wrapper/pull/16#discussion_r791631168



##########
File path: maven-wrapper-distribution/src/resources/mvnw
##########
@@ -259,20 +259,22 @@ else
         if [ "$MVNW_VERBOSE" = true ]; then
           echo "Falling back to using Java to download"
         fi
-        javaClass="$BASE_DIR/.mvn/wrapper/MavenWrapperDownloader.java"
+        javaSource="$BASE_DIR/.mvn/wrapper/MavenWrapperDownloader.java"
+        javaClass="$BASE_DIR/.mvn/wrapper/MavenWrapperDownloader.class"
         # For Cygwin, switch paths to Windows format before running javac
         if $cygwin; then
-          javaClass=`cygpath --path --windows "$javaClass"`
+          javaSource=`cygpath --path --windows "javaSource"`
+          javaClass=`cygpath --path --windows "javaClass"`
         fi
-        if [ -e "$javaClass" ]; then
-            if [ ! -e "$BASE_DIR/.mvn/wrapper/MavenWrapperDownloader.class" ]; then
+        if [ -e "$javaSource" ]; then
+            if [ ! -e "$javaClass" ]; then
                 if [ "$MVNW_VERBOSE" = true ]; then
                   echo " - Compiling MavenWrapperDownloader.java ..."
                 fi
                 # Compiling the Java class
-                ("$JAVA_HOME/bin/javac" "$javaClass")
+                ("$JAVA_HOME/bin/javac" "javaSource")

Review comment:
       ```suggestion
                   ("$JAVA_HOME/bin/javac" "$javaSource")
   ```
   
   i guess it was not intentional to remove $




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org