You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@bahir.apache.org by rmetzger <gi...@git.apache.org> on 2017/03/14 10:23:05 UTC

[GitHub] bahir-flink issue #13: [BAHIR-95] Add ZREM to Redis commands

Github user rmetzger commented on the issue:

    https://github.com/apache/bahir-flink/pull/13
  
    I think the reason why `ZREM` was not added is because this is the `RedisSink`, which implies that you are writing data to redis, not removing it.
    I'm not sure if it makes sense semantically. Do you have a use case for removing data in the sink?
    
    The change looks good overall.
    Maybe you could also update the `README.md` file with the new command?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---