You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@impala.apache.org by "Joe McDonnell (Jira)" <ji...@apache.org> on 2020/12/23 21:34:00 UTC
[jira] [Resolved] (IMPALA-7993) Fix build and scripts to be more
useful to developers
[ https://issues.apache.org/jira/browse/IMPALA-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe McDonnell resolved IMPALA-7993.
-----------------------------------
Fix Version/s: Impala 4.0
Resolution: Fixed
We added code that generates JUnitXML when a CMake command fails. This is enabled for jenkins.impala.io for the GVO jobs including clang-tidy-ub1604. That eliminates the need to look through logs for any build issue.
> Fix build and scripts to be more useful to developers
> -----------------------------------------------------
>
> Key: IMPALA-7993
> URL: https://issues.apache.org/jira/browse/IMPALA-7993
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 3.1.0
> Reporter: Paul Rogers
> Priority: Major
> Fix For: Impala 4.0
>
>
> Got a build failure on a Gerrit patch. The tidy log.txt file is 300 MB in size with 3.4 million lines. It contains 87,535 warnings identified by a "~~~" squiggle, 122 occurrences of the word "failure", 6947 occurrences of "fail", and 35,503 occurrences of the word "error." The bottom of the file states "7988 warnings generated." Indeed, there are 1077 occurrences of the line "warnings generated" in the build.
> It is not realistic for a human to plow through this stuff looking for the one obscure pattern that indicates and actual problem.
> This build is unusually large and verbose for an open source project.
> Some improvements:
> * Separate out normal "narration" (echoing of shell commands) from actual error output.
> * Fix the code to eliminate warnings, or turn off the warnings.
> * Turn off the extra checks which we just ignore.
> * Create a script that will grep through the file looking for the actual failures, ignoring the "expected" errors and failures, identifying the real ones.
> It also appears that the scripts build Javadoc (can't tell for what.) Impala is famous for its highly unorthodox use of Javadoc comments; the generate Javadoc will be gibberish. Either fix the comments to be Java-doc compliant, or stop building Javadoc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)