You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Purshotam Shah (JIRA)" <ji...@apache.org> on 2014/05/01 03:34:14 UTC

[jira] [Updated] (OOZIE-1818) CoordMaterializeTransitionXCommand verifyPrecondition doesn't verify current time

     [ https://issues.apache.org/jira/browse/OOZIE-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Purshotam Shah updated OOZIE-1818:
----------------------------------

    Description: 
{code}
        Timestamp startTime = coordJob.getNextMaterializedTimestamp();
        if (startTime == null) {
            startTime = coordJob.getStartTimestamp();

            if (startTime.after(new Timestamp(System.currentTimeMillis() + lookAheadWindow * 1000))) {
                throw new PreconditionException(ErrorCode.E1100, "CoordMaterializeTransitionXCommand for jobId="
                        + jobId + " job's start time is not reached yet - nothing to materialize");
            }
        }
{code}

It should be should be

{code}
        Timestamp startTime = coordJob.getNextMaterializedTimestamp();
        if (startTime == null) {
            startTime = coordJob.getStartTimestamp();

        }
        if (startTime.after(new Timestamp(System.currentTimeMillis() + lookAheadWindow * 1000))) {
                throw new PreconditionException(ErrorCode.E1100, "CoordMaterializeTransitionXCommand for jobId="
                        + jobId + " job's start time is not reached yet - nothing to materialize");
         }
{code}



> CoordMaterializeTransitionXCommand verifyPrecondition doesn't verify current time
> ---------------------------------------------------------------------------------
>
>                 Key: OOZIE-1818
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1818
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Purshotam Shah
>
> {code}
>         Timestamp startTime = coordJob.getNextMaterializedTimestamp();
>         if (startTime == null) {
>             startTime = coordJob.getStartTimestamp();
>             if (startTime.after(new Timestamp(System.currentTimeMillis() + lookAheadWindow * 1000))) {
>                 throw new PreconditionException(ErrorCode.E1100, "CoordMaterializeTransitionXCommand for jobId="
>                         + jobId + " job's start time is not reached yet - nothing to materialize");
>             }
>         }
> {code}
> It should be should be
> {code}
>         Timestamp startTime = coordJob.getNextMaterializedTimestamp();
>         if (startTime == null) {
>             startTime = coordJob.getStartTimestamp();
>         }
>         if (startTime.after(new Timestamp(System.currentTimeMillis() + lookAheadWindow * 1000))) {
>                 throw new PreconditionException(ErrorCode.E1100, "CoordMaterializeTransitionXCommand for jobId="
>                         + jobId + " job's start time is not reached yet - nothing to materialize");
>          }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)