[GitHub] [incubator-druid] himanshug commented on issue #7731: fix AggregatorFactory.finalizeComputation implementations to be ok with null inputs

[GitBox <gi...@apache.org>]

himanshug commented on issue #7731: fix AggregatorFactory.finalizeComputation implementations to be ok with null inputs
URL: https://github.com/apache/incubator-druid/pull/7731#issuecomment-494931501
 
 
   LGTM in general. But I had a thought of adding following method to AggregatorFactory
   
   ```
   @Nullable
   public final Object finalizeComputationWithNull(@Nullable Object object)
   {
       return object == null ? null : finalizeComputation(object);
   }
   ```
   
   and use above in all of druid code instead of `finalizeComputation(..)` . This would fix the problem for extensions not in druid codebase and also one less thing to worry by future aggregator factory writers.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org