[GitHub] [echarts] aemooooon commented on issue #10478: "Can't get dom width or height" incorrectly fires for width/height values of 0.

[GitBox <gi...@apache.org>]

aemooooon commented on issue #10478:
URL: https://github.com/apache/echarts/issues/10478#issuecomment-799049542


   > The width and height of the container are required to create a canvas with the same size. So none of `0` or `null` or `undefined` is valid when init. Although we could provide a default canvas size when container size is not given, it may cause some confusions (e.g., the user has defined canvas CSS width and height, and the size is not the same with canvas size).
   > Perhaps we should change the warning expression to make this information more understandable. But I don't think providing a default canvas size when container size is a very good idea. Because first of all, setting container size is not a hard job for the user to do, as long as they know what's wrong here. On the other hand, providing a default value that users don't know how to change (calling resize) is a bigger problem.
   
   I have to say that your English is sooooo nice! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org