You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "vrajat (via GitHub)" <gi...@apache.org> on 2024/12/18 10:11:46 UTC

Re: [PR] Allows multiple requests per server per request ID [pinot]

vrajat commented on code in PR #13742:
URL: https://github.com/apache/pinot/pull/13742#discussion_r1889973516


##########
pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java:
##########
@@ -39,10 +44,13 @@
 @ThreadSafe
 public class AsyncQueryResponse implements QueryResponse {
   private final QueryRouter _queryRouter;
-  private final long _requestId;
+
+  // TODO(egalpin): Remove the concept of truncated request ID in next major release after all servers are expected
+  //  to send back tableName in DataTable metadata
+  private final long _canonicalRequestId;

Review Comment:
   What is `query` in this case ? Is it the whole query string ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org