You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/15 16:53:42 UTC

[GitHub] [arrow-datafusion] Dandandan opened a new issue #347: Improve display of operators in Explain

Dandandan opened a new issue #347:
URL: https://github.com/apache/arrow-datafusion/issues/347


   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   Currently the plan shows the operators using the name instead of symbol. A readability improvement would be to use the operators symbols instead.
   
   Old
   
   ```
   Filter: #SUM(c) Gt Int64(10) And #b Gt Int64(10) And #SUM(c) Lt Int64(20)
   ```
   
   ```
   Filter: #SUM(c) > Int64(10) AND #b > Int64(10) AND #SUM(c) < Int64(20)
   ```
   
   
   
   **Describe the solution you'd like**
   Change the `Debug` implementation to use `Display` for the  operator + fix the tests (74 tests need to be updated).
   
   ![image](https://user-images.githubusercontent.com/163737/118371742-4155a180-b5ae-11eb-989a-8a46845838ca.png)
   
   
   
   **Describe alternatives you've considered**
   
   **Additional context**
   
   
   FYI @alamb 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #347: Improve display of operators in Explain output

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #347:
URL: https://github.com/apache/arrow-datafusion/issues/347#issuecomment-843995237


   FWIW this requires implementing `Display` for `Expr`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] matthewmturner commented on issue #347: Improve display of operators in Explain output

Posted by GitBox <gi...@apache.org>.
matthewmturner commented on issue #347:
URL: https://github.com/apache/arrow-datafusion/issues/347#issuecomment-913311783


   I can give this a shot.  To confirm - is the `BinaryExpr` the only variant of `Expr` that needs `Display` implemented?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #347: Improve display of operators in Explain output

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #347:
URL: https://github.com/apache/arrow-datafusion/issues/347#issuecomment-841795314






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #347: Improve display of operators in Explain output

Posted by GitBox <gi...@apache.org>.
alamb closed issue #347:
URL: https://github.com/apache/arrow-datafusion/issues/347


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #347: Improve display of operators in Explain output

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #347:
URL: https://github.com/apache/arrow-datafusion/issues/347#issuecomment-841807216


   I agree @jorgecarleitao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb edited a comment on issue #347: Improve display of operators in Explain output

Posted by GitBox <gi...@apache.org>.
alamb edited a comment on issue #347:
URL: https://github.com/apache/arrow-datafusion/issues/347#issuecomment-843995237


   FWIW this likely requires implementing `Display` for `Expr`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #347: Improve display of operators in Explain output

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #347:
URL: https://github.com/apache/arrow-datafusion/issues/347#issuecomment-916329763


   > I can give this a shot. To confirm - is the BinaryExpr the only variant of Expr that needs Display implemented?
   
   
   Thanks @matthewmturner  ! I think the intent is to have `Display` implemented for all variants of Expr (eventually) but it doesn't have to be all in one PR. I'll leave a comment on #971 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #347: Improve display of operators in Explain output

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #347:
URL: https://github.com/apache/arrow-datafusion/issues/347#issuecomment-916330078


   (ps sorry for the belated reviews, but I am just catching up from being on vacation)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on issue #347: Improve display of operators in Explain output

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #347:
URL: https://github.com/apache/arrow-datafusion/issues/347#issuecomment-841795314


   I think this is a great idea. Thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan commented on issue #347: Improve display of operators in Explain output

Posted by GitBox <gi...@apache.org>.
Dandandan commented on issue #347:
URL: https://github.com/apache/arrow-datafusion/issues/347#issuecomment-841812412


   Exactly 👍 
   
   IMO explain output also should be close or equal to SQL syntax, e.g. for the used expressions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jorgecarleitao commented on issue #347: Improve display of operators in Explain output

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on issue #347:
URL: https://github.com/apache/arrow-datafusion/issues/347#issuecomment-841797413


   IMO in general we should avoid relying on `{:?}` for printing things to end users. `{:?}` with `#[derive(Debug)]` is very useful to developers; usually users want less information.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan commented on issue #347: Improve display of operators in Explain output

Posted by GitBox <gi...@apache.org>.
Dandandan commented on issue #347:
URL: https://github.com/apache/arrow-datafusion/issues/347#issuecomment-841812412


   Exactly 👍 
   
   IMO explain output also should be close or equal to SQL syntax, e.g. for the used expressions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jorgecarleitao commented on issue #347: Improve display of operators in Explain output

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on issue #347:
URL: https://github.com/apache/arrow-datafusion/issues/347#issuecomment-841797413


   IMO in general we should avoid relying on `{:?}` for printing things to end users. `{:?}` with `#[derive(Debug)]` is very useful to developers; usually users want less information.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org